90954 2012-07-11 02:00:17 -0700 [EFL] Add const to the parameter of getters in ewk_security_origin 2012-07-13 04:44:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 90936 0 kihong.kwon webkit-unassigned g.czajkowski gyuyoung.kim gyuyoung.kim haraken lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 666529 0 kihong.kwon 2012-07-11 02:00:17 -0700 Add const to the parameter of ewk_security_origin_host_get and ewk_security_origin_protocol_get. 666540 1 151652 kihong.kwon 2012-07-11 02:10:07 -0700 Created attachment 151652 Patch 666552 2 151652 gyuyoung.kim 2012-07-11 02:19:33 -0700 Comment on attachment 151652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151652&action=review > Source/WebKit/efl/ewk/ewk_security_origin.cpp:139 > + origin->protocol = eina_stringshare_add(coreOrigin->protocol().utf8().data()); I wonder if coreOrigin always has protocol. > Source/WebKit/efl/ewk/ewk_security_origin.cpp:140 > + origin->host = eina_stringshare_add(coreOrigin->host().utf8().data()); ditto. 666557 3 kihong.kwon 2012-07-11 02:23:28 -0700 (In reply to comment #2) > (From update of attachment 151652 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151652&action=review > > > Source/WebKit/efl/ewk/ewk_security_origin.cpp:139 > > + origin->protocol = eina_stringshare_add(coreOrigin->protocol().utf8().data()); > > I wonder if coreOrigin always has protocol. > > > Source/WebKit/efl/ewk/ewk_security_origin.cpp:140 > > + origin->host = eina_stringshare_add(coreOrigin->host().utf8().data()); > > ditto. If there is not protocol or host in coreOrigin, eina_stringshare_add returns NULL. 666591 4 151652 cdumez 2012-07-11 03:00:19 -0700 Comment on attachment 151652 Patch LGTM. 666628 5 151652 gyuyoung.kim 2012-07-11 04:04:22 -0700 Comment on attachment 151652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151652&action=review >>> Source/WebKit/efl/ewk/ewk_security_origin.cpp:139 >>> + origin->protocol = eina_stringshare_add(coreOrigin->protocol().utf8().data()); >> >> I wonder if coreOrigin always has protocol. > > If there is not protocol or host in coreOrigin, eina_stringshare_add returns NULL. If so, don't you need to mention it in API description ? I think you need to mention this to ewk_security_origin.h. 666640 6 kihong.kwon 2012-07-11 04:21:21 -0700 (In reply to comment #5) > (From update of attachment 151652 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151652&action=review > > >>> Source/WebKit/efl/ewk/ewk_security_origin.cpp:139 > >>> + origin->protocol = eina_stringshare_add(coreOrigin->protocol().utf8().data()); > >> > >> I wonder if coreOrigin always has protocol. > > > > If there is not protocol or host in coreOrigin, eina_stringshare_add returns NULL. > > If so, don't you need to mention it in API description ? I think you need to mention this to ewk_security_origin.h. There is no description about this, because this is a private function. 666681 7 151652 gyuyoung.kim 2012-07-11 05:09:53 -0700 Comment on attachment 151652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151652&action=review > Source/WebKit/efl/ewk/ewk_security_origin.h:64 > * @return the host domain If origin->protocol can be NULL, I mean you need to add it to here. 667277 8 151831 kihong.kwon 2012-07-11 18:14:26 -0700 Created attachment 151831 Patch 667291 9 151831 gyuyoung.kim 2012-07-11 18:26:25 -0700 Comment on attachment 151831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151831&action=review > Source/WebKit/efl/ewk/ewk_security_origin.h:52 > + * @return the protocol scheme, if there is not a protocol scheme, return NULL. Use below description. "or @c 0 if there is not a protocol scheme" > Source/WebKit/efl/ewk/ewk_security_origin.h:64 > + * @return the host domain, if there is not a host scheme, return NULL. ditto. 667292 10 gyuyoung.kim 2012-07-11 18:26:54 -0700 CC'ing Grzegorz, could you take a look this API description ? 667308 11 151842 kihong.kwon 2012-07-11 18:46:40 -0700 Created attachment 151842 Patch 667438 12 151842 g.czajkowski 2012-07-11 23:45:52 -0700 Comment on attachment 151842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151842&action=review > Source/WebKit/efl/ewk/ewk_security_origin.cpp:44 > return origin->protocol; Are you sure that origin points out to correct pointer? I'd rather add null checking here as this is API - we should protect it. > Source/WebKit/efl/ewk/ewk_security_origin.cpp:49 > return origin->host; Ditto. > Source/WebKit/efl/ewk/ewk_security_origin.h:52 > + * @return the protocol scheme or 0 if there is not a protocol scheme. Please add @c to 0 and do not use dots in return/param descriptions. > Source/WebKit/efl/ewk/ewk_security_origin.h:64 > + * @return the host domain or 0 if there is not a host scheme. Ditto. 667454 13 kihong.kwon 2012-07-12 00:27:38 -0700 (In reply to comment #12) > (From update of attachment 151842 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151842&action=review > > > Source/WebKit/efl/ewk/ewk_security_origin.cpp:44 > > return origin->protocol; > > Are you sure that origin points out to correct pointer? I'd rather add null checking here as this is API - we should protect it. The description about eina_stringshare_add is "A pointer to an instance of the string on success. NULL on failure." It means, if pointer of Ewk_Security_Origin is available, there is no problem with this API. > > > Source/WebKit/efl/ewk/ewk_security_origin.cpp:49 > > return origin->host; > > Ditto. > > > Source/WebKit/efl/ewk/ewk_security_origin.h:52 > > + * @return the protocol scheme or 0 if there is not a protocol scheme. > > Please add @c to 0 and do not use dots in return/param descriptions. OK. > > > Source/WebKit/efl/ewk/ewk_security_origin.h:64 > > + * @return the host domain or 0 if there is not a host scheme. > > Ditto. 667465 14 g.czajkowski 2012-07-12 00:40:19 -0700 (In reply to comment #13) > (In reply to comment #12) > > (From update of attachment 151842 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=151842&action=review > > > > > Source/WebKit/efl/ewk/ewk_security_origin.cpp:44 > > > return origin->protocol; > > > > Are you sure that origin points out to correct pointer? I'd rather add null checking here as this is API - we should protect it. > > The description about eina_stringshare_add is "A pointer to an instance of the string on success. NULL on failure." > It means, if pointer of Ewk_Security_Origin is available, there is no problem with this API. I didn't mean about eina_stringshare behavior in case of NULL but about 'origin' pointer. What will happen if application calls ewk_security_origin_protocol_get(0) ? 667473 15 kihong.kwon 2012-07-12 00:49:42 -0700 (In reply to comment #14) > (In reply to comment #13) > > (In reply to comment #12) > > > (From update of attachment 151842 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=151842&action=review > > > > > > > Source/WebKit/efl/ewk/ewk_security_origin.cpp:44 > > > > return origin->protocol; > > > > > > Are you sure that origin points out to correct pointer? I'd rather add null checking here as this is API - we should protect it. > > > > The description about eina_stringshare_add is "A pointer to an instance of the string on success. NULL on failure." > > It means, if pointer of Ewk_Security_Origin is available, there is no problem with this API. > > I didn't mean about eina_stringshare behavior in case of NULL but about 'origin' pointer. What will happen if application calls ewk_security_origin_protocol_get(0) ? I got it. You are right. I missed it. 667483 16 151877 kihong.kwon 2012-07-12 01:00:42 -0700 Created attachment 151877 Patch 667534 17 g.czajkowski 2012-07-12 01:57:51 -0700 (In reply to comment #16) > Created an attachment (id=151877) [details] > Patch Thanks for changes. Looks fine for me. I'd add notes to ChangeLog that you are moving initialization of strings for protocol and host to the *_new method. That change allows to add const modifier for getters methods. Additionally null checks are added to the getters. 667596 18 gyuyoung.kim 2012-07-12 03:49:51 -0700 (In reply to comment #17) > (In reply to comment #16) > > Created an attachment (id=151877) [details] [details] > > Patch > > Thanks for changes. Looks fine for me. > I'd add notes to ChangeLog that you are moving initialization of strings for protocol and host to the *_new method. That change allows to add const modifier for getters methods. Additionally null checks are added to the getters. After updating ChangeLog according to Grezegorz's suggestion, I will give LGTM. 667649 19 151918 kihong.kwon 2012-07-12 05:16:14 -0700 Created attachment 151918 Patch 668150 20 rakuco 2012-07-12 13:23:09 -0700 I remember discussing with Thiago why all fields should not be initialized in ewk_security_origin_new() in bug 84023 -- CC'ing as he's the API author and might have something to say. 668199 21 tmpsantos 2012-07-12 14:16:12 -0700 IMO the patch is fine if you can explain me why remove the lazy initialization that can be a performance improvement in favor of using const. When I wrote the API, I say that it is mostly used for manipulating database (i.e. ewk_security_origin_web_database_get_all) These getters are seldom used. Finally, if using this const is really necessary, why not a const_cast/mutable/etc? 668255 22 tmpsantos 2012-07-12 14:47:26 -0700 Ah, one more thing: adding/changing API's, please add unit tests. 668507 23 kihong.kwon 2012-07-12 19:04:36 -0700 (In reply to comment #21) > IMO the patch is fine if you can explain me why remove the lazy initialization that can be a performance improvement in favor of using const. > > When I wrote the API, I say that it is mostly used for manipulating database (i.e. ewk_security_origin_web_database_get_all) These getters are seldom used. > > Finally, if using this const is really necessary, why not a const_cast/mutable/etc? Security origin would be used for not only database but also other features. Actually I'm using a Ewk_Security_Origin for the Web Notification. In that case getters will be called frequently, that's why I moved initialization to *_new. 668516 24 kihong.kwon 2012-07-12 19:19:34 -0700 (In reply to comment #22) > Ah, one more thing: adding/changing API's, please add unit tests. I agree. It can be covered by https://bugs.webkit.org/show_bug.cgi?id=90452. 668689 25 tmpsantos 2012-07-13 00:43:38 -0700 (In reply to comment #24) > (In reply to comment #22) > > Ah, one more thing: adding/changing API's, please add unit tests. > > I agree. It can be covered by https://bugs.webkit.org/show_bug.cgi?id=90452. You got me! :D 668801 26 151918 gyuyoung.kim 2012-07-13 03:06:34 -0700 Comment on attachment 151918 Patch It looks all issues are clear. LGTM. Thanks. 668827 27 151918 haraken 2012-07-13 03:48:23 -0700 Comment on attachment 151918 Patch Looks OK. r+ing based on informal reviews. 668878 28 151918 webkit.review.bot 2012-07-13 04:43:55 -0700 Comment on attachment 151918 Patch Clearing flags on attachment: 151918 Committed r122564: <http://trac.webkit.org/changeset/122564> 668879 29 webkit.review.bot 2012-07-13 04:44:02 -0700 All reviewed patches have been landed. Closing bug. 151652 2012-07-11 02:10:07 -0700 2012-07-11 18:14:16 -0700 Patch bug-90954-20120711181005.patch text/plain 3406 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQxZjhiZjFi ZTg3YWI4Yjg2NmQ5OTVlZGY2OWUyOWIzMDY5MzY0MS4uMGEzNmUyOTgyYzIyZmE4ZmU5NzA3YjFl M2ZkNTIyYmZiOTUxYzQ1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTA3LTExICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEFkZCBjb25zdCB0byB0aGUgcGFyYW1ldGVyIG9mIGdldHRlcnMgaW4gZXdrX3NlY3Vy aXR5X29yaWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTA5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgY29uc3QgcXVhbGlmaWVyIHRvIHRoZSBwYXJhbWV0ZXIgb2YgZXdrX3NlY3VyaXR5X29y aWdpbl9ob3N0X2dldCBhbmQgZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQuCisKKyAg ICAgICAgKiBld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHA6CisgICAgICAgIChld2tfc2VjdXJp dHlfb3JpZ2luX3Byb3RvY29sX2dldCk6CisgICAgICAgIChld2tfc2VjdXJpdHlfb3JpZ2luX2hv c3RfZ2V0KToKKyAgICAgICAgKGV3a19zZWN1cml0eV9vcmlnaW5fbmV3KToKKyAgICAgICAgKiBl d2svZXdrX3NlY3VyaXR5X29yaWdpbi5oOgorCiAyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcENvbmZp Z3VyYXRpb25Gb3JWaWV3cG9ydCBzaG91bGQgbW92ZSB0byBJbnRlcm5hbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcAppbmRleCA2NjA2NGEwMjlhYmYz YTQzZmM4OWM4ZTdkY2I3ZGZlNDJhMmE0MTJhLi5kMTk4N2U0M2Y4NTZmNWRjZjExNDdkMjI1NGRl NzNhZjkxYTFhYjMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9v cmlnaW4uY3BwCkBAIC0zOSwxOSArMzksMTMgQEAgc3RydWN0IF9Fd2tfU2VjdXJpdHlfT3JpZ2lu IHsKICAgICBjb25zdCBjaGFyKiBob3N0OwogfTsKIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5 X29yaWdpbl9wcm90b2NvbF9nZXQoRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luKQorY29uc3Qg Y2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoY29uc3QgRXdrX1NlY3VyaXR5 X09yaWdpbiogb3JpZ2luKQogewotICAgIGlmICghb3JpZ2luLT5wcm90b2NvbCkKLSAgICAgICAg b3JpZ2luLT5wcm90b2NvbCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKG9yaWdpbi0+c2VjdXJpdHlP cmlnaW4tPnByb3RvY29sKCkudXRmOCgpLmRhdGEoKSk7Ci0KICAgICByZXR1cm4gb3JpZ2luLT5w cm90b2NvbDsKIH0KIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChF d2tfU2VjdXJpdHlfT3JpZ2luKiBvcmlnaW4pCitjb25zdCBjaGFyKiBld2tfc2VjdXJpdHlfb3Jp Z2luX2hvc3RfZ2V0KGNvbnN0IEV3a19TZWN1cml0eV9PcmlnaW4qIG9yaWdpbikKIHsKLSAgICBp ZiAoIW9yaWdpbi0+aG9zdCkKLSAgICAgICAgb3JpZ2luLT5ob3N0ID0gZWluYV9zdHJpbmdzaGFy ZV9hZGQob3JpZ2luLT5zZWN1cml0eU9yaWdpbi0+aG9zdCgpLnV0ZjgoKS5kYXRhKCkpOwotCiAg ICAgcmV0dXJuIG9yaWdpbi0+aG9zdDsKIH0KIApAQCAtMTQyLDggKzEzNiw4IEBAIEV3a19TZWN1 cml0eV9PcmlnaW4qIGV3a19zZWN1cml0eV9vcmlnaW5fbmV3KFdlYkNvcmU6OlNlY3VyaXR5T3Jp Z2luKiBjb3JlT3JpZ2luCiAgICAgRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luID0gbmV3IEV3 a19TZWN1cml0eV9PcmlnaW47CiAKICAgICBvcmlnaW4tPnNlY3VyaXR5T3JpZ2luID0gY29yZU9y aWdpbjsKLSAgICBvcmlnaW4tPmhvc3QgPSAwOwotICAgIG9yaWdpbi0+cHJvdG9jb2wgPSAwOwor ICAgIG9yaWdpbi0+cHJvdG9jb2wgPSBlaW5hX3N0cmluZ3NoYXJlX2FkZChjb3JlT3JpZ2luLT5w cm90b2NvbCgpLnV0ZjgoKS5kYXRhKCkpOworICAgIG9yaWdpbi0+aG9zdCA9IGVpbmFfc3RyaW5n c2hhcmVfYWRkKGNvcmVPcmlnaW4tPmhvc3QoKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIHJldHVy biBvcmlnaW47CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4u aAppbmRleCA5OGFiZjc2OWEyNDY3YWE2NmQzZWMwYjdmMTY2OGQxMTg5MTNiMGMzLi40YTExOTM5 NzI2M2Y0MWRjOGI1MDJiODExMmFmMGJlYzZjNGNkNDkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmgKQEAgLTUxLDcgKzUxLDcgQEAgdHlwZWRlZiBzdHJ1 Y3QgX0V3a19TZWN1cml0eV9PcmlnaW4gRXdrX1NlY3VyaXR5X09yaWdpbjsKICAqCiAgKiBAcmV0 dXJuIHRoZSBwcm90b2NvbCBzY2hlbWUKICAqLwotRUFQSSBjb25zdCBjaGFyICAgICAgICAgICpl d2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29sX2dldChFd2tfU2VjdXJpdHlfT3JpZ2luICpvKTsK K0VBUEkgY29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9n ZXQoY29uc3QgRXdrX1NlY3VyaXR5X09yaWdpbiAqbyk7CiAKIC8qKgogICogUmV0dXJucyB0aGUg aG9zdCBvZiB0aGUgc2VjdXJpdHkgb3JpZ2luLgpAQCAtNjMsNyArNjMsNyBAQCBFQVBJIGNvbnN0 IGNoYXIgICAgICAgICAgKmV3a19zZWN1cml0eV9vcmlnaW5fcHJvdG9jb2xfZ2V0KEV3a19TZWN1 cml0eV9PcmlnaW4gKgogICoKICAqIEByZXR1cm4gdGhlIGhvc3QgZG9tYWluCiAgKi8KLUVBUEkg Y29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChFd2tfU2Vj dXJpdHlfT3JpZ2luICpvKTsKK0VBUEkgY29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5 X29yaWdpbl9ob3N0X2dldChjb25zdCBFd2tfU2VjdXJpdHlfT3JpZ2luICpvKTsKIAogLyoqCiAg KiBSZXR1cm5zIHRoZSBwb3J0IG9mIHRoZSBzZWN1cml0eSBvcmlnaW4uCg== 151831 2012-07-11 18:14:26 -0700 2012-07-11 18:46:29 -0700 Patch bug-90954-20120712101424.patch text/plain 3712 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQxZjhiZjFi ZTg3YWI4Yjg2NmQ5OTVlZGY2OWUyOWIzMDY5MzY0MS4uMGEzNmUyOTgyYzIyZmE4ZmU5NzA3YjFl M2ZkNTIyYmZiOTUxYzQ1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTA3LTExICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEFkZCBjb25zdCB0byB0aGUgcGFyYW1ldGVyIG9mIGdldHRlcnMgaW4gZXdrX3NlY3Vy aXR5X29yaWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTA5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgY29uc3QgcXVhbGlmaWVyIHRvIHRoZSBwYXJhbWV0ZXIgb2YgZXdrX3NlY3VyaXR5X29y aWdpbl9ob3N0X2dldCBhbmQgZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQuCisKKyAg ICAgICAgKiBld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHA6CisgICAgICAgIChld2tfc2VjdXJp dHlfb3JpZ2luX3Byb3RvY29sX2dldCk6CisgICAgICAgIChld2tfc2VjdXJpdHlfb3JpZ2luX2hv c3RfZ2V0KToKKyAgICAgICAgKGV3a19zZWN1cml0eV9vcmlnaW5fbmV3KToKKyAgICAgICAgKiBl d2svZXdrX3NlY3VyaXR5X29yaWdpbi5oOgorCiAyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcENvbmZp Z3VyYXRpb25Gb3JWaWV3cG9ydCBzaG91bGQgbW92ZSB0byBJbnRlcm5hbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcAppbmRleCA2NjA2NGEwMjlhYmYz YTQzZmM4OWM4ZTdkY2I3ZGZlNDJhMmE0MTJhLi5kMTk4N2U0M2Y4NTZmNWRjZjExNDdkMjI1NGRl NzNhZjkxYTFhYjMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9v cmlnaW4uY3BwCkBAIC0zOSwxOSArMzksMTMgQEAgc3RydWN0IF9Fd2tfU2VjdXJpdHlfT3JpZ2lu IHsKICAgICBjb25zdCBjaGFyKiBob3N0OwogfTsKIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5 X29yaWdpbl9wcm90b2NvbF9nZXQoRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luKQorY29uc3Qg Y2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoY29uc3QgRXdrX1NlY3VyaXR5 X09yaWdpbiogb3JpZ2luKQogewotICAgIGlmICghb3JpZ2luLT5wcm90b2NvbCkKLSAgICAgICAg b3JpZ2luLT5wcm90b2NvbCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKG9yaWdpbi0+c2VjdXJpdHlP cmlnaW4tPnByb3RvY29sKCkudXRmOCgpLmRhdGEoKSk7Ci0KICAgICByZXR1cm4gb3JpZ2luLT5w cm90b2NvbDsKIH0KIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChF d2tfU2VjdXJpdHlfT3JpZ2luKiBvcmlnaW4pCitjb25zdCBjaGFyKiBld2tfc2VjdXJpdHlfb3Jp Z2luX2hvc3RfZ2V0KGNvbnN0IEV3a19TZWN1cml0eV9PcmlnaW4qIG9yaWdpbikKIHsKLSAgICBp ZiAoIW9yaWdpbi0+aG9zdCkKLSAgICAgICAgb3JpZ2luLT5ob3N0ID0gZWluYV9zdHJpbmdzaGFy ZV9hZGQob3JpZ2luLT5zZWN1cml0eU9yaWdpbi0+aG9zdCgpLnV0ZjgoKS5kYXRhKCkpOwotCiAg ICAgcmV0dXJuIG9yaWdpbi0+aG9zdDsKIH0KIApAQCAtMTQyLDggKzEzNiw4IEBAIEV3a19TZWN1 cml0eV9PcmlnaW4qIGV3a19zZWN1cml0eV9vcmlnaW5fbmV3KFdlYkNvcmU6OlNlY3VyaXR5T3Jp Z2luKiBjb3JlT3JpZ2luCiAgICAgRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luID0gbmV3IEV3 a19TZWN1cml0eV9PcmlnaW47CiAKICAgICBvcmlnaW4tPnNlY3VyaXR5T3JpZ2luID0gY29yZU9y aWdpbjsKLSAgICBvcmlnaW4tPmhvc3QgPSAwOwotICAgIG9yaWdpbi0+cHJvdG9jb2wgPSAwOwor ICAgIG9yaWdpbi0+cHJvdG9jb2wgPSBlaW5hX3N0cmluZ3NoYXJlX2FkZChjb3JlT3JpZ2luLT5w cm90b2NvbCgpLnV0ZjgoKS5kYXRhKCkpOworICAgIG9yaWdpbi0+aG9zdCA9IGVpbmFfc3RyaW5n c2hhcmVfYWRkKGNvcmVPcmlnaW4tPmhvc3QoKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIHJldHVy biBvcmlnaW47CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4u aAppbmRleCA5OGFiZjc2OWEyNDY3YWE2NmQzZWMwYjdmMTY2OGQxMTg5MTNiMGMzLi4yZmNiOTg5 ZDZiMWM1ZjRhZDA3NGM3OGQwZjZkNTM2Mjk3YWEyNWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmgKQEAgLTQ5LDkgKzQ5LDkgQEAgdHlwZWRlZiBzdHJ1 Y3QgX0V3a19TZWN1cml0eV9PcmlnaW4gRXdrX1NlY3VyaXR5X09yaWdpbjsKICAqIEl0IHJldHVy bnMgYSBpbnRlcm5hbCBzdHJpbmcgd2hpY2ggc2hvdWxkIG5vdAogICogYmUgbW9kaWZpZWQuIFRo ZSBzdHJpbmcgaXMgZ3VhcmFudGVlZCB0byBiZSBzdHJpbmdzaGFyZWQuCiAgKgotICogQHJldHVy biB0aGUgcHJvdG9jb2wgc2NoZW1lCisgKiBAcmV0dXJuIHRoZSBwcm90b2NvbCBzY2hlbWUsIGlm IHRoZXJlIGlzIG5vdCBhIHByb3RvY29sIHNjaGVtZSwgcmV0dXJuIE5VTEwuCiAgKi8KLUVBUEkg Y29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoRXdr X1NlY3VyaXR5X09yaWdpbiAqbyk7CitFQVBJIGNvbnN0IGNoYXIgICAgICAgICAgKmV3a19zZWN1 cml0eV9vcmlnaW5fcHJvdG9jb2xfZ2V0KGNvbnN0IEV3a19TZWN1cml0eV9PcmlnaW4gKm8pOwog CiAvKioKICAqIFJldHVybnMgdGhlIGhvc3Qgb2YgdGhlIHNlY3VyaXR5IG9yaWdpbi4KQEAgLTYx LDkgKzYxLDkgQEAgRUFQSSBjb25zdCBjaGFyICAgICAgICAgICpld2tfc2VjdXJpdHlfb3JpZ2lu X3Byb3RvY29sX2dldChFd2tfU2VjdXJpdHlfT3JpZ2luICoKICAqCiAgKiBAcGFyYW0gbyBzZWN1 cml0eSBvcmlnaW4gb2JqZWN0CiAgKgotICogQHJldHVybiB0aGUgaG9zdCBkb21haW4KKyAqIEBy ZXR1cm4gdGhlIGhvc3QgZG9tYWluLCBpZiB0aGVyZSBpcyBub3QgYSBob3N0IHNjaGVtZSwgcmV0 dXJuIE5VTEwuCiAgKi8KLUVBUEkgY29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29y aWdpbl9ob3N0X2dldChFd2tfU2VjdXJpdHlfT3JpZ2luICpvKTsKK0VBUEkgY29uc3QgY2hhciAg ICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChjb25zdCBFd2tfU2VjdXJpdHlf T3JpZ2luICpvKTsKIAogLyoqCiAgKiBSZXR1cm5zIHRoZSBwb3J0IG9mIHRoZSBzZWN1cml0eSBv cmlnaW4uCg== 151842 2012-07-11 18:46:40 -0700 2012-07-12 01:00:29 -0700 Patch bug-90954-20120712104638.patch text/plain 3694 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQxZjhiZjFi ZTg3YWI4Yjg2NmQ5OTVlZGY2OWUyOWIzMDY5MzY0MS4uMGEzNmUyOTgyYzIyZmE4ZmU5NzA3YjFl M2ZkNTIyYmZiOTUxYzQ1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTA3LTExICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEFkZCBjb25zdCB0byB0aGUgcGFyYW1ldGVyIG9mIGdldHRlcnMgaW4gZXdrX3NlY3Vy aXR5X29yaWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTA5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgY29uc3QgcXVhbGlmaWVyIHRvIHRoZSBwYXJhbWV0ZXIgb2YgZXdrX3NlY3VyaXR5X29y aWdpbl9ob3N0X2dldCBhbmQgZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQuCisKKyAg ICAgICAgKiBld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHA6CisgICAgICAgIChld2tfc2VjdXJp dHlfb3JpZ2luX3Byb3RvY29sX2dldCk6CisgICAgICAgIChld2tfc2VjdXJpdHlfb3JpZ2luX2hv c3RfZ2V0KToKKyAgICAgICAgKGV3a19zZWN1cml0eV9vcmlnaW5fbmV3KToKKyAgICAgICAgKiBl d2svZXdrX3NlY3VyaXR5X29yaWdpbi5oOgorCiAyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcENvbmZp Z3VyYXRpb25Gb3JWaWV3cG9ydCBzaG91bGQgbW92ZSB0byBJbnRlcm5hbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcAppbmRleCA2NjA2NGEwMjlhYmYz YTQzZmM4OWM4ZTdkY2I3ZGZlNDJhMmE0MTJhLi5kMTk4N2U0M2Y4NTZmNWRjZjExNDdkMjI1NGRl NzNhZjkxYTFhYjMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9v cmlnaW4uY3BwCkBAIC0zOSwxOSArMzksMTMgQEAgc3RydWN0IF9Fd2tfU2VjdXJpdHlfT3JpZ2lu IHsKICAgICBjb25zdCBjaGFyKiBob3N0OwogfTsKIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5 X29yaWdpbl9wcm90b2NvbF9nZXQoRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luKQorY29uc3Qg Y2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoY29uc3QgRXdrX1NlY3VyaXR5 X09yaWdpbiogb3JpZ2luKQogewotICAgIGlmICghb3JpZ2luLT5wcm90b2NvbCkKLSAgICAgICAg b3JpZ2luLT5wcm90b2NvbCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKG9yaWdpbi0+c2VjdXJpdHlP cmlnaW4tPnByb3RvY29sKCkudXRmOCgpLmRhdGEoKSk7Ci0KICAgICByZXR1cm4gb3JpZ2luLT5w cm90b2NvbDsKIH0KIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChF d2tfU2VjdXJpdHlfT3JpZ2luKiBvcmlnaW4pCitjb25zdCBjaGFyKiBld2tfc2VjdXJpdHlfb3Jp Z2luX2hvc3RfZ2V0KGNvbnN0IEV3a19TZWN1cml0eV9PcmlnaW4qIG9yaWdpbikKIHsKLSAgICBp ZiAoIW9yaWdpbi0+aG9zdCkKLSAgICAgICAgb3JpZ2luLT5ob3N0ID0gZWluYV9zdHJpbmdzaGFy ZV9hZGQob3JpZ2luLT5zZWN1cml0eU9yaWdpbi0+aG9zdCgpLnV0ZjgoKS5kYXRhKCkpOwotCiAg ICAgcmV0dXJuIG9yaWdpbi0+aG9zdDsKIH0KIApAQCAtMTQyLDggKzEzNiw4IEBAIEV3a19TZWN1 cml0eV9PcmlnaW4qIGV3a19zZWN1cml0eV9vcmlnaW5fbmV3KFdlYkNvcmU6OlNlY3VyaXR5T3Jp Z2luKiBjb3JlT3JpZ2luCiAgICAgRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luID0gbmV3IEV3 a19TZWN1cml0eV9PcmlnaW47CiAKICAgICBvcmlnaW4tPnNlY3VyaXR5T3JpZ2luID0gY29yZU9y aWdpbjsKLSAgICBvcmlnaW4tPmhvc3QgPSAwOwotICAgIG9yaWdpbi0+cHJvdG9jb2wgPSAwOwor ICAgIG9yaWdpbi0+cHJvdG9jb2wgPSBlaW5hX3N0cmluZ3NoYXJlX2FkZChjb3JlT3JpZ2luLT5w cm90b2NvbCgpLnV0ZjgoKS5kYXRhKCkpOworICAgIG9yaWdpbi0+aG9zdCA9IGVpbmFfc3RyaW5n c2hhcmVfYWRkKGNvcmVPcmlnaW4tPmhvc3QoKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIHJldHVy biBvcmlnaW47CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4u aAppbmRleCA5OGFiZjc2OWEyNDY3YWE2NmQzZWMwYjdmMTY2OGQxMTg5MTNiMGMzLi42M2I5NTA4 OTRjZjZhZTViYzZhNWNjNDgwZWQ4NTQ4N2ZkNDU3MGY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmgKQEAgLTQ5LDkgKzQ5LDkgQEAgdHlwZWRlZiBzdHJ1 Y3QgX0V3a19TZWN1cml0eV9PcmlnaW4gRXdrX1NlY3VyaXR5X09yaWdpbjsKICAqIEl0IHJldHVy bnMgYSBpbnRlcm5hbCBzdHJpbmcgd2hpY2ggc2hvdWxkIG5vdAogICogYmUgbW9kaWZpZWQuIFRo ZSBzdHJpbmcgaXMgZ3VhcmFudGVlZCB0byBiZSBzdHJpbmdzaGFyZWQuCiAgKgotICogQHJldHVy biB0aGUgcHJvdG9jb2wgc2NoZW1lCisgKiBAcmV0dXJuIHRoZSBwcm90b2NvbCBzY2hlbWUgb3Ig MCBpZiB0aGVyZSBpcyBub3QgYSBwcm90b2NvbCBzY2hlbWUuCiAgKi8KLUVBUEkgY29uc3QgY2hh ciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoRXdrX1NlY3VyaXR5 X09yaWdpbiAqbyk7CitFQVBJIGNvbnN0IGNoYXIgICAgICAgICAgKmV3a19zZWN1cml0eV9vcmln aW5fcHJvdG9jb2xfZ2V0KGNvbnN0IEV3a19TZWN1cml0eV9PcmlnaW4gKm8pOwogCiAvKioKICAq IFJldHVybnMgdGhlIGhvc3Qgb2YgdGhlIHNlY3VyaXR5IG9yaWdpbi4KQEAgLTYxLDkgKzYxLDkg QEAgRUFQSSBjb25zdCBjaGFyICAgICAgICAgICpld2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29s X2dldChFd2tfU2VjdXJpdHlfT3JpZ2luICoKICAqCiAgKiBAcGFyYW0gbyBzZWN1cml0eSBvcmln aW4gb2JqZWN0CiAgKgotICogQHJldHVybiB0aGUgaG9zdCBkb21haW4KKyAqIEByZXR1cm4gdGhl IGhvc3QgZG9tYWluIG9yIDAgaWYgdGhlcmUgaXMgbm90IGEgaG9zdCBzY2hlbWUuCiAgKi8KLUVB UEkgY29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChFd2tf U2VjdXJpdHlfT3JpZ2luICpvKTsKK0VBUEkgY29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3Vy aXR5X29yaWdpbl9ob3N0X2dldChjb25zdCBFd2tfU2VjdXJpdHlfT3JpZ2luICpvKTsKIAogLyoq CiAgKiBSZXR1cm5zIHRoZSBwb3J0IG9mIHRoZSBzZWN1cml0eSBvcmlnaW4uCg== 151877 2012-07-12 01:00:42 -0700 2012-07-12 05:16:03 -0700 Patch bug-90954-20120712170041.patch text/plain 3794 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQxZjhiZjFi ZTg3YWI4Yjg2NmQ5OTVlZGY2OWUyOWIzMDY5MzY0MS4uYjI0ZDZjMmJhZjA2Zjk5MjE4OGMwNjEz OTVlMTMwMjQ0ZDcwNTc0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTA3LTEyICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEFkZCBjb25zdCB0byB0aGUgcGFyYW1ldGVyIG9mIGdldHRlcnMgaW4gZXdrX3NlY3Vy aXR5X29yaWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTA5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgY29uc3QgcXVhbGlmaWVyIHRvIHRoZSBwYXJhbWV0ZXIgb2YgZXdrX3NlY3VyaXR5X29y aWdpbl9ob3N0X2dldCBhbmQgZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQuCisKKyAg ICAgICAgKiBld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHA6CisgICAgICAgIChld2tfc2VjdXJp dHlfb3JpZ2luX3Byb3RvY29sX2dldCk6CisgICAgICAgIChld2tfc2VjdXJpdHlfb3JpZ2luX2hv c3RfZ2V0KToKKyAgICAgICAgKGV3a19zZWN1cml0eV9vcmlnaW5fbmV3KToKKyAgICAgICAgKiBl d2svZXdrX3NlY3VyaXR5X29yaWdpbi5oOgorCiAyMDEyLTA3LTEwICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcENvbmZp Z3VyYXRpb25Gb3JWaWV3cG9ydCBzaG91bGQgbW92ZSB0byBJbnRlcm5hbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcAppbmRleCA2NjA2NGEwMjlhYmYz YTQzZmM4OWM4ZTdkY2I3ZGZlNDJhMmE0MTJhLi4wNzYxNTg2NjM5Yjk4Y2IyYWUzNmNkNGRiOWUx ZDM4OWFkODJhZWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9v cmlnaW4uY3BwCkBAIC0zOSwxOSArMzksMTUgQEAgc3RydWN0IF9Fd2tfU2VjdXJpdHlfT3JpZ2lu IHsKICAgICBjb25zdCBjaGFyKiBob3N0OwogfTsKIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5 X29yaWdpbl9wcm90b2NvbF9nZXQoRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luKQorY29uc3Qg Y2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoY29uc3QgRXdrX1NlY3VyaXR5 X09yaWdpbiogb3JpZ2luKQogewotICAgIGlmICghb3JpZ2luLT5wcm90b2NvbCkKLSAgICAgICAg b3JpZ2luLT5wcm90b2NvbCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKG9yaWdpbi0+c2VjdXJpdHlP cmlnaW4tPnByb3RvY29sKCkudXRmOCgpLmRhdGEoKSk7Ci0KKyAgICBFSU5BX1NBRkVUWV9PTl9O VUxMX1JFVFVSTl9WQUwob3JpZ2luLCAwKTsKICAgICByZXR1cm4gb3JpZ2luLT5wcm90b2NvbDsK IH0KIAotY29uc3QgY2hhciogZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChFd2tfU2VjdXJp dHlfT3JpZ2luKiBvcmlnaW4pCitjb25zdCBjaGFyKiBld2tfc2VjdXJpdHlfb3JpZ2luX2hvc3Rf Z2V0KGNvbnN0IEV3a19TZWN1cml0eV9PcmlnaW4qIG9yaWdpbikKIHsKLSAgICBpZiAoIW9yaWdp bi0+aG9zdCkKLSAgICAgICAgb3JpZ2luLT5ob3N0ID0gZWluYV9zdHJpbmdzaGFyZV9hZGQob3Jp Z2luLT5zZWN1cml0eU9yaWdpbi0+aG9zdCgpLnV0ZjgoKS5kYXRhKCkpOwotCisgICAgRUlOQV9T QUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKG9yaWdpbiwgMCk7CiAgICAgcmV0dXJuIG9yaWdpbi0+ aG9zdDsKIH0KIApAQCAtMTQyLDggKzEzOCw4IEBAIEV3a19TZWN1cml0eV9PcmlnaW4qIGV3a19z ZWN1cml0eV9vcmlnaW5fbmV3KFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luKiBjb3JlT3JpZ2luCiAg ICAgRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luID0gbmV3IEV3a19TZWN1cml0eV9PcmlnaW47 CiAKICAgICBvcmlnaW4tPnNlY3VyaXR5T3JpZ2luID0gY29yZU9yaWdpbjsKLSAgICBvcmlnaW4t Pmhvc3QgPSAwOwotICAgIG9yaWdpbi0+cHJvdG9jb2wgPSAwOworICAgIG9yaWdpbi0+cHJvdG9j b2wgPSBlaW5hX3N0cmluZ3NoYXJlX2FkZChjb3JlT3JpZ2luLT5wcm90b2NvbCgpLnV0ZjgoKS5k YXRhKCkpOworICAgIG9yaWdpbi0+aG9zdCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKGNvcmVPcmln aW4tPmhvc3QoKS51dGY4KCkuZGF0YSgpKTsKIAogICAgIHJldHVybiBvcmlnaW47CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5oIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4uaAppbmRleCA5OGFiZjc2OWEy NDY3YWE2NmQzZWMwYjdmMTY2OGQxMTg5MTNiMGMzLi4yZDllYTQ2NzVmMmVlZGE0ZjJmZjM3N2Mw MTY0ZGNhYWVkMzFmYTdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Nl Y3VyaXR5X29yaWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlf b3JpZ2luLmgKQEAgLTQ5LDkgKzQ5LDkgQEAgdHlwZWRlZiBzdHJ1Y3QgX0V3a19TZWN1cml0eV9P cmlnaW4gRXdrX1NlY3VyaXR5X09yaWdpbjsKICAqIEl0IHJldHVybnMgYSBpbnRlcm5hbCBzdHJp bmcgd2hpY2ggc2hvdWxkIG5vdAogICogYmUgbW9kaWZpZWQuIFRoZSBzdHJpbmcgaXMgZ3VhcmFu dGVlZCB0byBiZSBzdHJpbmdzaGFyZWQuCiAgKgotICogQHJldHVybiB0aGUgcHJvdG9jb2wgc2No ZW1lCisgKiBAcmV0dXJuIHRoZSBwcm90b2NvbCBzY2hlbWUgb3IgQGMgMCBpZiB0aGVyZSBpcyBu b3QgYSBwcm90b2NvbCBzY2hlbWUKICAqLwotRUFQSSBjb25zdCBjaGFyICAgICAgICAgICpld2tf c2VjdXJpdHlfb3JpZ2luX3Byb3RvY29sX2dldChFd2tfU2VjdXJpdHlfT3JpZ2luICpvKTsKK0VB UEkgY29uc3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQo Y29uc3QgRXdrX1NlY3VyaXR5X09yaWdpbiAqbyk7CiAKIC8qKgogICogUmV0dXJucyB0aGUgaG9z dCBvZiB0aGUgc2VjdXJpdHkgb3JpZ2luLgpAQCAtNjEsOSArNjEsOSBAQCBFQVBJIGNvbnN0IGNo YXIgICAgICAgICAgKmV3a19zZWN1cml0eV9vcmlnaW5fcHJvdG9jb2xfZ2V0KEV3a19TZWN1cml0 eV9PcmlnaW4gKgogICoKICAqIEBwYXJhbSBvIHNlY3VyaXR5IG9yaWdpbiBvYmplY3QKICAqCi0g KiBAcmV0dXJuIHRoZSBob3N0IGRvbWFpbgorICogQHJldHVybiB0aGUgaG9zdCBkb21haW4gb3Ig QGMgMCBpZiB0aGVyZSBpcyBub3QgYSBob3N0IHNjaGVtZQogICovCi1FQVBJIGNvbnN0IGNoYXIg ICAgICAgICAgKmV3a19zZWN1cml0eV9vcmlnaW5faG9zdF9nZXQoRXdrX1NlY3VyaXR5X09yaWdp biAqbyk7CitFQVBJIGNvbnN0IGNoYXIgICAgICAgICAgKmV3a19zZWN1cml0eV9vcmlnaW5faG9z dF9nZXQoY29uc3QgRXdrX1NlY3VyaXR5X09yaWdpbiAqbyk7CiAKIC8qKgogICogUmV0dXJucyB0 aGUgcG9ydCBvZiB0aGUgc2VjdXJpdHkgb3JpZ2luLgo= 151918 2012-07-12 05:16:14 -0700 2012-07-13 04:43:55 -0700 Patch bug-90954-20120712211612.patch text/plain 3949 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMTQxZjhiZjFi ZTg3YWI4Yjg2NmQ5OTVlZGY2OWUyOWIzMDY5MzY0MS4uYTllYmUxODY1MDk3ZTUzZWFkMjJlMWQ4 ZTA4N2IyNDZlNGY3OTdkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEy LTA3LTEyICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEFkZCBjb25zdCB0byB0aGUgcGFyYW1ldGVyIG9mIGdldHRlcnMgaW4gZXdrX3NlY3Vy aXR5X29yaWdpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTA5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNb3ZlIGluaXRpYWxpemF0aW9uIG9mIHN0cmluZ3MgZm9yIHByb3RvY29sIGFuZCBob3N0IHRv IHRoZSBld2tfc2VjdXJpdHlfb3JpZ2luX25ldyBtZXRob2QsCisgICAgICAgIHdoaWNoIGFsbG93 cyB0byBhZGQgY29uc3QgcXVhbGlmaWVyIGZvciBld2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29s X2dldCBhbmQgZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldC4KKyAgICAgICAgSW4gYWRkaXRp b24sIGFkZCBudWxsIGNoZWNrcyB0byB0aGUgZ2V0dGVycy4KKworICAgICAgICAqIGV3ay9ld2tf c2VjdXJpdHlfb3JpZ2luLmNwcDoKKyAgICAgICAgKGV3a19zZWN1cml0eV9vcmlnaW5fcHJvdG9j b2xfZ2V0KToKKyAgICAgICAgKGV3a19zZWN1cml0eV9vcmlnaW5faG9zdF9nZXQpOgorICAgICAg ICAoZXdrX3NlY3VyaXR5X29yaWdpbl9uZXcpOgorICAgICAgICAqIGV3ay9ld2tfc2VjdXJpdHlf b3JpZ2luLmg6CisKIDIwMTItMDctMTAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBMYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQ29uZmlndXJhdGlvbkZvclZpZXdw b3J0IHNob3VsZCBtb3ZlIHRvIEludGVybmFscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4uY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19zZWN1cml0eV9vcmlnaW4uY3BwCmluZGV4IDY2MDY0YTAyOWFiZjNhNDNmYzg5YzhlN2RjYjdk ZmU0MmEyYTQxMmEuLjA3NjE1ODY2MzliOThjYjJhZTM2Y2Q0ZGI5ZTFkMzg5YWQ4MmFlYjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAKQEAgLTM5 LDE5ICszOSwxNSBAQCBzdHJ1Y3QgX0V3a19TZWN1cml0eV9PcmlnaW4gewogICAgIGNvbnN0IGNo YXIqIGhvc3Q7CiB9OwogCi1jb25zdCBjaGFyKiBld2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29s X2dldChFd2tfU2VjdXJpdHlfT3JpZ2luKiBvcmlnaW4pCitjb25zdCBjaGFyKiBld2tfc2VjdXJp dHlfb3JpZ2luX3Byb3RvY29sX2dldChjb25zdCBFd2tfU2VjdXJpdHlfT3JpZ2luKiBvcmlnaW4p CiB7Ci0gICAgaWYgKCFvcmlnaW4tPnByb3RvY29sKQotICAgICAgICBvcmlnaW4tPnByb3RvY29s ID0gZWluYV9zdHJpbmdzaGFyZV9hZGQob3JpZ2luLT5zZWN1cml0eU9yaWdpbi0+cHJvdG9jb2wo KS51dGY4KCkuZGF0YSgpKTsKLQorICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTChv cmlnaW4sIDApOwogICAgIHJldHVybiBvcmlnaW4tPnByb3RvY29sOwogfQogCi1jb25zdCBjaGFy KiBld2tfc2VjdXJpdHlfb3JpZ2luX2hvc3RfZ2V0KEV3a19TZWN1cml0eV9PcmlnaW4qIG9yaWdp bikKK2NvbnN0IGNoYXIqIGV3a19zZWN1cml0eV9vcmlnaW5faG9zdF9nZXQoY29uc3QgRXdrX1Nl Y3VyaXR5X09yaWdpbiogb3JpZ2luKQogewotICAgIGlmICghb3JpZ2luLT5ob3N0KQotICAgICAg ICBvcmlnaW4tPmhvc3QgPSBlaW5hX3N0cmluZ3NoYXJlX2FkZChvcmlnaW4tPnNlY3VyaXR5T3Jp Z2luLT5ob3N0KCkudXRmOCgpLmRhdGEoKSk7Ci0KKyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JF VFVSTl9WQUwob3JpZ2luLCAwKTsKICAgICByZXR1cm4gb3JpZ2luLT5ob3N0OwogfQogCkBAIC0x NDIsOCArMTM4LDggQEAgRXdrX1NlY3VyaXR5X09yaWdpbiogZXdrX3NlY3VyaXR5X29yaWdpbl9u ZXcoV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4qIGNvcmVPcmlnaW4KICAgICBFd2tfU2VjdXJpdHlf T3JpZ2luKiBvcmlnaW4gPSBuZXcgRXdrX1NlY3VyaXR5X09yaWdpbjsKIAogICAgIG9yaWdpbi0+ c2VjdXJpdHlPcmlnaW4gPSBjb3JlT3JpZ2luOwotICAgIG9yaWdpbi0+aG9zdCA9IDA7Ci0gICAg b3JpZ2luLT5wcm90b2NvbCA9IDA7CisgICAgb3JpZ2luLT5wcm90b2NvbCA9IGVpbmFfc3RyaW5n c2hhcmVfYWRkKGNvcmVPcmlnaW4tPnByb3RvY29sKCkudXRmOCgpLmRhdGEoKSk7CisgICAgb3Jp Z2luLT5ob3N0ID0gZWluYV9zdHJpbmdzaGFyZV9hZGQoY29yZU9yaWdpbi0+aG9zdCgpLnV0Zjgo KS5kYXRhKCkpOwogCiAgICAgcmV0dXJuIG9yaWdpbjsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3NlY3VyaXR5X29yaWdpbi5oCmluZGV4IDk4YWJmNzY5YTI0NjdhYTY2ZDNlYzBiN2Yx NjY4ZDExODkxM2IwYzMuLjJkOWVhNDY3NWYyZWVkYTRmMmZmMzc3YzAxNjRkY2FhZWQzMWZhN2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmgK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4uaApAQCAtNDks OSArNDksOSBAQCB0eXBlZGVmIHN0cnVjdCBfRXdrX1NlY3VyaXR5X09yaWdpbiBFd2tfU2VjdXJp dHlfT3JpZ2luOwogICogSXQgcmV0dXJucyBhIGludGVybmFsIHN0cmluZyB3aGljaCBzaG91bGQg bm90CiAgKiBiZSBtb2RpZmllZC4gVGhlIHN0cmluZyBpcyBndWFyYW50ZWVkIHRvIGJlIHN0cmlu Z3NoYXJlZC4KICAqCi0gKiBAcmV0dXJuIHRoZSBwcm90b2NvbCBzY2hlbWUKKyAqIEByZXR1cm4g dGhlIHByb3RvY29sIHNjaGVtZSBvciBAYyAwIGlmIHRoZXJlIGlzIG5vdCBhIHByb3RvY29sIHNj aGVtZQogICovCi1FQVBJIGNvbnN0IGNoYXIgICAgICAgICAgKmV3a19zZWN1cml0eV9vcmlnaW5f cHJvdG9jb2xfZ2V0KEV3a19TZWN1cml0eV9PcmlnaW4gKm8pOworRUFQSSBjb25zdCBjaGFyICAg ICAgICAgICpld2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29sX2dldChjb25zdCBFd2tfU2VjdXJp dHlfT3JpZ2luICpvKTsKIAogLyoqCiAgKiBSZXR1cm5zIHRoZSBob3N0IG9mIHRoZSBzZWN1cml0 eSBvcmlnaW4uCkBAIC02MSw5ICs2MSw5IEBAIEVBUEkgY29uc3QgY2hhciAgICAgICAgICAqZXdr X3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoRXdrX1NlY3VyaXR5X09yaWdpbiAqCiAgKgog ICogQHBhcmFtIG8gc2VjdXJpdHkgb3JpZ2luIG9iamVjdAogICoKLSAqIEByZXR1cm4gdGhlIGhv c3QgZG9tYWluCisgKiBAcmV0dXJuIHRoZSBob3N0IGRvbWFpbiBvciBAYyAwIGlmIHRoZXJlIGlz IG5vdCBhIGhvc3Qgc2NoZW1lCiAgKi8KLUVBUEkgY29uc3QgY2hhciAgICAgICAgICAqZXdrX3Nl Y3VyaXR5X29yaWdpbl9ob3N0X2dldChFd2tfU2VjdXJpdHlfT3JpZ2luICpvKTsKK0VBUEkgY29u c3QgY2hhciAgICAgICAgICAqZXdrX3NlY3VyaXR5X29yaWdpbl9ob3N0X2dldChjb25zdCBFd2tf U2VjdXJpdHlfT3JpZ2luICpvKTsKIAogLyoqCiAgKiBSZXR1cm5zIHRoZSBwb3J0IG9mIHRoZSBz ZWN1cml0eSBvcmlnaW4uCg==