90852 2012-07-10 00:04:50 -0700 REGRESSION(r122166): It made 170 tests crash on 32 bit platforms 2012-07-10 02:37:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 79668 90731 1 ossy webkit-unassigned barraclough fpizlo ossy webkit.review.bot oldest_to_newest 665519 0 ossy 2012-07-10 00:04:50 -0700 https://trac.webkit.org/changeset/122166 made 170 tests cras on 32 bit platforms. (at least on Qt and GTK) GTK: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r122167%20%2824889%29/results.html Qt: http://build.webkit.org/results/Qt%20Linux%20Release/r122167%20%2849248%29/results.html 665560 1 151416 fpizlo 2012-07-10 01:21:22 -0700 Created attachment 151416 the patch This might fix it. 665562 2 151417 fpizlo 2012-07-10 01:30:59 -0700 Created attachment 151417 better patch Really fix it this time. 665572 3 151417 zherczeg 2012-07-10 01:49:12 -0700 Comment on attachment 151417 better patch r=me 665597 4 151417 ossy 2012-07-10 02:36:25 -0700 Comment on attachment 151417 better patch Clearing flags on attachment: 151417 Committed r122208: <http://trac.webkit.org/changeset/122208> 665599 5 ossy 2012-07-10 02:36:32 -0700 All reviewed patches have been landed. Closing bug. 151416 2012-07-10 01:21:22 -0700 2012-07-10 01:30:59 -0700 the patch fixstubroutine_patch_1.diff text/plain 1573 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIyMjA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA3LTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTihyMTIyMTY2KTogSXQgbWFkZSAxNzAgdGVzdHMgY3Jhc2ggb24gMzIgYml0IHBs YXRmb3JtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA4NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIElmIHdlIGNhbid0IHVzZSB0aGUgcmFuZ2UgZmlsdGVyLCB3ZSBzaG91bGQgc3RpbGwg bWFrZSBzdXJlIHRoYXQgdGhlCisgICAgICAgIGFkZHJlc3MgaXMgcmVtb3RlbHkgc2FuZSwgb3Ro ZXJ3aXNlIHRoZSBoYXNodGFibGVzIHdpbGwgYXNzZXJ0LgorCisgICAgICAgICogaml0L0pJVFN0 dWJSb3V0aW5lLmg6CisgICAgICAgIChKU0M6OkpJVFN0dWJSb3V0aW5lOjpwYXNzZXNGaWx0ZXIp OgorCiAyMDEyLTA3LTA5ICBNYXR0IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4K IAogICAgICAgICBBZGQgRU5BQkxFX0RJQUxPR19FTEVNRU5UIGFuZCBza2VsZXRvbiBmaWxlcwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHViUm91dGluZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YlJvdXRpbmUuaAkocmV2aXNp b24gMTIyMTgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHViUm91dGluZS5o CSh3b3JraW5nIGNvcHkpCkBAIC0xMzAsOCArMTMwLDExIEBAIHB1YmxpYzoKICAgICB9CiAgICAg c3RhdGljIGJvb2wgcGFzc2VzRmlsdGVyKHVpbnRwdHJfdCBhZGRyZXNzKQogICAgIHsKLSAgICAg ICAgaWYgKCFjYW5QZXJmb3JtUmFuZ2VGaWx0ZXIoKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVl OworICAgICAgICBpZiAoIWNhblBlcmZvcm1SYW5nZUZpbHRlcigpKSB7CisgICAgICAgICAgICAv LyBKdXN0IGNoZWNrIHRoYXQgdGhlIGFkZHJlc3MgZG9lc24ndCB1c2UgYW55IHNwZWNpYWwgdmFs dWVzIHRoYXQgd291bGQgbWFrZQorICAgICAgICAgICAgLy8gb3VyIGhhc2h0YWJsZXMgdXBzZXQu CisgICAgICAgICAgICByZXR1cm4gISFhZGRyZXNzICYmIGFkZHJlc3MgIT0gc3RkOjpudW1lcmlj X2xpbWl0czx1aW50cHRyX3Q+OjptYXgoKTsKKyAgICAgICAgfQogICAgICAgICAKICAgICAgICAg aWYgKGFkZHJlc3MgLSBmaWx0ZXJpbmdTdGFydEFkZHJlc3MoKSA+PSBmaWx0ZXJpbmdFeHRlbnRT aXplKCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cg== 151417 2012-07-10 01:30:59 -0700 2012-07-10 02:36:25 -0700 better patch fixstubroutine_patch_2.diff text/plain 1595 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIyMjA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA3LTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTihyMTIyMTY2KTogSXQgbWFkZSAxNzAgdGVzdHMgY3Jhc2ggb24gMzIgYml0IHBs YXRmb3JtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA4NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIElmIHdlIGNhbid0IHVzZSB0aGUgcmFuZ2UgZmlsdGVyLCB3ZSBzaG91bGQgc3RpbGwg bWFrZSBzdXJlIHRoYXQgdGhlCisgICAgICAgIGFkZHJlc3MgaXMgcmVtb3RlbHkgc2FuZSwgb3Ro ZXJ3aXNlIHRoZSBoYXNodGFibGVzIHdpbGwgYXNzZXJ0LgorCisgICAgICAgICogaml0L0pJVFN0 dWJSb3V0aW5lLmg6CisgICAgICAgIChKU0M6OkpJVFN0dWJSb3V0aW5lOjpwYXNzZXNGaWx0ZXIp OgorCiAyMDEyLTA3LTA5ICBNYXR0IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4K IAogICAgICAgICBBZGQgRU5BQkxFX0RJQUxPR19FTEVNRU5UIGFuZCBza2VsZXRvbiBmaWxlcwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHViUm91dGluZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YlJvdXRpbmUuaAkocmV2aXNp b24gMTIyMTgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHViUm91dGluZS5o CSh3b3JraW5nIGNvcHkpCkBAIC0xMzAsOCArMTMwLDExIEBAIHB1YmxpYzoKICAgICB9CiAgICAg c3RhdGljIGJvb2wgcGFzc2VzRmlsdGVyKHVpbnRwdHJfdCBhZGRyZXNzKQogICAgIHsKLSAgICAg ICAgaWYgKCFjYW5QZXJmb3JtUmFuZ2VGaWx0ZXIoKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVl OworICAgICAgICBpZiAoIWNhblBlcmZvcm1SYW5nZUZpbHRlcigpKSB7CisgICAgICAgICAgICAv LyBKdXN0IGNoZWNrIHRoYXQgdGhlIGFkZHJlc3MgZG9lc24ndCB1c2UgYW55IHNwZWNpYWwgdmFs dWVzIHRoYXQgd291bGQgbWFrZQorICAgICAgICAgICAgLy8gb3VyIGhhc2h0YWJsZXMgdXBzZXQu CisgICAgICAgICAgICByZXR1cm4gYWRkcmVzcyA+PSBqaXRBbGxvY2F0aW9uR3JhbnVsZSAmJiBh ZGRyZXNzICE9IHN0ZDo6bnVtZXJpY19saW1pdHM8dWludHB0cl90Pjo6bWF4KCk7CisgICAgICAg IH0KICAgICAgICAgCiAgICAgICAgIGlmIChhZGRyZXNzIC0gZmlsdGVyaW5nU3RhcnRBZGRyZXNz KCkgPj0gZmlsdGVyaW5nRXh0ZW50U2l6ZSgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo=