90850 2012-07-09 23:49:19 -0700 [Qt] REGRESSION(r122175): It broke the Windows build 2012-07-10 06:27:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 90506 1 ossy ossy mrobinson noam ossy vestbo webkit.review.bot oldest_to_newest 665512 0 ossy 2012-07-09 23:49:19 -0700 It broke the Qt Windows build: /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:13:2: error: #error Trying to build a posix specific file in a non-posix build. /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp: In function 'OS_TLSIndex OS_AllocTLSIndex()': /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:21:5: error: 'pthread_key_t' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:21:19: error: expected ';' before 'pPoolIndex' /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:26:30: error: 'pPoolIndex' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:26:46: error: 'pthread_key_create' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp: In function 'bool OS_SetTLSValue(OS_TLSIndex, void*)': /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:43:45: error: 'pthread_setspecific' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp: In function 'bool OS_FreeTLSIndex(OS_TLSIndex)': /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:60:34: error: 'pthread_key_delete' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:64:1: warning: control reaches end of non-void function /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp: In function 'bool OS_SetTLSValue(OS_TLSIndex, void*)': /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:47:1: warning: control reaches end of non-void function /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp: In function 'OS_TLSIndex OS_AllocTLSIndex()': /ramdisk/qt-windows-32bit-release/build/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:33:1: warning: control reaches end of non-void function 665587 1 ossy 2012-07-10 02:12:09 -0700 I made some digging: Building ossource_posix.cpp was disabled on win previously, not only this file, but WEBGL was disabled: features.prf: ... # WebGL support !contains(DEFINES, ENABLE_WEBGL=.) { contains(QT_CONFIG, opengl):!win32-*: DEFINES += ENABLE_WEBGL=1 } ... Before r122175 building of these files was in ENABLE_WEBGL _and_ contains(QT_CONFIG, opengl) | contains(QT_CONFIG, opengles2) blocks. After r122175 building of these files are in USE(3DGRAPHICS) block. I think the problem is that we try to build ossource_posix.cpp for Windows. If we really want to enable 3DGRAPHICS on Windows, we should use ossource_win.cpp instead of ossource_posix.cpp. Or we should disable 3DGRAPHICS on Windows. 665603 2 ossy 2012-07-10 02:41:11 -0700 I tried to use ossource_win.cpp instead of ossource_posix.cpp, but I got zillion different build errors later: In file included from /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:39:0: /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:59:43: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:46: error: 'GLintptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:56: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:79:92: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:80:93: error: 'GLchar' has not been declared make[4]: *** [obj/release/Extensions3DOpenGL.o] Error 1 make[4]: *** Waiting for unfinished jobs.... In file included from /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:55:0: /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:59:43: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:46: error: 'GLintptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:56: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:79:92: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:80:93: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'void WebCore::GraphicsContext3D::prepareTexture()': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:171:23: error: 'GL_TEXTURE0' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'void WebCore::GraphicsContext3D::bindTexture(GC3Denum, Platform3DObject)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:353:28: error: 'GL_TEXTURE0' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'bool WebCore::GraphicsContext3D::getActiveAttrib(Platform3DObject, GC3Duint, WebCore::ActiveInfo&)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:619:31: error: 'GL_ACTIVE_ATTRIBUTE_MAX_LENGTH' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:620:5: error: 'GLchar' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:620:12: error: expected ';' before 'name' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:624:86: error: 'name' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'bool WebCore::GraphicsContext3D::getActiveUniform(Platform3DObject, GC3Duint, WebCore::ActiveInfo&)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:642:31: error: 'GL_ACTIVE_UNIFORM_MAX_LENGTH' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:644:17: error: 'GLchar' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:644:23: error: template argument 1 is invalid /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:644:30: error: invalid type in declaration before '=' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:644:50: error: expected type-specifier before 'GLchar' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:644:50: error: expected ')' before 'GLchar' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:644:72: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:648:90: error: request for member 'get' in 'name', which is of non-class type 'int' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:652:29: error: request for member 'get' in 'name', which is of non-class type 'int' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'WTF::String WebCore::GraphicsContext3D::getProgramInfoLog(Platform3DObject)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1124:31: error: 'GL_INFO_LOG_LENGTH' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1129:17: error: 'GLchar' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1129:23: error: template argument 1 is invalid /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1129:30: error: invalid type in declaration before '=' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1129:50: error: expected type-specifier before 'GLchar' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1129:50: error: expected ')' before 'GLchar' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1129:64: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1130:56: error: request for member 'get' in 'info', which is of non-class type 'int' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1132:24: error: request for member 'get' in 'info', which is of non-class type 'int' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'WTF::String WebCore::GraphicsContext3D::getShaderInfoLog(Platform3DObject)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1191:29: error: 'GL_INFO_LOG_LENGTH' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1196:17: error: 'GLchar' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1196:23: error: template argument 1 is invalid /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1196:30: error: invalid type in declaration before '=' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1196:50: error: expected type-specifier before 'GLchar' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1196:50: error: expected ')' before 'GLchar' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1196:64: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1197:54: error: request for member 'get' in 'info', which is of non-class type 'int' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1199:24: error: request for member 'get' in 'info', which is of non-class type 'int' /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'void WebCore::GraphicsContext3D::compressedTexImage2D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dint, GC3Dsizei, const void*)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1280:5: error: '::glCompressedTexImage2D' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'void WebCore::GraphicsContext3D::compressedTexSubImage2D(GC3Denum, GC3Dint, GC3Dint, GC3Dint, GC3Dsizei, GC3Dsizei, GC3Denum, GC3Dsizei, const void*)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1286:5: error: '::glCompressedTexSubImage2D' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'Platform3DObject WebCore::GraphicsContext3D::createShader(GC3Denum)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1322:55: error: 'GL_FRAGMENT_SHADER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1322:76: error: 'GL_VERTEX_SHADER' was not declared in this scope In file included from /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:27:0, from /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:22: /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:59:43: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:46: error: 'GLintptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:56: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:79:92: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:80:93: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1323:1: warning: control reaches end of non-void function /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'WTF::String WebCore::GraphicsContext3D::getShaderInfoLog(Platform3DObject)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1200:1: warning: control reaches end of non-void function /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'WTF::String WebCore::GraphicsContext3D::getProgramInfoLog(Platform3DObject)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1133:1: warning: control reaches end of non-void function make[4]: *** [obj/release/GraphicsContext3DOpenGLCommon.o] Error 1 In file included from /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:29:0: /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:59:43: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:46: error: 'GLintptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:56: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:79:92: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:80:93: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp: In member function 'void WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer() const': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:234:23: error: 'GL_READ_FRAMEBUFFER_EXT' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:235:23: error: 'GL_DRAW_FRAMEBUFFER_EXT' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp: In constructor 'WebCore::GraphicsContext3D::GraphicsContext3D(WebCore::GraphicsContext3D::Attributes, WebCore::HostWindow*, bool)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:325:23: error: 'GL_TEXTURE0' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:401:14: error: 'GL_POINT_SPRITE' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:402:14: error: 'GL_VERTEX_PROGRAM_POINT_SIZE' was not declared in this scope In file included from /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h:28:0, from /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:23: /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:59:43: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:46: error: 'GLintptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:60:56: error: 'GLsizeiptr' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:79:92: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h:80:93: error: 'GLchar' has not been declared /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'virtual void WebCore::TextureMapperGL::beginPainting(WebCore::TextureMapper::PaintFlags)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:256:5: error: 'GL_CURRENT_PROGRAM' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:272:19: error: 'GL_FRAMEBUFFER_BINDING' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'void WebCore::TextureMapperGL::drawQuad(const WebCore::TextureMapperGL::DrawQuad&, const WebCore::TransformationMatrix&, WebCore::TextureMapperShaderProgram*, GLenum, bool)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:311:5: error: 'GL_ARRAY_BUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'void WebCore::TextureMapperGL::drawTexturedQuadWithProgram(WebCore::TextureMapperShaderProgram*, uint32_t, WebCore::TextureMapperGL::Flags, const WebCore::TextureMapperGL::DrawQuad&, const WebCore::TransformationMatrix&, float, const WebCore::BitmapTexture*)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:559:5: error: 'GL_TEXTURE0' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:570:9: error: 'GL_TEXTURE1' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:573:9: error: 'GL_TEXTURE0' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'virtual void WebCore::BitmapTextureGL::didReset()': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:614:5: error: 'GL_CLAMP_TO_EDGE' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:615:5: error: 'GL_CLAMP_TO_EDGE' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'void WebCore::TextureMapperGL::drawFiltered(const WebCore::BitmapTexture&, const WebCore::BitmapTexture&, const WebCore::FilterOperation&, int)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:683:5: error: 'GL_TEXTURE0' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In function 'WebCore::TransformationMatrix WebCore::createProjectionMatrix(const WebCore::IntSize&, bool)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:721:22: error: expected unqualified-id before '=' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:722:21: error: expected unqualified-id before '=' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:724:32: error: expected primary-expression before '(' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:726:57: error: expected primary-expression before ')' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:727:68: error: expected primary-expression before ')' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:727:83: error: expected primary-expression before ')' token /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'void WebCore::BitmapTextureGL::initializeStencil()': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:735:5: error: 'GL_RENDERBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:739:5: error: 'GL_RENDERBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:739:5: error: 'GL_DEPTH_STENCIL' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:741:5: error: 'GL_RENDERBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:742:5: error: 'GL_FRAMEBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:742:5: error: 'GL_STENCIL_ATTACHMENT' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:742:5: error: 'GL_RENDERBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'void WebCore::BitmapTextureGL::createFboIfNeeded()': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:765:5: error: 'GL_FRAMEBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:766:5: error: 'GL_FRAMEBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:766:5: error: 'GL_COLOR_ATTACHMENT0' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'void WebCore::BitmapTextureGL::bind()': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:774:5: error: 'GL_FRAMEBUFFER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'void WebCore::TextureMapperGL::bindDefaultSurface()': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:810:5: error: 'GL_FRAMEBUFFER' was not declared in this scope make[4]: *** [obj/release/GraphicsContext3DQt.o] Error 1 /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In function 'WebCore::TransformationMatrix WebCore::createProjectionMatrix(const WebCore::IntSize&, bool)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:728:1: warning: control reaches end of non-void function make[4]: *** [obj/release/TextureMapperGL.o] Error 1 /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp: In member function 'void WebCore::TextureMapperShaderProgram::initializeProgram()': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:259:42: error: 'GL_VERTEX_SHADER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:260:44: error: 'GL_FRAGMENT_SHADER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp: In constructor 'WebCore::StandardFilterProgram::StandardFilterProgram(WebCore::FilterOperation::OperationType, unsigned int)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:605:42: error: 'GL_VERTEX_SHADER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:606:44: error: 'GL_FRAGMENT_SHADER' was not declared in this scope /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp: In member function 'virtual void WebCore::StandardFilterProgram::prepare(const WebCore::FilterOperation&, unsigned int, const WebCore::IntSize&, GLuint)': /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:740:29: error: 'GL_TEXTURE1' was not declared in this scope make[4]: *** [obj/release/TextureMapperShaderManager.o] Error 1 make[4]: Leaving directory `/ramdisk/qt-windows-32bit-release/build/WebKitBuild/Release/Source/WebCore' make[3]: *** [release] Error 2 make[3]: Leaving directory `/ramdisk/qt-windows-32bit-release/build/WebKitBuild/Release/Source/WebCore' make[2]: *** [sub-Target-pri-make_default-ordered] Error 2 make[2]: Leaving directory `/ramdisk/qt-windows-32bit-release/build/WebKitBuild/Release/Source/WebCore' make[1]: *** [sub-Source-WebCore-WebCore-pro-make_default-ordered] Error 2 make[1]: Leaving directory `/ramdisk/qt-windows-32bit-release/build/WebKitBuild/Release' make: *** [incremental] Error 2 (arch64)webkitbuildbot@cute1:~/slaves/windowsCrossRelease/buildslave/qt-windows-32bit-release/build$ mcedit /ramdisk/qt-windows-32bit-release/build/Source/WebCore/platform/graphics/OpenGLShims.h 665614 3 151424 ossy 2012-07-10 03:11:10 -0700 Created attachment 151424 Patch I think we should disable USE(3D_GRAPHICS) on Windows until proper fix. 665707 4 151424 ossy 2012-07-10 06:22:38 -0700 Comment on attachment 151424 Patch Clearing flags on attachment: 151424 Committed r122219: <http://trac.webkit.org/changeset/122219> 665708 5 ossy 2012-07-10 06:22:47 -0700 All reviewed patches have been landed. Closing bug. 665716 6 ossy 2012-07-10 06:27:02 -0700 I filed a new bug report for enabling 3D_GRAPHICS on Windows with low priority - https://bugs.webkit.org/show_bug.cgi?id=90879 If somebody is interested in it, feel free to pick it up. 151424 2012-07-10 03:11:10 -0700 2012-07-10 06:22:38 -0700 Patch bug-90850-20120710121108.patch text/plain 1538 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzcwNTU4MTRhN2NiODRjZmQ4MDcxNGFiNmM2NWZkOGJm OGM1NjMyNi4uYmMyMTc1NTIwOGY4MTdjMDVjYWY0NDFiNGRlNTA1NTc4MmNlZmFhNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTA3LTEwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMjIxNzUpOiBJdCBicm9rZSB0aGUgV2luZG93cyBi dWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA4 NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHFt YWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmOiBEaXNhYmxlIFVTRSgzRF9HUkFQSElD Uykgb24gV2luZG93cyB0ZW1wb3JhcmlseSB1bnRpbCBwcm9wZXIgZml4LgorCiAyMDEyLTA3LTEw ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcENvbmZpZ3VyYXRpb25Gb3JWaWV3cG9ydCBzaG91bGQgbW92ZSB0byBJbnRl cm5hbHMKZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMu cHJmIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKaW5kZXggMDc0 MzQxZDFjOWJmNGMxYTdjNWU1NmJjZmI1MGQyZGNlODdmMzRlMS4uMzI1YWVjYTBkNTZhNTBhYzA1 ZDkzZTQ1ZTM1YTI1NzNlZWQ2OTE0ZSAxMDA2NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9m ZWF0dXJlcy9mZWF0dXJlcy5wcmYKKysrIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9m ZWF0dXJlcy5wcmYKQEAgLTIxNSw3ICsyMTUsMTAgQEAgZm9yKGRlZmluZSwgREVGSU5FUykgewog CiAjIEVuYWJsZSB0aGUgVVNFKDNEX0dSQVBISUNTKSBmbGFnIGZvciBRdDUgb3Igd2hlbiBRdE9w ZW5HTCBpcyBlbmFibGVkLgogIWNvbnRhaW5zKERFRklORVMsIFdURl9VU0VfM0RfR1JBUEhJQ1M9 LikgewotICAgIGhhdmVRdCg1KXxjb250YWlucyhRVF9DT05GSUcsIG9wZW5nbCk6IERFRklORVMg Kz0gV1RGX1VTRV8zRF9HUkFQSElDUz0xCisgICAgIyBEaXNhYmxlIFVTRSgzRF9HUkFQSElDUykg b24gV2luZG93cyB0ZW1wb3JhcmlseSwgc2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MDg1MCBmb3IgZGV0YWlscy4KKyAgICAhd2luMzItKiB7CisgICAgICAgIGhh dmVRdCg1KXxjb250YWlucyhRVF9DT05GSUcsIG9wZW5nbCk6IERFRklORVMgKz0gV1RGX1VTRV8z RF9HUkFQSElDUz0xCisgICAgfQogfQogCiBoYXZlUXQoNCk6Y29udGFpbnMoREVGSU5FUywgRU5B QkxFX1dFQkdMPTEpOmNvbnRhaW5zKERFRklORVMsIFdURl9VU0VfM0RfR1JBUEhJQ1M9MCkgewo=