90757 2012-07-08 23:59:51 -0700 BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized. 2012-07-11 14:04:04 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90935 90375 0 dongseong.hwang webkit-unassigned gram simon.fraser skyul oldest_to_newest 664686 0 dongseong.hwang 2012-07-08 23:59:51 -0700 The current code fortunately has worked so far because only BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized. startAnimation returns at the first line becase shouldAnimate() always return false in this case. if (m_frameTimer || !shouldAnimate() || frameCount() <= 1) return; This change is needed because parallel image decoders call BitmapImage::frameIsCompleteAtIndex in other places too. 664713 1 151205 dongseong.hwang 2012-07-09 01:04:18 -0700 Created attachment 151205 Patch 667034 2 151205 skyul 2012-07-11 14:03:58 -0700 Comment on attachment 151205 Patch Clearing flags on attachment: 151205 Committed r122368: <http://trac.webkit.org/changeset/122368> 667035 3 skyul 2012-07-11 14:04:04 -0700 All reviewed patches have been landed. Closing bug. 151205 2012-07-09 01:04:18 -0700 2012-07-11 14:03:58 -0700 Patch bug-90757-20120709170416.patch text/plain 2158 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk0NTEwNjIwZDdlNzg4 NWQ0MDY2YWM1NGVkOWE3YzFkNTEyZTYwNi4uMmU5MTQyMGM3ZDU5ODkwYjQ3YTczNTcyNjkwOGVj NGVjMmVkMGQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA3LTA5ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIEJpdG1hcElt YWdlOjpmcmFtZUlzQ29tcGxldGVBdEluZGV4KCkgbXVzdCByZXR1cm4gZmFsc2UgaWYgSW1hZ2VE ZWNvZGVyIGlzIG5vdCBpbml0aWFsaXplZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTkwNzU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgY29kZSBmb3J0dW5hdGVseSBoYXMgd29ya2Vk IHNvIGZhciBiZWNhdXNlIG9ubHkKKyAgICAgICAgQml0bWFwSW1hZ2U6OnN0YXJ0QW5pbWF0aW9u IGNhbGxzIGZyYW1lSXNDb21wbGV0ZUF0SW5kZXgsIGFuZCBzdGFydEFuaW1hdGlvbgorICAgICAg ICBjYW5ub3QgY2FsbCBmcmFtZUlzQ29tcGxldGVBdEluZGV4IGlmIEltYWdlRGVjb2RlciBpcyBu b3QgeWV0IGluaXRpYWxpemVkLgorICAgICAgICBzdGFydEFuaW1hdGlvbiByZXR1cm5zIGF0IHRo ZSBmaXJzdCBsaW5lIGJlY2FzZSBzaG91bGRBbmltYXRlKCkgYWx3YXlzIHJldHVybgorICAgICAg ICBmYWxzZSBpbiB0aGlzIGNhc2UuCisKKyAgICAgICAgICAgIGlmIChtX2ZyYW1lVGltZXIgfHwg IXNob3VsZEFuaW1hdGUoKSB8fCBmcmFtZUNvdW50KCkgPD0gMSkKKyAgICAgICAgICAgICAgICBy ZXR1cm47CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgaXMgbmVlZGVkIGJlY2F1c2UgcGFyYWxsZWwg aW1hZ2UgZGVjb2RlcnMgY2FsbAorICAgICAgICBCaXRtYXBJbWFnZTo6ZnJhbWVJc0NvbXBsZXRl QXRJbmRleCBpbiBvdGhlciBwbGFjZXMgdG9vLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbWFu dWFsbHkgdGVzdGVkIHdoZXRoZXIgdGhlIGNhbGxlciBleGlzdHMgb3Igbm90IHRoYXQKKyAgICAg ICAgY2FsbHMgQml0bWFwSW1hZ2U6OmZyYW1lSXNDb21wbGV0ZUF0SW5kZXgoKSBiZWZvcmUgSW1h Z2VEZWNvZGVyIGlzCisgICAgICAgIGluaXRpYWxpemVkLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwSW1hZ2U6 OmZyYW1lSXNDb21wbGV0ZUF0SW5kZXgpOgorCiAyMDEyLTA3LTA2ICBMYXVybyBOZXRvICA8bGF1 cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtRdF0gQXZvaWQgZGVlcCBjb3B5IG9m IFFJbWFnZSBpbiBHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VEYXRhKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcAppbmRleCAyYzc1NDA0 MjhjOWVmNjZlNWE2NzYyYjg4NzQ5NDVjYTQ4NTI2ZmY0Li43NWMwN2I1Y2ZjOTYzYmE3YWE5ZDEx MmNhYmIyMzVkZmEzZDc1YWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9CaXRtYXBJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvQml0bWFwSW1hZ2UuY3BwCkBAIC0zMDEsNyArMzAxLDcgQEAgTmF0aXZlSW1hZ2VQdHIg Qml0bWFwSW1hZ2U6OmZyYW1lQXRJbmRleChzaXplX3QgaW5kZXgpCiBib29sIEJpdG1hcEltYWdl OjpmcmFtZUlzQ29tcGxldGVBdEluZGV4KHNpemVfdCBpbmRleCkKIHsKICAgICBpZiAoIWVuc3Vy ZUZyYW1lSXNDYWNoZWQoaW5kZXgpKQotICAgICAgICByZXR1cm4gdHJ1ZTsgLy8gV2h5IHdvdWxk IGFuIGludmFsaWQgaW5kZXggcmV0dXJuIHRydWUgaGVyZT8KKyAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgIHJldHVybiBtX2ZyYW1lc1tpbmRleF0ubV9pc0NvbXBsZXRlOwogfQogCg==