90433 2012-07-02 22:46:53 -0700 [WK2][EFL] Free Ewk_Intent calloc'd memory with free() instead of delete 2012-07-02 23:24:40 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90064 1 cdumez cdumez gyuyoung.kim kenneth lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 661977 0 cdumez 2012-07-02 22:46:53 -0700 The Ewk_Intent memory is allocated with calloc() but freed with delete. We need to switch to free(). 661979 1 150538 cdumez 2012-07-02 22:48:56 -0700 Created attachment 150538 Patch 661982 2 150538 kenneth 2012-07-02 22:53:27 -0700 Comment on attachment 150538 Patch Nice 661995 3 150538 webkit.review.bot 2012-07-02 23:24:35 -0700 Comment on attachment 150538 Patch Clearing flags on attachment: 150538 Committed r121731: <http://trac.webkit.org/changeset/121731> 661996 4 webkit.review.bot 2012-07-02 23:24:40 -0700 All reviewed patches have been landed. Closing bug. 150538 2012-07-02 22:48:56 -0700 2012-07-02 23:24:35 -0700 Patch 90433_use_free.patch text/plain 3842 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2NTgxNjVlLi5hN2IwNjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDctMDIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEZyZWUgRXdrX0ludGVudCBjYWxsb2MnZCBtZW1v cnkgd2l0aCBmcmVlKCkgaW5zdGVhZCBvZiBkZWxldGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwNDMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRnJlZSBjYWxsb2MnZCBtZW1vcnkgd2l0aCBmcmVlKCkg aW5zdGVhZCBvZiBkZWxldGUgaW4gRXdrX0ludGVudC4KKyAgICAgICAgQWRkIGJsYW5rIGxpbmVz IGJlZm9yZSByZXR1cm4gc3RhdGVtZW50cyBmb3IgY29uc2lzdGVuY3kuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC9ld2tfaW50ZW50LmNwcDoKKyAgICAgICAgKGV3a19pbnRlbnRfdW5y ZWYpOgorICAgICAgICAoZXdrX2ludGVudF9hY3Rpb25fZ2V0KToKKyAgICAgICAgKGV3a19pbnRl bnRfdHlwZV9nZXQpOgorICAgICAgICAoZXdrX2ludGVudF9zZXJ2aWNlX2dldCk6CisgICAgICAg IChld2tfaW50ZW50X3N1Z2dlc3Rpb25zX2dldCk6CisgICAgICAgIChld2tfaW50ZW50X2V4dHJh X2dldCk6CisgICAgICAgIChld2tfaW50ZW50X2V4dHJhX25hbWVzX2dldCk6CisgICAgICAgIChl d2tfaW50ZW50X25ldyk6CisKIDIwMTItMDctMDIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNv bkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtUZXh0dXJlTWFwcGVyXSBUaGUgVGV4dHVyZU1hcHBl ciBzaG91bGQgc3VwcG9ydCBlZGdlLWRpc3RhbmNlIGFudGktYW50aWFsaWFzaW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfaW50ZW50LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19pbnRlbnQuY3BwCmluZGV4IGY5NDg2 M2UuLmE1ZTIwMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a19pbnRlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a19pbnRlbnQuY3BwCkBAIC04Miw3ICs4Miw3IEBAIHZvaWQgZXdrX2ludGVudF91bnJlZihFd2tf SW50ZW50KiBpbnRlbnQpCiAgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwoaW50ZW50LT5hY3Rpb24p OwogICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKGludGVudC0+dHlwZSk7CiAgICAgZWluYV9zdHJp bmdzaGFyZV9kZWwoaW50ZW50LT5zZXJ2aWNlKTsKLSAgICBkZWxldGUgaW50ZW50OworICAgIGZy ZWUoaW50ZW50KTsKICNlbmRpZgogfQogCkBAIC05NCw2ICs5NCw3IEBAIGNvbnN0IGNoYXIqIGV3 a19pbnRlbnRfYWN0aW9uX2dldChjb25zdCBFd2tfSW50ZW50KiBpbnRlbnQpCiAgICAgV0tSZXRh aW5QdHI8V0tTdHJpbmdSZWY+IHdrQWN0aW9uKEFkb3B0V0ssIFdLSW50ZW50RGF0YUNvcHlBY3Rp b24od2tJbnRlbnQpKTsKICAgICBFd2tfSW50ZW50KiBld2tJbnRlbnQgPSBjb25zdF9jYXN0PEV3 a19JbnRlbnQqPihpbnRlbnQpOwogICAgIGVpbmFfc3RyaW5nc2hhcmVfcmVwbGFjZSgmZXdrSW50 ZW50LT5hY3Rpb24sIHRvSW1wbCh3a0FjdGlvbi5nZXQoKSktPnN0cmluZygpLnV0ZjgoKS5kYXRh KCkpOworCiAgICAgcmV0dXJuIGludGVudC0+YWN0aW9uOwogI2Vsc2UKICAgICByZXR1cm4gMDsK QEAgLTEwOCw2ICsxMDksNyBAQCBjb25zdCBjaGFyKiBld2tfaW50ZW50X3R5cGVfZ2V0KGNvbnN0 IEV3a19JbnRlbnQqIGludGVudCkKICAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gd2tUeXBl KEFkb3B0V0ssIFdLSW50ZW50RGF0YUNvcHlUeXBlKHdrSW50ZW50KSk7CiAgICAgRXdrX0ludGVu dCogZXdrSW50ZW50ID0gY29uc3RfY2FzdDxFd2tfSW50ZW50Kj4oaW50ZW50KTsKICAgICBlaW5h X3N0cmluZ3NoYXJlX3JlcGxhY2UoJmV3a0ludGVudC0+dHlwZSwgdG9JbXBsKHdrVHlwZS5nZXQo KSktPnN0cmluZygpLnV0ZjgoKS5kYXRhKCkpOworCiAgICAgcmV0dXJuIGludGVudC0+dHlwZTsK ICNlbHNlCiAgICAgcmV0dXJuIDA7CkBAIC0xMjIsNiArMTI0LDcgQEAgY29uc3QgY2hhciogZXdr X2ludGVudF9zZXJ2aWNlX2dldChjb25zdCBFd2tfSW50ZW50KiBpbnRlbnQpCiAgICAgV0tSZXRh aW5QdHI8V0tVUkxSZWY+IHdrU2VydmljZShBZG9wdFdLLCBXS0ludGVudERhdGFDb3B5U2Vydmlj ZSh3a0ludGVudCkpOwogICAgIEV3a19JbnRlbnQqIGV3a0ludGVudCA9IGNvbnN0X2Nhc3Q8RXdr X0ludGVudCo+KGludGVudCk7CiAgICAgZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZld2tJbnRl bnQtPnNlcnZpY2UsIHRvSW1wbCh3a1NlcnZpY2UuZ2V0KCkpLT5zdHJpbmcoKS51dGY4KCkuZGF0 YSgpKTsKKwogICAgIHJldHVybiBpbnRlbnQtPnNlcnZpY2U7CiAjZWxzZQogICAgIHJldHVybiAw OwpAQCAtMTQwLDYgKzE0Myw3IEBAIEVpbmFfTGlzdCogZXdrX2ludGVudF9zdWdnZXN0aW9uc19n ZXQoY29uc3QgRXdrX0ludGVudCogaW50ZW50KQogICAgICAgICBXS1VSTFJlZiB3a1N1Z2dlc3Rp b24gPSBzdGF0aWNfY2FzdDxXS1VSTFJlZj4oV0tBcnJheUdldEl0ZW1BdEluZGV4KHdrU3VnZ2Vz dGlvbnMuZ2V0KCksIGkpKTsKICAgICAgICAgbGlzdE9mU3VnZ2VzdGlvbnMgPSBlaW5hX2xpc3Rf YXBwZW5kKGxpc3RPZlN1Z2dlc3Rpb25zLCBzdHJkdXAodG9JbXBsKHdrU3VnZ2VzdGlvbiktPnN0 cmluZygpLnV0ZjgoKS5kYXRhKCkpKTsKICAgICB9CisKICAgICByZXR1cm4gbGlzdE9mU3VnZ2Vz dGlvbnM7CiAjZWxzZQogICAgIHJldHVybiAwOwpAQCAtMTU2LDYgKzE2MCw3IEBAIGNoYXIqIGV3 a19pbnRlbnRfZXh0cmFfZ2V0KGNvbnN0IEV3a19JbnRlbnQqIGludGVudCwgY29uc3QgY2hhciog a2V5KQogICAgIFN0cmluZyB2YWx1ZSA9IHRvSW1wbCh3a1ZhbHVlLmdldCgpKS0+c3RyaW5nKCk7 CiAgICAgaWYgKHZhbHVlLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIDA7CisKICAgICByZXR1 cm4gc3RyZHVwKHZhbHVlLnV0ZjgoKS5kYXRhKCkpOwogI2Vsc2UKICAgICByZXR1cm4gMDsKQEAg LTE3NSw2ICsxODAsNyBAQCBFaW5hX0xpc3QqIGV3a19pbnRlbnRfZXh0cmFfbmFtZXNfZ2V0KGNv bnN0IEV3a19JbnRlbnQqIGludGVudCkKICAgICAgICAgV0tTdHJpbmdSZWYgd2tLZXkgPSBzdGF0 aWNfY2FzdDxXS1N0cmluZ1JlZj4oV0tBcnJheUdldEl0ZW1BdEluZGV4KHdrS2V5cy5nZXQoKSwg aSkpOwogICAgICAgICBsaXN0T2ZLZXlzID0gZWluYV9saXN0X2FwcGVuZChsaXN0T2ZLZXlzLCBz dHJkdXAodG9JbXBsKHdrS2V5KS0+c3RyaW5nKCkudXRmOCgpLmRhdGEoKSkpOwogICAgIH0KKwog ICAgIHJldHVybiBsaXN0T2ZLZXlzOwogI2Vsc2UKICAgICByZXR1cm4gMDsKQEAgLTE4OSw2ICsx OTUsNyBAQCBFd2tfSW50ZW50KiBld2tfaW50ZW50X25ldyhXS0ludGVudERhdGFSZWYgaW50ZW50 RGF0YSkKICAgICBFd2tfSW50ZW50KiBld2tJbnRlbnQgPSBzdGF0aWNfY2FzdDxFd2tfSW50ZW50 Kj4oY2FsbG9jKDEsIHNpemVvZihFd2tfSW50ZW50KSkpOwogICAgIGV3a0ludGVudC0+X19yZWYg PSAxOwogICAgIGV3a0ludGVudC0+d2tJbnRlbnQgPSBpbnRlbnREYXRhOworCiAgICAgcmV0dXJu IGV3a0ludGVudDsKIH0KICNlbmRpZgo=