90432 2012-07-02 22:39:17 -0700 Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker 2012-07-04 18:25:32 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82702 1 hayato hayato dglazkov dominicc morrita shinyak tasak webkit.review.bot oldest_to_newest 661972 0 hayato 2012-07-02 22:39:17 -0700 Some functions can not be inlined as is because they are recursive ones and some of them call mutually. 661975 1 150536 hayato 2012-07-02 22:44:37 -0700 Created attachment 150536 remove inline. 661976 2 hayato 2012-07-02 22:46:32 -0700 Until https://bugs.webkit.org/show_bug.cgi?id=90415 is implemented, it might be better to remove inline keywords since the functions are not inlined actually. 662779 3 150536 morrita 2012-07-04 02:24:34 -0700 Comment on attachment 150536 remove inline. No, this is actually intended to be inlined. These functions are private, and called only from this file, thus can be inlined. And this inlining impacts NodRenderingContext speed. 662793 4 hayato 2012-07-04 02:40:34 -0700 We can not inline these. These are mutually recursive functions. See https://bugs.webkit.org/show_bug.cgi?id=90432#c0 and comment #2. objdump told me that these are not inlined on chromium linux port actually. (In reply to comment #3) > (From update of attachment 150536 [details]) > No, this is actually intended to be inlined. > These functions are private, and called only from this file, thus can be inlined. > And this inlining impacts NodRenderingContext speed. 663190 5 150850 hayato 2012-07-04 15:57:16 -0700 Created attachment 150850 Add a FIXME comment 663202 6 150850 morrita 2012-07-04 17:23:44 -0700 Comment on attachment 150850 Add a FIXME comment Ah got it. 663209 7 150850 webkit.review.bot 2012-07-04 18:25:27 -0700 Comment on attachment 150850 Add a FIXME comment Clearing flags on attachment: 150850 Committed r121875: <http://trac.webkit.org/changeset/121875> 663210 8 webkit.review.bot 2012-07-04 18:25:32 -0700 All reviewed patches have been landed. Closing bug. 150536 2012-07-02 22:44:37 -0700 2012-07-04 15:57:11 -0700 remove inline. bug-90432-20120703144436.patch text/plain 2129 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTFjMGQyMmRlZmFmYjE5 M2JiOTI2NmUxNGY4ZmUxMjVmM2ExMjk4MS4uNWY0ZDAxYjAxNDA3Yjc4MjUyNTRlYTA4YTk2NmE4 NWZmOThiZGQ2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTAyICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgaW5saW5lIGtl eXdvcmRzIGZyb20gZnVuY3Rpb25zIHdoaWNoIGNhbiBub3QgYmUgaW5saW5lZCBpbiBDb21wb3Nl ZFNoYWRvd1RyZWVXYWxrZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkwNDMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIC0gbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisgICAgICAg ICogZG9tL0NvbXBvc2VkU2hhZG93VHJlZVdhbGtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD b21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OnRyYXZlcnNlUGFyZW50KToKKyAgICAgICAgKFdlYkNv cmU6OkNvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6dHJhdmVyc2VQYXJlbnRCYWNrVG9Zb3VuZ2Vy U2hhZG93Um9vdE9ySG9zdCk6CisKIDIwMTItMDctMDEgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90 aHlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhlICJJbnNwZWN0IEVsZW1lbnQiIGNvbnRl eHQgbWVudSBpdGVtIGFwcGVhciBpbiBuaWdodGx5IGJ1aWxkcyBhZ2Fpbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvZG9tL0NvbXBvc2VkU2hhZG93VHJlZVdhbGtlci5jcHAKaW5kZXggMzJlOGUwZDEx OGJhZjhkOWEyZmUyZTI5NWYwNjExMWJlZDAwNWM4My4uYmJiYTk1ZDQ0OGY2YmVlNGFkOTFiYTQ2 MDg1NTg0ZWFmYzZhZDQxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbXBvc2Vk U2hhZG93VHJlZVdhbGtlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0NvbXBvc2VkU2hh ZG93VHJlZVdhbGtlci5jcHAKQEAgLTIyMCw3ICsyMjAsNyBAQCB2b2lkIENvbXBvc2VkU2hhZG93 VHJlZVdhbGtlcjo6cGFyZW50KCkKICAgICBhc3NlcnRQb3N0Y29uZGl0aW9uKCk7CiB9CiAKLWlu bGluZSBOb2RlKiBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OnRyYXZlcnNlUGFyZW50KGNvbnN0 IE5vZGUqIG5vZGUsIFBhcmVudFRyYW52ZXJzYWxEZXRhaWxzKiBkZXRhaWxzKSBjb25zdAorTm9k ZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0cmF2ZXJzZVBhcmVudChjb25zdCBOb2RlKiBu b2RlLCBQYXJlbnRUcmFudmVyc2FsRGV0YWlscyogZGV0YWlscykgY29uc3QKIHsKICAgICBpZiAo IWNhbkNyb3NzVXBwZXJCb3VuZGFyeSgpICYmIG5vZGUtPmlzU2hhZG93Um9vdCgpKSB7CiAgICAg ICAgIEFTU0VSVCh0b1NoYWRvd1Jvb3Qobm9kZSktPmlzWW91bmdlc3QoKSk7CkBAIC0yNDgsNyAr MjQ4LDcgQEAgaW5saW5lIE5vZGUqIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6dHJhdmVyc2VQ YXJlbnRJbkN1cnJlbnRUcmVlKGNvbnN0IE5vZGUqIG4KICAgICByZXR1cm4gMDsKIH0KIAotaW5s aW5lIE5vZGUqIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6dHJhdmVyc2VQYXJlbnRCYWNrVG9Z b3VuZ2VyU2hhZG93Um9vdE9ySG9zdChjb25zdCBTaGFkb3dSb290KiBzaGFkb3dSb290LCBQYXJl bnRUcmFudmVyc2FsRGV0YWlscyogZGV0YWlscykgY29uc3QKK05vZGUqIENvbXBvc2VkU2hhZG93 VHJlZVdhbGtlcjo6dHJhdmVyc2VQYXJlbnRCYWNrVG9Zb3VuZ2VyU2hhZG93Um9vdE9ySG9zdChj b25zdCBTaGFkb3dSb290KiBzaGFkb3dSb290LCBQYXJlbnRUcmFudmVyc2FsRGV0YWlscyogZGV0 YWlscykgY29uc3QKIHsKICAgICBBU1NFUlQoc2hhZG93Um9vdCk7CiAgICAgaWYgKHNoYWRvd1Jv b3QtPmlzWW91bmdlc3QoKSkgewo= 150850 2012-07-04 15:57:16 -0700 2012-07-04 18:25:27 -0700 Add a FIXME comment bug-90432-20120705075715.patch text/plain 2206 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxODM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNmODc5NTIwYWE0Y2Q5 NGEzZjBlNjczMmZiMDRiYzliNjY4NzM2ZS4uNWQxZDU3MmEyNjMyNDhlMTBkMDVmN2M3N2JiYzAy ODBiODc5NzBkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTAyICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgaW5saW5lIGtl eXdvcmRzIGZyb20gZnVuY3Rpb25zIHdoaWNoIGNhbiBub3QgYmUgaW5saW5lZCBpbiBDb21wb3Nl ZFNoYWRvd1RyZWVXYWxrZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkwNDMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIC0gbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisgICAgICAg ICogZG9tL0NvbXBvc2VkU2hhZG93VHJlZVdhbGtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD b21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OnRyYXZlcnNlUGFyZW50KToKKyAgICAgICAgKFdlYkNv cmU6OkNvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6dHJhdmVyc2VQYXJlbnRCYWNrVG9Zb3VuZ2Vy U2hhZG93Um9vdE9ySG9zdCk6CisKIDIwMTItMDctMDQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJl dmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIx MjE4MTMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRTaGFkb3dUcmVl V2Fsa2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIu Y3BwCmluZGV4IDMyZThlMGQxMThiYWY4ZDlhMmZlMmUyOTVmMDYxMTFiZWQwMDVjODMuLjFkOGZl ZWQxODNiMDNkODkxOTliMmU3NTg4MTdjYmUyYmYzNGQ3MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwCkBAIC0yMjAsNyArMjIwLDkgQEAg dm9pZCBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OnBhcmVudCgpCiAgICAgYXNzZXJ0UG9zdGNv bmRpdGlvbigpOwogfQogCi1pbmxpbmUgTm9kZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0 cmF2ZXJzZVBhcmVudChjb25zdCBOb2RlKiBub2RlLCBQYXJlbnRUcmFudmVyc2FsRGV0YWlscyog ZGV0YWlscykgY29uc3QKKy8vIEZJWE1FOiBVc2UgYW4gaXRlcmF0aXZlIGFsZ29yaXRobSBzbyB0 aGF0IGl0IGNhbiBiZSBpbmxpbmVkLgorLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkwNDE1CitOb2RlKiBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXI6OnRyYXZlcnNl UGFyZW50KGNvbnN0IE5vZGUqIG5vZGUsIFBhcmVudFRyYW52ZXJzYWxEZXRhaWxzKiBkZXRhaWxz KSBjb25zdAogewogICAgIGlmICghY2FuQ3Jvc3NVcHBlckJvdW5kYXJ5KCkgJiYgbm9kZS0+aXNT aGFkb3dSb290KCkpIHsKICAgICAgICAgQVNTRVJUKHRvU2hhZG93Um9vdChub2RlKS0+aXNZb3Vu Z2VzdCgpKTsKQEAgLTI0OCw3ICsyNTAsNyBAQCBpbmxpbmUgTm9kZSogQ29tcG9zZWRTaGFkb3dU cmVlV2Fsa2VyOjp0cmF2ZXJzZVBhcmVudEluQ3VycmVudFRyZWUoY29uc3QgTm9kZSogbgogICAg IHJldHVybiAwOwogfQogCi1pbmxpbmUgTm9kZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0 cmF2ZXJzZVBhcmVudEJhY2tUb1lvdW5nZXJTaGFkb3dSb290T3JIb3N0KGNvbnN0IFNoYWRvd1Jv b3QqIHNoYWRvd1Jvb3QsIFBhcmVudFRyYW52ZXJzYWxEZXRhaWxzKiBkZXRhaWxzKSBjb25zdAor Tm9kZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0cmF2ZXJzZVBhcmVudEJhY2tUb1lvdW5n ZXJTaGFkb3dSb290T3JIb3N0KGNvbnN0IFNoYWRvd1Jvb3QqIHNoYWRvd1Jvb3QsIFBhcmVudFRy YW52ZXJzYWxEZXRhaWxzKiBkZXRhaWxzKSBjb25zdAogewogICAgIEFTU0VSVChzaGFkb3dSb290 KTsKICAgICBpZiAoc2hhZG93Um9vdC0+aXNZb3VuZ2VzdCgpKSB7Cg==