90346 2012-06-30 23:47:04 -0700 [Qt] WebCoreTestSupport functions should be exported 2012-07-25 09:16:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 90262 Qt, QtTriaged P1 Blocker --- 1 ossy kbalazs ap gustavo hausmann kbalazs ossy philn rgabor xan.lopez zoltan oldest_to_newest 661110 0 ossy 2012-06-30 23:47:04 -0700 obj/release/InjectedBundlePage.o: In function `WTR::InjectedBundlePage::resetAfterTest()': InjectedBundlePage.cpp:(.text._ZN3WTR18InjectedBundlePage14resetAfterTestEv+0x14): undefined reference to `WebCoreTestSupport::resetInternalsObject(OpaqueJSContext const*)' obj/release/InjectedBundlePage.o: In function `WTR::InjectedBundlePage::didClearWindowForFrame(OpaqueWKBundleFrame const*, OpaqueWKBundleScriptWorld const*)': InjectedBundlePage.cpp:(.text._ZN3WTR18InjectedBundlePage22didClearWindowForFrameEPK19OpaqueWKBundleFramePK25OpaqueWKBundleScriptWorld+0x140): undefined reference to `WebCoreTestSupport::injectInternalsObject(OpaqueJSContext const*)' 661120 1 kbalazs 2012-07-01 02:52:23 -0700 I'm looking into it. 661122 2 kbalazs 2012-07-01 03:39:18 -0700 Seems like an export problem, and I have no clue why does it work on other platforms or even qt-x86 (if I recall correctly this is the second time we have such a strange export issue on ARM). I thing we have to export these functions to be able to use them in WTR. 661124 3 kbalazs 2012-07-01 05:42:03 -0700 Here is the diff on Qt: -viewport size 320x356 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 +viewport size 480x534 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 Relevant parts of the test: <meta name="viewport" content="width=device-width"> layoutTestController.dumpConfigurationForViewport(240, 480, 564, 480, 534); So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites. 661125 4 kbalazs 2012-07-01 05:42:46 -0700 (In reply to comment #3) > Here is the diff on Qt: > > -viewport size 320x356 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 > +viewport size 480x534 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 > > Relevant parts of the test: > <meta name="viewport" content="width=device-width"> > layoutTestController.dumpConfigurationForViewport(240, 480, 564, 480, 534); > > So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites. Ups, wrong bug... 661524 5 150432 kbalazs 2012-07-02 08:56:08 -0700 Created attachment 150432 Patch 661902 6 150432 hausmann 2012-07-02 20:15:30 -0700 Comment on attachment 150432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150432&action=review I think this is the right solution, exporting those symbols via export macros. But a little bit of fine tuning is needed :) > Source/WebCore/ChangeLog:8 > + [Qt] REGRESSION(r121550): It broke the Qt5 ARM build > + https://bugs.webkit.org/show_bug.cgi?id=90346 > + > + Reviewed by NOBODY (OOPS!). > + > + No new tests, this is a build fix. I suggest to correct the title and the description of the change log entry here. The title makes it look like that this is an ARM specific problem, but that is incorrect. It is a general build problem of the WK2 part of the Qt port for platforms that require symbol exports. This is the line in default_post.prf that controls this: !linux-g++*:!linux-icc*:contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols and as it so happens the arm mkspec doesn't match linux-g++*. But _that_ line itself is incorrect and I should've removed the linux-g++* part as part of r106650. Then this problem would manifest itself also on the x86 WK2 bot. I think the bug description should briefly include how the patch accomplishes to fix the issue. > Source/WebCore/testing/js/WebCoreTestSupport.h:35 > +#include <wtf/ExportMacros.h> > + > +#if PLATFORM(QT) > +#define TEST_SUPPORT_EXPORT WTF_EXPORT_PRIVATE > +#else > +#define TEST_SUPPORT_EXPORT > +#endif I think those belong into WebCore/platform/PlatformExportMacros.h and maybe should be prefixed with WEBKIT, i.e. WEBKIT_EXPORT_TEST_SUPPORT. 662296 7 150627 kbalazs 2012-07-03 09:25:11 -0700 Created attachment 150627 Patch 662298 8 150627 gyuyoung.kim 2012-07-03 09:32:46 -0700 Comment on attachment 150627 Patch Attachment 150627 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13130514 662299 9 150627 gustavo 2012-07-03 09:33:22 -0700 Comment on attachment 150627 Patch Attachment 150627 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13136453 662303 10 150629 kbalazs 2012-07-03 09:40:57 -0700 Created attachment 150629 Patch 662321 11 150629 jturcotte 2012-07-03 10:11:19 -0700 Comment on attachment 150629 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150629&action=review > Source/WebCore/platform/PlatformExportMacros.h:76 > +// Special cases. > + > +#if PLATFORM(QT) > +#if defined(BUILDING_WebCore) || defined(BUILDING_WebKit) || \ > + defined(STATICALLY_LINKED_WITH_WebCore) || defined(STATICALLY_LINKED_WITH_WebKit) > +#define WEBKIT_TEST_SUPPORT_EXPORT WTF_EXPORT > +#else > +#define WEBKIT_TEST_SUPPORT_EXPORT WTF_IMPORT > +#endif > +#else > +#define WEBKIT_TEST_SUPPORT_EXPORT > +#endif // PLATFORM(QT) > + I would prefer something like this just after "#endif // USE(EXPORT_MACROS)": #if PLATFORM(QT) #define WEBKIT_TEST_SUPPORT_EXPORT WEBKIT_EXPORTDATA #else #define WEBKIT_TEST_SUPPORT_EXPORT #endif // PLATFORM(QT) 662326 12 kbalazs 2012-07-03 10:17:15 -0700 It turned out that other ports have a special lib for these things, for example on Gtk it is libWebCoreTestSupport. The better solution is to set this up for Qt as well. 662327 13 150629 buildbot 2012-07-03 10:18:22 -0700 Comment on attachment 150629 Patch Attachment 150629 did not pass win-ews (win): Output: http://queues.webkit.org/results/13134487 666708 14 kbalazs 2012-07-11 06:29:47 -0700 *** This bug has been marked as a duplicate of bug 90978 *** 666748 15 hausmann 2012-07-11 07:41:22 -0700 (In reply to comment #6) [...] > The title makes it look like that this is an ARM specific problem, but that is incorrect. It is a general build problem of the WK2 part of the Qt port for platforms that require symbol exports. This is the line in default_post.prf that controls this: > > !linux-g++*:!linux-icc*:contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols > > and as it so happens the arm mkspec doesn't match linux-g++*. But _that_ line itself is incorrect and > I should've removed the linux-g++* part as part of r106650. Then this problem would manifest itself also > on the x86 WK2 bot. > > I think the bug description should briefly include how the patch accomplishes to fix the issue. I've filed bug #90981 to address this. 678123 16 kbalazs 2012-07-25 08:58:03 -0700 Let's start with this and do the separation later. It seems like a bit trickier than I expected (idl-s for example). 678141 17 kbalazs 2012-07-25 09:16:36 -0700 *** This bug has been marked as a duplicate of bug 90262 *** 150432 2012-07-02 08:56:08 -0700 2012-07-03 09:25:04 -0700 Patch bug-90346-20120702175606.patch text/plain 1704 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FmOGE0NTA3ZDIxMjli NTI4YmVlMzAwYjQ4NGE1ZWUwNWNkYTZlNS4uOGMwY2U2YTYyMGNmZmY3YWU1YWVjODRjNTczMWMw NDRhMjJhN2JjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTAyICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFJFR1JFU1NJ T04ocjEyMTU1MCk6IEl0IGJyb2tlIHRoZSBRdDUgQVJNIGJ1aWxkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDM0NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBhIGJ1 aWxkIGZpeC4KKworICAgICAgICAqIHRlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0Lmg6Cisg ICAgICAgIChXZWJDb3JlVGVzdFN1cHBvcnQpOgorICAgICAgICBFeHBvcnQgdGhlIHRlc3Qgc3Vw cG9ydCBmdW5jdGlvbnMgb24gUXQuCisKIDIwMTItMDYtMzAgIElhbiBWb2xsaWNrICA8dm9sbGlj a0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBDYW52YXNMYXllclRleHR1cmVV cGRhdGVyIG5lZWRzIHRvIGNvbnZlcnQgb3BhcXVlIHJlY3RzIGJhY2sgdG8gY29udGVudCBzcGFj ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBw b3J0LmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3VwcG9ydC5oCmlu ZGV4IGJmZDhhOGJhOTE0NjE0ZjNlZjU4NDI4MjRhNTU3MjkwMmY3NGY0ZGUuLjA3NmQwNzNhNTA3 OWY5Y2MzOTZjZDk0ZWVhOWI0OTNhYzI5OWY2YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVz dGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuaApAQCAtMjYsMTMgKzI2LDIzIEBACiAjaWZuZGVm IFdlYkNvcmVUZXN0U3VwcG9ydF9oCiAjZGVmaW5lIFdlYkNvcmVUZXN0U3VwcG9ydF9oCiAKKyNp bmNsdWRlIDx3dGYvRXhwb3J0TWFjcm9zLmg+CisKKyNpZiBQTEFURk9STShRVCkKKyNkZWZpbmUg VEVTVF9TVVBQT1JUX0VYUE9SVCBXVEZfRVhQT1JUX1BSSVZBVEUKKyNlbHNlCisjZGVmaW5lIFRF U1RfU1VQUE9SVF9FWFBPUlQKKyNlbmRpZgorCiB0eXBlZGVmIGNvbnN0IHN0cnVjdCBPcGFxdWVK U0NvbnRleHQqIEpTQ29udGV4dFJlZjsKIAogbmFtZXNwYWNlIFdlYkNvcmVUZXN0U3VwcG9ydCB7 CiAKLXZvaWQgaW5qZWN0SW50ZXJuYWxzT2JqZWN0KEpTQ29udGV4dFJlZik7Ci12b2lkIHJlc2V0 SW50ZXJuYWxzT2JqZWN0KEpTQ29udGV4dFJlZik7CitURVNUX1NVUFBPUlRfRVhQT1JUIHZvaWQg aW5qZWN0SW50ZXJuYWxzT2JqZWN0KEpTQ29udGV4dFJlZik7CitURVNUX1NVUFBPUlRfRVhQT1JU IHZvaWQgcmVzZXRJbnRlcm5hbHNPYmplY3QoSlNDb250ZXh0UmVmKTsKIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQogCisjdW5kZWYgVEVTVF9TVVBQT1JUX0VYUE9SVAorCiAjZW5kaWYK 150627 2012-07-03 09:25:11 -0700 2012-07-03 09:40:50 -0700 Patch bug-90346-20120703182508.patch text/plain 3706 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY0ODFlOWRlNzhiMmRm ODNlYTY2NjI5YTA3MjM3ZTk0ODljNDNjOS4uYjZkMmE5MTMzYWUxYmY5ZWE2ZWJkNTRjMGMzNzBh MTJmOWU2MGRjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA3LTAzICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFdlYkNvcmVU ZXN0U3VwcG9ydCBmdW5jdGlvbnMgc2hvdWxkIGJlIGV4cG9ydGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDM0NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBhIGJ1 aWxkIGZpeC4KKworICAgICAgICBFeHBvcnQgV2ViQ29yZVRlc3RTdXBwb3J0IGZ1bmN0aW9ucyB3 aXRoIGV4cG9ydCBtYWNyb3Mgb24gUXQuCisgICAgICAgIFRoZXNlIGFyZSB1c2VkIGZyb20gV2Vi S2l0VGVzdFJ1bm5lciB3aWhjaCBpcyBhIHJlZ3VsYXIgQVBJIHVzZXIKKyAgICAgICAgb2YgV2Vi S2l0IGFuZCBkb24ndCBoYXZlIGFjY2VzcyB0byBXZWJDb3JlIGludGVybmFscy4gVGhlcmUgaXMK KyAgICAgICAgbm8gb3RoZXIgcG9ydCB0aGF0IG5lZWQgdGhpcyBjdXJyZW50bHkgc28gSSByZXN0 cmljdGVkIGl0IHRvIFF0CisgICAgICAgIHRvIG5vdCBleHBvc2Ugc3R1ZmYgdW5uZWNlc3Nhcmls eSBvbiBvdGhlciBwb3J0cy4KKworICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtRXhwb3J0TWFj cm9zLmg6CisgICAgICAgIEFkZGVkIGEgc3BlY2lhbCBjYXNlIGV4cG9ydCBtYWNybyBmb3IgV2Vi Q29yZVRlc3RTdXBwb3J0LgorICAgICAgICAqIHRlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0 Lmg6CisgICAgICAgIChXZWJDb3JlVGVzdFN1cHBvcnQpOgorICAgICAgICAqIHRlc3Rpbmcvdjgv V2ViQ29yZVRlc3RTdXBwb3J0Lmg6CisgICAgICAgIChXZWJDb3JlVGVzdFN1cHBvcnQpOgorICAg ICAgICBVc2UgdGhlIGV4cG9ydCBtYWNyby4KKwogMjAxMi0wNy0wMyAgRXVnZW5lIEtseXVjaG5p a292ICA8ZXVzdGFzLmJ1Z0BnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRm9y d2FyZCBtZXNzYWdlIGxvb3AgaW5zdHJ1bWVudGF0aW9uIGRhdGEgdG8gZnJvbnRlbmQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybUV4cG9ydE1hY3Jvcy5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1FeHBvcnRNYWNyb3MuaAppbmRleCBhZTNl MzBhM2E5YmM4NTMyNzg3ZjY4MDNlYmQ5ODIwMjUxZTk3NzUyLi42OTAxMGU3ZWFhZGMzMjBhYmUz ZjRkNDIzODE2ZDdlNDRhYjg5OGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9QbGF0Zm9ybUV4cG9ydE1hY3Jvcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Bs YXRmb3JtRXhwb3J0TWFjcm9zLmgKQEAgLTYxLDQgKzYxLDE2IEBACiAKICNlbmRpZiAvLyBVU0Uo RVhQT1JUX01BQ1JPUykKIAorLy8gU3BlY2lhbCBjYXNlcy4KKworI2lmIFBMQVRGT1JNKFFUKQor I2lmIGRlZmluZWQoQlVJTERJTkdfV2ViQ29yZSkgfHwgZGVmaW5lZChCVUlMRElOR19XZWJLaXQp IHx8IFwKKyAgICBkZWZpbmVkKFNUQVRJQ0FMTFlfTElOS0VEX1dJVEhfV2ViQ29yZSkgfHwgZGVm aW5lZChTVEFUSUNBTExZX0xJTktFRF9XSVRIX1dlYktpdCkKKyNkZWZpbmUgV0VCS0lUX1RFU1Rf U1VQUE9SVF9FWFBPUlQgV1RGX0VYUE9SVAorI2Vsc2UKKyNkZWZpbmUgV0VCS0lUX1RFU1RfU1VQ UE9SVF9FWFBPUlQgV1RGX0lNUE9SVAorI2Vsc2UKKyNkZWZpbmUgV0VCS0lUX1RFU1RfU1VQUE9S VF9FWFBPUlQKKyNlbmRpZiAvLyBQTEFURk9STShRVCkKKwogI2VuZGlmIC8vIFBsYXRmb3JtRXhw b3J0TWFjcm9zX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvanMvV2ViQ29y ZVRlc3RTdXBwb3J0LmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3Vw cG9ydC5oCmluZGV4IGJmZDhhOGJhOTE0NjE0ZjNlZjU4NDI4MjRhNTU3MjkwMmY3NGY0ZGUuLmYw Njc0MWQ5NGJmMDRjYmI1M2UxMjExYzgyNmU1YjZlZWI3YTgyNTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuaApAQCAtMjYsMTIgKzI2LDE0IEBA CiAjaWZuZGVmIFdlYkNvcmVUZXN0U3VwcG9ydF9oCiAjZGVmaW5lIFdlYkNvcmVUZXN0U3VwcG9y dF9oCiAKKyNpbmNsdWRlICJQbGF0Zm9ybUV4cG9ydE1hY3Jvcy5oIgorCiB0eXBlZGVmIGNvbnN0 IHN0cnVjdCBPcGFxdWVKU0NvbnRleHQqIEpTQ29udGV4dFJlZjsKIAogbmFtZXNwYWNlIFdlYkNv cmVUZXN0U3VwcG9ydCB7CiAKLXZvaWQgaW5qZWN0SW50ZXJuYWxzT2JqZWN0KEpTQ29udGV4dFJl Zik7Ci12b2lkIHJlc2V0SW50ZXJuYWxzT2JqZWN0KEpTQ29udGV4dFJlZik7CitXRUJLSVRfVEVT VF9TVVBQT1JUX0VYUE9SVCB2b2lkIGluamVjdEludGVybmFsc09iamVjdChKU0NvbnRleHRSZWYp OworV0VCS0lUX1RFU1RfU1VQUE9SVF9FWFBPUlQgdm9pZCByZXNldEludGVybmFsc09iamVjdChK U0NvbnRleHRSZWYpOwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3Rlc3RpbmcvdjgvV2ViQ29yZVRlc3RTdXBwb3J0LmggYi9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL3Y4L1dlYkNvcmVUZXN0U3VwcG9ydC5oCmluZGV4IGZhNDljNjA2YmRjYTJl ZjQzODViMmEzODc1YTQ5ZmZlMDJlYWJmMTUuLmZmMDZkNDVkMWJlMGJlNzljZGNjYWY5MDkzNDgw NDNkNzhkOWVmMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvdjgvV2ViQ29y ZVRlc3RTdXBwb3J0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy92OC9XZWJDb3JlVGVz dFN1cHBvcnQuaApAQCAtMjYsNiArMjYsOCBAQAogI2lmbmRlZiBXZWJDb3JlVGVzdFN1cHBvcnRf aAogI2RlZmluZSBXZWJDb3JlVGVzdFN1cHBvcnRfaAogCisjaW5jbHVkZSAiUGxhdGZvcm1FeHBv cnRNYWNyb3MuaCIKKwogbmFtZXNwYWNlIHY4IHsKIGNsYXNzIENvbnRleHQ7CiB0ZW1wbGF0ZSA8 Y2xhc3MgVD4gY2xhc3MgTG9jYWw7CkBAIC0zMyw4ICszNSw4IEBAIHRlbXBsYXRlIDxjbGFzcyBU PiBjbGFzcyBMb2NhbDsKIAogbmFtZXNwYWNlIFdlYkNvcmVUZXN0U3VwcG9ydCB7CiAKLXZvaWQg aW5qZWN0SW50ZXJuYWxzT2JqZWN0KHY4OjpMb2NhbDx2ODo6Q29udGV4dD4pOwotdm9pZCByZXNl dEludGVybmFsc09iamVjdCh2ODo6TG9jYWw8djg6OkNvbnRleHQ+KTsKK1dFQktJVF9URVNUX1NV UFBPUlRfRVhQT1JUIHZvaWQgaW5qZWN0SW50ZXJuYWxzT2JqZWN0KHY4OjpMb2NhbDx2ODo6Q29u dGV4dD4pOworV0VCS0lUX1RFU1RfU1VQUE9SVF9FWFBPUlQgdm9pZCByZXNldEludGVybmFsc09i amVjdCh2ODo6TG9jYWw8djg6OkNvbnRleHQ+KTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQog Cg== 150629 2012-07-03 09:40:57 -0700 2012-07-03 10:18:56 -0700 Patch bug-90346-20120703184053.patch text/plain 3714 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY0ODFlOWRlNzhiMmRm ODNlYTY2NjI5YTA3MjM3ZTk0ODljNDNjOS4uYjZkMmE5MTMzYWUxYmY5ZWE2ZWJkNTRjMGMzNzBh MTJmOWU2MGRjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA3LTAzICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFdlYkNvcmVU ZXN0U3VwcG9ydCBmdW5jdGlvbnMgc2hvdWxkIGJlIGV4cG9ydGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDM0NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBhIGJ1 aWxkIGZpeC4KKworICAgICAgICBFeHBvcnQgV2ViQ29yZVRlc3RTdXBwb3J0IGZ1bmN0aW9ucyB3 aXRoIGV4cG9ydCBtYWNyb3Mgb24gUXQuCisgICAgICAgIFRoZXNlIGFyZSB1c2VkIGZyb20gV2Vi S2l0VGVzdFJ1bm5lciB3aWhjaCBpcyBhIHJlZ3VsYXIgQVBJIHVzZXIKKyAgICAgICAgb2YgV2Vi S2l0IGFuZCBkb24ndCBoYXZlIGFjY2VzcyB0byBXZWJDb3JlIGludGVybmFscy4gVGhlcmUgaXMK KyAgICAgICAgbm8gb3RoZXIgcG9ydCB0aGF0IG5lZWQgdGhpcyBjdXJyZW50bHkgc28gSSByZXN0 cmljdGVkIGl0IHRvIFF0CisgICAgICAgIHRvIG5vdCBleHBvc2Ugc3R1ZmYgdW5uZWNlc3Nhcmls eSBvbiBvdGhlciBwb3J0cy4KKworICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtRXhwb3J0TWFj cm9zLmg6CisgICAgICAgIEFkZGVkIGEgc3BlY2lhbCBjYXNlIGV4cG9ydCBtYWNybyBmb3IgV2Vi Q29yZVRlc3RTdXBwb3J0LgorICAgICAgICAqIHRlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0 Lmg6CisgICAgICAgIChXZWJDb3JlVGVzdFN1cHBvcnQpOgorICAgICAgICAqIHRlc3Rpbmcvdjgv V2ViQ29yZVRlc3RTdXBwb3J0Lmg6CisgICAgICAgIChXZWJDb3JlVGVzdFN1cHBvcnQpOgorICAg ICAgICBVc2UgdGhlIGV4cG9ydCBtYWNyby4KKwogMjAxMi0wNy0wMyAgRXVnZW5lIEtseXVjaG5p a292ICA8ZXVzdGFzLmJ1Z0BnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRm9y d2FyZCBtZXNzYWdlIGxvb3AgaW5zdHJ1bWVudGF0aW9uIGRhdGEgdG8gZnJvbnRlbmQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybUV4cG9ydE1hY3Jvcy5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1FeHBvcnRNYWNyb3MuaAppbmRleCBhZTNl MzBhM2E5YmM4NTMyNzg3ZjY4MDNlYmQ5ODIwMjUxZTk3NzUyLi4xNDVmNzNjMmJkYjE3YzA3OGI5 OWM5NWMwMzMyZGJlZDc2NzZhZTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9QbGF0Zm9ybUV4cG9ydE1hY3Jvcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Bs YXRmb3JtRXhwb3J0TWFjcm9zLmgKQEAgLTYxLDQgKzYxLDE3IEBACiAKICNlbmRpZiAvLyBVU0Uo RVhQT1JUX01BQ1JPUykKIAorLy8gU3BlY2lhbCBjYXNlcy4KKworI2lmIFBMQVRGT1JNKFFUKQor I2lmIGRlZmluZWQoQlVJTERJTkdfV2ViQ29yZSkgfHwgZGVmaW5lZChCVUlMRElOR19XZWJLaXQp IHx8IFwKKyAgICBkZWZpbmVkKFNUQVRJQ0FMTFlfTElOS0VEX1dJVEhfV2ViQ29yZSkgfHwgZGVm aW5lZChTVEFUSUNBTExZX0xJTktFRF9XSVRIX1dlYktpdCkKKyNkZWZpbmUgV0VCS0lUX1RFU1Rf U1VQUE9SVF9FWFBPUlQgV1RGX0VYUE9SVAorI2Vsc2UKKyNkZWZpbmUgV0VCS0lUX1RFU1RfU1VQ UE9SVF9FWFBPUlQgV1RGX0lNUE9SVAorI2VuZGlmCisjZWxzZQorI2RlZmluZSBXRUJLSVRfVEVT VF9TVVBQT1JUX0VYUE9SVAorI2VuZGlmIC8vIFBMQVRGT1JNKFFUKQorCiAjZW5kaWYgLy8gUGxh dGZvcm1FeHBvcnRNYWNyb3NfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9q cy9XZWJDb3JlVGVzdFN1cHBvcnQuaCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvanMvV2ViQ29y ZVRlc3RTdXBwb3J0LmgKaW5kZXggYmZkOGE4YmE5MTQ2MTRmM2VmNTg0MjgyNGE1NTcyOTAyZjc0 ZjRkZS4uZjA2NzQxZDk0YmYwNGNiYjUzZTEyMTFjODI2ZTViNmVlYjdhODI1MiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuaAorKysgYi9T b3VyY2UvV2ViQ29yZS90ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3VwcG9ydC5oCkBAIC0yNiwxMiAr MjYsMTQgQEAKICNpZm5kZWYgV2ViQ29yZVRlc3RTdXBwb3J0X2gKICNkZWZpbmUgV2ViQ29yZVRl c3RTdXBwb3J0X2gKIAorI2luY2x1ZGUgIlBsYXRmb3JtRXhwb3J0TWFjcm9zLmgiCisKIHR5cGVk ZWYgY29uc3Qgc3RydWN0IE9wYXF1ZUpTQ29udGV4dCogSlNDb250ZXh0UmVmOwogCiBuYW1lc3Bh Y2UgV2ViQ29yZVRlc3RTdXBwb3J0IHsKIAotdm9pZCBpbmplY3RJbnRlcm5hbHNPYmplY3QoSlND b250ZXh0UmVmKTsKLXZvaWQgcmVzZXRJbnRlcm5hbHNPYmplY3QoSlNDb250ZXh0UmVmKTsKK1dF QktJVF9URVNUX1NVUFBPUlRfRVhQT1JUIHZvaWQgaW5qZWN0SW50ZXJuYWxzT2JqZWN0KEpTQ29u dGV4dFJlZik7CitXRUJLSVRfVEVTVF9TVVBQT1JUX0VYUE9SVCB2b2lkIHJlc2V0SW50ZXJuYWxz T2JqZWN0KEpTQ29udGV4dFJlZik7CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy92OC9XZWJDb3JlVGVzdFN1cHBvcnQuaCBiL1Nv dXJjZS9XZWJDb3JlL3Rlc3RpbmcvdjgvV2ViQ29yZVRlc3RTdXBwb3J0LmgKaW5kZXggZmE0OWM2 MDZiZGNhMmVmNDM4NWIyYTM4NzVhNDlmZmUwMmVhYmYxNS4uZmYwNmQ0NWQxYmUwYmU3OWNkY2Nh ZjkwOTM0ODA0M2Q3OGQ5ZWYyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy92 OC9XZWJDb3JlVGVzdFN1cHBvcnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL3Y4L1dl YkNvcmVUZXN0U3VwcG9ydC5oCkBAIC0yNiw2ICsyNiw4IEBACiAjaWZuZGVmIFdlYkNvcmVUZXN0 U3VwcG9ydF9oCiAjZGVmaW5lIFdlYkNvcmVUZXN0U3VwcG9ydF9oCiAKKyNpbmNsdWRlICJQbGF0 Zm9ybUV4cG9ydE1hY3Jvcy5oIgorCiBuYW1lc3BhY2UgdjggewogY2xhc3MgQ29udGV4dDsKIHRl bXBsYXRlIDxjbGFzcyBUPiBjbGFzcyBMb2NhbDsKQEAgLTMzLDggKzM1LDggQEAgdGVtcGxhdGUg PGNsYXNzIFQ+IGNsYXNzIExvY2FsOwogCiBuYW1lc3BhY2UgV2ViQ29yZVRlc3RTdXBwb3J0IHsK IAotdm9pZCBpbmplY3RJbnRlcm5hbHNPYmplY3Qodjg6OkxvY2FsPHY4OjpDb250ZXh0Pik7Ci12 b2lkIHJlc2V0SW50ZXJuYWxzT2JqZWN0KHY4OjpMb2NhbDx2ODo6Q29udGV4dD4pOworV0VCS0lU X1RFU1RfU1VQUE9SVF9FWFBPUlQgdm9pZCBpbmplY3RJbnRlcm5hbHNPYmplY3Qodjg6OkxvY2Fs PHY4OjpDb250ZXh0Pik7CitXRUJLSVRfVEVTVF9TVVBQT1JUX0VYUE9SVCB2b2lkIHJlc2V0SW50 ZXJuYWxzT2JqZWN0KHY4OjpMb2NhbDx2ODo6Q29udGV4dD4pOwogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCiAK