90213 2012-06-28 14:57:02 -0700 Clean up m_data in ReferenceFilterOperation 2012-10-29 19:44:43 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco dino oldest_to_newest 659857 0 senorblanco 2012-06-28 14:57:02 -0700 We currently use a void* m_data to track the cached SVG document (if any) corresponding to a ReferenceFilterOperation. It isn't used down at the platform/graphics/filter level (and would be a layer violation if it was). We should probably find a better way to do this. Here was my comment on the original bug: "I really would rather have this data stored in a hash table at a higher level, but I seem to be hamstrung by data hiding. StyleResolver knows about the WebKitCSSSVGDocumentValue (where the CachedSVGDocument lives), and uses it to load the SVG document, but RenderLayerFilterInfo and FilterEffectRenderer only get the FilterOperations, not the WebKitCSSSVGDocumentValue. This void* is only to get the pointer from one place to the other two, so there's no real interface to be defined down at the FilterOperation level, since it doesn't do anything with it. If there's a better way to do that, I'm definitely interested." 753948 1 senorblanco 2012-10-29 19:44:43 -0700 This was fixed by http://trac.webkit.org/changeset/132528.