90173 2012-06-28 06:44:48 -0700 Fix LayoutUnit usage in RenderImage::imageDimensionsChanged 2012-07-03 12:07:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 d-r d-r abarth eae eric jchaffraix leviw webkit.review.bot oldest_to_newest 659463 0 d-r 2012-06-28 06:44:48 -0700 There's still two int declarations (oldwidth, oldheight) in RenderImage::imageDimensionsChanged - these should be LayoutUnit's in my understanding. Patch follows. 660339 1 150127 d-r 2012-06-29 03:25:40 -0700 Created attachment 150127 Fixing declarations. 662360 2 eae 2012-07-03 10:50:40 -0700 The intrinsic size for a replaced element is always in full pixels so in most cases this doesn't matter. You are right though that it should be using LayoutUnits. Thanks! 662403 3 150127 eric 2012-07-03 11:40:40 -0700 Comment on attachment 150127 Fixing declarations. LGTM. I don't see any way to trigger this bug. Unless intrinsic size is somehow scaled (which I doubt). 662404 4 150127 eric 2012-07-03 11:41:01 -0700 Comment on attachment 150127 Fixing declarations. Sorry, misclick. 662420 5 150127 webkit.review.bot 2012-07-03 12:07:21 -0700 Comment on attachment 150127 Fixing declarations. Clearing flags on attachment: 150127 Committed r121795: <http://trac.webkit.org/changeset/121795> 662421 6 webkit.review.bot 2012-07-03 12:07:27 -0700 All reviewed patches have been landed. Closing bug. 150127 2012-06-29 03:25:40 -0700 2012-07-03 12:07:21 -0700 Fixing declarations. bug-90173-20120629132741.patch text/plain 1639 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTdhOGE4ZWFlYjE2NmI5 ZjVmNDdjYTc5NWIyMTNlMGZhNmNlYjMxZS4uYTg4NWUzZDA5MTRkZmIwM2MxOWUyNGI5OTUzYzVj ZTc4MWQxNjIwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTI5ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg Rml4IExheW91dFVuaXQgdXNhZ2UgaW4gUmVuZGVySW1hZ2U6OmltYWdlRGltZW5zaW9uc0NoYW5n ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMTcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFw cHJvcHJpYXRlIHR5cGUgc2hvdWxkIGJlIHVzZWQgZm9yIHN0b3Jpbmcgd2lkdGgoKSBhbmQgaGVp Z2h0KCkgaW50byBsb2NhbCB0ZW1wb3JhcnkgdmFyaWFibGVzLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckltYWdlOjppbWFnZURpbWVuc2lv bnNDaGFuZ2VkKToKKwogMjAxMi0wNi0yOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMTUyOS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCmluZGV4IDZlMTEwOWM3YmQ3 ODg1ZTdhNGUyYjU5ZjdkODNjNDUwMzQ3NDFkMGQuLjc3NmUyNzg3YmYyODk0OWQ0ZjMyMWIxNzM1 NDNiYzg0MmM4ZTUwN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNw cApAQCAtMjE5LDggKzIxOSw4IEBAIHZvaWQgUmVuZGVySW1hZ2U6OmltYWdlRGltZW5zaW9uc0No YW5nZWQoYm9vbCBpbWFnZVNpemVDaGFuZ2VkLCBjb25zdCBJbnRSZWN0KiByCiAgICAgYm9vbCBz aG91bGRSZXBhaW50ID0gdHJ1ZTsKICAgICBpZiAoaW50cmluc2ljU2l6ZUNoYW5nZWQpIHsKICAg ICAgICAgLy8gbGV0cyBzZWUgaWYgd2UgbmVlZCB0byByZWxheW91dCBhdCBhbGwuLgotICAgICAg ICBpbnQgb2xkd2lkdGggPSB3aWR0aCgpOwotICAgICAgICBpbnQgb2xkaGVpZ2h0ID0gaGVpZ2h0 KCk7CisgICAgICAgIExheW91dFVuaXQgb2xkd2lkdGggPSB3aWR0aCgpOworICAgICAgICBMYXlv dXRVbml0IG9sZGhlaWdodCA9IGhlaWdodCgpOwogICAgICAgICBpZiAoIXByZWZlcnJlZExvZ2lj YWxXaWR0aHNEaXJ0eSgpKQogICAgICAgICAgICAgc2V0UHJlZmVycmVkTG9naWNhbFdpZHRoc0Rp cnR5KHRydWUpOwogICAgICAgICBjb21wdXRlTG9naWNhbFdpZHRoKCk7Cg==