90072 2012-06-27 06:49:27 -0700 Use source.svn.SVN instead of source.oldsource.SVN 2017-06-20 02:16:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 85887 90075 1 ossy webkit-unassigned galpeter lforschler ossy tony oldest_to_newest 658574 0 ossy 2012-06-27 06:49:27 -0700 Because the old one is very old. :) And the newer one is good for us to make https://bugs.webkit.org/show_bug.cgi?id=85887 unittestable and we can make clean build request feature with it quite easily. Patch is coming soon. 658575 1 149741 ossy 2012-06-27 06:55:45 -0700 Created attachment 149741 Patch 658583 2 149741 ossy 2012-06-27 07:08:28 -0700 Comment on attachment 149741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149741&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:13 > -from buildbot.steps import master, shell, source, transfer, trigger > +from buildbot.steps import master, shell, transfer, trigger > +from buildbot.steps.source.svn import SVN We need it, because steps.source.__init__.py makes oldsource default: from buildbot.steps.source.oldsource import _ComputeRepositoryURL, Source, CVS, \ SVN, Git, Darcs, Repo, Bzr, Mercurial, P4, P4Sync, Monotone, BK > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:117 > - mode = "update" > + mode = "incremental" "incremental" is similar to the old update mode. In the future we can use the "fresh" method of the "full" mode to trigger clean builds on the bots if it necessary http://buildbot.net/buildbot/docs/0.8.6p1/manual/cfg-buildsteps.html#step-SVN 658589 3 ossy 2012-06-27 07:15:32 -0700 (In reply to comment #2) > "incremental" is similar to the old update mode. Not similar, same. :) "This mode is exactly same as the old update mode." 659311 4 galpeter 2012-06-28 00:57:04 -0700 (In reply to comment #1) > Created an attachment (id=149741) [details] > Patch Code looks sane to me. 667599 5 149741 ossy 2012-07-12 04:01:38 -0700 Comment on attachment 149741 Patch It works more or less ... but there are some problems with master-side SVN step now: - It doesn't work with buildslave older than 0.8.5 because of an annoying bug. I already fixed it in the buildbot, so it will be in the next buildmaster release. - SVN revision isn't shown on the waterfall. I started experimenting with it, we can make it with a buildbot fix or a workaround in master.cfg. I'm on it. 694884 6 158307 ossy 2012-08-14 05:53:39 -0700 Created attachment 158307 patch It depends on https://bugs.webkit.org/show_bug.cgi?id=85887 and fixes in buildbot, so I don't ask r? now. 149741 2012-06-27 06:55:45 -0700 2012-07-12 04:01:37 -0700 Patch bug-90072-20120627065544.patch text/plain 2180 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjNhOTAxOTJkYjNmNjY1MjYzNmI0N2VhZDc5MTMwMDYz MjFhOGRmNy4uODNiZGZjYWI5NGIyNDhlYjM2OTU3YjhmMWZlMzMzNjU1NzIzZmY0MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDEyLTA2LTI3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgbWFzdGVyLmNmZyBjbGVhbnVwOiBVc2Ugc291cmNlLnN2bi5TVk4gaW5zdGVhZCBv ZiBzb3VyY2Uub2xkc291cmNlLlNWTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTAwNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L21hc3Rlci5jZmc6CisgICAgICAgIChDaGVja091dFNvdXJjZSk6CisgICAgICAgIChDaGVja091 dFNvdXJjZS5fX2luaXRfXyk6CisKKzIwMTItMDYtMjcgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9z c3lAd2Via2l0Lm9yZz4KKwogICAgICAgICBBZGQgbWFzdGVyLmNmZyB1bml0dGVzdCB0byBoZWxw IG1pZ3JhdGlvbiAtIHBhc3MgQnVpbGRTdGVwIGluc3RhbmNlcyBpbnN0ZWFkIG9mIEJ1aWxkU3Rl cCBzdWJjbGFzc2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04OTU2NAogCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwppbmRleCA5ZTU3ZDMyM2VmMzc1MzYzMWI0 M2I1OTYxNjE2ZDBlMjhiZWU4OTU5Li44ZGRmZDNmMzJhYjIzMDY0YTYwMTU4NjFkNjU2ZGM0MjQ2 MGJkNzBkIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKQEAgLTksNyArOSw4IEBAIGZyb20gYnVpbGRi b3Quc2NoZWR1bGVycy5maWx0ZXIgaW1wb3J0IENoYW5nZUZpbHRlcgogZnJvbSBidWlsZGJvdC5z dGF0dXMgaW1wb3J0IGh0bWwKIGZyb20gYnVpbGRib3Quc3RhdHVzLndlYi5hdXRoeiBpbXBvcnQg QXV0aHoKIGZyb20gYnVpbGRib3QucHJvY2VzcyBpbXBvcnQgYnVpbGRzdGVwLCBmYWN0b3J5LCBw cm9wZXJ0aWVzCi1mcm9tIGJ1aWxkYm90LnN0ZXBzIGltcG9ydCBtYXN0ZXIsIHNoZWxsLCBzb3Vy Y2UsIHRyYW5zZmVyLCB0cmlnZ2VyCitmcm9tIGJ1aWxkYm90LnN0ZXBzIGltcG9ydCBtYXN0ZXIs IHNoZWxsLCB0cmFuc2ZlciwgdHJpZ2dlcgorZnJvbSBidWlsZGJvdC5zdGVwcy5zb3VyY2Uuc3Zu IGltcG9ydCBTVk4KIGZyb20gYnVpbGRib3Quc3RhdHVzLmJ1aWxkZXIgaW1wb3J0IFNVQ0NFU1Ms IEZBSUxVUkUsIFdBUk5JTkdTLCBTS0lQUEVECiAKIGZyb20gdHdpc3RlZC5pbnRlcm5ldCBpbXBv cnQgZGVmZXIKQEAgLTExMSwxNCArMTEyLDE0IEBAIGNsYXNzIENvbmZpZ3VyZUJ1aWxkKGJ1aWxk c3RlcC5CdWlsZFN0ZXApOgogICAgICAgICByZXR1cm4gZGVmZXIuc3VjY2VlZChOb25lKQogCiAK LWNsYXNzIENoZWNrT3V0U291cmNlKHNvdXJjZS5TVk4pOgorY2xhc3MgQ2hlY2tPdXRTb3VyY2Uo U1ZOKToKICAgICBiYXNlVVJMID0gImh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dl YmtpdC8iCi0gICAgbW9kZSA9ICJ1cGRhdGUiCisgICAgbW9kZSA9ICJpbmNyZW1lbnRhbCIKICAg ICBkZWYgX19pbml0X18oc2VsZiwgKiprd2FyZ3MpOgogICAgICAgICBrd2FyZ3NbJ2Jhc2VVUkwn XSA9IHNlbGYuYmFzZVVSTAogICAgICAgICBrd2FyZ3NbJ2RlZmF1bHRCcmFuY2gnXSA9ICJ0cnVu ayIKICAgICAgICAga3dhcmdzWydtb2RlJ10gPSBzZWxmLm1vZGUKLSAgICAgICAgc291cmNlLlNW Ti5fX2luaXRfXyhzZWxmLCAqKmt3YXJncykKKyAgICAgICAgU1ZOLl9faW5pdF9fKHNlbGYsICoq a3dhcmdzKQogCiAKIAo= 158307 2012-08-14 05:53:39 -0700 2012-08-14 05:53:39 -0700 patch 1.patch text/plain 1931 ossy ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGVmZmM1OWIuLjNkMjI3ZDcgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtMTAsNiArMTAsNyBAQCBmcm9tIGJ1aWxkYm90LnN0YXR1cyBpbXBvcnQgaHRt bAogZnJvbSBidWlsZGJvdC5zdGF0dXMud2ViLmF1dGh6IGltcG9ydCBBdXRoegogZnJvbSBidWls ZGJvdC5wcm9jZXNzIGltcG9ydCBidWlsZHN0ZXAsIGZhY3RvcnksIHByb3BlcnRpZXMKIGZyb20g YnVpbGRib3Quc3RlcHMgaW1wb3J0IG1hc3Rlciwgc2hlbGwsIHNvdXJjZSwgdHJhbnNmZXIsIHRy aWdnZXIKK2Zyb20gYnVpbGRib3Quc3RlcHMuc291cmNlLnN2biBpbXBvcnQgU1ZOCiBmcm9tIGJ1 aWxkYm90LnN0YXR1cy5idWlsZGVyIGltcG9ydCBTVUNDRVNTLCBGQUlMVVJFLCBXQVJOSU5HUywg U0tJUFBFRAogCiBmcm9tIHR3aXN0ZWQuaW50ZXJuZXQgaW1wb3J0IGRlZmVyCkBAIC0xMTMsMTMg KzExNCwxMyBAQCBjbGFzcyBDb25maWd1cmVCdWlsZChidWlsZHN0ZXAuQnVpbGRTdGVwKToKICAg ICAgICAgcmV0dXJuIGRlZmVyLnN1Y2NlZWQoTm9uZSkKIAogCi1jbGFzcyBDaGVja091dFNvdXJj ZShzb3VyY2UuU1ZOKToKLSAgICBtb2RlID0gInVwZGF0ZSIKK2NsYXNzIENoZWNrT3V0U291cmNl KFNWTik6CisgICAgbW9kZSA9ICJpbmNyZW1lbnRhbCIKICAgICBkZWYgX19pbml0X18oc2VsZiwg U1ZOTWlycm9yLCAqKmt3YXJncyk6CiAgICAgICAgIGt3YXJnc1snYmFzZVVSTCddID0gU1ZOTWly cm9yIG9yICJodHRwOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93ZWJraXQvIgogICAgICAg ICBrd2FyZ3NbJ2RlZmF1bHRCcmFuY2gnXSA9ICJ0cnVuayIKICAgICAgICAga3dhcmdzWydtb2Rl J10gPSBzZWxmLm1vZGUKLSAgICAgICAgc291cmNlLlNWTi5fX2luaXRfXyhzZWxmLCAqKmt3YXJn cykKKyAgICAgICAgU1ZOLl9faW5pdF9fKHNlbGYsICoqa3dhcmdzKQogICAgICAgICBzZWxmLmFk ZEZhY3RvcnlBcmd1bWVudHMoU1ZOTWlycm9yPVNWTk1pcnJvcikKIAogY2xhc3MgV2FpdEZvclNW TlNlcnZlcihzaGVsbC5TaGVsbENvbW1hbmQpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDI2ZWQ2NjAuLjI1YTc5MTQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAx Mi0wOC0xNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCisgICAgICAg IFVzZSBzb3VyY2Uuc3ZuLlNWTiBpbnN0ZWFkIG9mIHNvdXJjZS5vbGRzb3VyY2UuU1ZOCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDA3MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKENoZWNr T3V0U291cmNlKToKKyAgICAgICAgKENoZWNrT3V0U291cmNlLl9faW5pdF9fKToKKworMjAxMi0w OC0xNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCiAgICAgICAgIEFk ZCBTVk4gbWlycm9yIGhhbmRsaW5nIGZlYXR1cmUgdG8gYnVpbGQud2Via2l0Lm9yZwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU4ODcKIAo=