90049 2012-06-26 23:12:56 -0700 [Qt] EWS bots should call qmake always 2012-12-20 05:46:59 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy ossy dbates hausmann ossy vestbo webkit.review.bot oldest_to_newest 658368 0 ossy 2012-06-26 23:12:56 -0700 When the latest build suceeded and there isn't new SVN revision, buildHint in webkitdirs.pm isn't "incremental", but "". It is correct behaviour for developer build, but it isn't for EWS. Unfortunately it can cause and it causes incremental build problems on the EWS bots sometimes. Here is an example: https://bugs.webkit.org/show_bug.cgi?id=89939 I'm going to check how can we make the EWS bots do full incremental build always (call qmake always to regenerate dependency) to avoid these false positive alarms. Tor Arne, if you have any idea how to fix it, please share with me. :) Thanks in advance. 658462 1 vestbo 2012-06-27 01:53:19 -0700 One option would be to run build-webkit with --makeargs=incremental 658481 2 ossy 2012-06-27 02:19:14 -0700 (In reply to comment #1) > One option would be to run build-webkit with --makeargs=incremental Thanks, it is the best option. We don't have to modify anything in the build system. I added the following env to our EWS config: export BUILD_WEBKIT_ARGS=--makeargs=incremental Now it works fine. ;-) 795371 3 ossy 2012-12-20 05:05:06 -0800 Reopen, because "export BUILD_WEBKIT_ARGS=--makeargs=incremental" wasn't a good idea. Because now it causes many false negative red EWS bubbles. The problem is when a patch changes any configuration which triggers "make wipeclean" before anything else. But in this case "make incremental wipeclean" is called, which is incorrect, and makes the build fail because of race condition. I think we should handle it in webkitdirs.pm and set $needsIncrementalBuild if CONFIG+=buildbot is used instead of setting this buggy env on the EWS bots. Patch is coming. 795372 4 180324 ossy 2012-12-20 05:06:26 -0800 Created attachment 180324 Patch 795375 5 ossy 2012-12-20 05:08:28 -0800 Here is an example for false negative results - https://bugs.webkit.org/show_bug.cgi?id=104804 795387 6 180324 ossy 2012-12-20 05:46:54 -0800 Comment on attachment 180324 Patch Clearing flags on attachment: 180324 Committed r138246: <http://trac.webkit.org/changeset/138246> 795388 7 ossy 2012-12-20 05:46:59 -0800 All reviewed patches have been landed. Closing bug. 180324 2012-12-20 05:06:26 -0800 2012-12-20 05:46:54 -0800 Patch bug-90049-20121220140342.patch text/plain 1347 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2JiMDExNmIyMzE2Mjc2OTFkNmY5ZjU4ZWIzZmE1NTkw MTE1ZDA5MC4uNTE2YTMwMzQ2ZDRhZDNiYzEwMTkwOTE3NDU2MjI3MjliNGFjNzQxNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTEyLTIwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XSBFV1MgYm90cyBzaG91bGQgY2FsbCBxbWFrZSBhbHdheXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwMDQ5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRp cnMucG06CisgICAgICAgIChidWlsZFFNYWtlUHJvamVjdHMpOgorCiAyMDEyLTEyLTIwICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0g Zml4IHN0cmF5IHByaW50ZiBpbiBUZXN0UnVubmVyJ3MgV2ViVGVzdFByb3h5CmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0KaW5kZXggZTZmNjJhYmY0NTYwOWIwOTljYzg4NGU3MGNjODljN2ZiYjFlOTUyMi4uNWEyZTA0 NDgwMDZhYjE1NDY0MTFiYWZjMDNjNWZjZWNhMTYzZWU1NyAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAt MjM1Niw2ICsyMzU2LDExIEBAIHN1YiBidWlsZFFNYWtlUHJvamVjdHMKICAgICBteSAkbWF5YmVO ZWVkc0NsZWFuQnVpbGQgPSAwOwogICAgIG15ICRuZWVkc0luY3JlbWVudGFsQnVpbGQgPSAwOwog CisgICAgIyBGdWxsIGluY3JlbWVudGFsIGJ1aWxkIChydW4gcW1ha2UpIG5lZWRlZCBvbiBidWls ZGJvdHMgYW5kIEVXUyBib3RzIGFsd2F5cy4KKyAgICBpZiAoZ3JlcCgvQ09ORklHXCs9YnVpbGRi b3QvLEBidWlsZFBhcmFtcykpIHsKKyAgICAgICAgJG5lZWRzSW5jcmVtZW50YWxCdWlsZCA9IDE7 CisgICAgfQorCiAgICAgaWYgKCRzdm5SZXZpc2lvbiBuZSAkcHJldmlvdXNTdm5SZXZpc2lvbikg ewogICAgICAgICBwcmludCAiTGFzdCBidWlsdCByZXZpc2lvbiB3YXMgIiAuICRwcmV2aW91c1N2 blJldmlzaW9uIC4KICAgICAgICAgICAgICIsIG5vdyBhdCByZXZpc2lvbiAkc3ZuUmV2aXNpb24u IEZ1bGwgaW5jcmVtZW50YWwgYnVpbGQgbmVlZGVkLlxuIjsK