90045 2012-06-26 22:49:07 -0700 Change FrameView::scrollContentsFastPath to use m_fixedObjects 2012-06-28 11:09:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90046 1 simon.fraser simon.fraser abarth aelias dbates jamesr sam simon.fraser skyostil webkit.review.bot oldest_to_newest 658348 0 simon.fraser 2012-06-26 22:49:07 -0700 Bug 78864 added a FixedObjectSet on FrameView. We should change FrameView::scrollContentsFastPath() to use this, rather than positionedObjects(), because it will also get used for position:sticky. 659231 1 149878 simon.fraser 2012-06-27 23:04:02 -0700 Created attachment 149878 Patch 659597 2 149878 jamesr 2012-06-28 10:27:17 -0700 Comment on attachment 149878 Patch R=me 659628 3 149878 webkit.review.bot 2012-06-28 11:09:02 -0700 Comment on attachment 149878 Patch Clearing flags on attachment: 149878 Committed r121443: <http://trac.webkit.org/changeset/121443> 659629 4 webkit.review.bot 2012-06-28 11:09:09 -0700 All reviewed patches have been landed. Closing bug. 149878 2012-06-27 23:04:02 -0700 2012-06-28 11:09:02 -0700 Patch bug-90045-20120627230402.patch text/plain 4087 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE4ZDRkNGQxMjczNWZj NzQ0YzZjZjA5MDY0OWYxYjI5Y2RiMDg1My4uOTNlNWZjMmU0NTVkOGFkZWRmNjU5ZTM5N2RiNDc4 N2Q2ZjJkOTQwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBGcmFt ZVZpZXc6OnNjcm9sbENvbnRlbnRzRmFzdFBhdGggdG8gdXNlIG1fZml4ZWRPYmplY3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDA0NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRnJhbWVW aWV3IG5vdyBoYXMgYSBoYXNoIHNldCBvZiBmaXhlZC1wb3NpdGlvbiBvYmplY3RzLCBzbyB1c2UK KyAgICAgICAgdGhhdCBpbnN0ZWFkIG9mIFJlbmRlckJsb2NrOjpwb3NpdGlvbmVkT2JqZWN0cygp OyB3ZSdsbCBhdm9pZCB0cmF2ZXJzaW5nCisgICAgICAgIHRocm91Z2ggYWJzb2x1dGVseSBwb3Np dGlvbmVkIG9iamVjdHMsIGFuZCB0aGlzIHdpbGwgd29yayBiZXR0ZXIgZm9yIHN0aWNreQorICAg ICAgICBwb3NpdGlvbmluZyBpbiBmdXR1cmUuCisKKyAgICAgICAgTm8gYmVoYXZpb3IgY2hhbmdl LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnNjcm9sbENvbnRlbnRzRmFzdFBhdGgpOgorCiAyMDEy LTA2LTI3ICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W1BsYXRmb3JtXSBJbXBsZW1lbnQgbG9jYWxpemVkRGVjaW1hbFNlcGFyYXRvciBmdW5jdGlvbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDJjZWNjMDI4NDllNDg1MDc0Mjg4YmUzMzgy MWMxMzU1NjMwYTk2ZjYuLjkxMDQ2M2Y5MDNiZjBiYTFhNWQ4OTRhODRhYzRjNjc3ZjZlM2MyMWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTE0NDAsMTEgKzE0NDAsNyBAQCBJbnRQ b2ludCBGcmFtZVZpZXc6OmN1cnJlbnRNb3VzZVBvc2l0aW9uKCkgY29uc3QKIAogYm9vbCBGcmFt ZVZpZXc6OnNjcm9sbENvbnRlbnRzRmFzdFBhdGgoY29uc3QgSW50U2l6ZSYgc2Nyb2xsRGVsdGEs IGNvbnN0IEludFJlY3QmIHJlY3RUb1Njcm9sbCwgY29uc3QgSW50UmVjdCYgY2xpcFJlY3QpCiB7 Ci0gICAgUmVuZGVyQmxvY2s6OlBvc2l0aW9uZWRPYmplY3RzTGlzdEhhc2hTZXQqIHBvc2l0aW9u ZWRPYmplY3RzID0gMDsKLSAgICBpZiAoUmVuZGVyVmlldyogcm9vdCA9IHJvb3RSZW5kZXJlcih0 aGlzKSkKLSAgICAgICAgcG9zaXRpb25lZE9iamVjdHMgPSByb290LT5wb3NpdGlvbmVkT2JqZWN0 cygpOwotCi0gICAgaWYgKCFwb3NpdGlvbmVkT2JqZWN0cyB8fCBwb3NpdGlvbmVkT2JqZWN0cy0+ aXNFbXB0eSgpKSB7CisgICAgaWYgKCFtX2ZpeGVkT2JqZWN0cyB8fCBtX2ZpeGVkT2JqZWN0cy0+ aXNFbXB0eSgpKSB7CiAgICAgICAgIGhvc3RXaW5kb3coKS0+c2Nyb2xsKHNjcm9sbERlbHRhLCBy ZWN0VG9TY3JvbGwsIGNsaXBSZWN0KTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQpAQCAt MTQ1MywxOCArMTQ0OSwyMyBAQCBib29sIEZyYW1lVmlldzo6c2Nyb2xsQ29udGVudHNGYXN0UGF0 aChjb25zdCBJbnRTaXplJiBzY3JvbGxEZWx0YSwgY29uc3QgSW50UmVjdAogCiAgICAgLy8gR2V0 IHRoZSByZWN0cyBvZiB0aGUgZml4ZWQgb2JqZWN0cyB2aXNpYmxlIGluIHRoZSByZWN0VG9TY3Jv bGwKICAgICBSZWdpb24gcmVnaW9uVG9VcGRhdGU7Ci0gICAgUmVuZGVyQmxvY2s6OlBvc2l0aW9u ZWRPYmplY3RzTGlzdEhhc2hTZXQ6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IHBvc2l0aW9uZWRPYmpl Y3RzLT5lbmQoKTsKLSAgICBmb3IgKFJlbmRlckJsb2NrOjpQb3NpdGlvbmVkT2JqZWN0c0xpc3RI YXNoU2V0Ojpjb25zdF9pdGVyYXRvciBpdCA9IHBvc2l0aW9uZWRPYmplY3RzLT5iZWdpbigpOyBp dCAhPSBlbmQ7ICsraXQpIHsKLSAgICAgICAgUmVuZGVyQm94KiByZW5kZXJCb3ggPSAqaXQ7Ci0g ICAgICAgIGlmIChyZW5kZXJCb3gtPnN0eWxlKCktPnBvc2l0aW9uKCkgIT0gRml4ZWRQb3NpdGlv bikKKyAgICBGaXhlZE9iamVjdFNldDo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbV9maXhlZE9iamVj dHMtPmVuZCgpOworICAgIGZvciAoRml4ZWRPYmplY3RTZXQ6OmNvbnN0X2l0ZXJhdG9yIGl0ID0g bV9maXhlZE9iamVjdHMtPmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkgeworICAgICAgICBSZW5k ZXJPYmplY3QqIHJlbmRlcmVyID0gKml0OworICAgICAgICBpZiAocmVuZGVyZXItPnN0eWxlKCkt PnBvc2l0aW9uKCkgIT0gRml4ZWRQb3NpdGlvbikKICAgICAgICAgICAgIGNvbnRpbnVlOwogI2lm IFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICAgICAgaWYgKHJlbmRlckJveC0+aXND b21wb3NpdGVkKCkpCisgICAgICAgIGlmIChyZW5kZXJlci0+aXNDb21wb3NpdGVkKCkpCiAgICAg ICAgICAgICBjb250aW51ZTsKICNlbmRpZgorICAgIAorICAgICAgICAvLyBGaXhlZCBpdGVtcyBz aG91bGQgYWx3YXlzIGhhdmUgbGF5ZXJzLgorICAgICAgICBBU1NFUlQocmVuZGVyZXItPmhhc0xh eWVyKCkpOworICAgICAgICBSZW5kZXJMYXllciogbGF5ZXIgPSB0b1JlbmRlckJveE1vZGVsT2Jq ZWN0KHJlbmRlcmVyKS0+bGF5ZXIoKTsKKyAgICAgICAgCiAjaWYgRU5BQkxFKENTU19GSUxURVJT KQotICAgICAgICBpZiAocmVuZGVyQm94LT5sYXllcigpICYmIHJlbmRlckJveC0+bGF5ZXIoKS0+ cGFyZW50KCkpIHsKLSAgICAgICAgICAgIFJlbmRlckJveE1vZGVsT2JqZWN0KiByZW5kZXJlciA9 IHJlbmRlckJveC0+bGF5ZXIoKS0+cGFyZW50KCktPnJlbmRlcmVyKCk7CisgICAgICAgIGlmIChs YXllci0+cGFyZW50KCkpIHsKKyAgICAgICAgICAgIFJlbmRlckJveE1vZGVsT2JqZWN0KiByZW5k ZXJlciA9IGxheWVyLT5wYXJlbnQoKS0+cmVuZGVyZXIoKTsKICAgICAgICAgICAgIGlmIChyZW5k ZXJlci0+c3R5bGUoKS0+aGFzRmlsdGVyT3V0c2V0cygpKSB7CiAgICAgICAgICAgICAgICAgLy8g SWYgdGhlIGZpeGVkIGxheWVyIGhhcyBhIGJsdXIvZHJvcC1zaGFkb3cgZmlsdGVyIGFwcGxpZWQg b24gaXRzIHBhcmVudCwgd2UgY2Fubm90IAogICAgICAgICAgICAgICAgIC8vIHNjcm9sbCB1c2lu ZyB0aGUgZmFzdCBwYXRoLCBvdGhlcndpc2UgdGhlIG91dHNldHMgb2YgdGhlIGZpbHRlciB3aWxs IGJlIG1vdmVkIGFyb3VuZCB0aGUgcGFnZS4KQEAgLTE0NzIsNyArMTQ3Myw3IEBAIGJvb2wgRnJh bWVWaWV3OjpzY3JvbGxDb250ZW50c0Zhc3RQYXRoKGNvbnN0IEludFNpemUmIHNjcm9sbERlbHRh LCBjb25zdCBJbnRSZWN0CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICNlbmRpZgotICAgICAg ICBJbnRSZWN0IHVwZGF0ZVJlY3QgPSBwaXhlbFNuYXBwZWRJbnRSZWN0KHJlbmRlckJveC0+bGF5 ZXIoKS0+cmVwYWludFJlY3RJbmNsdWRpbmdOb25Db21wb3NpdGluZ0Rlc2NlbmRhbnRzKCkpOwor ICAgICAgICBJbnRSZWN0IHVwZGF0ZVJlY3QgPSBwaXhlbFNuYXBwZWRJbnRSZWN0KGxheWVyLT5y ZXBhaW50UmVjdEluY2x1ZGluZ05vbkNvbXBvc2l0aW5nRGVzY2VuZGFudHMoKSk7CiAgICAgICAg IHVwZGF0ZVJlY3QgPSBjb250ZW50c1RvUm9vdFZpZXcodXBkYXRlUmVjdCk7CiAgICAgICAgIGlm ICghaXNDb21wb3NpdGVkQ29udGVudExheWVyICYmIGNsaXBzUmVwYWludHMoKSkKICAgICAgICAg ICAgIHVwZGF0ZVJlY3QuaW50ZXJzZWN0KHJlY3RUb1Njcm9sbCk7Cg==