89953 2012-06-26 00:42:17 -0700 New fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit 2012-06-26 02:23:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 87008 89802 1 ossy fpizlo barraclough fpizlo mrobinson ossy pnormand pvarga webkit.review.bot zan zherczeg oldest_to_newest 657361 0 ossy 2012-06-26 00:42:17 -0700 It is a new test introduced in http://trac.webkit.org/changeset/121215 and fails on 32 bit platforms. (Qt and GTK) --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit-actual.txt @@ -153,56 +153,56 @@ PASS foo(3, {f:f, g:g}, p) is 85 PASS foo(3, {f:f, g:g}, p) is 1 PASS foo(3, {f:f, g:g}, p) is 85 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 -PASS foo(3, {f:f, g:g}, p) is 0.5 -PASS foo(3, {f:f, g:g}, p) is 85.5 +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 0.5. Was 43. +FAIL foo(3, {f:f, g:g}, p) should be 85.5. Was 43. PASS successfullyParsed is true TEST COMPLETE 657364 1 fpizlo 2012-06-26 00:43:58 -0700 Oh no! Fix on the way... 657379 2 fpizlo 2012-06-26 01:00:21 -0700 Oh wow, good thing I wrote that test. Looks like the 32-bit DFG was assuming totally bad things about the types of local variables. Patch forthcoming. 657383 3 149475 fpizlo 2012-06-26 01:10:09 -0700 Created attachment 149475 the patch This ought to do it. 657421 4 ossy 2012-06-26 02:07:50 -0700 All tests pass on 32 bit Qt with this patch. Thanks for the fix. 657432 5 149475 webkit.review.bot 2012-06-26 02:23:02 -0700 Comment on attachment 149475 the patch Clearing flags on attachment: 149475 Committed r121243: <http://trac.webkit.org/changeset/121243> 657433 6 webkit.review.bot 2012-06-26 02:23:08 -0700 All reviewed patches have been landed. Closing bug. 149475 2012-06-26 01:10:09 -0700 2012-06-26 02:23:02 -0700 the patch fix32bit_patch_1.diff text/plain 2899 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxMjM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDEyLTA2LTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TmV3IGZhc3QvanMvZGZnLXN0b3JlLXVuZXhwZWN0ZWQtdmFsdWUtaW50by1hcmd1bWVudC1hbmQt b3NyLWV4aXQuaHRtbCBmYWlscyBvbiAzMiBiaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg5OTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBERkcgMzItYml0IEpJVCB3YXMgY29uZnVzZWQg YWJvdXQgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiBhIHByZWRpY3RlZCB0eXBlIGFuZCBhCisgICAg ICAgIHByb3ZlbiB0eXBlLiBUaGlzIGlzIGVhc3kgdG8gZ2V0IGNvbmZ1c2VkIGFib3V0LCBzaW5j ZSBhIGxvY2FsIHRoYXQgaXMgcHJlZGljdGVkIGludDMyCisgICAgICAgIGFsbW9zdCBhbHdheXMg bWVhbnMgdGhhdCB0aGUgbG9jYWwgbXVzdCBiZSBhbiBpbnQzMiBzaW5jZSBzcGVjdWxhdGlvbnMg YXJlIGhvaXN0ZWQgdG8KKyAgICAgICAgc3RvcmVzIHRvIGxvY2Fscy4gQnV0IHRoYXQgaXMgbGVz cyBsaWtlbHkgdG8gYmUgdGhlIGNhc2UgZm9yIGFyZ3VtZW50cywgd2hlcmUgdGhlcmUgaXMKKyAg ICAgICAgYW4gYWRkaXRpb25hbCBsZWFzdC11cHBlci1ib3VuZGluZyBzdGVwOiBhbnkgc3RvcmUg dG8gYW4gYXJndW1lbnQgd2l0aCBhIHdlaXJkIHR5cGUKKyAgICAgICAgbWF5IGZvcmNlIHRoZSBh cmd1bWVudCB0byBiZSBhbnkgdHlwZS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgcGF0Y2ggYmFz aWNhbGx5IGR1cGxpY2F0ZXMgdGhlIGZ1bmN0aW9uYWxpdHkgaW4gREZHU3BlY3VsYXRpdmVKSVQ2 NC5jcHAgZm9yCisgICAgICAgIEdldExvY2FsOiB0aGUgZGVjaXNpb24gb2Ygd2hldGhlciB0byBs b2FkIGEgbG9jYWwgYXMgYW4gaW50MzIgKG9yIGFzIGFuIGFycmF5LCBvciBhcworICAgICAgICBh IGJvb2xlYW4pIGlzIG1hZGUgYmFzZWQgb24gdGhlIEFic3RyYWN0VmFsdWU6Om1fdHlwZSwgd2hp Y2ggaXMgYSB0eXBlIHByb29mLCByYXRoZXIKKyAgICAgICAgdGhhbiB0aGUgVmFyaWFibGVBY2Nl c3NEYXRhOjpwcmVkaWN0aW9uKCksIHdoaWNoIGlzIGEgcHJlZGljdGVkIHR5cGUuCisKKyAgICAg ICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6 U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDEyLTA2LTI1ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIHNob3VsZCB0cnkgdG8gbWFrZSBwcm9maWxp bmcgZGV0ZXJtaW5pc3RpYyBiZWNhdXNlIG90aGVyd2lzZSByZXByb2R1Y2luZyBmYWlsdXJlcyBp cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklUMzJfNjQuY3BwCShyZXZpc2lvbiAxMjEyMzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODkx LDcgKzE4OTEsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUmIG5vZGUpCiAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgIAotICAgICAgICAg ICAgaWYgKGlzSW50MzJTcGVjdWxhdGlvbihwcmVkaWN0aW9uKSkgeworICAgICAgICAgICAgaWYg KGlzSW50MzJTcGVjdWxhdGlvbih2YWx1ZS5tX3R5cGUpKSB7CiAgICAgICAgICAgICAgICAgR1BS VGVtcG9yYXJ5IHJlc3VsdCh0aGlzKTsKICAgICAgICAgICAgICAgICBtX2ppdC5sb2FkMzIoSklU Q29tcGlsZXI6OnBheWxvYWRGb3Iobm9kZS5sb2NhbCgpKSwgcmVzdWx0LmdwcigpKTsKIApAQCAt MTkwMyw3ICsxOTAzLDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2Rl KQogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBp ZiAoaXNBcnJheVNwZWN1bGF0aW9uKHByZWRpY3Rpb24pKSB7CisgICAgICAgICAgICBpZiAoaXNB cnJheVNwZWN1bGF0aW9uKHZhbHVlLm1fdHlwZSkpIHsKICAgICAgICAgICAgICAgICBHUFJUZW1w b3JhcnkgcmVzdWx0KHRoaXMpOwogICAgICAgICAgICAgICAgIG1faml0LmxvYWQzMihKSVRDb21w aWxlcjo6cGF5bG9hZEZvcihub2RlLmxvY2FsKCkpLCByZXN1bHQuZ3ByKCkpOwogCkBAIC0xOTE1 LDcgKzE5MTUsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUmIG5vZGUpCiAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIGlmIChp c0Jvb2xlYW5TcGVjdWxhdGlvbihwcmVkaWN0aW9uKSkgeworICAgICAgICAgICAgaWYgKGlzQm9v bGVhblNwZWN1bGF0aW9uKHZhbHVlLm1fdHlwZSkpIHsKICAgICAgICAgICAgICAgICBHUFJUZW1w b3JhcnkgcmVzdWx0KHRoaXMpOwogICAgICAgICAgICAgICAgIG1faml0LmxvYWQzMihKSVRDb21w aWxlcjo6cGF5bG9hZEZvcihub2RlLmxvY2FsKCkpLCByZXN1bHQuZ3ByKCkpOwogCg==