89871 2012-06-25 05:40:53 -0700 REGRESSION(r121135): It made qmltests::WebViewColorChooser::test_accept() fail 2012-06-27 14:19:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 70236 89653 1 ossy tmpsantos cmarcelo hausmann kenneth laszlo.gombos menard ossy tmpsantos webkit.review.bot zoltan oldest_to_newest 656505 0 ossy 2012-06-25 05:40:53 -0700 It made a Qt-WK2 API test fail: FAIL! : qmltests::WebViewColorChooser::test_accept() Compared values are not the same Actual (): 1 Expected (): 2 Loc: [/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml(68)] Could you check it, please? 656619 1 ossy 2012-06-25 09:21:23 -0700 You can easily reproduce this fail with and without xvfb: - WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView - ./Tools/Scripts/run-qtwebkit-tests --output-file=qt-unit-tests.html --do-not-open-results --timeout=120 WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/ - xvfb-run -a --server-args="-screen 0 1024x768x24" $@ ... This test always fail for me, execution mode doesn't matter at all. 656820 2 149343 tmpsantos 2012-06-25 13:46:54 -0700 Created attachment 149343 Patch 656829 3 tmpsantos 2012-06-25 13:53:20 -0700 Ossy, I could not reproduce the error on my desktop, but anyway, some assumptions made by the test case about the arrival of titleChanged events are wrong. Also, the SignalSpy counter was potentially leaking to the next test case. This would all depends on how fast the machine delivery these asynchronous signals. I do believe now that the test case is fixed (added signal synchronization and test cleanup). I tried here both with --input-type-color and without and it works. Would be really nice if you could try the patch at your computer. Thanks a lot! 657401 4 ossy 2012-06-26 01:33:50 -0700 The test passes with your patch. (But unfortunately I can't review it, because I don't know anything about this stuff.) 658774 5 149781 tmpsantos 2012-06-27 12:20:29 -0700 Created attachment 149781 Patch 658776 6 tmpsantos 2012-06-27 12:26:29 -0700 (In reply to comment #5) > Created an attachment (id=149781) [details] > Patch Addressed comments by Simon on the #irc. Basically got rid of the magic numbers at "function init()" from the previous patch. 658870 7 149781 webkit.review.bot 2012-06-27 14:19:09 -0700 Comment on attachment 149781 Patch Clearing flags on attachment: 149781 Committed r121370: <http://trac.webkit.org/changeset/121370> 658871 8 webkit.review.bot 2012-06-27 14:19:14 -0700 All reviewed patches have been landed. Closing bug. 149343 2012-06-25 13:46:54 -0700 2012-06-27 12:20:19 -0700 Patch bug-89871-20120625234653.patch text/plain 2384 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDhjOTc0YmRjMTVjNDgz YTFkNjE0YmM4OGUwY2UwZGEwNjU3NjRjNC4uYzg4MWMyNTY0OTU3MzU0MDhiZjQ5MDY0YWY0Mzgy MTk0ZWYwNGRmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTI1ICBUaGlh Z28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocjEyMTEzNSk6IEl0IG1hZGUgcW1sdGVzdHM6OldlYlZpZXdDb2xvckNob29z ZXI6OnRlc3RfYWNjZXB0KCkgZmFpbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODk4NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBwcm9wZXIgZXZlbnQgc3luY2hyb25pemF0aW9uIHRvIHRoZSB0 ZXN0IGNhc2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dl YlZpZXcvdHN0X2NvbG9yQ2hvb3Nlci5xbWw6CisKIDIwMTItMDYtMjUgIFlvdW5nVGFlY2sgU29u ZyAgPHlvdW5ndGFlY2suc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbV0syXVtRdF1bRUZM XSBNb3ZlIExheWVyQmFja2luZ1N0b3JlIGludG8gY29tbW9uIGRpcmVjdG9yeQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3 L3RzdF9jb2xvckNob29zZXIucW1sIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9jb2xvckNob29zZXIucW1sCmluZGV4IDM2NmU3YzAw YzlhMWViY2M0NGExNzQ0OTViMmZiZmU4MWFmNTBiYmIuLmM4ZDYxZTZiNjFlZTU3YTgzY2M4ZmM4 MDc1ZTc4Y2I2OThjMjQ1MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfY29sb3JDaG9vc2VyLnFtbAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0 X2NvbG9yQ2hvb3Nlci5xbWwKQEAgLTQ2LDE0ICs0NiwyNiBAQCBUZXN0V2ViVmlldyB7CiAgICAg ICAgICAgICB3ZWJWaWV3LnVybCA9IFF0LnJlc29sdmVkVXJsKCIuLi9jb21tb24vY29sb3JDaG9v c2VyLmh0bWwiKQogICAgICAgICAgICAgdmVyaWZ5KHdlYlZpZXcud2FpdEZvckxvYWRTdWNjZWVk ZWQoKSkKIAorICAgICAgICAgICAgd2hpbGUgKHRpdGxlU3B5LmNvdW50IDwgMikKKyAgICAgICAg ICAgICAgICB3YWl0KDApCisKICAgICAgICAgICAgIHdlYlZpZXcuZmVhdHVyZUVuYWJsZWQgPSAo d2ViVmlldy50aXRsZSA9PSAiRmVhdHVyZSBlbmFibGVkIikKKyAgICAgICAgICAgIGlmICghd2Vi Vmlldy5mZWF0dXJlRW5hYmxlZCkKKyAgICAgICAgICAgICAgICByZXR1cm4KIAorICAgICAgICAg ICAgLy8gTWFrZSBzdXJlIHRoYXQgbm8gdGl0bGVDaGFuZ2VkIHNpZ25hbHMgYXJlCisgICAgICAg ICAgICAvLyBsZWFraW5nIHRvIHRoZSB0ZXN0IGNhc2UuCisgICAgICAgICAgICB0aXRsZVNweS53 YWl0KCkKICAgICAgICAgICAgIHRpdGxlU3B5LmNsZWFyKCkKIAogICAgICAgICAgICAgd2ViVmll dy5zaG91bGRSZWplY3QgPSBmYWxzZTsKICAgICAgICAgICAgIHdlYlZpZXcuc2hvdWxkQWNjZXB0 Q3VycmVudCA9IGZhbHNlOwogICAgICAgICB9CiAKKyAgICAgICAgZnVuY3Rpb24gY2xlYW51cCgp IHsKKyAgICAgICAgICAgIHRpdGxlU3B5LmNsZWFyKCkKKyAgICAgICAgfQorCiAgICAgICAgIGZ1 bmN0aW9uIHRlc3RfYWNjZXB0KCkgewogICAgICAgICAgICAgaWYgKCF3ZWJWaWV3LmZlYXR1cmVF bmFibGVkKQogICAgICAgICAgICAgICAgIHJldHVybgpAQCAtNjQsOCArNzYsOCBAQCBUZXN0V2Vi VmlldyB7CiAgICAgICAgICAgICAvLyBwaWNrIGEgbmV3IGNvbG9yIHdpdGggdGhlIGNob29zZXIu CiAgICAgICAgICAgICB3ZWJWaWV3LnNlbGVjdGVkQ29sb3IgPSAiIzAyMDAyMCIKICAgICAgICAg ICAgIG9wZW5Db2xvckNob29zZXIoKQotICAgICAgICAgICAgdGl0bGVTcHkud2FpdCgpCi0gICAg ICAgICAgICBjb21wYXJlKHRpdGxlU3B5LmNvdW50LCAyKQorICAgICAgICAgICAgd2hpbGUgKHRp dGxlU3B5LmNvdW50ICE9IDIpCisgICAgICAgICAgICAgICAgd2FpdCgwKQogICAgICAgICAgICAg Y29tcGFyZSh3ZWJWaWV3LnRpdGxlLCAiIzAyMDAyMCIpCiAgICAgICAgIH0KIAo= 149781 2012-06-27 12:20:29 -0700 2012-06-27 14:19:08 -0700 Patch bug-89871-20120627222028.patch text/plain 3182 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQxYjQxZDAzYWJkY2Iy NTdjYjJmNTE5MmUxZDA2MTJkYTJlODQ5OS4uMDEwYTM2ZjAxODY3YjA2MDA3N2IwNzc1YzU2ZTA2 YjcyNWEwOGZmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTI1ICBUaGlh Z28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocjEyMTEzNSk6IEl0IG1hZGUgcW1sdGVzdHM6OldlYlZpZXdDb2xvckNob29z ZXI6OnRlc3RfYWNjZXB0KCkgZmFpbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODk4NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBwcm9wZXIgZXZlbnQgc3luY2hyb25pemF0aW9uIHRvIHRoZSB0 ZXN0IGNhc2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dl YlZpZXcvdHN0X2NvbG9yQ2hvb3Nlci5xbWw6CisKIDIwMTItMDYtMjcgIFphbiBEb2JlcnNlayAg PHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBbR3RrXSBBZGQgc3VwcG9ydCBmb3Ig dGhlIEdhbWVwYWQgQVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2NvbG9yQ2hvb3Nlci5xbWwgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2NvbG9y Q2hvb3Nlci5xbWwKaW5kZXggMzY2ZTdjMDBjOWExZWJjYzQ0YTE3NDQ5NWIyZmJmZTgxYWY1MGJi Yi4uYjUxNTJjMmJiZmUxYmM0ZWE2MzhjMjk4NTJiY2U1ZTUyMTkxMWYwMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3Rz dF9jb2xvckNob29zZXIucW1sCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv dGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfY29sb3JDaG9vc2VyLnFtbApAQCAtNDYsMTIgKzQ2 LDIxIEBAIFRlc3RXZWJWaWV3IHsKICAgICAgICAgICAgIHdlYlZpZXcudXJsID0gUXQucmVzb2x2 ZWRVcmwoIi4uL2NvbW1vbi9jb2xvckNob29zZXIuaHRtbCIpCiAgICAgICAgICAgICB2ZXJpZnko d2ViVmlldy53YWl0Rm9yTG9hZFN1Y2NlZWRlZCgpKQogCisgICAgICAgICAgICB3aGlsZSAod2Vi Vmlldy50aXRsZSAhPSAiRmVhdHVyZSBlbmFibGVkIiAmJiB3ZWJWaWV3LnRpdGxlICE9ICJGZWF0 dXJlIGRpc2FibGVkIikKKyAgICAgICAgICAgICAgICB3YWl0KDApCisKICAgICAgICAgICAgIHdl YlZpZXcuZmVhdHVyZUVuYWJsZWQgPSAod2ViVmlldy50aXRsZSA9PSAiRmVhdHVyZSBlbmFibGVk IikKKyAgICAgICAgICAgIGlmICghd2ViVmlldy5mZWF0dXJlRW5hYmxlZCkKKyAgICAgICAgICAg ICAgICByZXR1cm4KIAogICAgICAgICAgICAgdGl0bGVTcHkuY2xlYXIoKQogCi0gICAgICAgICAg ICB3ZWJWaWV3LnNob3VsZFJlamVjdCA9IGZhbHNlOwotICAgICAgICAgICAgd2ViVmlldy5zaG91 bGRBY2NlcHRDdXJyZW50ID0gZmFsc2U7CisgICAgICAgICAgICB3ZWJWaWV3LnNob3VsZFJlamVj dCA9IGZhbHNlCisgICAgICAgICAgICB3ZWJWaWV3LnNob3VsZEFjY2VwdEN1cnJlbnQgPSBmYWxz ZQorICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gY2xlYW51cCgpIHsKKyAgICAgICAgICAg IHRpdGxlU3B5LmNsZWFyKCkKICAgICAgICAgfQogCiAgICAgICAgIGZ1bmN0aW9uIHRlc3RfYWNj ZXB0KCkgewpAQCAtNjQsOCArNzMsOCBAQCBUZXN0V2ViVmlldyB7CiAgICAgICAgICAgICAvLyBw aWNrIGEgbmV3IGNvbG9yIHdpdGggdGhlIGNob29zZXIuCiAgICAgICAgICAgICB3ZWJWaWV3LnNl bGVjdGVkQ29sb3IgPSAiIzAyMDAyMCIKICAgICAgICAgICAgIG9wZW5Db2xvckNob29zZXIoKQot ICAgICAgICAgICAgdGl0bGVTcHkud2FpdCgpCi0gICAgICAgICAgICBjb21wYXJlKHRpdGxlU3B5 LmNvdW50LCAyKQorICAgICAgICAgICAgd2hpbGUgKHRpdGxlU3B5LmNvdW50ICE9IDIpCisgICAg ICAgICAgICAgICAgd2FpdCgwKQogICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3LnRpdGxlLCAi IzAyMDAyMCIpCiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9jb21tb24vY29sb3JDaG9vc2VyLmh0bWwgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL2NvbW1vbi9jb2xvckNo b29zZXIuaHRtbAppbmRleCBiMDQ3MTBhYjljYTFkNzIwYjM0MjY0ZGQ5Nzk3MWViYzYxNzZlNmE4 Li5iMzI1NGMzYjhlNDYxYTdkYWFjYTYwMWVjM2UwODhhNWE0YWY1NTlkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL2NvbW1vbi9jb2xv ckNob29zZXIuaHRtbAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3Rz L3FtbHRlc3RzL2NvbW1vbi9jb2xvckNob29zZXIuaHRtbApAQCAtMSwxMyArMSwxNSBAQAogPCFE T0NUWVBFIGh0bWw+CiA8aHRtbD4KIDxoZWFkPgotPHRpdGxlPkZlYXR1cmUgZGlzYWJsZWQ8L3Rp dGxlPgorPHRpdGxlPlRpdGxlPC90aXRsZT4KIDxzY3JpcHQ+CiBmdW5jdGlvbiBkZXRlY3RJbnB1 dFR5cGVDb2xvckVuYWJsZWQoKSB7CiAgICAgdmFyIGVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgndGVzdCcpCiAgICAgZWxlbWVudC52YWx1ZSA9ICdzaG91bGQgc2FuaXRpemUnOwog ICAgIGlmIChlbGVtZW50LnZhbHVlICE9ICdzaG91bGQgc2FuaXRpemUnKQogICAgICAgICBkb2N1 bWVudC50aXRsZSA9ICdGZWF0dXJlIGVuYWJsZWQnOworICAgIGVsc2UKKyAgICAgICAgZG9jdW1l bnQudGl0bGUgPSAnRmVhdHVyZSBkaXNhYmxlZCc7CiB9CiBmdW5jdGlvbiB1cGRhdGVUaXRsZShl bGVtZW50KSB7CiAgICAgZG9jdW1lbnQudGl0bGUgPSBlbGVtZW50LnZhbHVlOwo=