89458 2012-06-19 04:23:58 -0700 [EFL] Enable SUBPIXEL_LAYOUT feature flag for EFL 2013-01-22 10:05:42 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 89572 90169 102374 103121 103129 106774 107548 85532 1 d-r d-r eae gyuyoung.kim laszlo.gombos leviw lucas.de.marchi ostap73 s.choi sw0524.lee tmpsantos oldest_to_newest 652319 0 d-r 2012-06-19 04:23:58 -0700 We'd like to follow suit with bug 85532, enabling sub-pixel layout for the EFL port. 653382 1 d-r 2012-06-20 06:10:40 -0700 First obstacle, in a number of cases setLogicalTop(roundToInt(top + maxAscent - fontMetrics.ascent(baselineType))); inside InlineFlowBox::placeBoxesInBlockDirection actually results in -1. maxAscent is 840/60 = 14, while fontMetrics.ascent (and fontMetrics.floatAscent fwiw) return 15. Will investigate - but if you have any ideas, Levi, Emil - let me know. 653391 2 d-r 2012-06-20 06:20:27 -0700 (In reply to comment #1) > First obstacle, in a number of cases > setLogicalTop(roundToInt(top + maxAscent - fontMetrics.ascent(baselineType))); > inside > InlineFlowBox::placeBoxesInBlockDirection > actually results in -1. To clarify: ...leading to hundreds of test cases failing to show expected results just by this -1 offset - they previously had the logialTop just at 0. 811446 3 d-r 2013-01-19 12:45:26 -0800 Freetype updated and feature enabled in bug 106774, new baselines completely uploaded and the bots are returning back to normal. Closing bug. 811486 4 d-r 2013-01-19 15:43:43 -0800 Big thanks, Thiago, for helping with the rebaselines! 813121 5 eae 2013-01-22 10:05:42 -0800 Awesome, thanks for making this happen Dominik!