89447 2012-06-19 01:26:15 -0700 [JSC] Implement support for JSDictionary::convertValue(Vector<String>& result) 2012-06-19 08:47:52 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 45110 1 cdumez cdumez abarth donggwan.kim gyuyoung.kim rakuco ryuan.choi s.choi webkit.review.bot oldest_to_newest 652203 0 cdumez 2012-06-19 01:26:15 -0700 Without JSDictionary::convertValue(Vector<String>& result), the IndexedDB code is not compiling for JSC. This is needed for these line to compile: Vector<String> keyPathArray; if (options.get("keyPath", keyPathArray)) in IDBDatabase::createObjectStore(). 652208 1 148284 cdumez 2012-06-19 01:29:44 -0700 Created attachment 148284 Patch 652216 2 148284 abarth 2012-06-19 01:37:55 -0700 Comment on attachment 148284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148284&action=review > Source/WebCore/bindings/js/JSDictionary.cpp:110 > + unsigned length; unsigned -> size_t, right? 652258 3 cdumez 2012-06-19 02:28:17 -0700 (In reply to comment #2) > (From update of attachment 148284 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148284&action=review > > > Source/WebCore/bindings/js/JSDictionary.cpp:110 > > + unsigned length; > > unsigned -> size_t, right? No, the method I'm calling is defined as: Source/WebCore/bindings/js/JSDOMBinding.h: JSC::JSObject* toJSSequence(JSC::ExecState*, JSC::JSValue, unsigned&); 652259 4 148284 cdumez 2012-06-19 02:29:28 -0700 Comment on attachment 148284 Patch Setting back cq? flag after double checking. 652326 5 cdumez 2012-06-19 04:41:27 -0700 Could someone please cq+? 652496 6 148284 webkit.review.bot 2012-06-19 08:47:45 -0700 Comment on attachment 148284 Patch Clearing flags on attachment: 148284 Committed r120719: <http://trac.webkit.org/changeset/120719> 652497 7 webkit.review.bot 2012-06-19 08:47:52 -0700 All reviewed patches have been landed. Closing bug. 148284 2012-06-19 01:29:44 -0700 2012-06-19 08:47:45 -0700 Patch 89447_jsc_indexeddb.patch text/plain 2810 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMzVhYmRkLi45YTU3NDNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDYtMTkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbSlNDXSBJbXBsZW1lbnQgc3VwcG9ydCBmb3IgSlNEaWN0aW9uYXJ5 Ojpjb252ZXJ0VmFsdWUoVmVjdG9yPFN0cmluZz4mIHJlc3VsdCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NDQ3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGltcGxlbWVudGF0aW9uIGZvciBKU0Rp Y3Rpb25hcnk6OmNvbnZlcnRWYWx1ZShWZWN0b3I8U3RyaW5nPiYgcmVzdWx0KQorICAgICAgICBz byB0aGF0IElEQkRhdGFiYXNlOjpjcmVhdGVPYmplY3RTdG9yZSgpIGNvbXBpbGVzIHdpdGggSlND LgorCisgICAgICAgIFRlc3RzOiBzdG9yYWdlL2luZGV4ZWRkYgorCisgICAgICAgICogYmluZGlu Z3MvanMvSlNEaWN0aW9uYXJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRGljdGlvbmFyeTo6 Y29udmVydFZhbHVlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGJpbmRpbmdzL2pz L0pTRGljdGlvbmFyeS5oOgorCiAyMDEyLTA2LTE5ICBNaWtlIFdlc3QgIDxta3dzdEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgQWRkIGEgc2NoZW1lIHJlZ2lzdHJ5IGZvciBieXBhc3NpbmcgQ29u dGVudCBTZWN1cml0eSBQb2xpY3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0RpY3Rpb25hcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNEaWN0 aW9uYXJ5LmNwcAppbmRleCAwMTllZjQzLi40OTY3MTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRGljdGlvbmFyeS5jcHAKQEAgLTEwMiw2ICsxMDIsMjQgQEAgdm9pZCBKU0Rp Y3Rpb25hcnk6OmNvbnZlcnRWYWx1ZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUsIFN0 cmluZyYgcmVzdWx0KQogICAgIHJlc3VsdCA9IHVzdHJpbmdUb1N0cmluZyh2YWx1ZS50b1N0cmlu ZyhleGVjKS0+dmFsdWUoZXhlYykpOwogfQogCit2b2lkIEpTRGljdGlvbmFyeTo6Y29udmVydFZh bHVlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgVmVjdG9yPFN0cmluZz4mIHJlc3Vs dCkKK3sKKyAgICBpZiAodmFsdWUuaXNVbmRlZmluZWRPck51bGwoKSkKKyAgICAgICAgcmV0dXJu OworCisgICAgdW5zaWduZWQgbGVuZ3RoOworICAgIEpTT2JqZWN0KiBvYmplY3QgPSB0b0pTU2Vx dWVuY2UoZXhlYywgdmFsdWUsIGxlbmd0aCk7CisgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigp KQorICAgICAgICByZXR1cm47CisKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwIDsgaSA8IGxlbmd0 aDsgKytpKSB7CisgICAgICAgIEpTVmFsdWUgaXRlbVZhbHVlID0gb2JqZWN0LT5nZXQoZXhlYywg aSk7CisgICAgICAgIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKKyAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgcmVzdWx0LmFwcGVuZCh1c3RyaW5nVG9TdHJpbmcoaXRlbVZhbHVlLnRvU3Ry aW5nKGV4ZWMpLT52YWx1ZShleGVjKSkpOworICAgIH0KK30KKwogdm9pZCBKU0RpY3Rpb25hcnk6 OmNvbnZlcnRWYWx1ZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUsIFNjcmlwdFZhbHVl JiByZXN1bHQpCiB7CiAgICAgcmVzdWx0ID0gU2NyaXB0VmFsdWUoZXhlYy0+Z2xvYmFsRGF0YSgp LCB2YWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rp b25hcnkuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGljdGlvbmFyeS5oCmluZGV4 IDE5MGY2NjQuLmJkMTc1NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTRGljdGlvbmFyeS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGljdGlv bmFyeS5oCkBAIC05Miw2ICs5Miw3IEBAIHByaXZhdGU6CiAgICAgc3RhdGljIHZvaWQgY29udmVy dFZhbHVlKEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1ZhbHVlLCBEaWN0aW9uYXJ5JiByZXN1bHQp OwogICAgIHN0YXRpYyB2b2lkIGNvbnZlcnRWYWx1ZShKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6SlNW YWx1ZSwgU3RyaW5nJiByZXN1bHQpOwogICAgIHN0YXRpYyB2b2lkIGNvbnZlcnRWYWx1ZShKU0M6 OkV4ZWNTdGF0ZSosIEpTQzo6SlNWYWx1ZSwgU2NyaXB0VmFsdWUmIHJlc3VsdCk7CisgICAgc3Rh dGljIHZvaWQgY29udmVydFZhbHVlKEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1ZhbHVlLCBWZWN0 b3I8U3RyaW5nPiYgcmVzdWx0KTsKICAgICBzdGF0aWMgdm9pZCBjb252ZXJ0VmFsdWUoSlNDOjpF eGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUsIFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+JiBy ZXN1bHQpOwogICAgIHN0YXRpYyB2b2lkIGNvbnZlcnRWYWx1ZShKU0M6OkV4ZWNTdGF0ZSosIEpT Qzo6SlNWYWx1ZSwgUmVmUHRyPERPTVdpbmRvdz4mIHJlc3VsdCk7CiAgICAgc3RhdGljIHZvaWQg Y29udmVydFZhbHVlKEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1ZhbHVlLCBSZWZQdHI8RXZlbnRU YXJnZXQ+JiByZXN1bHQpOwo=