89393 2012-06-18 15:30:38 -0700 RenderLayer subtrees without any self-painting layer shouldn't be walked during hit testing 2012-10-17 16:33:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 89389 1 jchaffraix jchaffraix allan.jensen eric esprehn jamesr ojan simon.fraser webkit.review.bot oldest_to_newest 651807 0 jchaffraix 2012-06-18 15:30:38 -0700 Bug 88888 added an optimization to avoid walking such subtrees during painting but it didn't patch the hit testing path. On http://dglazkov.github.com/performance-tests/biggrid.html, hit testing is suffering from the same over-head as painting: merely traversing a lot of non-self-painting-layers is proving costly. This means hit testing would benefit from the same optimization. 651824 1 148191 jchaffraix 2012-06-18 15:51:02 -0700 Created attachment 148191 Proposed performance change 1. 744560 2 148191 eric 2012-10-17 13:24:53 -0700 Comment on attachment 148191 Proposed performance change 1. Looks reasonable. 744703 3 jchaffraix 2012-10-17 15:30:01 -0700 Thanks Eric, this optimization is still valid and would be superseded by bug 89899. I don't have much time to investigate the other bug so let's just land this in the meantime. 744717 4 169280 jchaffraix 2012-10-17 15:43:48 -0700 Created attachment 169280 Patch for landing 744769 5 169280 webkit.review.bot 2012-10-17 16:33:55 -0700 Comment on attachment 169280 Patch for landing Clearing flags on attachment: 169280 Committed r131665: <http://trac.webkit.org/changeset/131665> 744770 6 webkit.review.bot 2012-10-17 16:33:59 -0700 All reviewed patches have been landed. Closing bug. 148191 2012-06-18 15:51:02 -0700 2012-10-17 15:43:45 -0700 Proposed performance change 1. bug-89393-20120618155056.patch text/plain 4119 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRiYzUxNzBlMGJmMGUy NjE4NGM1MjAwYjgzNDViYzlmZDNhNTQzYy4uMGY4MjdmMzhjNGE1ZmQzNWIzODkyMzk2Yjg0OTFl ZDIyMzgzMGJlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTA2LTE4ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbmRlckxh eWVyIHN1YnRyZWVzIHdpdGhvdXQgYW55IHNlbGYtcGFpbnRpbmcgbGF5ZXIgc2hvdWxkbid0IGJl IHdhbGtlZCBkdXJpbmcgaGl0IHRlc3RpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg5MzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUGVyZm9ybWFuY2Ugb3B0aW1pemF0aW9uLCBjb3ZlcmVkIGJ5IGV4 aXN0aW5nIHRlc3RzLgorCisgICAgICAgIEJ1ZyA4ODg4OCBhZGRlZCBhbiBwZWZvcm1hbmNlIG9w dGltaXphdGlvbiBmb3IgcGFpbnRpbmcuIEFzIGhpdCB0ZXN0aW5nIGlzIHZlcnkgc2ltaWxhciB0 bworICAgICAgICBwYWludGluZywgaXQgd291bGQgYmVuZWZpdCBmcm9tIHRoZSBzYW1lIG9wdGlt aXphdGlvbi4KKworICAgICAgICBPbiBodHRwOi8vZGdsYXprb3YuZ2l0aHViLmNvbS9wZXJmb3Jt YW5jZS10ZXN0cy9iaWdncmlkLmh0bWwsIHdpdGggYSAxMCwwMDAgKiAxMDAgdGFibGVzLAorICAg ICAgICBpdCByZWR1Y2VzIHRoZSB0aW1lIHRvIHNlbGVjdCBzb21lIHRleHQgaW5zaWRlIGEgY2Vs bCBmcm9tIDEtMiBzZWNvbmRzIHRvIGEgdXNhYmxlIHRpbWUKKyAgICAgICAgKEkgZGlkbid0IG1l YXN1cmUgdGhlIGV4YWN0IHRpbWluZykuCisKKyAgICAgICAgTm90ZSB0aGF0IGFzIGluIGJ1ZyA4 ODg4OCwgdGhlIG11bHRpLWNvbHVtbiBjb2RlIGlzIG5vdCBjb3ZlcmVkIGJ5IHRoaXMgb3B0aW1p emF0aW9uLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckxheWVyOjpoaXRUZXN0KToKKyAgICAgICAgVGhpcyBpcyB0aGUgZW50 cmFuY2UgdG8gdGhlIGhpdCB0ZXN0aW5nIGNvZGUgc28gd2UgY2hlY2sgaWYgd2UgY2FuIGJhaWwg b3V0IGVhcmx5LgorCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6aGl0VGVzdExpc3Qp OgorICAgICAgICBJZiB3ZSBoYXZlIG5vIHNlbGYtcGFpbnRpbmcgZGVzY2VuZGFudCBsYXllcnMs IHdlIGNhbiBiYWlsIG91dC4KKworICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmhpdFRl c3RDb250ZW50cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6aGl0VGVzdExheWVy KToKKyAgICAgICAgaGl0VGVzdCBzaG91bGQgZmlsdGVyIHRoZSBsYXllcnMgdGhhdCBjYWxsIHRo ZXNlIGZ1bmN0aW9ucy4gQWRkZWQgc29tZSBBU1NFUlQgdG8KKyAgICAgICAgbWFrZSBzdXJlIHdl IGRvbid0IG1pc3Rha2VubHkgY2FsbCB0aGVtIHdoZW4gY291bGQgYXZvaWQgaXQuCisKIDIwMTIt MDYtMTggIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBDU1NPTSB3cmFwcGVycyBhcmUgbm90IGJ1aWx0IGZvciBydWxlcyBpbiB0aGUgcGVyLWRvY3Vt ZW50IGFuZCBwYWdlIGdyb3VwIHVzZXIgc3R5bGVzaGVldHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGVjMzYzMmNiMjMzNjMxNTkwYzA1OWEyOTA5NzE5NGYz OGEwNDkxYTEuLjE4Y2JiY2FkZDdjYTk5MzczMjc0MDZkMTQ4ZGI3MDc3Y2UyOTA2ZjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMzM1Miw2ICszMzUyLDgg QEAgc3RhdGljIGlubGluZSBMYXlvdXRSZWN0IGZyYW1lVmlzaWJsZVJlY3QoUmVuZGVyT2JqZWN0 KiByZW5kZXJlcikKIAogYm9vbCBSZW5kZXJMYXllcjo6aGl0VGVzdChjb25zdCBIaXRUZXN0UmVx dWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYgcmVzdWx0KQogeworICAgIEFTU0VSVChpc1Nl bGZQYWludGluZ0xheWVyKCkgfHwgaGFzU2VsZlBhaW50aW5nTGF5ZXJEZXNjZW5kYW50KCkpOwor CiAgICAgcmVuZGVyZXIoKS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0KCk7CiAgICAgCiAgICAg TGF5b3V0UmVjdCBoaXRUZXN0QXJlYSA9IHJlbmRlcmVyKCktPmlzUmVuZGVyRmxvd1RocmVhZCgp ID8gdG9SZW5kZXJGbG93VGhyZWFkKHJlbmRlcmVyKCkpLT5ib3JkZXJCb3hSZWN0KCkgOiByZW5k ZXJlcigpLT52aWV3KCktPmRvY3VtZW50UmVjdCgpOwpAQCAtMzQ3NSw2ICszNDc3LDkgQEAgUmVu ZGVyTGF5ZXIqIFJlbmRlckxheWVyOjpoaXRUZXN0TGF5ZXIoUmVuZGVyTGF5ZXIqIHJvb3RMYXll ciwgUmVuZGVyTGF5ZXIqIGNvbnQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnN0IExheW91dFJlY3QmIGhpdFRlc3RSZWN0LCBjb25zdCBMYXlvdXRQb2ludCYgaGl0 VGVzdFBvaW50LCBib29sIGFwcGxpZWRUcmFuc2Zvcm0sCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBIaXRUZXN0aW5nVHJhbnNmb3JtU3RhdGUqIHRyYW5zZm9y bVN0YXRlLCBkb3VibGUqIHpPZmZzZXQpCiB7CisgICAgaWYgKCFpc1NlbGZQYWludGluZ0xheWVy KCkgJiYgIWhhc1NlbGZQYWludGluZ0xheWVyRGVzY2VuZGFudCgpKQorICAgICAgICByZXR1cm4g MDsKKwogICAgIC8vIFRoZSBuYXR1cmFsIHRoaW5nIHdvdWxkIGJlIHRvIGtlZXAgSGl0VGVzdGlu Z1RyYW5zZm9ybVN0YXRlIG9uIHRoZSBzdGFjaywgYnV0IGl0J3MgYmlnLCBzbyB3ZSBoZWFwLWFs bG9jYXRlLgogCiAgICAgYm9vbCB1c2VUZW1wb3JhcnlDbGlwUmVjdHMgPSByZW5kZXJlcigpLT52 aWV3KCktPmZyYW1lVmlldygpLT5jb250YWluc1Njcm9sbGFibGVBcmVhV2l0aE92ZXJsYXlTY3Jv bGxiYXJzKCk7CkBAIC0zNjQxLDYgKzM2NDYsOCBAQCBSZW5kZXJMYXllciogUmVuZGVyTGF5ZXI6 OmhpdFRlc3RMYXllcihSZW5kZXJMYXllciogcm9vdExheWVyLCBSZW5kZXJMYXllciogY29udAog CiBib29sIFJlbmRlckxheWVyOjpoaXRUZXN0Q29udGVudHMoY29uc3QgSGl0VGVzdFJlcXVlc3Qm IHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgTGF5b3V0UmVjdCYgbGF5ZXJC b3VuZHMsIGNvbnN0IExheW91dFBvaW50JiBoaXRUZXN0UG9pbnQsIEhpdFRlc3RGaWx0ZXIgaGl0 VGVzdEZpbHRlcikgY29uc3QKIHsKKyAgICBBU1NFUlQoaXNTZWxmUGFpbnRpbmdMYXllcigpIHx8 IGhhc1NlbGZQYWludGluZ0xheWVyRGVzY2VuZGFudCgpKTsKKwogICAgIGlmICghcmVuZGVyZXIo KS0+aGl0VGVzdChyZXF1ZXN0LCByZXN1bHQsIGhpdFRlc3RQb2ludCwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB0b0xheW91dFBvaW50KGxheWVyQm91bmRzLmxvY2F0aW9uKCkgLSByZW5k ZXJCb3hMb2NhdGlvbigpKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoaXRUZXN0Rmls dGVyKSkgewpAQCAtMzY3NSw3ICszNjgyLDEwIEBAIFJlbmRlckxheWVyKiBSZW5kZXJMYXllcjo6 aGl0VGVzdExpc3QoVmVjdG9yPFJlbmRlckxheWVyKj4qIGxpc3QsIFJlbmRlckxheWVyKiByCiB7 CiAgICAgaWYgKCFsaXN0KQogICAgICAgICByZXR1cm4gMDsKLSAgICAKKworICAgIGlmICghaGFz U2VsZlBhaW50aW5nTGF5ZXJEZXNjZW5kYW50KCkpCisgICAgICAgIHJldHVybiAwOworCiAgICAg UmVuZGVyTGF5ZXIqIHJlc3VsdExheWVyID0gMDsKICAgICBmb3IgKGludCBpID0gbGlzdC0+c2l6 ZSgpIC0gMTsgaSA+PSAwOyAtLWkpIHsKICAgICAgICAgUmVuZGVyTGF5ZXIqIGNoaWxkTGF5ZXIg PSBsaXN0LT5hdChpKTsK 169280 2012-10-17 15:43:48 -0700 2012-10-17 16:33:55 -0700 Patch for landing bug-89393-20121017154235.patch text/plain 4161 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjc2OGVkNmIyMjFhNjAz M2EwZDIzYzBhZWIyMDZhOTNkYThkNzM3NS4uYzBkNWMxNmVlMmRlYjZhMjQ0M2IwMDE2ZjFkY2Mz ODBlNTUzMjIyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTEwLTE3ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbmRlckxh eWVyIHN1YnRyZWVzIHdpdGhvdXQgYW55IHNlbGYtcGFpbnRpbmcgbGF5ZXIgc2hvdWxkbid0IGJl IHdhbGtlZCBkdXJpbmcgaGl0IHRlc3RpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg5MzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCisKKyAgICAgICAgUGVyZm9ybWFuY2Ugb3B0aW1pemF0aW9uLCBjb3ZlcmVkIGJ5IGV4aXN0 aW5nIHRlc3RzLgorCisgICAgICAgIEJ1ZyA4ODg4OCBhZGRlZCBhbiBwZWZvcm1hbmNlIG9wdGlt aXphdGlvbiBmb3IgcGFpbnRpbmcuIEFzIGhpdCB0ZXN0aW5nIGlzIHZlcnkgc2ltaWxhciB0bwor ICAgICAgICBwYWludGluZywgaXQgd291bGQgYmVuZWZpdCBmcm9tIHRoZSBzYW1lIG9wdGltaXph dGlvbi4KKworICAgICAgICBPbiBodHRwOi8vZGdsYXprb3YuZ2l0aHViLmNvbS9wZXJmb3JtYW5j ZS10ZXN0cy9iaWdncmlkLmh0bWwsIHdpdGggYSAxMCwwMDAgKiAxMDAgdGFibGVzLAorICAgICAg ICBpdCByZWR1Y2VzIHRoZSB0aW1lIHRvIHNlbGVjdCBzb21lIHRleHQgaW5zaWRlIGEgY2VsbCBm cm9tIDEtMiBzZWNvbmRzIHRvIGEgdXNhYmxlIHRpbWUKKyAgICAgICAgKEkgZGlkbid0IG1lYXN1 cmUgdGhlIGV4YWN0IHRpbWluZykuCisKKyAgICAgICAgTm90ZSB0aGF0IGFzIGluIGJ1ZyA4ODg4 OCwgdGhlIG11bHRpLWNvbHVtbiBjb2RlIGlzIG5vdCBjb3ZlcmVkIGJ5IHRoaXMgb3B0aW1pemF0 aW9uLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckxheWVyOjpoaXRUZXN0KToKKyAgICAgICAgVGhpcyBpcyB0aGUgZW50cmFu Y2UgdG8gdGhlIGhpdCB0ZXN0aW5nIGNvZGUgc28gd2UgY2hlY2sgaWYgd2UgY2FuIGJhaWwgb3V0 IGVhcmx5LgorCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6aGl0VGVzdExpc3QpOgor ICAgICAgICBJZiB3ZSBoYXZlIG5vIHNlbGYtcGFpbnRpbmcgZGVzY2VuZGFudCBsYXllcnMsIHdl IGNhbiBiYWlsIG91dC4KKworICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmhpdFRlc3RD b250ZW50cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6aGl0VGVzdExheWVyKToK KyAgICAgICAgaGl0VGVzdCBzaG91bGQgZmlsdGVyIHRoZSBsYXllcnMgdGhhdCBjYWxsIHRoZXNl IGZ1bmN0aW9ucy4gQWRkZWQgc29tZSBBU1NFUlQgdG8KKyAgICAgICAgbWFrZSBzdXJlIHdlIGRv bid0IG1pc3Rha2VubHkgY2FsbCB0aGVtIHdoZW4gY291bGQgYXZvaWQgaXQuCisKIDIwMTItMTAt MTcgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQ3JlYXRp bmcgYSBTdHJpbmcgZnJvbSBhbiBOU1N0cmluZyBzaG91bGQgY2hlY2sgZm9yIGFsbCA4IGJpdCBz dHJpbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAwYTlj ZjkxOTYxOWJiYWMyNTkxMjcxNDk0MjhhYWRhZjc0ZTU2NWE5Li42MjYwNmYxOTZjMWE4ZGU5MWVh OWVjMmM0NGNkMzZlZjQ1MDZiMzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAKQEAgLTM1MDQsNiArMzUwNCw4IEBAIGJvb2wgUmVuZGVyTGF5ZXI6OmhpdFRlc3Qo Y29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsdCkKIAog Ym9vbCBSZW5kZXJMYXllcjo6aGl0VGVzdChjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwg Y29uc3QgSGl0VGVzdExvY2F0aW9uJiBoaXRUZXN0TG9jYXRpb24sIEhpdFRlc3RSZXN1bHQmIHJl c3VsdCkKIHsKKyAgICBBU1NFUlQoaXNTZWxmUGFpbnRpbmdMYXllcigpIHx8IGhhc1NlbGZQYWlu dGluZ0xheWVyRGVzY2VuZGFudCgpKTsKKwogICAgIHJlbmRlcmVyKCktPmRvY3VtZW50KCktPnVw ZGF0ZUxheW91dCgpOwogICAgIAogICAgIExheW91dFJlY3QgaGl0VGVzdEFyZWEgPSByZW5kZXJl cigpLT5pc1JlbmRlckZsb3dUaHJlYWQoKSA/IHRvUmVuZGVyRmxvd1RocmVhZChyZW5kZXJlcigp KS0+Ym9yZGVyQm94UmVjdCgpIDogcmVuZGVyZXIoKS0+dmlldygpLT5kb2N1bWVudFJlY3QoKTsK QEAgLTM2MjQsNiArMzYyNiw5IEBAIFJlbmRlckxheWVyKiBSZW5kZXJMYXllcjo6aGl0VGVzdExh eWVyKFJlbmRlckxheWVyKiByb290TGF5ZXIsIFJlbmRlckxheWVyKiBjb250CiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBMYXlvdXRSZWN0JiBoaXRUZXN0UmVj dCwgY29uc3QgSGl0VGVzdExvY2F0aW9uJiBoaXRUZXN0TG9jYXRpb24sIGJvb2wgYXBwbGllZFRy YW5zZm9ybSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IEhp dFRlc3RpbmdUcmFuc2Zvcm1TdGF0ZSogdHJhbnNmb3JtU3RhdGUsIGRvdWJsZSogek9mZnNldCkK IHsKKyAgICBpZiAoIWlzU2VsZlBhaW50aW5nTGF5ZXIoKSAmJiAhaGFzU2VsZlBhaW50aW5nTGF5 ZXJEZXNjZW5kYW50KCkpCisgICAgICAgIHJldHVybiAwOworCiAgICAgLy8gVGhlIG5hdHVyYWwg dGhpbmcgd291bGQgYmUgdG8ga2VlcCBIaXRUZXN0aW5nVHJhbnNmb3JtU3RhdGUgb24gdGhlIHN0 YWNrLCBidXQgaXQncyBiaWcsIHNvIHdlIGhlYXAtYWxsb2NhdGUuCiAKICAgICBib29sIHVzZVRl bXBvcmFyeUNsaXBSZWN0cyA9IHJlbmRlcmVyKCktPnZpZXcoKS0+ZnJhbWVWaWV3KCktPmNvbnRh aW5zU2Nyb2xsYWJsZUFyZWFXaXRoT3ZlcmxheVNjcm9sbGJhcnMoKTsKQEAgLTM3OTUsNiArMzgw MCw4IEBAIFJlbmRlckxheWVyKiBSZW5kZXJMYXllcjo6aGl0VGVzdExheWVyKFJlbmRlckxheWVy KiByb290TGF5ZXIsIFJlbmRlckxheWVyKiBjb250CiAKIGJvb2wgUmVuZGVyTGF5ZXI6OmhpdFRl c3RDb250ZW50cyhjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYg cmVzdWx0LCBjb25zdCBMYXlvdXRSZWN0JiBsYXllckJvdW5kcywgY29uc3QgSGl0VGVzdExvY2F0 aW9uJiBoaXRUZXN0TG9jYXRpb24sIEhpdFRlc3RGaWx0ZXIgaGl0VGVzdEZpbHRlcikgY29uc3QK IHsKKyAgICBBU1NFUlQoaXNTZWxmUGFpbnRpbmdMYXllcigpIHx8IGhhc1NlbGZQYWludGluZ0xh eWVyRGVzY2VuZGFudCgpKTsKKwogICAgIGlmICghcmVuZGVyZXIoKS0+aGl0VGVzdChyZXF1ZXN0 LCByZXN1bHQsIGhpdFRlc3RMb2NhdGlvbiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0 b0xheW91dFBvaW50KGxheWVyQm91bmRzLmxvY2F0aW9uKCkgLSByZW5kZXJCb3hMb2NhdGlvbigp KSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoaXRUZXN0RmlsdGVyKSkgewpAQCAtMzgy OSw3ICszODM2LDEwIEBAIFJlbmRlckxheWVyKiBSZW5kZXJMYXllcjo6aGl0VGVzdExpc3QoVmVj dG9yPFJlbmRlckxheWVyKj4qIGxpc3QsIFJlbmRlckxheWVyKiByCiB7CiAgICAgaWYgKCFsaXN0 KQogICAgICAgICByZXR1cm4gMDsKLSAgICAKKworICAgIGlmICghaGFzU2VsZlBhaW50aW5nTGF5 ZXJEZXNjZW5kYW50KCkpCisgICAgICAgIHJldHVybiAwOworCiAgICAgUmVuZGVyTGF5ZXIqIHJl c3VsdExheWVyID0gMDsKICAgICBmb3IgKGludCBpID0gbGlzdC0+c2l6ZSgpIC0gMTsgaSA+PSAw OyAtLWkpIHsKICAgICAgICAgUmVuZGVyTGF5ZXIqIGNoaWxkTGF5ZXIgPSBsaXN0LT5hdChpKTsK