89151 2012-06-14 18:47:50 -0700 [JSC/V8] "DOMString[]" for function return values should not be null 2012-06-14 19:11:42 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89070 1 tkent tkent abarth haraken japhet jochen webkit.review.bot oldest_to_newest 649730 0 tkent 2012-06-14 18:47:50 -0700 [JSC/V8] "DOMString[]" for function return values should not be null 649748 1 147707 tkent 2012-06-14 19:01:46 -0700 Created attachment 147707 Patch 649758 2 147707 haraken 2012-06-14 19:09:44 -0700 Comment on attachment 147707 Patch Looks OK 649759 3 tkent 2012-06-14 19:11:42 -0700 Committed r120389: <http://trac.webkit.org/changeset/120389> 147707 2012-06-14 19:01:46 -0700 2012-06-14 19:09:44 -0700 Patch bug-89151-20120615110145.patch text/plain 3597 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM1YzU4YTVhNGZhOTFk Yjg5NTI2ZWU2ZjcyMDA0NTRmZjdiOTk2OS4uOTJiODZhNmNlZDVkMjc5MTBjZjdhNWNjZTcxZTAw N2QzZTA2ZmJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA2LTE0ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBbSlNDL1Y4XSAiRE9NU3Ry aW5nW10iIGZvciBmdW5jdGlvbiByZXR1cm4gdmFsdWVzIHNob3VsZCBub3QgYmUgbnVsbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkxNTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBqc0FycmF5IGFuZCB2 OEFycmF5IGFyZSB1c2VkIGZvciAiRE9NU3RyaW5nW10iLCBub3QgIkRPTVN0cmluZ1tdPyIuIFNv CisgICAgICAgIHdlIHNob3VsZCBub3QgcmV0dXJuIEphdmFTY3JpcHQgbnVsbCBvYmplY3QuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBXZSBoYXZlIG5vIHBsYW4gdG8gdXNlIHRoaXMgY29kZSBp biBwcm9kdWN0aW9uIGNvZGUgZm9yCisgICAgICAgIG5vdy4gSXQgd2lsbCBiZSB1c2VkIGZvciB3 aW5kb3cuaW50ZXJuYWxzIGZ1bmN0aW9ucy4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9N QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpqc0FycmF5KTogRm9yIG51bGwgaW5wdXQs IHJldHVybnMgYW4gZW1wdHkgYXJyYXksIG5vdCBudWxsLgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2OEFycmF5KTogSW1wbGVtZW50IERP TVN0cmluZ0xpc3QgLT4gSmF2YVNjcmlwdCBhcnJheSBjb252ZXJzaW9uLgorICAgICAgICBMaWtl IGpzQXJyYXkoKSwgd2UgZG9uJ3QgcmV0dXJuIG51bGwgb2JqZWN0LgorICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4QmluZGluZy5oOgorICAgICAgICAoV2ViQ29yZSk6IERlY2xhcmUgdjhBcnJheSgp LgorCiAyMDEyLTA2LTE0ICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBGaWxlUmVhZGVyIGlzIGR5c2Z1bmN0aW9uYWwgaW4gZG9jdW1lbnRzIHdpdGggIm51bGwiIG9y aWdpbiBzdHJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9N QmluZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuY3Bw CmluZGV4IGQwMzY1NWUyNGUzN2RlYTRhZGM0MDNmODQzNDZjNWFjMzc0ODYzMWMuLmZjMTc5OTA3 YTJiNjc0OTJmNmM2Y2VhM2IzMTk0MjJlZDI3ZjY5YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcApAQCAtMTQ5LDExICsxNDksMTEgQEAgZG91YmxlIHZh bHVlVG9EYXRlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSkKIAogSlNDOjpKU1ZhbHVl IGpzQXJyYXkoSlNDOjpFeGVjU3RhdGUqIGV4ZWMsIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxP YmplY3QsIFBhc3NSZWZQdHI8RE9NU3RyaW5nTGlzdD4gc3RyaW5nTGlzdCkKIHsKLSAgICBpZiAo IXN0cmluZ0xpc3QpCi0gICAgICAgIHJldHVybiBqc051bGwoKTsKICAgICBKU0M6Ok1hcmtlZEFy Z3VtZW50QnVmZmVyIGxpc3Q7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHN0cmluZ0xp c3QtPmxlbmd0aCgpOyArK2kpCi0gICAgICAgIGxpc3QuYXBwZW5kKGpzU3RyaW5nKGV4ZWMsIHN0 cmluZ0xpc3QtPml0ZW0oaSkpKTsKKyAgICBpZiAoc3RyaW5nTGlzdCkgeworICAgICAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgc3RyaW5nTGlzdC0+bGVuZ3RoKCk7ICsraSkKKyAgICAgICAg ICAgIGxpc3QuYXBwZW5kKGpzU3RyaW5nKGV4ZWMsIHN0cmluZ0xpc3QtPml0ZW0oaSkpKTsKKyAg ICB9CiAgICAgcmV0dXJuIEpTQzo6Y29uc3RydWN0QXJyYXkoZXhlYywgZ2xvYmFsT2JqZWN0LCBs aXN0KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k aW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKaW5kZXgg NmUwMzZhY2U3YjIzYWU2Y2Y3ZDg1ZTIyM2RiNzc5NWRlNjg2ZjM4Ni4uOTc0ZGEwNWNhOTJkYzU3 MmRlY2U0ODJiYTI4ZWRhM2VmY2FjZjdmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEJpbmRpbmcuY3BwCkBAIC0yMTIsNiArMjEyLDE2IEBAIEF0b21pY1N0cmluZyB2OFZhbHVlVG9B dG9taWNXZWJDb3JlU3RyaW5nKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSkKICAgICByZXR1 cm4gdjhOb25TdHJpbmdWYWx1ZVRvQXRvbWljV2ViQ29yZVN0cmluZyh2YWx1ZSk7CiB9CiAKK3Y4 OjpIYW5kbGU8djg6OlZhbHVlPiB2OEFycmF5KFBhc3NSZWZQdHI8RE9NU3RyaW5nTGlzdD4gc3Ry aW5nTGlzdCwgdjg6Oklzb2xhdGUqIGlzb2xhdGUpCit7CisgICAgaWYgKCFzdHJpbmdMaXN0KQor ICAgICAgICByZXR1cm4gdjg6OkFycmF5OjpOZXcoKTsKKyAgICB2ODo6TG9jYWw8djg6OkFycmF5 PiByZXN1bHQgPSB2ODo6QXJyYXk6Ok5ldyhzdHJpbmdMaXN0LT5sZW5ndGgoKSk7CisgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IHN0cmluZ0xpc3QtPmxlbmd0aCgpOyArK2kpCisgICAgICAg IHJlc3VsdC0+U2V0KHY4OjpJbnRlZ2VyOjpOZXcoaSksIHY4U3RyaW5nKHN0cmluZ0xpc3QtPml0 ZW0oaSksIGlzb2xhdGUpKTsKKyAgICByZXR1cm4gcmVzdWx0OworfQorCiBpbnQgdG9JbnQzMih2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wmIG9rKQogewogICAgIG9rID0gdHJ1ZTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKaW5kZXggM2YzNDI0OWI0ZTA2NzEx NGMxNTNiYjUyZjdmZTI4ZDRkNmY3NjJhZS4uZjg3ZTRiOTI0NGRhMzU0MjczZTRjYTlkYmQxNmFi ODA0YzNkMzE3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k aW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTMx NSw2ICszMTUsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHJldHVybiBhcnJheTsK ICAgICB9CiAKKyAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhBcnJheShQYXNzUmVmUHRyPERP TVN0cmluZ0xpc3Q+LCB2ODo6SXNvbGF0ZSopOworCiAgICAgdGVtcGxhdGUgPGNsYXNzIFQ+CiAg ICAgVmVjdG9yPFQ+IHRvTmF0aXZlQXJyYXkodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQog ICAgIHsK