88870 2012-06-12 07:18:52 -0700 [Qt]New API tests introuduced in r119723 marked as fail, but pass 2012-08-07 14:53:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 70236 88531 1 ossy ossy abecsi ahf cmarcelo hausmann kenneth menard ossy webkit.review.bot zoltan oldest_to_newest 646908 0 ossy 2012-06-12 07:18:52 -0700 See https://bugs.webkit.org/show_bug.cgi?id=88531#c4 for details. 652480 1 148342 ossy 2012-06-19 08:39:15 -0700 Created attachment 148342 Patch It is a speculative fix, because I don't know _anything_ about QML testing ... but now it passes. Am I correct? 656506 2 ossy 2012-06-25 05:41:38 -0700 ping? 656518 3 148342 abecsi 2012-06-25 06:20:02 -0700 Comment on attachment 148342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148342&action=review This is a bit confusing. Was the testcase marked as expected fail but passed already when it was checked in? Or was there a recent change which made the test work? > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml:40 > + expectFail("", "This currently fails since window.devicePixelRatio doesn't return the updated value.") If the test passes, I think we do not have to re-add this line here. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml:58 > + expectFail("", "This currently fails since the devicePixelRatio from the QML API isn't propagated correctly.") Ditto. 656559 4 ossy 2012-06-25 07:53:30 -0700 It reported two XPASS (as I mentioned in https://bugs.webkit.org/show_bug.cgi?id=88531#c4): XPASS : qmltests::DevicePixelRatio::test_devicePixelRatio() '' returned TRUE unexpectedly. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(33)] XPASS : qmltests::DevicePixelRatio::test_devicePixelRatioMediaQuery() '' returned TRUE unexpectedly. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(51)] The first check marked as expected to fail, but pass. If I removed these expected fails, there are two fails later - where I moved expected fail to. As I said, it is speculative fix, because I don't know _anything_ about QML and devicePixelRatio ... It would be great if the author of the original patch can check it. 662888 5 ossy 2012-07-04 05:32:16 -0700 Alex, Kenneth, any opinion? API tests haven't been pass 100% since a month because of this bug. Please comment this bug at least if you don't want (or don't have time) to fix the test you committed. 662987 6 abecsi 2012-07-04 08:40:49 -0700 (In reply to comment #4) > It reported two XPASS (as I mentioned in https://bugs.webkit.org/show_bug.cgi?id=88531#c4): > > XPASS : qmltests::DevicePixelRatio::test_devicePixelRatio() '' returned TRUE unexpectedly. () > Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(33)] > XPASS : qmltests::DevicePixelRatio::test_devicePixelRatioMediaQuery() '' returned TRUE unexpectedly. () > Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(51)] > > > The first check marked as expected to fail, but pass. If I removed > these expected fails, there are two fails later - where I moved > expected fail to. As I said, it is speculative fix, because I don't > know _anything_ about QML and devicePixelRatio ... It would be great > if the author of the original patch can check it. Although I'm not familiar with the QML testing infrastructure, this looks pretty much like the expectFail calls are not in the right position which makes your patch correct IMHO. If someone sheds more light on, and eventually confirms this I would suggest to rename the bug to something like "[Qt]New API tests introuduced in r119723 should correctly be marked as expected fail" 682825 7 ossy 2012-07-31 01:41:56 -0700 Alex, Kenneth, please answer and don't ignore this bug! The API tests haven't been pass because of your buggy patch for 1.5 months. Have you got any idea why they tests fail and could you fix them? (( Alexis: That's why API tests will never make bots red ... because folks don't care about API tests at all ... We don't need always red bot. )) 685667 8 148342 kenneth 2012-08-02 12:25:55 -0700 Comment on attachment 148342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148342&action=review >> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml:40 >> + expectFail("", "This currently fails since window.devicePixelRatio doesn't return the updated value.") > > If the test passes, I think we do not have to re-add this line here. Agree; do you know what patch fixed this test? 686499 9 ossy 2012-08-03 03:05:59 -0700 (In reply to comment #8) > (From update of attachment 148342 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148342&action=review > > >> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml:40 > >> + expectFail("", "This currently fails since window.devicePixelRatio doesn't return the updated value.") > > > > If the test passes, I think we do not have to re-add this line here. > > Agree; do you know what patch fixed this test? It passes from the beginning ... 689395 10 ossy 2012-08-07 14:34:11 -0700 PING again and again ... I really don't undestand why do we have unittests if someone can commit failing API tests and then ignore answering why they are failing for months ... I suggest we should simply revert the original patch if you aren't interested in fixing it and when you simply ignore this bug report ... 689413 11 157011 ossy 2012-08-07 14:43:12 -0700 Created attachment 157011 Patch revert the original patch 689421 12 157011 menard 2012-08-07 14:50:26 -0700 Comment on attachment 157011 Patch Broken tests are useless. Please re-land with the correct expectation. 689430 13 157011 ossy 2012-08-07 14:53:21 -0700 Comment on attachment 157011 Patch Clearing flags on attachment: 157011 Committed r124923: <http://trac.webkit.org/changeset/124923> 689432 14 ossy 2012-08-07 14:53:28 -0700 All reviewed patches have been landed. Closing bug. 148342 2012-06-19 08:39:15 -0700 2012-08-07 14:43:05 -0700 Patch bug-88870-20120619083914.patch text/plain 2398 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTZmMTFhNTYyNTIyYjM0 NWRmNzMxZjE1MmJmOTFkNjY0NzljMjM2NC4uYTA3MzM5NmNmYzQ5Y2M5YmI2MThiMzYxZjZhZDNl YjhjY2UyM2Y5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2LTE5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XU5ldyBBUEkg dGVzdHMgaW50cm91ZHVjZWQgaW4gcjExOTcyMyBtYXJrZWQgYXMgZmFpbCwgYnV0IHBhc3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODcwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RldmljZVBpeGVsUmF0aW8ucW1sOiBV cGRhdGVkIHRoZSB0ZXN0LgorCiAyMDEyLTA2LTE5ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1l bmFyZEBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtRdF0gQ3JlYXRlIGFuIGV4dHJhIGF0bGFz IHdoZW4gdGhlcmUgaXMgbm8gYXZhaWxhYmxlIGJ1ZmZlciBzcGFjZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3Rf ZGV2aWNlUGl4ZWxSYXRpby5xbWwgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rl c3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RldmljZVBpeGVsUmF0aW8ucW1sCmluZGV4IDY0M2M3 MjFkYWJjOTE3OTkwYjMwNTlhNjZjOWZhYzAyYjE1N2EwOTguLjU1MjI5OTFjMzZiODY2MWMwN2Zm ZDE2OGYwMzZiOTJiNTZlZWQzZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfZGV2aWNlUGl4ZWxSYXRpby5xbWwK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJW aWV3L3RzdF9kZXZpY2VQaXhlbFJhdGlvLnFtbApAQCAtMjUsOCArMjUsNiBAQCBJdGVtIHsKICAg ICAgICAgfQogCiAgICAgICAgIGZ1bmN0aW9uIHRlc3RfZGV2aWNlUGl4ZWxSYXRpbygpIHsKLSAg ICAgICAgICAgIGV4cGVjdEZhaWwoIiIsICJUaGlzIGN1cnJlbnRseSBmYWlscyBzaW5jZSB3aW5k b3cuZGV2aWNlUGl4ZWxSYXRpbyBkb2Vzbid0IHJldHVybiB0aGUgdXBkYXRlZCB2YWx1ZS4iKQot CiAgICAgICAgICAgICByZXN1bHRTcHkuY2xlYXIoKQogICAgICAgICAgICAgd2ViVmlldy51cmwg PSAiYWJvdXQ6YmxhbmsiCiAgICAgICAgICAgICB3ZWJWaWV3LmV4cGVyaW1lbnRhbC5kZXZpY2VQ aXhlbFJhdGlvID0gMi4wCkBAIC0zOSwxMiArMzcsMTIgQEAgSXRlbSB7CiAgICAgICAgICAgICAg ICAgfSkKIAogICAgICAgICAgICAgcmVzdWx0U3B5LndhaXQoKQorICAgICAgICAgICAgZXhwZWN0 RmFpbCgiIiwgIlRoaXMgY3VycmVudGx5IGZhaWxzIHNpbmNlIHdpbmRvdy5kZXZpY2VQaXhlbFJh dGlvIGRvZXNuJ3QgcmV0dXJuIHRoZSB1cGRhdGVkIHZhbHVlLiIpCiAgICAgICAgICAgICBjb21w YXJlKHdlYlZpZXcubGFzdFJlc3VsdCwgMi4wKQogICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3 Lmxhc3RSZXN1bHQsIHdlYlZpZXcuZXhwZXJpbWVudGFsLmRldmljZVBpeGVsUmF0aW8pCiAgICAg ICAgIH0KIAogICAgICAgICBmdW5jdGlvbiB0ZXN0X2RldmljZVBpeGVsUmF0aW9NZWRpYVF1ZXJ5 KCkgewotICAgICAgICAgICAgZXhwZWN0RmFpbCgiIiwgIlRoaXMgY3VycmVudGx5IGZhaWxzIHNp bmNlIHRoZSBkZXZpY2VQaXhlbFJhdGlvIGZyb20gdGhlIFFNTCBBUEkgaXNuJ3QgcHJvcGFnYXRl ZCBjb3JyZWN0bHkuIikKICAgICAgICAgICAgIHJlc3VsdFNweS5jbGVhcigpCiAgICAgICAgICAg ICB3ZWJWaWV3LnVybCA9ICJhYm91dDpibGFuayIKICAgICAgICAgICAgIHdlYlZpZXcuZXhwZXJp bWVudGFsLmRldmljZVBpeGVsUmF0aW8gPSAyLjAKQEAgLTU3LDYgKzU1LDcgQEAgSXRlbSB7CiAg ICAgICAgICAgICAgICAgfSkKIAogICAgICAgICAgICAgcmVzdWx0U3B5LndhaXQoKQorICAgICAg ICAgICAgZXhwZWN0RmFpbCgiIiwgIlRoaXMgY3VycmVudGx5IGZhaWxzIHNpbmNlIHRoZSBkZXZp Y2VQaXhlbFJhdGlvIGZyb20gdGhlIFFNTCBBUEkgaXNuJ3QgcHJvcGFnYXRlZCBjb3JyZWN0bHku IikKICAgICAgICAgICAgIHZlcmlmeSh3ZWJWaWV3Lmxhc3RSZXN1bHQpCiAgICAgICAgIH0KICAg ICB9Cg== 157011 2012-08-07 14:43:12 -0700 2012-08-07 14:53:20 -0700 Patch bug-88870-20120807234246.patch text/plain 3218 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjMwMDgzNWZhYzdmN2M1 MGVjMmI4MjE4NDMzMjE5Y2M1ZWMzMDk0Yy4uZTdlMGMxODRhNGQ1ZjA2ZmE4YTdmZTM3N2EzNWIx NjNjMGY3MTYwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTA3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICBbUXRdIE5ldyBBUEkg dGVzdHMgaW50cm91ZHVjZWQgaW4gcjExOTcyMyBtYXJrZWQgYXMgZmFpbCwgYnV0IHBhc3MKKyAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg4NzAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgcjExOTcy MywgYmVjYXVzZSB0aGVyZSBhcmUgMiBmYWlsaW5nIHRlc3RzLCBhbmQgdGhlIGF1dGhvciBhbmQK KyAgICAgICAgdGhlIHJldmlld2VyIG9mIHRoZSBvcmlnaW5hbCBwYXRjaCBpZ25vcmUgdGhlIGJ1 ZyByZXBvcnQgbG9uZyB0aW1lIGFnby4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVz dHMvcW1sdGVzdHMvV2ViVmlldy90c3RfZGV2aWNlUGl4ZWxSYXRpby5xbWw6IFJlbW92ZWQuCisK IDIwMTItMDgtMDcgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4K IAogICAgICAgICBHcmFwaGljc0xheWVyQW5pbWF0aW9uIHNob3VsZG4ndCB1c2UgSGFzaE1hcDxT dHJpbmc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3Rz L3FtbHRlc3RzL1dlYlZpZXcvdHN0X2RldmljZVBpeGVsUmF0aW8ucW1sIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9kZXZpY2VQaXhl bFJhdGlvLnFtbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggNjQzYzcyMWRhYmM5MTc5 OTBiMzA1OWE2NmM5ZmFjMDJiMTU3YTA5OC4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Ft bHRlc3RzL1dlYlZpZXcvdHN0X2RldmljZVBpeGVsUmF0aW8ucW1sCisrKyAvZGV2L251bGwKQEAg LTEsNjMgKzAsMCBAQAotaW1wb3J0IFF0UXVpY2sgMi4wCi1pbXBvcnQgUXRUZXN0IDEuMAotaW1w b3J0IFF0V2ViS2l0IDMuMAotaW1wb3J0IFF0V2ViS2l0LmV4cGVyaW1lbnRhbCAxLjAKLWltcG9y dCAiLi4vY29tbW9uIgotCi1JdGVtIHsKLSAgICBUZXN0V2ViVmlldyB7Ci0gICAgICAgIGlkOiB3 ZWJWaWV3Ci0gICAgICAgIHByb3BlcnR5IHZhcmlhbnQgbGFzdFJlc3VsdAotICAgIH0KLQotICAg IFNpZ25hbFNweSB7Ci0gICAgICAgIGlkOiByZXN1bHRTcHkKLSAgICAgICAgdGFyZ2V0OiB3ZWJW aWV3Ci0gICAgICAgIHNpZ25hbE5hbWU6ICJsYXN0UmVzdWx0Q2hhbmdlZCIKLSAgICB9Ci0KLSAg ICBUZXN0Q2FzZSB7Ci0gICAgICAgIG5hbWU6ICJEZXZpY2VQaXhlbFJhdGlvIgotCi0gICAgICAg IGZ1bmN0aW9uIGluaXQoKSB7Ci0gICAgICAgICAgICByZXN1bHRTcHkuY2xlYXIoKQotICAgICAg ICAgICAgd2ViVmlldy5sYXN0UmVzdWx0ID0gbnVsbAotICAgICAgICB9Ci0KLSAgICAgICAgZnVu Y3Rpb24gdGVzdF9kZXZpY2VQaXhlbFJhdGlvKCkgewotICAgICAgICAgICAgZXhwZWN0RmFpbCgi IiwgIlRoaXMgY3VycmVudGx5IGZhaWxzIHNpbmNlIHdpbmRvdy5kZXZpY2VQaXhlbFJhdGlvIGRv ZXNuJ3QgcmV0dXJuIHRoZSB1cGRhdGVkIHZhbHVlLiIpCi0KLSAgICAgICAgICAgIHJlc3VsdFNw eS5jbGVhcigpCi0gICAgICAgICAgICB3ZWJWaWV3LnVybCA9ICJhYm91dDpibGFuayIKLSAgICAg ICAgICAgIHdlYlZpZXcuZXhwZXJpbWVudGFsLmRldmljZVBpeGVsUmF0aW8gPSAyLjAKLSAgICAg ICAgICAgIHZlcmlmeSh3ZWJWaWV3LndhaXRGb3JMb2FkU3VjY2VlZGVkKCkpCi0KLSAgICAgICAg ICAgIHdlYlZpZXcuZXhwZXJpbWVudGFsLmV2YWx1YXRlSmF2YVNjcmlwdCgKLSAgICAgICAgICAg ICAgICAiKGZ1bmN0aW9uKCkgeyByZXR1cm4gd2luZG93LmRldmljZVBpeGVsUmF0aW8gfSkoKSIs Ci0gICAgICAgICAgICAgICAgZnVuY3Rpb24ocmVzdWx0KSB7Ci0gICAgICAgICAgICAgICAgICAg IHdlYlZpZXcubGFzdFJlc3VsdCA9IHJlc3VsdAotICAgICAgICAgICAgICAgIH0pCi0KLSAgICAg ICAgICAgIHJlc3VsdFNweS53YWl0KCkKLSAgICAgICAgICAgIGNvbXBhcmUod2ViVmlldy5sYXN0 UmVzdWx0LCAyLjApCi0gICAgICAgICAgICBjb21wYXJlKHdlYlZpZXcubGFzdFJlc3VsdCwgd2Vi Vmlldy5leHBlcmltZW50YWwuZGV2aWNlUGl4ZWxSYXRpbykKLSAgICAgICAgfQotCi0gICAgICAg IGZ1bmN0aW9uIHRlc3RfZGV2aWNlUGl4ZWxSYXRpb01lZGlhUXVlcnkoKSB7Ci0gICAgICAgICAg ICBleHBlY3RGYWlsKCIiLCAiVGhpcyBjdXJyZW50bHkgZmFpbHMgc2luY2UgdGhlIGRldmljZVBp eGVsUmF0aW8gZnJvbSB0aGUgUU1MIEFQSSBpc24ndCBwcm9wYWdhdGVkIGNvcnJlY3RseS4iKQot ICAgICAgICAgICAgcmVzdWx0U3B5LmNsZWFyKCkKLSAgICAgICAgICAgIHdlYlZpZXcudXJsID0g ImFib3V0OmJsYW5rIgotICAgICAgICAgICAgd2ViVmlldy5leHBlcmltZW50YWwuZGV2aWNlUGl4 ZWxSYXRpbyA9IDIuMAotICAgICAgICAgICAgdmVyaWZ5KHdlYlZpZXcud2FpdEZvckxvYWRTdWNj ZWVkZWQoKSkKLQotICAgICAgICAgICAgd2ViVmlldy5leHBlcmltZW50YWwuZXZhbHVhdGVKYXZh U2NyaXB0KAotICAgICAgICAgICAgICAgICIoZnVuY3Rpb24oKSB7IHJldHVybiB3aW5kb3cubWF0 Y2hNZWRpYSgnLXdlYmtpdC1kZXZpY2UtcGl4ZWwtcmF0aW86IDInKS5tYXRjaGVzIH0pKCkiLAot ICAgICAgICAgICAgICAgIGZ1bmN0aW9uKHJlc3VsdCkgewotICAgICAgICAgICAgICAgICAgICB3 ZWJWaWV3Lmxhc3RSZXN1bHQgPSByZXN1bHQKLSAgICAgICAgICAgICAgICB9KQotCi0gICAgICAg ICAgICByZXN1bHRTcHkud2FpdCgpCi0gICAgICAgICAgICB2ZXJpZnkod2ViVmlldy5sYXN0UmVz dWx0KQotICAgICAgICB9Ci0gICAgfQotfQo=