88851 2012-06-12 03:58:51 -0700 Remove support for counterValueForElementById from chromium port 2012-06-14 23:33:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84406 1 kaustubh.ra kaustubh.ra abarth dglazkov fishd jamesr kaustubh.ra morrita tkent+wkapi webkit.review.bot oldest_to_newest 646785 0 kaustubh.ra 2012-06-12 03:58:51 -0700 This API has been moved to window.Internals Remove the supported APIs from webkit's chromium port. Reference - https://bugs.webkit.org/show_bug.cgi?id=84406 649007 1 147535 kaustubh.ra 2012-06-14 02:45:58 -0700 Created attachment 147535 Patch Removed the chromium port specific code for counterValueForElementById 649011 2 webkit.review.bot 2012-06-14 02:49:48 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 649212 3 147535 webkit.review.bot 2012-06-14 09:03:18 -0700 Comment on attachment 147535 Patch Attachment 147535 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12950750 649214 4 147535 abarth 2012-06-14 09:08:24 -0700 Comment on attachment 147535 Patch The patch is fine, but it looks like you've got a compile problem to work through. 649215 5 abarth 2012-06-14 09:08:57 -0700 Looks like someone is using this feature: Source/WebKit/chromium/webkit/glue/webkit_glue.cc: In function 'bool webkit_glue::CounterValueForElementById(WebKit::WebFrame*, const std::string&, string16*)': 649258 6 jamesr 2012-06-14 09:58:08 -0700 That was removed in chromium r141631, so I suspect you just need to roll http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS forward past that revision 649774 7 kaustubh.ra 2012-06-14 19:27:54 -0700 Thanks Adam for the review. And yes, this I had logged bug with chromium and removed it from there in r141631. I saw the DEPS has been just updated yesterday past that r141631 (currently r141884) So i will just try to hit the patch again for cr-ews. and if passes will commit. 649808 8 147718 kaustubh.ra 2012-06-14 20:21:06 -0700 Created attachment 147718 Patch Another upload for patch for build check of cr-linux 649814 9 147718 abarth 2012-06-14 20:46:36 -0700 Comment on attachment 147718 Patch Let's see if it compiles! 649924 10 147718 webkit.review.bot 2012-06-14 23:33:42 -0700 Comment on attachment 147718 Patch Clearing flags on attachment: 147718 Committed r120408: <http://trac.webkit.org/changeset/120408> 649925 11 webkit.review.bot 2012-06-14 23:33:47 -0700 All reviewed patches have been landed. Closing bug. 147535 2012-06-14 02:45:58 -0700 2012-06-14 20:17:53 -0700 Patch bug-88851-20120614151451.patch text/plain 3316 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjAzMDApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA2LTE0ICBLYXVzdHViaCBBdHJhd2Fsa2FyICA8a2F1c3R1YmhAbW90b3JvbGEu Y29tPgorCisgICAgICAgIFJlbW92ZSBzdXBwb3J0IGZvciBjb3VudGVyVmFsdWVGb3JFbGVtZW50 QnlJZCBmcm9tIGNocm9taXVtIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg4ODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTW92ZWQgdGhlIGNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkIGZyb20g TGF5b3V0VGVzdENvdHJvbGxlciB0byBJbnRlcm5hbHMgc28KKyAgICAgICAgcmVtb3ZlIHRoZSBv bGQgcGxhdGZvcm0gc3BlY2lmaWMgaW1wbGVtZW50YXRpb25zIGFzIGl0IGV4Y2x1c2l2ZWx5IHRl c3RzIFdlYkNvcmUgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHB1YmxpYy9XZWJGcmFtZS5o OgorICAgICAgICAoV2ViRnJhbWUpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmg6CisgICAgICAg IChXZWJGcmFtZUltcGwpOgorCiAyMDEyLTA2LTE0ICBNaW4gUWluICA8cWlubWluQGdvb2dsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBjb25zdCBrZXl3b3JkIGZyb20gTWVkaWFQbGF5ZXJQ cml2YXRlOjplbnRlckZ1bGxzY3JlZW4oKQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJGcmFtZS5oCShyZXZpc2lvbiAxMjAyOTUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJGcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02MTgsMTAgKzYxOCw2IEBA IHB1YmxpYzoKICAgICAvLyB0byBzdXBwb3J0IGxheW91dCB0ZXN0cy4KICAgICB2aXJ0dWFsIFdl YlN0cmluZyByZW5kZXJUcmVlQXNUZXh0KFJlbmRlckFzVGV4dENvbnRyb2xzIHRvU2hvdyA9IFJl bmRlckFzVGV4dE5vcm1hbCkgY29uc3QgPSAwOwogCi0gICAgLy8gUmV0dXJucyB0aGUgY291bnRl ciB2YWx1ZSBmb3IgdGhlIHNwZWNpZmllZCBlbGVtZW50LiAgVGhpcyBtZXRob2QgaXMKLSAgICAv LyB1c2VkIHRvIHN1cHBvcnQgbGF5b3V0IHRlc3RzLgotICAgIHZpcnR1YWwgV2ViU3RyaW5nIGNv dW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkKGNvbnN0IFdlYlN0cmluZyYgaWQpIGNvbnN0ID0gMDsK LQogICAgIC8vIENhbGxzIG1hcmtlclRleHRGb3JMaXN0SXRlbSgpIGRlZmluZWQgaW4gV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5oLgogICAgIHZpcnR1YWwgV2ViU3RyaW5nIG1h cmtlclRleHRGb3JMaXN0SXRlbShjb25zdCBXZWJFbGVtZW50JikgY29uc3QgPSAwOwogCkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9u IDEyMDI5NSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE5NzcsMTggKzE5NzcsNiBAQCBXZWJTdHJpbmcgV2ViRnJhbWVJ bXBsOjpyZW5kZXJUcmVlQXNUZXh0CiAgICAgcmV0dXJuIGV4dGVybmFsUmVwcmVzZW50YXRpb24o bV9mcmFtZSwgYmVoYXZpb3IpOwogfQogCi1XZWJTdHJpbmcgV2ViRnJhbWVJbXBsOjpjb3VudGVy VmFsdWVGb3JFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlkKSBjb25zdAotewotICAgIGlm ICghbV9mcmFtZSkKLSAgICAgICAgcmV0dXJuIFdlYlN0cmluZygpOwotCi0gICAgRWxlbWVudCog ZWxlbWVudCA9IG1fZnJhbWUtPmRvY3VtZW50KCktPmdldEVsZW1lbnRCeUlkKGlkKTsKLSAgICBp ZiAoIWVsZW1lbnQpCi0gICAgICAgIHJldHVybiBXZWJTdHJpbmcoKTsKLQotICAgIHJldHVybiBj b3VudGVyVmFsdWVGb3JFbGVtZW50KGVsZW1lbnQpOwotfQotCiBXZWJTdHJpbmcgV2ViRnJhbWVJ bXBsOjptYXJrZXJUZXh0Rm9yTGlzdEl0ZW0oY29uc3QgV2ViRWxlbWVudCYgd2ViRWxlbWVudCkg Y29uc3QKIHsKICAgICByZXR1cm4gV2ViQ29yZTo6bWFya2VyVGV4dEZvckxpc3RJdGVtKGNvbnN0 X2Nhc3Q8RWxlbWVudCo+KHdlYkVsZW1lbnQuY29uc3RVbndyYXA8RWxlbWVudD4oKSkpOwpJbmRl eDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgJKHJldmlzaW9uIDEy MDI5NSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMjMsNyArMjIzLDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgV2ViU3Ry aW5nIGNvbnRlbnRBc1RleHQoc2l6ZV90IG1heENoYXJzKSBjb25zdDsKICAgICB2aXJ0dWFsIFdl YlN0cmluZyBjb250ZW50QXNNYXJrdXAoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBy ZW5kZXJUcmVlQXNUZXh0KFJlbmRlckFzVGV4dENvbnRyb2xzIHRvU2hvdyA9IFJlbmRlckFzVGV4 dE5vcm1hbCkgY29uc3Q7Ci0gICAgdmlydHVhbCBXZWJTdHJpbmcgY291bnRlclZhbHVlRm9yRWxl bWVudEJ5SWQoY29uc3QgV2ViU3RyaW5nJiBpZCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJTdHJp bmcgbWFya2VyVGV4dEZvckxpc3RJdGVtKGNvbnN0IFdlYkVsZW1lbnQmKSBjb25zdDsKICAgICB2 aXJ0dWFsIGludCBwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQoY29uc3QgV2ViU3RyaW5nJiBpZCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxvYXQgcGFnZVdpZHRo SW5QaXhlbHMsCg== 147718 2012-06-14 20:21:06 -0700 2012-06-14 23:33:42 -0700 Patch bug-88851-20120615084906.patch text/plain 3354 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjAzOTApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA2LTE1ICBLYXVzdHViaCBBdHJhd2Fsa2FyICA8a2F1c3R1YmhAbW90b3JvbGEu Y29tPgorCisgICAgICAgIFJlbW92ZSBzdXBwb3J0IGZvciBjb3VudGVyVmFsdWVGb3JFbGVtZW50 QnlJZCBmcm9tIGNocm9taXVtIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg4ODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTW92ZWQgdGhlIGNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkIGZyb20g TGF5b3V0VGVzdENvdHJvbGxlciB0byBJbnRlcm5hbHMgc28KKyAgICAgICAgcmVtb3ZlIHRoZSBv bGQgcGxhdGZvcm0gc3BlY2lmaWMgaW1wbGVtZW50YXRpb25zIGFzIGl0IGV4Y2x1c2l2ZWx5IHRl c3RzIFdlYkNvcmUgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHB1YmxpYy9XZWJGcmFtZS5o OgorICAgICAgICAoV2ViRnJhbWUpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmg6CisgICAgICAg IChXZWJGcmFtZUltcGwpOgorCiAyMDEyLTA2LTE0ICBEYXZpZCBSZXZlbWFuICA8cmV2ZW1hbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBTdWItcGl4ZWwgdGV4dCByZW5kZXJp bmcgaXMgaW5jb3JyZWN0bHkgdXNlZCBmb3IgV2ViVmlldyB3aXRoIHRyYW5zcGFyZW50IGJhY2tn cm91bmQuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgJKHJl dmlzaW9uIDEyMDM5MCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1l LmgJKHdvcmtpbmcgY29weSkKQEAgLTYxOCwxMCArNjE4LDYgQEAgcHVibGljOgogICAgIC8vIHRv IHN1cHBvcnQgbGF5b3V0IHRlc3RzLgogICAgIHZpcnR1YWwgV2ViU3RyaW5nIHJlbmRlclRyZWVB c1RleHQoUmVuZGVyQXNUZXh0Q29udHJvbHMgdG9TaG93ID0gUmVuZGVyQXNUZXh0Tm9ybWFsKSBj b25zdCA9IDA7CiAKLSAgICAvLyBSZXR1cm5zIHRoZSBjb3VudGVyIHZhbHVlIGZvciB0aGUgc3Bl Y2lmaWVkIGVsZW1lbnQuICBUaGlzIG1ldGhvZCBpcwotICAgIC8vIHVzZWQgdG8gc3VwcG9ydCBs YXlvdXQgdGVzdHMuCi0gICAgdmlydHVhbCBXZWJTdHJpbmcgY291bnRlclZhbHVlRm9yRWxlbWVu dEJ5SWQoY29uc3QgV2ViU3RyaW5nJiBpZCkgY29uc3QgPSAwOwotCiAgICAgLy8gQ2FsbHMgbWFy a2VyVGV4dEZvckxpc3RJdGVtKCkgZGVmaW5lZCBpbiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU cmVlQXNUZXh0LmguCiAgICAgdmlydHVhbCBXZWJTdHJpbmcgbWFya2VyVGV4dEZvckxpc3RJdGVt KGNvbnN0IFdlYkVsZW1lbnQmKSBjb25zdCA9IDA7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAkocmV2aXNpb24gMTIwMzkwKQorKysgU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTk3NywxOCArMTk3Nyw2IEBAIFdlYlN0cmluZyBXZWJGcmFtZUltcGw6OnJlbmRlclRyZWVBc1Rl eHQKICAgICByZXR1cm4gZXh0ZXJuYWxSZXByZXNlbnRhdGlvbihtX2ZyYW1lLCBiZWhhdmlvcik7 CiB9CiAKLVdlYlN0cmluZyBXZWJGcmFtZUltcGw6OmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlk KGNvbnN0IFdlYlN0cmluZyYgaWQpIGNvbnN0Ci17Ci0gICAgaWYgKCFtX2ZyYW1lKQotICAgICAg ICByZXR1cm4gV2ViU3RyaW5nKCk7Ci0KLSAgICBFbGVtZW50KiBlbGVtZW50ID0gbV9mcmFtZS0+ ZG9jdW1lbnQoKS0+Z2V0RWxlbWVudEJ5SWQoaWQpOwotICAgIGlmICghZWxlbWVudCkKLSAgICAg ICAgcmV0dXJuIFdlYlN0cmluZygpOwotCi0gICAgcmV0dXJuIGNvdW50ZXJWYWx1ZUZvckVsZW1l bnQoZWxlbWVudCk7Ci19Ci0KIFdlYlN0cmluZyBXZWJGcmFtZUltcGw6Om1hcmtlclRleHRGb3JM aXN0SXRlbShjb25zdCBXZWJFbGVtZW50JiB3ZWJFbGVtZW50KSBjb25zdAogewogICAgIHJldHVy biBXZWJDb3JlOjptYXJrZXJUZXh0Rm9yTGlzdEl0ZW0oY29uc3RfY2FzdDxFbGVtZW50Kj4od2Vi RWxlbWVudC5jb25zdFVud3JhcDxFbGVtZW50PigpKSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAkocmV2aXNpb24gMTIwMzkwKQorKysgU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTIyMyw3 ICsyMjMsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgY29udGVudEFzVGV4dChz aXplX3QgbWF4Q2hhcnMpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViU3RyaW5nIGNvbnRlbnRBc01h cmt1cCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViU3RyaW5nIHJlbmRlclRyZWVBc1RleHQoUmVu ZGVyQXNUZXh0Q29udHJvbHMgdG9TaG93ID0gUmVuZGVyQXNUZXh0Tm9ybWFsKSBjb25zdDsKLSAg ICB2aXJ0dWFsIFdlYlN0cmluZyBjb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZChjb25zdCBXZWJT dHJpbmcmIGlkKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBtYXJrZXJUZXh0Rm9yTGlz dEl0ZW0oY29uc3QgV2ViRWxlbWVudCYpIGNvbnN0OwogICAgIHZpcnR1YWwgaW50IHBhZ2VOdW1i ZXJGb3JFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlkLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmbG9hdCBwYWdlV2lkdGhJblBpeGVscywK