88750 2012-06-10 21:51:14 -0700 XHR with .responseType=blob returns 0 size blob 2012-06-12 04:55:39 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 88844 1 tzik kinuko ap eric jbadics kinuko mario oldest_to_newest 645721 0 tzik 2012-06-10 21:51:14 -0700 XHR with .responseType = 'blob' returns Blob, but its .size is set to 0. 645722 1 146779 tzik 2012-06-10 21:51:44 -0700 Created attachment 146779 failcase 645724 2 146780 tzik 2012-06-10 22:01:55 -0700 Created attachment 146780 +reading blob with FileReader Note that, we can read this blob with FileReader, even if its size is 0. 645995 3 146854 kinuko 2012-06-11 07:38:03 -0700 Created attachment 146854 Patch 646231 4 146854 ap 2012-06-11 13:58:42 -0700 Comment on attachment 146854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146854&action=review > Source/WebCore/xml/XMLHttpRequest.cpp:287 > if (m_binaryResponseBuilder.get()) { This is old code, but this ".get()" is unnecessary, and should be removed sooner or later. 646232 5 ap 2012-06-11 13:59:01 -0700 <rdar://problem/11640154> 646618 6 kinuko 2012-06-11 21:58:25 -0700 (In reply to comment #4) > (From update of attachment 146854 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146854&action=review > > > Source/WebCore/xml/XMLHttpRequest.cpp:287 > > if (m_binaryResponseBuilder.get()) { > > This is old code, but this ".get()" is unnecessary, and should be removed sooner or later. Thanks, will delete .get() before landing. 646659 7 kinuko 2012-06-11 23:18:02 -0700 Committed r120042: <http://trac.webkit.org/changeset/120042> 646715 8 jbadics 2012-06-12 01:03:56 -0700 Unfortunately this new test fails on every bots since it was introduced in 120042. See https://bugs.webkit.org/show_bug.cgi?id=88844 646736 9 kinuko 2012-06-12 01:43:15 -0700 (In reply to comment #8) > Unfortunately this new test fails on every bots since it was introduced in 120042. See https://bugs.webkit.org/show_bug.cgi?id=88844 It looks it's passing at least on chromium. (In reply to comment #8) > Unfortunately this new test fails on every bots since it was introduced in 120042. See https://bugs.webkit.org/show_bug.cgi?id=88844 Sorry for the breakage, I'll take a look. (At least it's passing on chromium?) 646739 10 jbadics 2012-06-12 01:46:34 -0700 > It looks it's passing at least on chromium. (In reply to comment #8) > Sorry for the breakage, I'll take a look. (At least it's passing on chromium?) I'm sorry, it passes only on chromium : ) 646745 11 kinuko 2012-06-12 02:02:38 -0700 (In reply to comment #10) > > It looks it's passing at least on chromium. (In reply to comment #8) > > Sorry for the breakage, I'll take a look. (At least it's passing on chromium?) > I'm sorry, it passes only on chromium : ) It looks like XHR_RESPONSE_BLOB is not enabled on those platforms and I needed to add the test to Skipped for them. I'm going to make Skipped changes while I'll take another look. 646831 12 mario 2012-06-12 04:50:14 -0700 (In reply to comment #11) > [...] > It looks like XHR_RESPONSE_BLOB is not enabled on those platforms and I needed > to add the test to Skipped for them. > I'm going to make Skipped changes while I'll take another look. I think it would have been better to have filed a bug and use BUGWK###### instead of BUGWKGTK SKIP in the expectations file, so we have a clue were to look at when unskipping it. Already did it: http://trac.webkit.org/changeset/120059 (new bug reported: 88859) 646835 13 kinuko 2012-06-12 04:55:39 -0700 (In reply to comment #12) > (In reply to comment #11) > > [...] > > It looks like XHR_RESPONSE_BLOB is not enabled on those platforms and I needed > > to add the test to Skipped for them. > > I'm going to make Skipped changes while I'll take another look. > > I think it would have been better to have filed a bug and use BUGWK###### instead of BUGWKGTK SKIP in the expectations file, so we have a clue were to look at when unskipping it. > > Already did it: http://trac.webkit.org/changeset/120059 (new bug reported: 88859) Thanks for doing this!! I was going to file a new bug but must have done so when I update Skipped/TestExpectations. 146779 2012-06-10 21:51:44 -0700 2012-06-10 21:51:44 -0700 failcase failcase.html text/html 315 tzik PCFET0NUWVBFIGh0bWw+PG1ldGEgY2hhcnNldD0iVVRGLTgiPgo8c2NyaXB0Pgp2YXIgeGhyID0g bmV3IFhNTEh0dHBSZXF1ZXN0KCk7Cnhoci5yZXNwb25zZVR5cGUgPSAiYmxvYiI7Cnhoci5vcGVu KCJHRVQiLCBsb2NhdGlvbi5ocmVmKTsKeGhyLnNlbmQobnVsbCk7Cnhoci5vbmxvYWQgPSBmdW5j dGlvbigpIHsKICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJUZXh0ID0g eGhyLnJlc3BvbnNlLnNpemUgPT09IDAgPyAiRkFJTCIgOiAiUEFTUyI7Cn07Cjwvc2NyaXB0Pgo8 ZGl2IGlkPSJyZXN1bHQiPlJ1bm5pbmc8L2Rpdj4K 146780 2012-06-10 22:01:55 -0700 2012-06-10 22:01:55 -0700 +reading blob with FileReader failcase.html text/html 549 tzik PCFET0NUWVBFIGh0bWw+PG1ldGEgY2hhcnNldD0iVVRGLTgiPgo8c2NyaXB0Pgp2YXIgeGhyID0g bmV3IFhNTEh0dHBSZXF1ZXN0KCk7Cnhoci5yZXNwb25zZVR5cGUgPSAiYmxvYiI7Cnhoci5vcGVu KCJHRVQiLCBsb2NhdGlvbi5ocmVmKTsKeGhyLnNlbmQobnVsbCk7Cnhoci5vbmxvYWQgPSBmdW5j dGlvbigpIHsKICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJUZXh0ID0g eGhyLnJlc3BvbnNlLnNpemUgPT09IDAgPyAiRkFJTCIgOiAiUEFTUyI7CgogIHZhciByZWFkZXIg PSBuZXcgRmlsZVJlYWRlcigpOwogIHJlYWRlci5yZWFkQXNUZXh0KHhoci5yZXNwb25zZSk7CiAg cmVhZGVyLm9ubG9hZCA9IGZ1bmN0aW9uKCkgewogICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImJsb2ItY29udGVudCIpLmlubmVyVGV4dCA9IHJlYWRlci5yZXN1bHQ7CiAgfTsKfTsKPC9zY3Jp cHQ+CjxkaXYgaWQ9InJlc3VsdCI+UnVubmluZzwvZGl2PgoKPHA+Q29udGVudCBvZiB0aGUgYmxv Yjo8cHJlIGlkPSJibG9iLWNvbnRlbnQiPjwvcHJlPjwvcD4K 146854 2012-06-11 07:38:03 -0700 2012-06-11 13:58:42 -0700 Patch bug-88750-20120611233803.patch text/plain 4634 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ1YmVjYmRlNDc0MWRi MjJjMTYwMDhmNDM2Y2U5MzcxNjc5YjBiOC4uYzg2YmU0ZWM3YWMwYmI1OTg4M2RmMzI3ODkxNGM3 ZjZhZDZiZjU5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTExICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBYSFIgcmV0dXJucyBz aXplPT0wIEJsb2IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVzcG9uc2UgQmxvYidzIC5zaXplIGZpZWxkIG11c3QgaGF2ZSB0aGUgY29ycmVjdCByZXNw b25zZSBzaXplLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVz cG9uc2UtYmxvYi1zaXplLmh0bWwKKworICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6cmVzcG9uc2VCbG9iKToKKwogMjAx Mi0wNi0xMCAgUGFibG8gRmxvdXJldCAgPHBhYmxvZkBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAg QWNjZXNzIGNvbnRyb2wgYWxsb3cgbGlzdHMgc3RhcnRpbmcgd2l0aCBhIGNvbW1hIGFyZSBwYXJz ZWQgaW5jb3JyZWN0bHkgKENPUlMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1M SHR0cFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcApp bmRleCA3YzVlNWI1ZjA4N2IwNTg4ODU1NDY1NDE1NzI4YjlkY2Y2MjA2NTRlLi41YmZkYzQzMWZl ZDczNDQ0OWZhZDFlNTlkZjg3MGE0NTRlNzRiYWI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRw UmVxdWVzdC5jcHAKQEAgLTI4MywxNSArMjgzLDE2IEBAIEJsb2IqIFhNTEh0dHBSZXF1ZXN0Ojpy ZXNwb25zZUJsb2IoRXhjZXB0aW9uQ29kZSYgZWMpCiAgICAgICAgIC8vIGEgU2hhcmVkQnVmZmVy LCBldmVuIGlmIHRoZXkgZG9uJ3QgZ2V0IHRoZSBCbG9iIGZyb20gdGhlIG5ldHdvcmsgbGF5ZXIg ZGlyZWN0bHkuCiAgICAgICAgIE93blB0cjxCbG9iRGF0YT4gYmxvYkRhdGEgPSBCbG9iRGF0YTo6 Y3JlYXRlKCk7CiAgICAgICAgIC8vIElmIHdlIGVycm9yZWQgb3V0IG9yIGdvdCBubyBkYXRhLCB3 ZSBzdGlsbCByZXR1cm4gYSBibG9iLCBqdXN0IGFuIGVtcHR5IG9uZS4KKyAgICAgICAgc2l6ZV90 IHNpemUgPSAwOwogICAgICAgICBpZiAobV9iaW5hcnlSZXNwb25zZUJ1aWxkZXIuZ2V0KCkpIHsK ICAgICAgICAgICAgIFJlZlB0cjxSYXdEYXRhPiByYXdEYXRhID0gUmF3RGF0YTo6Y3JlYXRlKCk7 Ci0gICAgICAgICAgICBzaXplX3Qgc2l6ZSA9IG1fYmluYXJ5UmVzcG9uc2VCdWlsZGVyLT5zaXpl KCk7CisgICAgICAgICAgICBzaXplID0gbV9iaW5hcnlSZXNwb25zZUJ1aWxkZXItPnNpemUoKTsK ICAgICAgICAgICAgIHJhd0RhdGEtPm11dGFibGVEYXRhKCktPmFwcGVuZChtX2JpbmFyeVJlc3Bv bnNlQnVpbGRlci0+ZGF0YSgpLCBzaXplKTsKICAgICAgICAgICAgIGJsb2JEYXRhLT5hcHBlbmRE YXRhKHJhd0RhdGEsIDAsIEJsb2JEYXRhSXRlbTo6dG9FbmRPZkZpbGUpOwogICAgICAgICAgICAg YmxvYkRhdGEtPnNldENvbnRlbnRUeXBlKHJlc3BvbnNlTUlNRVR5cGUoKSk7IC8vIHJlc3BvbnNl TUlNRVR5cGUgZGVmYXVsdHMgdG8gdGV4dC94bWwgd2hpY2ggbWF5IGJlIGluY29ycmVjdC4KICAg ICAgICAgICAgIG1fYmluYXJ5UmVzcG9uc2VCdWlsZGVyLmNsZWFyKCk7CiAgICAgICAgIH0KLSAg ICAgICAgbV9yZXNwb25zZUJsb2IgPSBCbG9iOjpjcmVhdGUoYmxvYkRhdGEucmVsZWFzZSgpLCBt X2JpbmFyeVJlc3BvbnNlQnVpbGRlci5nZXQoKSA/IG1fYmluYXJ5UmVzcG9uc2VCdWlsZGVyLT5z aXplKCkgOiAwKTsKKyAgICAgICAgbV9yZXNwb25zZUJsb2IgPSBCbG9iOjpjcmVhdGUoYmxvYkRh dGEucmVsZWFzZSgpLCBzaXplKTsKICAgICB9CiAKICAgICByZXR1cm4gbV9yZXNwb25zZUJsb2Iu Z2V0KCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggMTVkNGIwZTllYjVhNDFkZGJjMDNhNjMyNzc0ZmE4ZDI4MTgzMGRmZi4u MzQxM2FkYjdkMGRmNmVlODQ5NTM3MGUyMmQ0ODkwOTA4ZDQ5YjBhOSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEyLTA2LTExICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4K KworICAgICAgICBYSFIgcmV0dXJucyBzaXplPT0wIEJsb2IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jl c3BvbnNlLWJsb2Itc2l6ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVz dHMveG1saHR0cHJlcXVlc3QvcmVzcG9uc2UtYmxvYi1zaXplLmh0bWw6IEFkZGVkLgorCiAyMDEy LTA2LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEV4cG9z ZSBsYXlvdXRUZXN0Q29udHJvbGxlciBhcyB0ZXN0UnVubmVyCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jlc3BvbnNlLWJsb2Itc2l6ZS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jlc3BvbnNlLWJs b2Itc2l6ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjkwN2RmNDI3NTQ4NzQzODc2YWZiYjU3 YTM0MWI3MzRmZjliMjUwNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMveG1saHR0cHJlcXVlc3QvcmVzcG9uc2UtYmxvYi1zaXplLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDUgQEAKK1Rlc3QgQmxvYi5zaXplIG9mIHJlc3BvbnNlIGJsb2IgcmVjZWl2ZWQgZm9yIFhN TEh0dHBSZXF1ZXN0CisKK1BBU1M6ICIyMDAiID09ICIyMDAiCitQQVNTOiAiMTAzNzQ2IiA9PSAi MTAzNzQ2IgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L3Jlc3BvbnNlLWJsb2Itc2l6ZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxo dHRwcmVxdWVzdC9yZXNwb25zZS1ibG9iLXNpemUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kNmNiYjJmMzk1 Y2Y1ZTQwZjgxZmRhMWM1ODA3ZGQzYWJkNWZlYmYwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZXNwb25zZS1ibG9iLXNpemUuaHRtbApA QCAtMCwwICsxLDM2IEBACis8aHRtbD4KKzxib2R5PgorPHA+VGVzdCBCbG9iLnNpemUgb2YgcmVz cG9uc2UgYmxvYiByZWNlaXZlZCBmb3IgWE1MSHR0cFJlcXVlc3Q8L3A+Cis8cHJlIGlkPSJjb25z b2xlIj48L3ByZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7 CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRlc3RD b250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KKworZnVuY3Rpb24gbG9nKHRleHQpCit7Cisg ICAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpOworICAg IGNvbnNvbGUuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUodGV4dCArICdcbicp KTsKK30KKworZnVuY3Rpb24gdGVzdChleHBlY3QsIGFjdHVhbCkKK3sKKyAgICBsb2coKGV4cGVj dCA9PSBhY3R1YWwgPyAnUEFTUycgOiAnRkFJTCcpICsgJzogIicgKyBleHBlY3QgKyAnIiA9PSAi JyArIGFjdHVhbCArICciJyk7Cit9CisKK3ZhciByZXEgPSBuZXcgWE1MSHR0cFJlcXVlc3Q7City ZXEucmVzcG9uc2VUeXBlID0gJ2Jsb2InOworcmVxLm9wZW4oJ0dFVCcsICcuLi9yZXNvdXJjZXMv dGVzdC5vZ3YnLCB0cnVlKTsKK3JlcS5vbnJlYWR5c3RhdGVjaGFuZ2UgPSBmdW5jdGlvbigpIHsK KyAgICBpZiAocmVxLnJlYWR5U3RhdGUgPT0gNCkgeworICAgICAgICB0ZXN0KDIwMCwgcmVxLnN0 YXR1cyk7CisgICAgICAgIHRlc3QoMTAzNzQ2LCByZXEucmVzcG9uc2Uuc2l6ZSkKKyAgICAgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9Cit9OworcmVxLnNlbmQobnVsbCk7CisKKzwv c2NyaXB0PgorPC9ib2R5Pgo=