88685 2012-06-08 13:40:34 -0700 REGRESSION(r106388): Form hidden element values being restored incorrectly for dynamically generated content 2012-06-28 23:12:43 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 89539 23346 0 priyajeet.hora tkent ap jonlee morrita priyajeet.hora tkent webkit.review.bot oldest_to_newest 644998 0 146641 priyajeet.hora 2012-06-08 13:40:34 -0700 Created attachment 146641 testcase Upstream bug: http://code.google.com/p/chromium/issues/detail?id=131645 As mentioned in the above bug, regression likely caused by http://trac.webkit.org/changeset/106388 Copying from the above bug: index.html (attached): <html> <body> <form method="POST" action="index2.html" > <input type="hidden" id="one" name="one" value="one" /> <input type="submit" value="submit" /> </form> </body> </html> index2.html (attached): just an empty file, does nothing. Steps: 1] Open index.html in the browser, inspect the form and you will see the above structure. 2] Submit the form and remain on this index2 page. 3] In an editor, edit the index.html file as follows to simulate a server side change of dynamic content <html> <body> <form method="POST" action="index2.html" > <input type="hidden" id="one" name="one" value="two" /> <input type="submit" value="submit" /> </form> </body> </html> Notice how I re-used the name and id, but the value is changed by the server 4] Press the browser back button 5] inspect the form again in web inspector as well as the response in the network tab What is the expected result? <input type="hidden" id="one" name="one" value="two" /> What happens instead? <input type="hidden" id="one" name="one" value="one" /> 6] Try the same in Chrome 18 or with autocomplete=off in the form and it works as expected 645001 1 146643 priyajeet.hora 2012-06-08 13:41:34 -0700 Created attachment 146643 form submit action file 654238 2 tkent 2012-06-20 21:59:29 -0700 https://bugs.webkit.org/show_bug.cgi?id=77391#c13 > I think the second one (saving hidden values updated after HTMLInputElement::finishParsingChildren()) is the safest for Bug 88685. 654239 3 148728 tkent 2012-06-20 22:03:33 -0700 Created attachment 148728 Patch 660142 4 148728 morrita 2012-06-28 22:34:53 -0700 Comment on attachment 148728 Patch Why is this only for hidden? 660145 5 tkent 2012-06-28 22:40:28 -0700 (In reply to comment #4) > Why is this only for hidden? We can detect whether the value is updated or not for other types because the current value is separately stored in other types. However the hidden type doesn't have such separated value. http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-value Many types behave as "value" mode, and the hidden type behaves as "default". 660158 6 148728 webkit.review.bot 2012-06-28 23:12:38 -0700 Comment on attachment 148728 Patch Clearing flags on attachment: 148728 Committed r121519: <http://trac.webkit.org/changeset/121519> 660159 7 webkit.review.bot 2012-06-28 23:12:43 -0700 All reviewed patches have been landed. Closing bug. 146641 2012-06-08 13:40:34 -0700 2012-06-08 13:40:34 -0700 testcase index.html text/html 182 priyajeet.hora PGh0bWw+DQo8Ym9keT4NCjxmb3JtIG1ldGhvZD0iUE9TVCIgYWN0aW9uPSJpbmRleDIuaHRtbCIg Pg0KPGlucHV0IHR5cGU9ImhpZGRlbiIgaWQ9Im9uZSIgbmFtZT0ib25lIiB2YWx1ZT0ib25lIiAv Pg0KPGlucHV0IHR5cGU9InN1Ym1pdCIgdmFsdWU9InN1Ym1pdCIgLz4NCjwvZm9ybT4NCjwvYm9k eT4NCjwvaHRtbD4= 146643 2012-06-08 13:41:34 -0700 2012-06-08 13:41:34 -0700 form submit action file index2.html text/html 32 priyajeet.hora PGh0bWw+DQo8Ym9keT4NCjwvYm9keT4NCjwvaHRtbD4= 148728 2012-06-20 22:03:33 -0700 2012-06-28 23:12:38 -0700 Patch bug-88685-20120621140332.patch text/plain 6351 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZlOWVhYTQ5NTFjYzgx NmI5ZTI2Yjk5ZWIxMDliZWM2ZjA1MDRhNi4uZDY0OTE3NjE3ZWZmZWUwZTUwNjkwOTBjMmIxYmYy NTg2MzZlZjg2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA2LTIwICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIxMDYz ODgpOiBGb3JtIGhpZGRlbiBlbGVtZW50IHZhbHVlcyBiZWluZyByZXN0b3JlZAorICAgICAgICBp bmNvcnJlY3RseSBmb3IgZHluYW1pY2FsbHkgZ2VuZXJhdGVkIGNvbnRlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4Njg1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIG5vdCBzYXZlIHZh bHVlIGF0dHJpYnV0ZSB1cGRhdGVkIGR1cmluZyBwYXJzaW5nLgorCisgICAgICAgIFRlc3Q6IGZh c3QvZm9ybXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRpdGVkLWNvbnRyb2xzLmh0bWwKKworICAg ICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M SW5wdXRFbGVtZW50OjpIVE1MSW5wdXRFbGVtZW50KToKKyAgICAgICAgSW5pdGlhbGl6ZSBtX3Zh bHVlQXR0cmlidXRlV2FzVXBkYXRlZEFmdGVyUGFyc2luZy4KKyAgICAgICAgKFdlYkNvcmU6OkhU TUxJbnB1dEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKyAgICAgICAgU2V0IHRydWUgdG8gbV92 YWx1ZUF0dHJpYnV0ZVdhc1VwZGF0ZWRBZnRlclBhcnNpbmcgaWYgdmFsdWUKKyAgICAgICAgYXR0 cmlidXRlIGlzIHVwZGF0ZWQgYW5kIGl0J3Mgbm90IGluIHBhcnNpbmcuCisgICAgICAgICogaHRt bC9IVE1MSW5wdXRFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50 Ojp2YWx1ZUF0dHJpYnV0ZVdhc1VwZGF0ZWRBZnRlclBhcnNpbmcpOgorICAgICAgICBBZGRlZCBm b3IgSGlkZGVuSW5wdXRUeXBlLgorICAgICAgICAqIGh0bWwvSGlkZGVuSW5wdXRUeXBlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhpZGRlbklucHV0VHlwZTo6c2F2ZUZvcm1Db250cm9sU3RhdGUp OgorICAgICAgICBTYXZlIHRoZSB2YWx1ZSBvbmx5IGlmIHZhbHVlQXR0cmlidXRlV2FzVXBkYXRl ZEFmdGVyUGFyc2luZygpIGlzIHRydWUuCisKIDIwMTItMDYtMjAgIEhheWF0byBJdG8gIDxoYXlh dG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtTaGFkb3ddW0VkaXRpbmddIERlbGV0aW5nIGNo YXJhY3RlciBpbiBkaXN0cmlidXRlZCBlbGVtZW50IGNhdXNlZCBhIGNyYXNoLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKaW5kZXggNGE4MTA3ZWU1ZDYwM2QwMjZiNGJj MTE3NGU0YTRlNjU5NzZjNWNlMS4uYjM1YzY3NWM3NWViNDY2YTAzNWZmODczYTUxYTk4OWRiNjFm MDFiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC05NSw2 ICs5NSw3IEBAIEhUTUxJbnB1dEVsZW1lbnQ6OkhUTUxJbnB1dEVsZW1lbnQoY29uc3QgUXVhbGlm aWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQqIGRvY3VtCiAgICAgLCBtX2lzQXV0b2ZpbGxlZChm YWxzZSkKICAgICAsIG1fc3RhdGVSZXN0b3JlZChmYWxzZSkKICAgICAsIG1fcGFyc2luZ0luUHJv Z3Jlc3MoY3JlYXRlZEJ5UGFyc2VyKQorICAgICwgbV92YWx1ZUF0dHJpYnV0ZVdhc1VwZGF0ZWRB ZnRlclBhcnNpbmcoZmFsc2UpCiAgICAgLCBtX3dhc01vZGlmaWVkQnlVc2VyKGZhbHNlKQogICAg ICwgbV9jYW5SZWNlaXZlRHJvcHBlZEZpbGVzKGZhbHNlKQogICAgICwgbV9pbnB1dFR5cGUoSW5w dXRUeXBlOjpjcmVhdGVUZXh0KHRoaXMpKQpAQCAtNTk0LDYgKzU5NSw3IEBAIHZvaWQgSFRNTElu cHV0RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUoY29uc3QgQXR0cmlidXRlJiBhdHRyaWJ1dGUpCiAg ICAgICAgIH0KICAgICAgICAgc2V0Rm9ybUNvbnRyb2xWYWx1ZU1hdGNoZXNSZW5kZXJlcihmYWxz ZSk7CiAgICAgICAgIHNldE5lZWRzVmFsaWRpdHlDaGVjaygpOworICAgICAgICBtX3ZhbHVlQXR0 cmlidXRlV2FzVXBkYXRlZEFmdGVyUGFyc2luZyA9ICFtX3BhcnNpbmdJblByb2dyZXNzOwogICAg IH0gZWxzZSBpZiAoYXR0cmlidXRlLm5hbWUoKSA9PSBjaGVja2VkQXR0cikgewogICAgICAgICAv LyBBbm90aGVyIHJhZGlvIGJ1dHRvbiBpbiB0aGUgc2FtZSBncm91cCBtaWdodCBiZSBjaGVja2Vk IGJ5IHN0YXRlCiAgICAgICAgIC8vIHJlc3RvcmUuIFdlIHNob3VsZG4ndCBjYWxsIHNldENoZWNr ZWQoKSBldmVuIGlmIHRoaXMgaGFzIHRoZSBjaGVja2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5oCmluZGV4IDNhZjJiMzUyNTY4ZGMyYjVhY2I5ZWU4NDcxYjc1Zjk0N2U1Mjhj MTUuLjMxMWM2OWIxNTQxYzM5NGQ0NDQwZjNkYzY0NTZmOTY4YTkzZGVlZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBAIC0yMzksMTEgKzIzOSwxMiBAQCBwdWJsaWM6 CiAgICAgSFRNTElucHV0RWxlbWVudCogY2hlY2tlZFJhZGlvQnV0dG9uRm9yR3JvdXAoKSBjb25z dDsKICAgICBib29sIGlzSW5SZXF1aXJlZFJhZGlvQnV0dG9uR3JvdXAoKSBjb25zdDsKIAorICAg IC8vIEZ1bmN0aW9ucyBmb3IgSW5wdXRUeXBlIGNsYXNzZXMuCiAgICAgdm9pZCBzZXRWYWx1ZUlu dGVybmFsKGNvbnN0IFN0cmluZyYsIFRleHRGaWVsZEV2ZW50QmVoYXZpb3IpOwotCiAgICAgYm9v bCBpc1RleHRGb3JtQ29udHJvbEZvY3VzYWJsZSgpIGNvbnN0OwogICAgIGJvb2wgaXNUZXh0Rm9y bUNvbnRyb2xLZXlib2FyZEZvY3VzYWJsZShLZXlib2FyZEV2ZW50KikgY29uc3Q7CiAgICAgYm9v bCBpc1RleHRGb3JtQ29udHJvbE1vdXNlRm9jdXNhYmxlKCkgY29uc3Q7CisgICAgYm9vbCB2YWx1 ZUF0dHJpYnV0ZVdhc1VwZGF0ZWRBZnRlclBhcnNpbmcoKSBjb25zdCB7IHJldHVybiBtX3ZhbHVl QXR0cmlidXRlV2FzVXBkYXRlZEFmdGVyUGFyc2luZzsgfQogCiAgICAgdm9pZCBjYWNoZVNlbGVj dGlvbkluUmVzcG9uc2VUb1NldFZhbHVlKGludCBjYXJldE9mZnNldCkgeyBjYWNoZVNlbGVjdGlv bihjYXJldE9mZnNldCwgY2FyZXRPZmZzZXQsIFNlbGVjdGlvbkhhc05vRGlyZWN0aW9uKTsgfQog CkBAIC0zODcsNiArMzg4LDcgQEAgcHJpdmF0ZToKICNlbmRpZgogICAgIGJvb2wgbV9zdGF0ZVJl c3RvcmVkIDogMTsKICAgICBib29sIG1fcGFyc2luZ0luUHJvZ3Jlc3MgOiAxOworICAgIGJvb2wg bV92YWx1ZUF0dHJpYnV0ZVdhc1VwZGF0ZWRBZnRlclBhcnNpbmcgOiAxOwogICAgIGJvb2wgbV93 YXNNb2RpZmllZEJ5VXNlciA6IDE7CiAgICAgYm9vbCBtX2NhblJlY2VpdmVEcm9wcGVkRmlsZXMg OiAxOwogICAgIE93blB0cjxJbnB1dFR5cGU+IG1faW5wdXRUeXBlOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IaWRkZW5JbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IaWRkZW5JbnB1dFR5cGUuY3BwCmluZGV4IDk2ZDRjZTAwMWI3ZjEwNjdlNzA0NzhmODcxOGI1 MzNmODgyYTlhN2YuLjNhNDhlYmZjMjdkNmRhYmU4MTM3NDRmYmY4NjM3N2ExZjcxNjA1NWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSGlkZGVuSW5wdXRUeXBlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hpZGRlbklucHV0VHlwZS5jcHAKQEAgLTU0LDggKzU0LDExIEBA IGNvbnN0IEF0b21pY1N0cmluZyYgSGlkZGVuSW5wdXRUeXBlOjpmb3JtQ29udHJvbFR5cGUoKSBj b25zdAogCiBGb3JtQ29udHJvbFN0YXRlIEhpZGRlbklucHV0VHlwZTo6c2F2ZUZvcm1Db250cm9s U3RhdGUoKSBjb25zdAogewotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgbm90IGFsd2F5cyBzYXZl IHRoZSB2YWx1ZS4gaHR0cDovL3dlYmtpdC5vcmcvYi84ODY4NQotICAgIHJldHVybiBGb3JtQ29u dHJvbFN0YXRlKGVsZW1lbnQoKS0+dmFsdWUoKSk7CisgICAgLy8gdmFsdWVBdHRyaWJ1dGVXYXNV cGRhdGVkQWZ0ZXJQYXJzaW5nKCkgbmV2ZXIgYmUgdHJ1ZSBmb3IgZm9ybQorICAgIC8vIGNvbnRy b2xzIGNyZWF0ZSBieSBjcmVhdGVFbGVtZW50KCkgb3IgY2xvbmVOb2RlKCkuIEl0J3Mgb2sgZm9y CisgICAgLy8gbm93IGJlY2F1c2Ugd2UgcmVzdG9yZSB2YWx1ZXMgb25seSB0byBmb3JtIGNvbnRy b2xzIGNyZWF0ZWQgYnkKKyAgICAvLyBwYXJzaW5nLgorICAgIHJldHVybiBlbGVtZW50KCktPnZh bHVlQXR0cmlidXRlV2FzVXBkYXRlZEFmdGVyUGFyc2luZygpID8gRm9ybUNvbnRyb2xTdGF0ZShl bGVtZW50KCktPnZhbHVlKCkpIDogRm9ybUNvbnRyb2xTdGF0ZSgpOwogfQogCiB2b2lkIEhpZGRl bklucHV0VHlwZTo6cmVzdG9yZUZvcm1Db250cm9sU3RhdGUoY29uc3QgRm9ybUNvbnRyb2xTdGF0 ZSYgc3RhdGUpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNDI5MzI3NTkxY2VkZGI3YjlkMzcwNjZlMjQ2ZmNlNmY2NjRkMzYw MC4uOGE4OTkxNjllNDc1YjY0NDlmMzJiNGFjZDhlZTNmMjllNWIzOWQxOSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTA2LTIwICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4K KworICAgICAgICBSRUdSRVNTSU9OKHIxMDYzODgpOiBGb3JtIGhpZGRlbiBlbGVtZW50IHZhbHVl cyBiZWluZyByZXN0b3JlZAorICAgICAgICBpbmNvcnJlY3RseSBmb3IgZHluYW1pY2FsbHkgZ2Vu ZXJhdGVkIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg4Njg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9uLWVkaXRlZC1jb250cm9scy1l eHBlY3RlZC50eHQ6CisgICAgICAgIEEgZmFpbGluZyB0ZXN0IGlzIGZpeGVkLgorCiAyMDEyLTA2 LTIwICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbU2hhZG93 XVtFZGl0aW5nXSBEZWxldGluZyBjaGFyYWN0ZXIgaW4gZGlzdHJpYnV0ZWQgZWxlbWVudCBjYXVz ZWQgYSBjcmFzaApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0 b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQudHh0 CmluZGV4IDBhOWIwZDg1NDVhMzM5NzE3OTQ2OTY1NjYzYmVjOWQ5YWUzNGU2YzcuLjljNmNlOTc1 N2YzZGNjYWUzMmRlZDZjNzY4NThmY2NiOTBjN2EwNTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRpdGVkLWNvbnRyb2xzLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9uLWVk aXRlZC1jb250cm9scy1leHBlY3RlZC50eHQKQEAgLTEsNyArMSw3IEBACiBUZXN0IHRvIE5PVCBz YXZlIHN0YXRlIGZvciBub24tZWRpdGVkIGNvbnRyb2xzCiAKIFBBU1MgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImJ1dHRvbiIpLnZhbHVlIGlzICIyIgotRkFJTCBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiaGlkZGVuIikudmFsdWUgc2hvdWxkIGJlIDIuIFdhcyAxLgorUEFTUyBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiaGlkZGVuIikudmFsdWUgaXMgIjIiCiBQQVNTIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJpbWFnZSIpLnZhbHVlIGlzICIyIgogUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgicmVzZXQiKS52YWx1ZSBpcyAiMiIKIFBBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InN1Ym1pdDEiKS52YWx1ZSBpcyAiMiIK