88538 2012-06-07 07:22:53 -0700 [Qt][Win] Add missing includes to fix the build 2012-06-11 03:29:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 88300 1 ossy ossy hausmann ossy oldest_to_newest 643537 0 ossy 2012-06-07 07:22:53 -0700 Including HTMLFormElement.h and FormState.h are missing in many Source/WebKit/qt/Api/* file ... It is problem, because many "Foo.FooMethod" is used before declaration of class Foo. I don't know why wasn't it problem before. Patch is coming soon. 643552 1 ossy 2012-06-07 07:45:19 -0700 problematic source files: - Source/WebKit/qt/Api/qwebframe.cpp - Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp - Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp - Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp - Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.cpp 643580 2 ossy 2012-06-07 08:42:03 -0700 MSVC Error log why we need this fix: qwebframe.cpp f:\WebKit\Source\WTF\wtf/PassRefPtr.h(52) : error C2027: use of undefined type ' WebCore::FormState' f:\webkit\source\webcore\loader\PolicyCallback.h(41) : see declaration o f 'WebCore::FormState' f:\WebKit\Source\WTF\wtf/PassRefPtr.h(67) : see reference to function te mplate instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled with [ T=WebCore::FormState ] f:\WebKit\Source\WTF\wtf/PassRefPtr.h(67) : while compiling class templa te member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)' with [ T=WebCore::FormState ] f:\WebKit\Source\WebKit\qt\WebCoreSupport\FrameLoaderClientQt.h(138) : s ee reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled with [ T=WebCore::FormState ] f:\WebKit\Source\WTF\wtf/PassRefPtr.h(52) : error C2227: left of '->deref' must 643604 3 146301 ossy 2012-06-07 09:14:35 -0700 Created attachment 146301 Patch Including HTMLFormElement.h is enough to make MSVC happy. 643607 4 146301 ossy 2012-06-07 09:16:00 -0700 Comment on attachment 146301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146301&action=review > Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:48 > +#include "HTMLFormElement.h" > #include "HitTestResult.h" It is strange a little bit, but necessarry to make style checker happy. (because HT < Hi) > Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:62 > -#include "HistoryItem.h" > +#include "HTMLFormElement.h" > #include "HTMLInputElement.h" > +#include "HistoryItem.h" ditto 645881 5 146301 ossy 2012-06-11 03:29:19 -0700 Comment on attachment 146301 Patch Clearing flags on attachment: 146301 Committed r119970: <http://trac.webkit.org/changeset/119970> 645882 6 ossy 2012-06-11 03:29:27 -0700 All reviewed patches have been landed. Closing bug. 146301 2012-06-07 09:14:35 -0700 2012-06-11 03:29:19 -0700 Patch bug-88538-20120607091434.patch text/plain 3610 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDUxNGNiYTFlMWYy Yjc1MTg4MjBiNzVkMGVkOGIyMThhM2U3OWRmNmIuLjAzYjBmZmZiMDFkZGQ1N2JiZTI3MzZhODU3 Mjc3YTFmOWNmZGNjOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYt MDcgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRd W1dpbl0gQWRkIG1pc3NpbmcgaW5jbHVkZXMgdG8gZml4IHRoZSBidWlsZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg1MzgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFwaS9xd2ViZnJhbWUuY3BwOgor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcDoKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHA6CisgICAgICAgICogV2Vi Q29yZVN1cHBvcnQvR2VvbG9jYXRpb25DbGllbnRRdC5jcHA6CisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvSWNvbkRhdGFiYXNlQ2xpZW50UXQuY3BwOgorCiAyMDEyLTA2LTA2ICBab2x0YW4gSG9y dmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gUXQgRFJUIC8gV1RSIHNo b3VsZCBiZSBhYmxlIHRvIGxvYWQgZXh0ZXJuYWwgcmVzb3VyY2VzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdl YmZyYW1lLmNwcAppbmRleCBhYmE1OGRiMGNkNmM3M2FkNWI3MDRkZDdjNTM2ZmYwZTcxZjlmNzI1 Li40MzllOGVkMTJhMTFkZjdlMjJkNTlmY2JkZTBmZjAyZDNiZDk1YTY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQv QXBpL3F3ZWJmcmFtZS5jcHAKQEAgLTQ1LDYgKzQ1LDcgQEAKICNpbmNsdWRlICJWOEdDQ29udHJv bGxlci5oIgogI2VuZGlmCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCisjaW5jbHVkZSAi SFRNTEZvcm1FbGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTE1ldGFFbGVtZW50LmgiCiAjaW5jbHVk ZSAiSGl0VGVzdFJlc3VsdC5oIgogI2luY2x1ZGUgIkhUVFBQYXJzZXJzLmgiCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcCBiL1Nv dXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCmluZGV4IGFl ZTJjZjhmYzU4NGQ5YmMxMGNkYzAwMmNlNWU2ZGFlMTA2ZGIyMTguLmMxYjgxNmMyYWVlZjFkMDYw ZTA3NWRmZTIzMDk4MjgyY2ExZjI2ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCkBAIC00NCw2ICs0NCw3IEBACiAjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogI2luY2x1ZGUgIkdyYXBoaWNzTGF5ZXIuaCIKICNl bmRpZgorI2luY2x1ZGUgIkhUTUxGb3JtRWxlbWVudC5oIgogI2luY2x1ZGUgIkhpdFRlc3RSZXN1 bHQuaCIKICNpbmNsdWRlICJJY29uLmgiCiAjaW5jbHVkZSAiTmF2aWdhdGlvbkFjdGlvbi5oIgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJl ZVN1cHBvcnRRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0LmNwcAppbmRleCBlNzBiZjAwNGE0OTEyNmY0NGJkMTQ3NWRkNDgyY2E4 MjcyNWRkZmVlLi43MGRkNWZiMzYxYzM3NjQwYTI4M2E4NmE4YWMxNjMxYWI1MzI2ZjNhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3Vw cG9ydFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydFF0LmNwcApAQCAtNTcsOCArNTcsOSBAQAogI2luY2x1ZGUgIkdlb2xvY2F0 aW9uQ29udHJvbGxlci5oIgogI2luY2x1ZGUgIkdlb2xvY2F0aW9uRXJyb3IuaCIKICNpbmNsdWRl ICJHZW9sb2NhdGlvblBvc2l0aW9uLmgiCi0jaW5jbHVkZSAiSGlzdG9yeUl0ZW0uaCIKKyNpbmNs dWRlICJIVE1MRm9ybUVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MSW5wdXRFbGVtZW50LmgiCisj aW5jbHVkZSAiSGlzdG9yeUl0ZW0uaCIKICNpbmNsdWRlICJJbml0V2ViQ29yZVF0LmgiCiAjaW5j bHVkZSAiSW5zcGVjdG9yQ29udHJvbGxlci5oIgogI2luY2x1ZGUgIk5vZGVMaXN0LmgiCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50 UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVu dFF0LmNwcAppbmRleCBlYzRkMWJiOWU5YWZjM2Y3YTA5MDlkYzVlNDhlNTE4N2FjZjE3MjRiLi4y MGJhMzUzYmQwOTQzMjJmZDU2YWY5ODdjYjY1M2Q2N2I1MmU0YTFhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50UXQuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25DbGllbnRRdC5jcHAK QEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJHZW9sb2NhdGlvbkVycm9yLmgiCiAjaW5jbHVk ZSAiR2VvbG9jYXRpb25QZXJtaXNzaW9uQ2xpZW50UXQuaCIKICNpbmNsdWRlICJHZW9sb2NhdGlv blBvc2l0aW9uLmgiCisjaW5jbHVkZSAiSFRNTEZvcm1FbGVtZW50LmgiCiAjaW5jbHVkZSAiUGFn ZS5oIgogI2luY2x1ZGUgInF3ZWJmcmFtZS5oIgogI2luY2x1ZGUgInF3ZWJmcmFtZV9wLmgiCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ljb25EYXRhYmFzZUNs aWVudFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSWNvbkRhdGFiYXNl Q2xpZW50UXQuY3BwCmluZGV4IDc3YjQxZGI2NDU2ODAyNzFiMzZlMzRmMjRlNjM4NGI3NTgxMzNm MGMuLmJhYWVjYWVmNWM0YmM5MDUxMTc5NDU2OTdmYzZhMDFiZDk5ZjMwM2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSWNvbkRhdGFiYXNlQ2xpZW50UXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSWNvbkRhdGFiYXNlQ2xpZW50 UXQuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiSWNvbkRhdGFiYXNlQ2xpZW50UXQu aCIKIAogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50UXQuaCIKKyNpbmNsdWRlICJIVE1MRm9y bUVsZW1lbnQuaCIKICNpbmNsdWRlICJJY29uRGF0YWJhc2VCYXNlLmgiCiAjaW5jbHVkZSA8d3Rm L3RleHQvQ1N0cmluZy5oPgogCg==