88489 2012-06-06 20:44:42 -0700 [Forms] Improve test coverage of input-number-size.html 2012-06-07 02:47:46 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88383 1 yosin yosin tkent webkit.review.bot oldest_to_newest 643142 0 yosin 2012-06-06 20:44:42 -0700 When we introduce decimal arithmetic, we change NumberInputType::sizeShouldIncludeDecoration(). To make sure that change doesn't change behavior, we would like to improve test coverage for sizeShouldIncludeDecoration(). This bug suggests to add following test case to /forms/number/input-number-size.html shouldBe('numberWidth(123456, 123456, 0.0000005)', 'textWidthPlusSpinButtonWidth(14)'); 643147 1 146185 yosin 2012-06-06 20:52:43 -0700 Created attachment 146185 Patch 1 643148 2 146185 yosin 2012-06-06 20:53:14 -0700 Comment on attachment 146185 Patch 1 Could you review this patch? Thanks in advance. 643154 3 146185 tkent 2012-06-06 21:11:30 -0700 Comment on attachment 146185 Patch 1 ok 643361 4 146185 webkit.review.bot 2012-06-07 02:47:41 -0700 Comment on attachment 146185 Patch 1 Clearing flags on attachment: 146185 Committed r119699: <http://trac.webkit.org/changeset/119699> 643362 5 webkit.review.bot 2012-06-07 02:47:46 -0700 All reviewed patches have been landed. Closing bug. 146185 2012-06-06 20:52:43 -0700 2012-06-07 02:47:41 -0700 Patch 1 bug-88489-20120607125243.patch text/plain 2336 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NjU3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTI5NjYxZmU3MjUzOTQzZWNlYTgx NmZiZWFhZDA1NmMyZGFmZDIxNS4uY2EwYTJlNzVjODg2NzY3ZGQwMmNjMGE1MzFmYWZjNDkxNzA0 ZDllYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTA2ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBJbXByb3ZlIHRlc3QgY292 ZXJhZ2Ugb2YgaW5wdXQtbnVtYmVyLXNpemUuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg0ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGltcHJvdmVzIHRlc3QgY292ZXJhZ2Ug Zm9yIE51bWJlcklucHV0VHlwZTo6c2l6ZVNob3VsZEluY2x1ZGVEZWNvcmF0aW9uKCkKKyAgICAg ICAgZm9yIHByZXBhcmF0aW9uIG9mIGludHJvZHVjaW5nIGRlY2ltYWwgYXJpdGhtZXRpYy4KKwor ICAgICAgICAqIGZhc3QvZm9ybXMvbnVtYmVyL2lucHV0LW51bWJlci1zaXplLWV4cGVjdGVkLnR4 dDogVXBkYXRlZCBmb3IgYSBuZXcgdGVzdCBjYXNlLgorICAgICAgICAqIGZhc3QvZm9ybXMvbnVt YmVyL2lucHV0LW51bWJlci1zaXplLmh0bWw6IEFkZGVkIGEgdGVzdCBjYXNlLgorCiAyMDEyLTA2 LTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmVydCBl cnJvbmVvdXMgY2hhbmdlIGluIHIxMTk2MzcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL251bWJlci9pbnB1dC1udW1iZXItc2l6ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL251bWJlci9pbnB1dC1udW1iZXItc2l6ZS1leHBlY3RlZC50eHQKaW5kZXgg OTBhYmIyMDY4NGY3NzQzMzhiNTUzODUxMjk4ZDNiMWIwYTA2YjBiMC4uYjJiYTljNGUxYTMyM2Qw MjgxNWIxNzVkZDFkZjAwZDk5ZjhlNGY1OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9udW1iZXIvaW5wdXQtbnVtYmVyLXNpemUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZm9ybXMvbnVtYmVyL2lucHV0LW51bWJlci1zaXplLWV4cGVjdGVkLnR4dApAQCAt NzcsNiArNzcsNyBAQCBQQVNTIG51bWJlcldpZHRoKDAuMDA1LCAxLCAxKSBpcyB0ZXh0V2lkdGhQ bHVzU3BpbkJ1dHRvbldpZHRoKDUpCiBQQVNTIG51bWJlcldpZHRoKDEuNSwgMiwgMSkgaXMgdGV4 dFdpZHRoUGx1c1NwaW5CdXR0b25XaWR0aCgzKQogUEFTUyBudW1iZXJXaWR0aCgxLjA1LCAyLCAx KSBpcyB0ZXh0V2lkdGhQbHVzU3BpbkJ1dHRvbldpZHRoKDQpCiBQQVNTIG51bWJlcldpZHRoKDEu MDA1LCAyLCAxKSBpcyB0ZXh0V2lkdGhQbHVzU3BpbkJ1dHRvbldpZHRoKDUpCitQQVNTIG51bWJl cldpZHRoKDEyMzQ1NiwgMTIzNDU2LCAwLjAwMDAwMDUpIGlzIHRleHRXaWR0aFBsdXNTcGluQnV0 dG9uV2lkdGgoMTQpCiAKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9udW1iZXIvaW5wdXQtbnVtYmVyLXNpemUuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL2lucHV0LW51bWJlci1zaXplLmh0bWwK aW5kZXggM2FiOTllZDgxNGRlMjk0NTBkYWJhYjA1YTEzNzEyN2ZmMzAxYmJmZS4uMzYwMzFhOWQ0 ZmUyM2ZiNThlZjMxZDc0ZmI2NDBkZDNhYzRjZjBkMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9udW1iZXIvaW5wdXQtbnVtYmVyLXNpemUuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL251bWJlci9pbnB1dC1udW1iZXItc2l6ZS5odG1sCkBAIC0xNDksNiArMTQ5 LDggQEAgc2hvdWxkQmUoJ251bWJlcldpZHRoKDEuNSwgMiwgMSknLCAndGV4dFdpZHRoUGx1c1Nw aW5CdXR0b25XaWR0aCgzKScpOwogc2hvdWxkQmUoJ251bWJlcldpZHRoKDEuMDUsIDIsIDEpJywg J3RleHRXaWR0aFBsdXNTcGluQnV0dG9uV2lkdGgoNCknKTsKIHNob3VsZEJlKCdudW1iZXJXaWR0 aCgxLjAwNSwgMiwgMSknLCAndGV4dFdpZHRoUGx1c1NwaW5CdXR0b25XaWR0aCg1KScpOwogCitz aG91bGRCZSgnbnVtYmVyV2lkdGgoMTIzNDU2LCAxMjM0NTYsIDAuMDAwMDAwNSknLCAndGV4dFdp ZHRoUGx1c1NwaW5CdXR0b25XaWR0aCgxNCknKTsKKwogZGVidWcoJycpCiA8L3NjcmlwdD4KIAo=