88394 2012-06-05 23:51:48 -0700 [Form] Changes for InputNumber type 2012-06-06 21:05:55 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88383 1 yosin yosin tkent webkit.review.bot oldest_to_newest 642229 0 yosin 2012-06-05 23:51:48 -0700 On bug 88220, we introduced InputNumber type for reducing patch size of introducing Decimal type. Although, I forgot number of places to use InputNumber. We should fix this before introducing Decimal type. 642256 1 145952 yosin 2012-06-06 00:44:31 -0700 Created attachment 145952 Patch 1 642269 2 145952 yosin 2012-06-06 00:59:17 -0700 Comment on attachment 145952 Patch 1 Could you review this patch? Thanks in advance. * Local build with enabling all input type on * To avoid including wtf/MathExtras.h for round in StepRange.h. roundByStep function is defined in StepRange.cpp. ** On Decimal, we don't need to include MathExtras.h to use round. 642290 3 145952 tkent 2012-06-06 01:55:56 -0700 Comment on attachment 145952 Patch 1 ok 642332 4 145952 webkit.review.bot 2012-06-06 03:26:36 -0700 Comment on attachment 145952 Patch 1 Clearing flags on attachment: 145952 Committed r119580: <http://trac.webkit.org/changeset/119580> 642333 5 webkit.review.bot 2012-06-06 03:26:40 -0700 All reviewed patches have been landed. Closing bug. 145952 2012-06-06 00:44:31 -0700 2012-06-06 03:26:36 -0700 Patch 1 bug-88394-20120606164430.patch text/plain 7241 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTdkZjM3ZWNlMDEzOWMz MjkyZmNkODFjNDgyNWM0NDIxZTVjNmQ4Ni4uYWM4NTk5MjliNTM1OTc2YjdhOTc3NWE5OThiZDhk ZDQyMmQ3ZWM0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTA2LTA2ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1dIENoYW5n ZXMgZm9yIElucHV0TnVtYmVyIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg4Mzk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBjaGFuZ2VzIGNvZGVzIGZvciBjb25zaXRlbmN5IG9m IElucHV0TnVtYmVyIHVzYWdlIGZvcgorICAgICAgICByZWR1Y2luZyBzaXplIG9mIHBhdGNoIHdo ZW4gd2UgY2hhbmdlIElucHV0TnVtYmVyIHR5cGUgYWxpYXMgZnJvbQorICAgICAgICBkb3VibGUg dG8gRGVjaW1hbC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBj aGFuZ2UgYmVoYXZpb3IuCisKKyAgICAgICAgKiBodG1sL0Jhc2VEYXRlQW5kVGltZUlucHV0VHlw ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGU6OnNlcmlh bGl6ZVdpdGhDb21wb25lbnRzKTogRml4ZWQgcGFyYW1ldGVyIHR5cGUgZm9yIGdldEFsbG93ZWRW YWx1ZVN0ZXAuCisgICAgICAgICogaHRtbC9JbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SW5wdXRUeXBlOjptaW5pbXVtKTogRml4ZWQgcmV0dXJuIHZhbHVlIHR5cGUgdG8gSW5wdXRO dW1iZXIuCisgICAgICAgIChXZWJDb3JlOjpJbnB1dFR5cGU6Om1heGltdW0pOiBkaXR0by4KKyAg ICAgICAgKiBodG1sL01vbnRoSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1vbnRo SW5wdXRUeXBlOjpkZWZhdWx0VmFsdWVGb3JTdGVwVXApOiBGaXggcmV0dXJuIHZhbHVlIHR5cGUg dG8gSW5wdXROdW1iZXIuCisgICAgICAgIChXZWJDb3JlOjpNb250aElucHV0VHlwZTo6cGFyc2VU b051bWJlcik6IGRpdHRvLgorICAgICAgICAqIGh0bWwvTnVtYmVySW5wdXRUeXBlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok51bWJlcklucHV0VHlwZTo6c2V0VmFsdWVBc0RvdWJsZSk6IFJlbW92 ZWQgZXh0cmEgY29udmVydERvdWJsZVRvSW5wdXROdW1iZXIuCisgICAgICAgICogaHRtbC9TdGVw UmFuZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RlcFJhbmdlOjphbGlnblZhbHVlRm9yU3Rl cCk6IFVzZSByb3VuZEJ5U3RlcCBmb3IgY29kZSBzaGFyaW5nLgorICAgICAgICAoV2ViQ29yZTo6 U3RlcFJhbmdlOjpjbGFtcFZhbHVlKTogZGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpTdGVwUmFu Z2U6OnJvdW5kQnlTdGVwKTogQWRkZWQuCisgICAgICAgICogaHRtbC9TdGVwUmFuZ2UuaDoKKyAg ICAgICAgKFN0ZXBSYW5nZSk6IEFkZGVkIGEgZGVjbGFyYXRpb24gb2Ygcm91bmRCeVN0ZXAuCisK IDIwMTItMDYtMDUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBD aGFuZ2luZyBmbGV4Ym94IGp1c3RpZnkvYWxpZ25tZW50IGRvZXNuJ3QgdXBkYXRlIHRoZWlyIHBv c2l0aW9uaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VEYXRlQW5kVGlt ZUlucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VEYXRlQW5kVGltZUlucHV0 VHlwZS5jcHAKaW5kZXggODUyODQxMjU5YjAxYmMyNDBhMzNjN2ZkZGYzMjEyMDU0MDc1OWE5NC4u NzNlNDk5MjNiMDYwYjQ2MzUzOGRkODEyOGVkNzZmOWUwY2FhZTgwZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9CYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvQmFzZURhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcApAQCAtMTQ2LDcgKzE0 Niw3IEBAIFN0cmluZyBCYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGU6OnNlcmlhbGl6ZShjb25zdCBJ bnB1dE51bWJlciYgdmFsdWUpIGNvbnN0CiAKIFN0cmluZyBCYXNlRGF0ZUFuZFRpbWVJbnB1dFR5 cGU6OnNlcmlhbGl6ZVdpdGhDb21wb25lbnRzKGNvbnN0IERhdGVDb21wb25lbnRzJiBkYXRlKSBj b25zdAogewotICAgIGRvdWJsZSBzdGVwOworICAgIElucHV0TnVtYmVyIHN0ZXA7CiAgICAgaWYg KCFlbGVtZW50KCktPmdldEFsbG93ZWRWYWx1ZVN0ZXAoJnN0ZXApKQogICAgICAgICByZXR1cm4g ZGF0ZS50b1N0cmluZygpOwogICAgIGlmICghZm1vZChzdGVwLCBtc2VjUGVyTWludXRlKSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSW5wdXRUeXBlLmNwcAppbmRleCBkMzY0ODFlNDJlODk4ODc1MmI4ZmQyYmE5NTVm YzBlZmRkNGM2M2RjLi5lMjNmOTJlOGQ5OTJjNmZkODdhNzA3YmJmMzc2MjFkYzBlYmM5MjY3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwCkBAIC0yODIsMTIgKzI4MiwxMiBAQCBJbnB1dE51 bWJlciBJbnB1dFR5cGU6OmRlZmF1bHRWYWx1ZUZvclN0ZXBVcCgpIGNvbnN0CiAKIGRvdWJsZSBJ bnB1dFR5cGU6Om1pbmltdW0oKSBjb25zdAogewotICAgIHJldHVybiBjcmVhdGVTdGVwUmFuZ2Uo UmVqZWN0QW55KS5taW5pbXVtKCk7CisgICAgcmV0dXJuIGNvbnZlcnRJbnB1dE51bWJlclRvRG91 YmxlKGNyZWF0ZVN0ZXBSYW5nZShSZWplY3RBbnkpLm1pbmltdW0oKSk7CiB9CiAKIGRvdWJsZSBJ bnB1dFR5cGU6Om1heGltdW0oKSBjb25zdAogewotICAgIHJldHVybiBjcmVhdGVTdGVwUmFuZ2Uo UmVqZWN0QW55KS5tYXhpbXVtKCk7CisgICAgcmV0dXJuIGNvbnZlcnRJbnB1dE51bWJlclRvRG91 YmxlKGNyZWF0ZVN0ZXBSYW5nZShSZWplY3RBbnkpLm1heGltdW0oKSk7CiB9CiAKIGJvb2wgSW5w dXRUeXBlOjpzaXplU2hvdWxkSW5jbHVkZURlY29yYXRpb24oaW50LCBpbnQmIHByZWZlcnJlZFNp emUpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01vbnRoSW5wdXRUeXBl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJbnB1dFR5cGUuY3BwCmluZGV4IDRiN2Nk Mzc0NTAzYTE1MDY5M2I2ODdkOTU2MmQzY2YzYmE5MmJlOTMuLmJhMTJiZWY1ZDk5ZDA0ODFlMWI3 YjMxMWFjYTZmZjRhMDYzOGMwNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9u dGhJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJbnB1dFR5cGUu Y3BwCkBAIC05NCw3ICs5NCw3IEBAIElucHV0TnVtYmVyIE1vbnRoSW5wdXRUeXBlOjpkZWZhdWx0 VmFsdWVGb3JTdGVwVXAoKSBjb25zdAogICAgIGRhdGUuc2V0TWlsbGlzZWNvbmRzU2luY2VFcG9j aEZvck1vbnRoKGN1cnJlbnQpOwogICAgIGRvdWJsZSBtb250aHMgPSBkYXRlLm1vbnRoc1NpbmNl RXBvY2goKTsKICAgICBBU1NFUlQoaXNmaW5pdGUobW9udGhzKSk7Ci0gICAgcmV0dXJuIG1vbnRo czsKKyAgICByZXR1cm4gY29udmVydERvdWJsZVRvSW5wdXROdW1iZXIobW9udGhzKTsKIH0KIAog U3RlcFJhbmdlIE1vbnRoSW5wdXRUeXBlOjpjcmVhdGVTdGVwUmFuZ2UoQW55U3RlcEhhbmRsaW5n IGFueVN0ZXBIYW5kbGluZykgY29uc3QKQEAgLTExNSw3ICsxMTUsNyBAQCBJbnB1dE51bWJlciBN b250aElucHV0VHlwZTo6cGFyc2VUb051bWJlcihjb25zdCBTdHJpbmcmIHNyYywgY29uc3QgSW5w dXROdW1iZXImCiAgICAgICAgIHJldHVybiBkZWZhdWx0VmFsdWU7CiAgICAgZG91YmxlIG1vbnRo cyA9IGRhdGUubW9udGhzU2luY2VFcG9jaCgpOwogICAgIEFTU0VSVChpc2Zpbml0ZShtb250aHMp KTsKLSAgICByZXR1cm4gbW9udGhzOworICAgIHJldHVybiBjb252ZXJ0RG91YmxlVG9JbnB1dE51 bWJlcihtb250aHMpOwogfQogCiBib29sIE1vbnRoSW5wdXRUeXBlOjpwYXJzZVRvRGF0ZUNvbXBv bmVudHNJbnRlcm5hbChjb25zdCBVQ2hhciogY2hhcmFjdGVycywgdW5zaWduZWQgbGVuZ3RoLCBE YXRlQ29tcG9uZW50cyogb3V0KSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9OdW1iZXJJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5 cGUuY3BwCmluZGV4IDZjMjFiMzlkMWFiZDBkNjE4ODJmNDBkNDlkZGMwMTgyMDA1NDVlYzYuLjY5 MmU3OTkwNGFhZTgwNzc5Mzc2ZjMxZmQzNTE5MTI2NDlkNDcxNTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvTnVtYmVySW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL051bWJlcklucHV0VHlwZS5jcHAKQEAgLTg3LDcgKzg3LDcgQEAgZG91YmxlIE51bWJlcklu cHV0VHlwZTo6dmFsdWVBc0RvdWJsZSgpIGNvbnN0CiB2b2lkIE51bWJlcklucHV0VHlwZTo6c2V0 VmFsdWVBc0RvdWJsZShkb3VibGUgbmV3VmFsdWUsIFRleHRGaWVsZEV2ZW50QmVoYXZpb3IgZXZl bnRCZWhhdmlvciwgRXhjZXB0aW9uQ29kZSYgZWMpIGNvbnN0CiB7CiAgICAgLy8gRklYTUU6IFdl IHNob3VsZCB1c2UgbnVtZXJpY19saW1pdHM8ZG91YmxlPjo6bWF4IGZvciBudW1iZXIgaW5wdXQg dHlwZS4KLSAgICBjb25zdCBkb3VibGUgZmxvYXRNYXggPSBjb252ZXJ0RG91YmxlVG9JbnB1dE51 bWJlcihudW1lcmljX2xpbWl0czxmbG9hdD46Om1heCgpKTsKKyAgICBjb25zdCBkb3VibGUgZmxv YXRNYXggPSBudW1lcmljX2xpbWl0czxmbG9hdD46Om1heCgpOwogICAgIGlmIChuZXdWYWx1ZSA8 IC1mbG9hdE1heCkgewogICAgICAgICBlYyA9IElOVkFMSURfU1RBVEVfRVJSOwogICAgICAgICBy ZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1N0ZXBSYW5nZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL1N0ZXBSYW5nZS5jcHAKaW5kZXggM2UxZTIzMzdiNzAyNGEyMzQz NWI3MzcwZDkxYzQxNTJlZjNiODA4Yy4uMGQ4ZmNjYjM3MjExMGQ5NzRjNzRmMzViZWU5NjFlZjgz YmZmOTBlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9TdGVwUmFuZ2UuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvU3RlcFJhbmdlLmNwcApAQCAtODcsNyArODcsNyBAQCBJ bnB1dE51bWJlciBTdGVwUmFuZ2U6OmFsaWduVmFsdWVGb3JTdGVwKGNvbnN0IElucHV0TnVtYmVy JiBjdXJyZW50VmFsdWUsIHVuc2lnbgogICAgICAgICBuZXdWYWx1ZSA9IHJvdW5kKG5ld1ZhbHVl ICogc2NhbGUpIC8gc2NhbGU7CiAgICAgfSBlbHNlIHsKICAgICAgICAgY29uc3QgSW5wdXROdW1i ZXIgc2NhbGUgPSBwb3coMTAuMCwgc3RhdGljX2Nhc3Q8SW5wdXROdW1iZXI+KG1heChtX3N0ZXBE ZWNpbWFsUGxhY2VzLCBtX3N0ZXBCYXNlRGVjaW1hbFBsYWNlcykpKTsKLSAgICAgICAgbmV3VmFs dWUgPSByb3VuZCgobV9zdGVwQmFzZSArIHJvdW5kKChuZXdWYWx1ZSAtIG1fc3RlcEJhc2UpIC8g bV9zdGVwKSAqIG1fc3RlcCkgKiBzY2FsZSkgLyBzY2FsZTsKKyAgICAgICAgbmV3VmFsdWUgPSBy b3VuZChyb3VuZEJ5U3RlcChuZXdWYWx1ZSwgbV9zdGVwQmFzZSkgKiBzY2FsZSkgLyBzY2FsZTsK ICAgICB9CiAKICAgICByZXR1cm4gbmV3VmFsdWU7CkBAIC05OSw3ICs5OSw3IEBAIElucHV0TnVt YmVyIFN0ZXBSYW5nZTo6Y2xhbXBWYWx1ZShjb25zdCBJbnB1dE51bWJlciYgdmFsdWUpIGNvbnN0 CiAgICAgaWYgKCFtX2hhc1N0ZXApCiAgICAgICAgIHJldHVybiBpblJhbmdlVmFsdWU7CiAgICAg Ly8gUm91bmRzIGluUmFuZ2VWYWx1ZSB0byBtaW5pbXVtICsgTiAqIHN0ZXAuCi0gICAgY29uc3Qg SW5wdXROdW1iZXIgcm91bmRlZFZhbHVlID0gbV9taW5pbXVtICsgcm91bmQoKGluUmFuZ2VWYWx1 ZSAtIG1fbWluaW11bSkgLyBtX3N0ZXApICogbV9zdGVwOworICAgIGNvbnN0IElucHV0TnVtYmVy IHJvdW5kZWRWYWx1ZSA9IHJvdW5kQnlTdGVwKGluUmFuZ2VWYWx1ZSwgbV9taW5pbXVtKTsKICAg ICBjb25zdCBJbnB1dE51bWJlciBjbGFtcGVkVmFsdWUgPSByb3VuZGVkVmFsdWUgPiBtX21heGlt dW0gPyByb3VuZGVkVmFsdWUgLSBtX3N0ZXAgOiByb3VuZGVkVmFsdWU7CiAgICAgQVNTRVJUKGNs YW1wZWRWYWx1ZSA+PSBtX21pbmltdW0pOwogICAgIEFTU0VSVChjbGFtcGVkVmFsdWUgPD0gbV9t YXhpbXVtKTsKQEAgLTE0OSw2ICsxNDksMTEgQEAgU3RlcFJhbmdlOjpOdW1iZXJXaXRoRGVjaW1h bFBsYWNlc09yTWlzc2luZyBTdGVwUmFuZ2U6OnBhcnNlU3RlcChBbnlTdGVwSGFuZGxpbmcKICAg ICByZXR1cm4gc3RlcDsKIH0KIAorSW5wdXROdW1iZXIgU3RlcFJhbmdlOjpyb3VuZEJ5U3RlcChj b25zdCBJbnB1dE51bWJlciYgdmFsdWUsIGNvbnN0IElucHV0TnVtYmVyJiBiYXNlKSBjb25zdAor eworICAgIHJldHVybiBiYXNlICsgcm91bmQoKHZhbHVlIC0gYmFzZSkgLyBtX3N0ZXApICogbV9z dGVwOworfQorCiBib29sIFN0ZXBSYW5nZTo6c3RlcE1pc21hdGNoKGNvbnN0IElucHV0TnVtYmVy JiB2YWx1ZUZvckNoZWNrKSBjb25zdAogewogICAgIGlmICghbV9oYXNTdGVwKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9TdGVwUmFuZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv U3RlcFJhbmdlLmgKaW5kZXggY2MzMDQ5N2Y1MzQ0NmRhYjY5OWU3ODRhNmY5ZWQ1MWY0MzcyOTVl ZS4uZWM3OTM2YjM1NzRkMGYxNDM0OGMyNzkzZWQ1N2UyYjI1ZmI5Yjg3YiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9TdGVwUmFuZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L1N0ZXBSYW5nZS5oCkBAIC0xNDEsNiArMTQxLDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAg IFN0ZXBSYW5nZSYgb3BlcmF0b3IgPShjb25zdCBTdGVwUmFuZ2UmKTsKKyAgICBJbnB1dE51bWJl ciByb3VuZEJ5U3RlcChjb25zdCBJbnB1dE51bWJlciYgdmFsdWUsIGNvbnN0IElucHV0TnVtYmVy JiBiYXNlKSBjb25zdDsKIAogICAgIGNvbnN0IElucHV0TnVtYmVyIG1fbWF4aW11bTsgLy8gbWF4 aW11bSBtdXN0IGJlID49IG1pbmltdW0uCiAgICAgY29uc3QgSW5wdXROdW1iZXIgbV9taW5pbXVt Owo=