88388 2012-06-05 19:22:55 -0700 [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349 2012-06-06 00:51:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88349 1 fischman fischman abarth dglazkov eric.carlson feature-media-reviews fischman fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 642104 0 fischman 2012-06-05 19:22:55 -0700 [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349 642105 1 145915 fischman 2012-06-05 19:23:11 -0700 Created attachment 145915 Patch 642106 2 145916 fischman 2012-06-05 19:23:56 -0700 Created attachment 145916 Patch 642108 3 webkit.review.bot 2012-06-05 19:26:45 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 642129 4 145916 eric.carlson 2012-06-05 20:48:22 -0700 Comment on attachment 145916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review Looks fine to me, but I am not abarth, dglazkov, fishd, jamesr or tkent... > Source/WebKit/chromium/public/WebMediaPlayer.h:107 > + enum CORSMode { > + Unspecified, > + Anonymous, > + UseCredentials, > + }; Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp? 642132 5 fischman 2012-06-05 20:54:27 -0700 (In reply to comment #4) > (From update of attachment 145916 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review > > Source/WebKit/chromium/public/WebMediaPlayer.h:107 > > + enum CORSMode { > > + Unspecified, > > + Anonymous, > > + UseCredentials, > > + }; > > Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp? They will (see 88349). The point of *this* patch is just to be able to land https://chromiumcodereview.appspot.com/10543007/ so that I can then land 88349... 642149 6 145916 fishd 2012-06-05 21:19:08 -0700 Comment on attachment 145916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review > Source/WebKit/chromium/public/WebMediaPlayer.h:103 > + enum CORSMode { nit: please fix enum naming: http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums 642174 7 145933 fischman 2012-06-05 22:11:55 -0700 Created attachment 145933 Patch 642175 8 fischman 2012-06-05 22:12:55 -0700 (In reply to comment #6) > (From update of attachment 145916 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review > > > Source/WebKit/chromium/public/WebMediaPlayer.h:103 > > + enum CORSMode { > > nit: please fix enum naming: > http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums Done. 642200 9 145933 fishd 2012-06-05 22:59:02 -0700 Comment on attachment 145933 Patch (please remember to add the AssertMatchingEnums.cpp change) 642258 10 145933 webkit.review.bot 2012-06-06 00:51:46 -0700 Comment on attachment 145933 Patch Clearing flags on attachment: 145933 Committed r119569: <http://trac.webkit.org/changeset/119569> 642259 11 webkit.review.bot 2012-06-06 00:51:53 -0700 All reviewed patches have been landed. Closing bug. 145915 2012-06-05 19:23:11 -0700 2012-06-05 19:23:53 -0700 Patch bug-88388-20120605192311.patch text/plain 2830 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM0YjgzMmEzM2ZlYWViOGM5ZmQ1YzAzNWY0MzlkMzU1ZDczZGQxYTguLmU5ZWUzNWIxNWNlNTQ4 YTFmMWUyMTNiNzlhMWMxM2QyZTYxNzI5ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDYtMDUgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBhIFdlYktpdDo6V2ViTWVkaWFQbGF5 ZXI6OkNPUlNNb2RlIGVudW0gaW4gcHJlcGFyYXRpb24gZm9yIDg4MzQ5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODM4OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVy Lmg6CisgICAgICAgICogc3JjL0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi S2l0OjpBc3NvY2lhdGVkVVJMTG9hZGVyOjpsb2FkQXN5bmNocm9ub3VzbHkpOgorCiAyMDEyLTA2 LTA1ICBEb25nd29vIEltICA8ZHcuaW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQWRkICdpc1By b3RvY29sSGFuZGxlclJlZ2lzdGVyZWQnIGFuZCAndW5yZWdpc3RlclByb3RvY29sSGFuZGxlcicu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXll ci5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaAppbmRl eCA0NDRhMmNjOTAxZjdlYzRmM2IwZjNiZGYyMTdhZTE5NDhkMmRlMzRhLi5lZjI3OGFhYThkY2Zh YjA4YTViZWI3MjVhOGRiYTEwMjc3OTg4NzViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYk1lZGlhUGxheWVyLmgKQEAgLTEwMCw2ICsxMDAsMTIgQEAgcHVibGljOgog ICAgICAgICBNZWRpYUtleUV4Y2VwdGlvbktleVN5c3RlbU5vdFN1cHBvcnRlZCwKICAgICB9Owog CisgICAgZW51bSBDT1JTTW9kZSB7CisgICAgICAgIFVuc3BlY2lmaWVkLAorICAgICAgICBBbm9u eW1vdXMsCisgICAgICAgIFVzZUNyZWRlbnRpYWxzLAorICAgIH07CisKICAgICB2aXJ0dWFsIH5X ZWJNZWRpYVBsYXllcigpIHt9CiAKICAgICB2aXJ0dWFsIHZvaWQgbG9hZChjb25zdCBXZWJVUkwm KSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Bc3NvY2lhdGVk VVJMTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Fzc29jaWF0ZWRVUkxM b2FkZXIuY3BwCmluZGV4IGYxYzJhYWIzMDFkMjUxNGFhNzgwNzcxMzFjZmNkMTQxYmI1ZTI2ZDgu LmU0NjZmNGRmNGYwZjBkOWY0ZDJhNzkwMzM0Zjc4ODY2OGJjYTYwMDkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwCkBAIC0zMiw2 ICszMiw3IEBACiAjaW5jbHVkZSAiQXNzb2NpYXRlZFVSTExvYWRlci5oIgogCiAjaW5jbHVkZSAi Q3Jvc3NPcmlnaW5BY2Nlc3NDb250cm9sLmgiCisjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNs dWRlICJEb2N1bWVudFRocmVhZGFibGVMb2FkZXIuaCIKICNpbmNsdWRlICJEb2N1bWVudFRocmVh ZGFibGVMb2FkZXJDbGllbnQuaCIKICNpbmNsdWRlICJIVFRQVmFsaWRhdGlvbi5oIgpAQCAtMzQ2 LDggKzM0NywxMCBAQCB2b2lkIEFzc29jaWF0ZWRVUkxMb2FkZXI6OmxvYWRBc3luY2hyb25vdXNs eShjb25zdCBXZWJVUkxSZXF1ZXN0JiByZXF1ZXN0LCBXZWJVUgogICAgICAgICBvcHRpb25zLmNy b3NzT3JpZ2luUmVxdWVzdFBvbGljeSA9IHN0YXRpY19jYXN0PFdlYkNvcmU6OkNyb3NzT3JpZ2lu UmVxdWVzdFBvbGljeT4obV9vcHRpb25zLmNyb3NzT3JpZ2luUmVxdWVzdFBvbGljeSk7CiAgICAg ICAgIG9wdGlvbnMuc2hvdWxkQnVmZmVyRGF0YSA9IERvTm90QnVmZmVyRGF0YTsKIAotICAgICAg ICBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHdlYmNvcmVSZXF1ZXN0ID0gbmV3UmVxdWVzdC50b1Jl c291cmNlUmVxdWVzdCgpOworICAgICAgICBSZXNvdXJjZVJlcXVlc3QmIHdlYmNvcmVSZXF1ZXN0 ID0gbmV3UmVxdWVzdC50b011dGFibGVSZXNvdXJjZVJlcXVlc3QoKTsKICAgICAgICAgRG9jdW1l bnQqIHdlYmNvcmVEb2N1bWVudCA9IG1fZnJhbWVJbXBsLT5mcmFtZSgpLT5kb2N1bWVudCgpOwor ICAgICAgICBpZiAob3B0aW9ucy5jcm9zc09yaWdpblJlcXVlc3RQb2xpY3kgPT0gV2ViQ29yZTo6 VXNlQWNjZXNzQ29udHJvbCkKKyAgICAgICAgICAgIHVwZGF0ZVJlcXVlc3RGb3JBY2Nlc3NDb250 cm9sKHdlYmNvcmVSZXF1ZXN0LCB3ZWJjb3JlRG9jdW1lbnQtPnNlY3VyaXR5T3JpZ2luKCksIG9w dGlvbnMuYWxsb3dDcmVkZW50aWFscyk7CiAgICAgICAgIG1fbG9hZGVyID0gRG9jdW1lbnRUaHJl YWRhYmxlTG9hZGVyOjpjcmVhdGUod2ViY29yZURvY3VtZW50LCBtX2NsaWVudEFkYXB0ZXIuZ2V0 KCksIHdlYmNvcmVSZXF1ZXN0LCBvcHRpb25zKTsKICAgICB9IGVsc2UgewogICAgICAgICAvLyBG SVhNRTogcmV0dXJuIG1lYW5pbmdmdWwgZXJyb3IgY29kZXMuCg== 145916 2012-06-05 19:23:56 -0700 2012-06-05 22:11:49 -0700 Patch bug-88388-20120605192356.patch text/plain 1275 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM0YjgzMmEzM2ZlYWViOGM5ZmQ1YzAzNWY0MzlkMzU1ZDczZGQxYTguLjc1NjFhOWY3MTJmYmJl MDcwZWUxN2ZkZmQzMmU4MzNlODk4NWRlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMDUgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBhIFdlYktpdDo6V2ViTWVkaWFQbGF5 ZXI6OkNPUlNNb2RlIGVudW0gaW4gcHJlcGFyYXRpb24gZm9yIDg4MzQ5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODM4OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVy Lmg6CisKIDIwMTItMDYtMDUgIERvbmd3b28gSW0gIDxkdy5pbUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBBZGQgJ2lzUHJvdG9jb2xIYW5kbGVyUmVnaXN0ZXJlZCcgYW5kICd1bnJlZ2lzdGVyUHJv dG9jb2xIYW5kbGVyJy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYk1lZGlhUGxheWVyLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRp YVBsYXllci5oCmluZGV4IDQ0NGEyY2M5MDFmN2VjNGYzYjBmM2JkZjIxN2FlMTk0OGQyZGUzNGEu LmVmMjc4YWFhOGRjZmFiMDhhNWJlYjcyNWE4ZGJhMTAyNzc5ODg3NWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyLmgKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaApAQCAtMTAwLDYgKzEwMCwx MiBAQCBwdWJsaWM6CiAgICAgICAgIE1lZGlhS2V5RXhjZXB0aW9uS2V5U3lzdGVtTm90U3VwcG9y dGVkLAogICAgIH07CiAKKyAgICBlbnVtIENPUlNNb2RlIHsKKyAgICAgICAgVW5zcGVjaWZpZWQs CisgICAgICAgIEFub255bW91cywKKyAgICAgICAgVXNlQ3JlZGVudGlhbHMsCisgICAgfTsKKwog ICAgIHZpcnR1YWwgfldlYk1lZGlhUGxheWVyKCkge30KIAogICAgIHZpcnR1YWwgdm9pZCBsb2Fk KGNvbnN0IFdlYlVSTCYpID0gMDsK 145933 2012-06-05 22:11:55 -0700 2012-06-06 00:51:46 -0700 Patch bug-88388-20120605221154.patch text/plain 1299 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM0YjgzMmEzM2ZlYWViOGM5ZmQ1YzAzNWY0MzlkMzU1ZDczZGQxYTguLjc1NjFhOWY3MTJmYmJl MDcwZWUxN2ZkZmQzMmU4MzNlODk4NWRlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMDUgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBhIFdlYktpdDo6V2ViTWVkaWFQbGF5 ZXI6OkNPUlNNb2RlIGVudW0gaW4gcHJlcGFyYXRpb24gZm9yIDg4MzQ5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODM4OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVy Lmg6CisKIDIwMTItMDYtMDUgIERvbmd3b28gSW0gIDxkdy5pbUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBBZGQgJ2lzUHJvdG9jb2xIYW5kbGVyUmVnaXN0ZXJlZCcgYW5kICd1bnJlZ2lzdGVyUHJv dG9jb2xIYW5kbGVyJy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYk1lZGlhUGxheWVyLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRp YVBsYXllci5oCmluZGV4IDQ0NGEyY2M5MDFmN2VjNGYzYjBmM2JkZjIxN2FlMTk0OGQyZGUzNGEu Ljc1MTk0MmI1YzhlODIzMDg3MTgzMGVjOTBiZTA2Nzk1NTBlNWQ1ZDYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyLmgKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaApAQCAtMTAwLDYgKzEwMCwx MiBAQCBwdWJsaWM6CiAgICAgICAgIE1lZGlhS2V5RXhjZXB0aW9uS2V5U3lzdGVtTm90U3VwcG9y dGVkLAogICAgIH07CiAKKyAgICBlbnVtIENPUlNNb2RlIHsKKyAgICAgICAgQ09SU01vZGVVbnNw ZWNpZmllZCwKKyAgICAgICAgQ09SU01vZGVBbm9ueW1vdXMsCisgICAgICAgIENPUlNNb2RlVXNl Q3JlZGVudGlhbHMsCisgICAgfTsKKwogICAgIHZpcnR1YWwgfldlYk1lZGlhUGxheWVyKCkge30K IAogICAgIHZpcnR1YWwgdm9pZCBsb2FkKGNvbnN0IFdlYlVSTCYpID0gMDsK