88366 2012-06-05 14:57:15 -0700 Changing flexbox justify/alignment doesn't update their positioning 2012-06-05 23:45:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62048 1 ericbidelman tony eric ojan tony webkit.review.bot oldest_to_newest 641917 0 ericbidelman 2012-06-05 14:57:15 -0700 The attached test case demonstrates this. The buttons update the justify/alignment properties of the flex container, but the items are not repositioned correctly. Toggling off the original style set on the flex contain (via the inspector) works. It appears a repaint is happening. I'm on 536.5 (@118056) 641920 1 145875 ericbidelman 2012-06-05 14:59:46 -0700 Created attachment 145875 Test case 641928 2 tony 2012-06-05 15:10:28 -0700 I don't have time to investigate this right now, but I suspect that the bug is that in RenderStyle::diff, we don't compare the new values on rareNonInheritedData. Previously, we would compare rareNonInheritedData->m_flexibleBox against each other, but moving the values to rareNonInheritedData doesn't automatically do this. Once we realize that the style has changed, we'll probably re-layout properly. The fix is probably around line RenderStyle.cpp:376. 642044 3 145903 tony 2012-06-05 17:35:03 -0700 Created attachment 145903 Patch 642045 4 tony 2012-06-05 17:35:27 -0700 I wasn't making progress on my other bug, so I decided to fix this :) 642226 5 145903 webkit.review.bot 2012-06-05 23:45:40 -0700 Comment on attachment 145903 Patch Clearing flags on attachment: 145903 Committed r119564: <http://trac.webkit.org/changeset/119564> 642227 6 webkit.review.bot 2012-06-05 23:45:50 -0700 All reviewed patches have been landed. Closing bug. 145875 2012-06-05 14:59:46 -0700 2012-06-05 14:59:46 -0700 Test case test.html text/html 1213 ericbidelman PHN0eWxlPgpib2R5IHsKCWRpc3BsYXk6IC13ZWJraXQtZmxleDsKCS13ZWJraXQtanVzdGlmeS1j b250ZW50OiBjZW50ZXI7CiAgLXdlYmtpdC1hbGlnbi1pdGVtczogY2VudGVyOwogIC13ZWJraXQt ZmxleC1kaXJlY3Rpb246IGNvbHVtbjsKICBoZWlnaHQ6IDEwMCU7CiAgb3ZlcmZsb3c6IGhpZGRl bjsKfQpib2R5ID4gZGl2IHsKCWRpc3BsYXk6IC13ZWJraXQtZmxleDsKCXBhZGRpbmc6IDEwcHg7 Cglib3JkZXI6IDFweCBzb2xpZCByZWQ7CgloZWlnaHQ6IDIwMHB4OwoJd2lkdGg6IDQwMHB4OwoJ LXdlYmtpdC1qdXN0aWZ5LWNvbnRlbnQ6IGNlbnRlcjsKICAtd2Via2l0LWFsaWduLWl0ZW1zOiBj ZW50ZXI7Cn0KZGl2ID4gZGl2IHsKICBtYXgtd2lkdGg6IDUwcHg7CiAgYm9yZGVyOiAxcHggc29s aWQgYmxhY2s7Cn0KPC9zdHlsZT4KPGRpdj4KCTxkaXY+VGVzdDwvZGl2Pgo8L2Rpdj4KPHA+Cgk8 YnV0dG9uIG9uY2xpY2s9InVwZGF0ZSgnLXdlYmtpdC1qdXN0aWZ5LWNvbnRlbnQnLCAnZmxleC1z dGFydCcpIj4td2Via2l0LWp1c3RpZnktY29udGVudDogZmxleC1zdGFydDs8L2J1dHRvbj4KCTxi dXR0b24gb25jbGljaz0idXBkYXRlKCctd2Via2l0LWp1c3RpZnktY29udGVudCcsICdjZW50ZXIn KSI+LXdlYmtpdC1qdXN0aWZ5LWNvbnRlbnQ6IGNlbnRlcjs8L2J1dHRvbj4KCTxidXR0b24gb25j bGljaz0idXBkYXRlKCctd2Via2l0LWp1c3RpZnktY29udGVudCcsICdmbGV4LWVuZCcpIj4td2Vi a2l0LWp1c3RpZnktY29udGVudDogZmxleC1lbmQ7PC9idXR0b24+PGJyPgoJPGJ1dHRvbiBvbmNs aWNrPSJ1cGRhdGUoJy13ZWJraXQtYWxpZ24taXRlbXMnLCAnZmxleC1zdGFydCcpIj4td2Via2l0 LWFsaWduLWNvbnRlbnQ6IGZsZXgtc3RhcnQ7PC9idXR0b24+Cgk8YnV0dG9uIG9uY2xpY2s9InVw ZGF0ZSgnLXdlYmtpdC1hbGlnbi1pdGVtcycsICdjZW50ZXInKSI+LXdlYmtpdC1hbGlnbi1jb250 ZW50OiBjZW50ZXI7PC9idXR0b24+Cgk8YnV0dG9uIG9uY2xpY2s9InVwZGF0ZSgnLXdlYmtpdC1h bGlnbi1pdGVtcycsICdmbGV4LWVuZCcpIj4td2Via2l0LWFsaWduLWNvbnRlbnQ6IGZsZXgtZW5k OzwvYnV0dG9uPgo8L3A+CjxzY3JpcHQ+CnZhciBkaXYgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCdkaXYnKTsKZnVuY3Rpb24gdXBkYXRlKHByb3AsIHZhbCkgewoJZGl2LnN0eWxlW3Byb3BdID0g dmFsOwp9Cjwvc2NyaXB0Pg== 145903 2012-06-05 17:35:03 -0700 2012-06-05 23:45:40 -0700 Patch bug-88366-20120605173503.patch text/plain 5581 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ1MWI1MzE0ODg0NDMx MWQ4MWVlZTdhMWQxMWU0MDk4NGM0ZGM3MS4uYmQ3NGVhMDYzZDE2ZmI1Y2ZkMWFhMzI3MWUzZWQ1 MjZhOTZkMmQ1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTA1ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hhbmdpbmcgZmxleGJveCBq dXN0aWZ5L2FsaWdubWVudCBkb2Vzbid0IHVwZGF0ZSB0aGVpciBwb3NpdGlvbmluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgzNjYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBjc3MzL2ZsZXhi b3gvc3R5bGUtY2hhbmdlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9SZW5kZXJT dHlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTdHlsZTo6ZGlmZik6IFNpbmNlIHRo ZXNlIG1lbWJlciB2YXJpYWJsZXMgd2VyZSBtb3ZlZAorICAgICAgICBvdXQgb2YgU3R5bGVGbGV4 aWJsZUJveERhdGEsIHdlIGhhdmUgdG8gY29tcGFyZSB0aGVtIGluIFJlbmRlclN0eWxlOjpkaWZm LgorCiAyMDEyLTA2LTA1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K IAogICAgICAgICBbQ2Fpcm9dIFtPcGVuR0xdIEVuYWJsZSBHTF9PRVNfc3RhbmRhcmRfZGVyaXZh dGl2ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJT dHlsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3Bw CmluZGV4IGFmNjczNjcwNDc0MmIzYTIyOGEyN2IxNWI3M2Y1YjUzOWE1ODk0N2QuLjc5MzQyZTM3 YTUyZTc2ZGNiOGMwYzdiMDNhMzUwOWE4NjJmNDllYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcApAQCAtMzk2LDYgKzM5NiwxMiBAQCBTdHls ZURpZmZlcmVuY2UgUmVuZGVyU3R5bGU6OmRpZmYoY29uc3QgUmVuZGVyU3R5bGUqIG90aGVyLCB1 bnNpZ25lZCYgY2hhbmdlZENvbgogICAgICAgICBpZiAocmFyZU5vbkluaGVyaXRlZERhdGEtPm1f ZmxleGlibGVCb3guZ2V0KCkgIT0gb3RoZXItPnJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX2ZsZXhp YmxlQm94LmdldCgpCiAgICAgICAgICAgICAmJiAqcmFyZU5vbkluaGVyaXRlZERhdGEtPm1fZmxl eGlibGVCb3guZ2V0KCkgIT0gKm90aGVyLT5yYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV9mbGV4aWJs ZUJveC5nZXQoKSkKICAgICAgICAgICAgIHJldHVybiBTdHlsZURpZmZlcmVuY2VMYXlvdXQ7Cisg ICAgICAgIGlmIChyYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV9vcmRlciAhPSBvdGhlci0+cmFyZU5v bkluaGVyaXRlZERhdGEtPm1fb3JkZXIKKyAgICAgICAgICAgIHx8IHJhcmVOb25Jbmhlcml0ZWRE YXRhLT5tX2FsaWduQ29udGVudCAhPSBvdGhlci0+cmFyZU5vbkluaGVyaXRlZERhdGEtPm1fYWxp Z25Db250ZW50CisgICAgICAgICAgICB8fCByYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV9hbGlnbkl0 ZW1zICE9IG90aGVyLT5yYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV9hbGlnbkl0ZW1zCisgICAgICAg ICAgICB8fCByYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV9hbGlnblNlbGYgIT0gb3RoZXItPnJhcmVO b25Jbmhlcml0ZWREYXRhLT5tX2FsaWduU2VsZgorICAgICAgICAgICAgfHwgcmFyZU5vbkluaGVy aXRlZERhdGEtPm1fanVzdGlmeUNvbnRlbnQgIT0gb3RoZXItPnJhcmVOb25Jbmhlcml0ZWREYXRh LT5tX2p1c3RpZnlDb250ZW50KQorICAgICAgICAgICAgcmV0dXJuIFN0eWxlRGlmZmVyZW5jZUxh eW91dDsKIAogICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGFkZCBhbiBvcHRpbWl6ZWQgZm9y bSBvZiBsYXlvdXQgdGhhdCBqdXN0IHJlY29tcHV0ZXMgdmlzdWFsIG92ZXJmbG93LgogICAgICAg ICBpZiAoIXJhcmVOb25Jbmhlcml0ZWREYXRhLT5zaGFkb3dEYXRhRXF1aXZhbGVudCgqb3RoZXIt PnJhcmVOb25Jbmhlcml0ZWREYXRhLmdldCgpKSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNWI3ZDY0OTk4YmYxNmVhN2Ni ZmQxZjYwMzAwZTY3ZmJhYjViNjcwLi4yYmQxNThiMTBjMmIxNjc5MmRmMDM1YjllNGE2ZDE5MTFl YThlN2QxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDYtMDUgIFRvbnkgQ2hhbmcgIDx0 b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2luZyBmbGV4Ym94IGp1c3RpZnkvYWxp Z25tZW50IGRvZXNuJ3QgdXBkYXRlIHRoZWlyIHBvc2l0aW9uaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODM2NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3NzMy9mbGV4Ym94L3N0eWxlLWNoYW5n ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNzczMvZmxleGJveC9zdHlsZS1jaGFu Z2UuaHRtbDogQWRkZWQuCisKIDIwMTItMDYtMDUgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEZpeGluZyB0d28gbGVvcGFyZC1zcGVjaWZpYyBiYXNlbGlu ZXMgZm9sbG93aW5nIHIxMTk1MjguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhi b3gvc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9z dHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZkODU0NGQ4ZWNhNTczYTQwYmI2 MjM0NWQ3Y2NkYTA2ZGRjOGVhZjcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3Mz L2ZsZXhib3gvc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAKK1RoaXMg dGVzdCB2ZXJpZmllcyB0aGF0IGNoYW5naW5nIG9yZGVyLCBhbGlnbi1jb250ZW50LCBhbGlnbi1p dGVtcywgYWxpZ24tc2VsZiwgb3IganVzdGlmeS1jb250ZW50IHdpbGwgcmVsYXlvdXQuCisKK1BB U1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2NzczMvZmxleGJveC9zdHlsZS1jaGFuZ2UuaHRtbCBiL0xheW91dFRlc3RzL2NzczMvZmxleGJv eC9zdHlsZS1jaGFuZ2UuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yOWFiZjdiZTY4NzY1ZWVlZTk4ZDZjOGQ2 NzNjZTQ0NzZjMWZjODRkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9mbGV4 Ym94L3N0eWxlLWNoYW5nZS5odG1sCkBAIC0wLDAgKzEsNzcgQEAKKzwhRE9DVFlQRSBodG1sPgor PGh0bWw+Cis8c3R5bGU+Citib2R5IHsKKyAgICBtYXJnaW46IDA7Cit9CisuZmxleGJveCB7Cisg ICAgZGlzcGxheTogLXdlYmtpdC1mbGV4OworICAgIGJhY2tncm91bmQtY29sb3I6ICNhYWE7Cisg ICAgcG9zaXRpb246IHJlbGF0aXZlOworfQorCisuZmxleGJveCA+IDpudGgtY2hpbGQoMSkgewor ICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7Cit9CisuZmxleGJveCA+IDpudGgtY2hpbGQoMikg eworICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOworfQorCisuYWJzb2x1dGUgeworICBwb3Np dGlvbjogYWJzb2x1dGU7CisgIHdpZHRoOiA1MHB4OworICBoZWlnaHQ6IDUwcHg7CisgIGJhY2tn cm91bmQtY29sb3I6IHllbGxvdyAhaW1wb3J0YW50OworfQorPC9zdHlsZT4KKzxzY3JpcHQ+Citp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9mbGV4Ym94 LmpzIj48L3NjcmlwdD4KKzxib2R5PgorCis8cD5UaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBjaGFu Z2luZyBvcmRlciwgYWxpZ24tY29udGVudCwgYWxpZ24taXRlbXMsIGFsaWduLXNlbGYsIG9yIGp1 c3RpZnktY29udGVudCB3aWxsIHJlbGF5b3V0LjwvcD4KKworPGRpdiBpZD0iZmxleGJveCIgY2xh c3M9ImZsZXhib3giIHN0eWxlPSJ3aWR0aDogMzAwcHg7IGhlaWdodDogMzAwcHg7Ij4KKyAgPGRp diBpZD0iYSIgc3R5bGU9Ii13ZWJraXQtZmxleDogMCAwIGF1dG87IHdpZHRoOiAxMDBweDsgaGVp Z2h0OiAxMDBweDsiPjwvZGl2PgorICA8ZGl2IGlkPSJiIiBzdHlsZT0iLXdlYmtpdC1mbGV4OiAw IDAgYXV0bzsgd2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyI+PC9kaXY+Cis8L2Rpdj4KKzxz Y3JpcHQ+CisKK3ZhciBmbGV4Ym94ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZsZXhib3gi KTsKK3ZhciBhRGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImEiKTsKK3ZhciBiRGl2ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImIiKTsKKworZnVuY3Rpb24gY2hlY2tWYWx1ZXMoYVhP ZmZzZXQsIGFZT2Zmc2V0LCBiWE9mZnNldCwgYllPZmZzZXQpCit7CisgICAgYURpdi5zZXRBdHRy aWJ1dGUoImRhdGEtb2Zmc2V0LXgiLCBhWE9mZnNldCk7CisgICAgYURpdi5zZXRBdHRyaWJ1dGUo ImRhdGEtb2Zmc2V0LXkiLCBhWU9mZnNldCk7CisgICAgYkRpdi5zZXRBdHRyaWJ1dGUoImRhdGEt b2Zmc2V0LXgiLCBiWE9mZnNldCk7CisgICAgYkRpdi5zZXRBdHRyaWJ1dGUoImRhdGEtb2Zmc2V0 LXkiLCBiWU9mZnNldCk7CisgICAgY2hlY2tGbGV4Qm94ZW4oKTsKK30KKworY2hlY2tWYWx1ZXMo MCwgMCwgMTAwLCAwKTsKKworZmxleGJveC5zdHlsZS53ZWJraXRKdXN0aWZ5Q29udGVudCA9ICJm bGV4LWVuZCI7CitjaGVja1ZhbHVlcygxMDAsIDAsIDIwMCwgMCk7CisKK2ZsZXhib3guc3R5bGUu d2Via2l0QWxpZ25JdGVtcyA9ICJmbGV4LWVuZCI7CitjaGVja1ZhbHVlcygxMDAsIDIwMCwgMjAw LCAyMDApOworCitiRGl2LnN0eWxlLndlYmtpdE9yZGVyID0gLTE7CitjaGVja1ZhbHVlcygyMDAs IDIwMCwgMTAwLCAyMDApOworCithRGl2LnN0eWxlLndlYmtpdEFsaWduU2VsZiA9ICJmbGV4LXN0 YXJ0IjsKK2NoZWNrVmFsdWVzKDIwMCwgMCwgMTAwLCAyMDApOworCitmbGV4Ym94LnN0eWxlLndp ZHRoID0gIjEwMHB4IjsKK2ZsZXhib3guc3R5bGUud2Via2l0RmxleFdyYXAgPSAid3JhcCI7Citm bGV4Ym94LnN0eWxlLndlYmtpdEFsaWduQ29udGVudCA9ICJmbGV4LWVuZCI7CitjaGVja1ZhbHVl cygwLCAyMDAsIDAsIDEwMCk7CisKKzwvc2NyaXB0PgorCis8L2JvZHk+Cis8L2h0bWw+Cg==