88309 2012-06-05 01:26:40 -0700 [Qt][Win] Fix const problem in Source/WebCore/xml/parser/XMLDocumentParserQt.cpp 2012-06-12 08:37:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ All All RESOLVED WORKSFORME Qt, QtTriaged P1 Blocker --- 88300 1 ossy ossy hausmann jturcotte ossy vestbo oldest_to_newest 641294 0 ossy 2012-06-05 01:26:40 -0700 The compiler (MSVC) said that Attribute local variable in ctr in Source/WebCore/xml/parser/XMLDocumentParserQt.cpp should be const, because const Attribute * -> Attribute * conversion isn't allowed. 641512 1 145785 ossy 2012-06-05 07:18:12 -0700 Created attachment 145785 Patch I trust in MSVC. :) Let's see the other bots' opinion ... 641607 2 ossy 2012-06-05 08:56:20 -0700 Ah, the build error which is fixed by the attached patch: f:\WebKit\Source\WebCore\xml\parser\XMLDocumentParserQt.cpp(143) : error C2440: 'initializing' : cannot convert from 'const WebCore::Attribute *' to 'WebCore::Attribute *' Conversion loses qualifiers NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 10.0\VC\Bi n\cl.EXE"' : return code '0x2' 641891 3 145785 hausmann 2012-06-05 14:26:32 -0700 Comment on attachment 145785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145785&action=review > Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:143 > - Attribute* attr = attrs->attributeItem(i); > + const Attribute* attr = attrs->attributeItem(i); I'm confused. Why does the compiler think the return value of attributeItem() is a const Attribute* given the signature in ElementAttributeData: dom/ElementAttributeData.h: Attribute* attributeItem(unsigned index) const { return &const_cast<ElementAttributeData*>(this)->m_attributes[index]; } 643441 4 ossy 2012-06-07 05:17:43 -0700 I can't see inside the MSVC's soul, so I have no idea ... But the patch I attached would make it happy. :) 646891 5 ossy 2012-06-12 06:33:35 -0700 ping r? 646967 6 ossy 2012-06-12 08:37:18 -0700 I don't know what changed in WebKit, but it seems it works now without this patch. (I'll reopen if it occurs again.) 145785 2012-06-05 07:18:12 -0700 2012-06-12 08:37:40 -0700 Patch bug-88309-20120605161810.patch text/plain 1703 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZkYWViNjg5MDNhNjA1 NjdkZjk3MTdjN2JjZGEyZjNjNjY0OWM2MS4uYWZkZjA0NTdkYTQ5MzVkNDQ3NDQ2NGM2M2U2NzZj MTQ3ODQ1NTg3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA2LTA1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XVtXaW5dIEZp eCBjb25zdCBwcm9ibGVtIGluIFNvdXJjZS9XZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQ YXJzZXJRdC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4MzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB4bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyUXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6WE1MRG9jdW1lbnRQYXJzZXI6OlhNTERvY3VtZW50UGFyc2VyKToKKwogMjAxMi0wNi0wNSAg Q2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAg SlNDOm5lZWQgdG8gaW1wbGVtZW50IERpY3Rpb25hcnk6OmdldFdpdGhVbmRlZmluZWRPck51bGxD aGVjayBmb3IgSURCCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERv Y3VtZW50UGFyc2VyUXQuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9YTUxEb2N1bWVu dFBhcnNlclF0LmNwcAppbmRleCA1OWQ5NDQ5MzQyMDExY2FjNDFmNWNhZjdhNWMyZTQwZTdmMzU1 MzVhLi45MDFkM2E1NDZjNmVhNGI4ZTM1N2Q3NTNjN2FiMzZkZjNiY2I2Mzk0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyUXQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAKQEAgLTE0 MCw3ICsxNDAsNyBAQCBYTUxEb2N1bWVudFBhcnNlcjo6WE1MRG9jdW1lbnRQYXJzZXIoRG9jdW1l bnRGcmFnbWVudCogZnJhZ21lbnQsIEVsZW1lbnQqIHBhcmVudAogICAgIGZvciAoRWxlbWVudCog ZWxlbWVudCA9IGVsZW1TdGFjay5sYXN0KCk7ICFlbGVtU3RhY2suaXNFbXB0eSgpOyBlbGVtU3Rh Y2sucmVtb3ZlTGFzdCgpKSB7CiAgICAgICAgIGlmIChFbGVtZW50QXR0cmlidXRlRGF0YSogYXR0 cnMgPSBlbGVtZW50LT51cGRhdGVkQXR0cmlidXRlRGF0YSgpKSB7CiAgICAgICAgICAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgYXR0cnMtPmxlbmd0aCgpOyBpKyspIHsKLSAgICAgICAgICAg ICAgICBBdHRyaWJ1dGUqIGF0dHIgPSBhdHRycy0+YXR0cmlidXRlSXRlbShpKTsKKyAgICAgICAg ICAgICAgICBjb25zdCBBdHRyaWJ1dGUqIGF0dHIgPSBhdHRycy0+YXR0cmlidXRlSXRlbShpKTsK ICAgICAgICAgICAgICAgICBpZiAoYXR0ci0+bG9jYWxOYW1lKCkgPT0gInhtbG5zIikKICAgICAg ICAgICAgICAgICAgICAgbV9kZWZhdWx0TmFtZXNwYWNlVVJJID0gYXR0ci0+dmFsdWUoKTsKICAg ICAgICAgICAgICAgICBlbHNlIGlmIChhdHRyLT5wcmVmaXgoKSA9PSAieG1sbnMiKQo=