<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>88308</bug_id>
          
          <creation_ts>2012-06-05 01:21:57 -0700</creation_ts>
          <short_desc>[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp</short_desc>
          <delta_ts>2012-06-10 06:44:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>420+</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>88300</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Balazs Kelemen">kbalazs</assigned_to>
          <cc>cmarcelo</cc>
    
    <cc>hausmann</cc>
    
    <cc>kbalazs</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>641288</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-05 01:21:57 -0700</bug_when>
    <thetext>- Use QtWidgets/QWidget include instead of obsolete QWidget
- QWidget-&gt;winId() doesn&apos;t work for some reason</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641623</commentid>
    <comment_count>1</comment_count>
      <attachid>145814</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-05 09:10:39 -0700</bug_when>
    <thetext>Created attachment 145814
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641629</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-05 09:14:00 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; - Use QtWidgets/QWidget include instead of obsolete QWidget
&gt; - QWidget-&gt;winId() doesn&apos;t work for some reason

The patch only fixes the first bug.

The second one is here, but I don&apos;t know how to fix it:
f:\WebKit\Source\WebCore\plugins\win\PluginViewWin.cpp(105) : error C2440: &apos;return&apos; : cannot convert from &apos;WId&apos; to &apos;HWND&apos;
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641739</commentid>
    <comment_count>3</comment_count>
    <who name="Caio Marcelo de Oliveira Filho">cmarcelo</who>
    <bug_when>2012-06-05 11:19:33 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #0)
&gt; &gt; - Use QtWidgets/QWidget include instead of obsolete QWidget
&gt; &gt; - QWidget-&gt;winId() doesn&apos;t work for some reason
&gt; 
&gt; The patch only fixes the first bug.
&gt; 
&gt; The second one is here, but I don&apos;t know how to fix it:
&gt; f:\WebKit\Source\WebCore\plugins\win\PluginViewWin.cpp(105) : error C2440: &apos;return&apos; : cannot convert from &apos;WId&apos; to &apos;HWND&apos;
&gt;         Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast

WId used to be a typedef to HWND, but it isn&apos;t anymore. It seems to me we need to do more work to get the HWND.

By insepcting Qt code, it seems using QApplicationPrivate::getHWNDForWidget() instead of winId() would suffice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641875</commentid>
    <comment_count>4</comment_count>
      <attachid>145814</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-06-05 14:08:54 -0700</bug_when>
    <thetext>Comment on attachment 145814
Patch

Hm no, if we were using QT += widgets in WebCore, then this would not be needed. But we shouldn&apos;t use QT += widgets in WebCore, so the question is: Why dos PluginViewWin.cpp need QWidget?

I have the feeling that for Qt 5 it&apos;s not actually QWidget that&apos;s needed but QWindow instead, to make the resolution from the WebView to a HWND.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641953</commentid>
    <comment_count>5</comment_count>
    <who name="Caio Marcelo de Oliveira Filho">cmarcelo</who>
    <bug_when>2012-06-05 15:44:21 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; By insepcting Qt code, it seems using QApplicationPrivate::getHWNDForWidget() instead of winId() would suffice.

Note that getHWNDForWidget() is implemented using the QWidget&apos;s QWindow, so we possibly can do the same, getting rid of the QWidget dependency.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641955</commentid>
    <comment_count>6</comment_count>
    <who name="Caio Marcelo de Oliveira Filho">cmarcelo</who>
    <bug_when>2012-06-05 15:44:45 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Note that getHWNDForWidget() is implemented using the QWidget&apos;s QWindow, so we possibly can do the same, getting rid of the QWidget dependency.

(...in this particular case.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643555</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-07 07:53:39 -0700</bug_when>
    <thetext>I don&apos;t understand what are you talking about. :)

Any volunteer to fix it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643631</commentid>
    <comment_count>8</comment_count>
      <attachid>146311</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-07 09:43:59 -0700</bug_when>
    <thetext>Created attachment 146311
Patch

Please don&apos;t review it, I don&apos;t want to land it. It is only a workaround until proper fix to be able test other build problems.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643633</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-07 09:44:30 -0700</bug_when>
    <thetext>No, I didn&apos;t want to assign it to myself, but webkit-patch did it again ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644673</commentid>
    <comment_count>10</comment_count>
      <attachid>146573</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-06-08 07:59:28 -0700</bug_when>
    <thetext>Created attachment 146573
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644675</commentid>
    <comment_count>11</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-06-08 08:01:04 -0700</bug_when>
    <thetext>Ossy, could you test it? Maybe a cast is missing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644718</commentid>
    <comment_count>12</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-08 09:11:20 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; Ossy, could you test it? Maybe a cast is missing.
Sure.

PluginViewWin.cpp

f:\WebKit\Source\WebCore\plugins\win\PluginViewWin.cpp(104) : error C2027: use of undefined type &apos;QWindow&apos;
        f:\qt5\qtbase\include\qtgui\../../src/gui/kernel/qwindowdefs.h(57) : see
 declaration of &apos;QWindow&apos;
f:\WebKit\Source\WebCore\plugins\win\PluginViewWin.cpp(104) : error C2227: left of &apos;-&gt;winId&apos; must point to class/struct/union/generic type
NMAKE : fatal error U1077: &apos;&quot;C:\Program Files\Microsoft Visual Studio 10.0\VC\Bin\cl.EXE&quot;&apos; : return code &apos;0x2&apos;
Stop.

It seems we need different codepaths for Qt4 and Qt5:

#if HAVE(QT5)
#include &lt;QWindow&gt;
#else
#include &lt;QWidget&gt;
#endif

...

and similar when we use included things


and after this fix I got the following error:
f:\WebKit\Source\WebCore\plugins\win\PluginViewWin.cpp(109) : error C2440: return&apos; : cannot convert from &apos;WId&apos; to &apos;HWND&apos;
        Conversion from integral type to pointer type requires reinterpret_cast, C-style cast or function-style cast</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>644768</commentid>
    <comment_count>13</comment_count>
      <attachid>146590</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-06-08 09:59:43 -0700</bug_when>
    <thetext>Created attachment 146590
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645495</commentid>
    <comment_count>14</comment_count>
      <attachid>146590</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-06-10 06:44:45 -0700</bug_when>
    <thetext>Comment on attachment 146590
Patch

Clearing flags on attachment: 146590

Committed r119927: &lt;http://trac.webkit.org/changeset/119927&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645496</commentid>
    <comment_count>15</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-06-10 06:44:54 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>145814</attachid>
            <date>2012-06-05 09:10:39 -0700</date>
            <delta_ts>2012-06-07 09:43:47 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88308-20120605181037.patch</filename>
            <type>text/plain</type>
            <size>1155</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRmYzdlNTJjNzgyOGY1
ZjBiM2JhMDllYzMwNzc0MGZlNmMzOTBkMS4uMjY5NTg2Y2JhYTU1OGVmOTM3OTU1ZGZhYmU0MjQ1
MmFhOWE3MjA0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2LTA1ICBDc2Fi
YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XVtXaW5dIEZp
eCBidWlsZGluZyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgzMDgKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsdWdpbnMv
d2luL1BsdWdpblZpZXdXaW4uY3BwOiBJbmNsdWRlIFF0V2lkZ2V0cy9RV2lkZ2V0IGluc3RlYWQg
b2Ygb2Jzb2xldGUgUVdpZGdldC4KKwogMjAxMi0wNi0wNSAgQXJwaXRhIEJhaHVndW5hICA8YXJw
aXRhYmFodWd1bmFAZ21haWwuY29tPgogCiAgICAgICAgIENTUyAyLjEgZmFpbHVyZTogYm9yZGVy
LWNvbmZsaWN0LWVsZW1lbnQtMDIxYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lu
cy93aW4vUGx1Z2luVmlld1dpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVn
aW5WaWV3V2luLmNwcAppbmRleCBhMGEyZTk4OGY0NDI4OGRmNjU5ZTRjYzQ3YmVjNWM2M2NiMWFk
NjQzLi5kM2ZhMGQ3ZjBhOWE5MTlkNmY0ZjgzMGNkMjFlYTMxYjUzZjQzNTFkIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcApAQCAtODgsNyArODgsNyBA
QAogCiAjaWYgUExBVEZPUk0oUVQpCiAjaW5jbHVkZSAiUVdlYlBhZ2VDbGllbnQuaCIKLSNpbmNs
dWRlIDxRV2lkZ2V0PgorI2luY2x1ZGUgPFF0V2lkZ2V0cy9RV2lkZ2V0PgogI2VuZGlmCiAKICNp
ZiBQTEFURk9STShXWCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>146311</attachid>
            <date>2012-06-07 09:43:59 -0700</date>
            <delta_ts>2012-06-08 07:59:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88308-20120607094358.patch</filename>
            <type>text/plain</type>
            <size>1516</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjdmZmIwZGVhMzk0YWU5
ZjllMmVkOWRiNjExZThhMGQwZWEzNzhkZi4uZDNjMDU0MGIxYzE5N2YxYWY5NDhmYzdkYjVjNmEw
M2EyMDc0YmY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA2LTA3ICBDc2Fi
YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XVtXaW5dIEZp
eCBidWlsZGluZyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgzMDgKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsdWdpbnMv
d2luL1BsdWdpblZpZXdXaW4uY3BwOgorICAgICAgICAod2luZG93SGFuZGxlRm9yUGFnZUNsaWVu
dCk6CisKIDIwMTItMDYtMDYgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAK
ICAgICAgICAgW2Nocm9taXVtXSBJbiBlYWNoIGNvbXBvc2l0ZWQgZnJhbWUsIGRpZERyYXcoKSBz
aG91bGQgb25seSBiZSBjYWxsZWQgb24gbGF5ZXJzIGZvciB3aGljaCB3aWxsRHJhdygpIHdhcyBj
YWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdX
aW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKaW5k
ZXggYTBhMmU5ODhmNDQyODhkZjY1OWU0Y2M0N2JlYzVjNjNjYjFhZDY0My4uYTIwMmUwMDY0MzE4
NTRhOTc3ZTFlNmU2MzZlM2M2YzZlYTU5OWUzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv
cGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lu
cy93aW4vUGx1Z2luVmlld1dpbi5jcHAKQEAgLTg4LDcgKzg4LDcgQEAKIAogI2lmIFBMQVRGT1JN
KFFUKQogI2luY2x1ZGUgIlFXZWJQYWdlQ2xpZW50LmgiCi0jaW5jbHVkZSA8UVdpZGdldD4KKyNp
bmNsdWRlIDxRdFdpZGdldHMvUVdpZGdldD4KICNlbmRpZgogCiAjaWYgUExBVEZPUk0oV1gpCkBA
IC0xMDIsNyArMTAyLDcgQEAgc3RhdGljIGlubGluZSBIV05EIHdpbmRvd0hhbmRsZUZvclBhZ2VD
bGllbnQoUGxhdGZvcm1QYWdlQ2xpZW50IGNsaWVudCkKICAgICBpZiAoIWNsaWVudCkKICAgICAg
ICAgcmV0dXJuIDA7CiAgICAgaWYgKFFXaWRnZXQqIHBsdWdpblBhcmVudCA9IHFvYmplY3RfY2Fz
dDxRV2lkZ2V0Kj4oY2xpZW50LT5wbHVnaW5QYXJlbnQoKSkpCi0gICAgICAgIHJldHVybiBwbHVn
aW5QYXJlbnQtPndpbklkKCk7CisgICAgICAgIHJldHVybiAwOwogICAgIHJldHVybiAwOwogI2Vs
aWYgUExBVEZPUk0oV1gpCiAgICAgaWYgKCFjbGllbnQpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>146573</attachid>
            <date>2012-06-08 07:59:28 -0700</date>
            <delta_ts>2012-06-08 09:59:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88308-20120608165923.patch</filename>
            <type>text/plain</type>
            <size>1709</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZhMjZlNTYzMDBjMDE4
NzJlNDVkYmRhNGM4OTlkMmQ5YTBjNWZhYS4uMjZjNzAxOGE0ZmI4NWE2YWY0ZjBlZGY5NzhmMmRl
YTJhYjNhYjQ0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTA4ICBCYWxh
enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dpbl0gRml4
IGJ1aWxkaW5nIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODMwOAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0
cywganVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICBVc2Ugb3duZXJXaW5kb3coKSBmcm9tIHBh
Z2UgY2xpZW50LiBJdCBoYXMgYmVlbgorICAgICAgICBpbnRyb2R1Y2VkIGZvciB4MTEgcGx1Z2lu
cyB0byBzb2x2ZSBleGFjdGx5IHRoZQorICAgICAgICBzYW1lIHByb2JsZW0uCisKKyAgICAgICAg
KiBwbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcDoKKyAgICAgICAgKHdpbmRvd0hhbmRsZUZv
clBhZ2VDbGllbnQpOgorCiAyMDEyLTA2LTA3ICBBbGV4ZWkgRmlsaXBwb3YgIDxhbGV4ZWlmQGNo
cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzb3J0aW5nIG9mIG9iamVjdCBm
aWVsZHMgaXMgYnJva2VuIGluIGhlYXAgcHJvZmlsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lu
cy93aW4vUGx1Z2luVmlld1dpbi5jcHAKaW5kZXggYTBhMmU5ODhmNDQyODhkZjY1OWU0Y2M0N2Jl
YzVjNjNjYjFhZDY0My4uNjdkNGFlYjJiNTVkMmM2ZWNiZjU1ZTJiZTM3ZGE5MGJjNzA4N2ZlMSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKQEAgLTg4
LDcgKzg4LDYgQEAKIAogI2lmIFBMQVRGT1JNKFFUKQogI2luY2x1ZGUgIlFXZWJQYWdlQ2xpZW50
LmgiCi0jaW5jbHVkZSA8UVdpZGdldD4KICNlbmRpZgogCiAjaWYgUExBVEZPUk0oV1gpCkBAIC0x
MDEsOCArMTAwLDggQEAgc3RhdGljIGlubGluZSBIV05EIHdpbmRvd0hhbmRsZUZvclBhZ2VDbGll
bnQoUGxhdGZvcm1QYWdlQ2xpZW50IGNsaWVudCkKICNpZiBQTEFURk9STShRVCkKICAgICBpZiAo
IWNsaWVudCkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgaWYgKFFXaWRnZXQqIHBsdWdpblBhcmVu
dCA9IHFvYmplY3RfY2FzdDxRV2lkZ2V0Kj4oY2xpZW50LT5wbHVnaW5QYXJlbnQoKSkpCi0gICAg
ICAgIHJldHVybiBwbHVnaW5QYXJlbnQtPndpbklkKCk7CisgICAgaWYgKFFXaW5kb3cqIHdpbmRv
dyA9IGNsaWVudC0+b3duZXJXaW5kb3coKSkKKyAgICAgICAgcmV0dXJuIHdpbmRvdy0+d2luSWQo
KTsKICAgICByZXR1cm4gMDsKICNlbGlmIFBMQVRGT1JNKFdYKQogICAgIGlmICghY2xpZW50KQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>146590</attachid>
            <date>2012-06-08 09:59:43 -0700</date>
            <delta_ts>2012-06-10 06:44:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88308-20120608185938.patch</filename>
            <type>text/plain</type>
            <size>1876</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIxNjI5MjM1MTFjZGI0
YzI4MjU0MTI0NTZiMzdhYjMzZTliYzQ1MC4uOTY1NTkwYTVmZTU2OTZjODVkYWU2ZTA0OGE0NjIy
YWJiMWMwZmFmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTA4ICBCYWxh
enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dpbl0gRml4
IGJ1aWxkaW5nIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODMwOAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0
cywganVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICBVc2Ugb3duZXJXaW5kb3coKSBmcm9tIHBh
Z2UgY2xpZW50LiBJdCBoYXMgYmVlbgorICAgICAgICBpbnRyb2R1Y2VkIGZvciB4MTEgcGx1Z2lu
cyB0byBzb2x2ZSBleGFjdGx5IHRoZQorICAgICAgICBzYW1lIHByb2JsZW0uCisKKyAgICAgICAg
KiBwbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcDoKKyAgICAgICAgKHdpbmRvd0hhbmRsZUZv
clBhZ2VDbGllbnQpOgorCiAyMDEyLTA2LTA4ICBJb24gUm9zY2EgIDxyb3NjYUBhZG9iZS5jb20+
CiAKICAgICAgICAgU29tZSBvdmVybGF5IHNjcm9sbGJhciBBUEkgY2FsbHMgaW4gU2Nyb2xsQW5p
bWF0b3JNYWMgY2FuIGxlYWQgdG8gYW4gYXNzZXJ0aW9uIGluIFJlbmRlckJveDo6bWFwQWJzb2x1
dGVUb0xvY2FsUG9pbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvd2luL1Bs
dWdpblZpZXdXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dp
bi5jcHAKaW5kZXggYTBhMmU5ODhmNDQyODhkZjY1OWU0Y2M0N2JlYzVjNjNjYjFhZDY0My4uYzg1
N2E0MDEwZDgzN2I1NjUzMTEwMzk0Mzk1YmI5NmQ5YmU4Nzc3MiAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKKysrIGIvU291cmNlL1dlYkNv
cmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKQEAgLTg4LDggKzg4LDEyIEBACiAKICNp
ZiBQTEFURk9STShRVCkKICNpbmNsdWRlICJRV2ViUGFnZUNsaWVudC5oIgorI2lmIEhBVkUoUVQ1
KQorI2luY2x1ZGUgPFFXaW5kb3c+CisjZWxzZQogI2luY2x1ZGUgPFFXaWRnZXQ+CiAjZW5kaWYK
KyNlbmRpZgogCiAjaWYgUExBVEZPUk0oV1gpCiAjaW5jbHVkZSA8d3gvZGVmcy5oPgpAQCAtMTAx
LDggKzEwNSwxMyBAQCBzdGF0aWMgaW5saW5lIEhXTkQgd2luZG93SGFuZGxlRm9yUGFnZUNsaWVu
dChQbGF0Zm9ybVBhZ2VDbGllbnQgY2xpZW50KQogI2lmIFBMQVRGT1JNKFFUKQogICAgIGlmICgh
Y2xpZW50KQogICAgICAgICByZXR1cm4gMDsKKyNpZiBIQVZFKFFUNSkKKyAgICBpZiAoUVdpbmRv
dyogd2luZG93ID0gY2xpZW50LT5vd25lcldpbmRvdygpKQorICAgICAgICByZXR1cm4gcmVpbnRl
cnByZXRfY2FzdDxIV05EPih3aW5kb3ctPndpbklkKCkpOworI2Vsc2UKICAgICBpZiAoUVdpZGdl
dCogcGx1Z2luUGFyZW50ID0gcW9iamVjdF9jYXN0PFFXaWRnZXQqPihjbGllbnQtPnBsdWdpblBh
cmVudCgpKSkKICAgICAgICAgcmV0dXJuIHBsdWdpblBhcmVudC0+d2luSWQoKTsKKyNlbmRpZgog
ICAgIHJldHVybiAwOwogI2VsaWYgUExBVEZPUk0oV1gpCiAgICAgaWYgKCFjbGllbnQpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>