<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>88305</bug_id>
          
          <creation_ts>2012-06-05 01:12:26 -0700</creation_ts>
          <short_desc>[Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/GraphicsContext.h</short_desc>
          <delta_ts>2012-06-07 04:49:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>420+</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>88300</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Csaba Osztrogonác">ossy</assigned_to>
          <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>641271</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-05 01:12:26 -0700</bug_when>
    <thetext>... because Q_WS_WIN doesn&apos;t exist anymore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641633</commentid>
    <comment_count>1</comment_count>
      <attachid>145817</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-05 09:20:11 -0700</bug_when>
    <thetext>Created attachment 145817
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>641892</commentid>
    <comment_count>2</comment_count>
      <attachid>145817</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-06-05 14:28:53 -0700</bug_when>
    <thetext>Comment on attachment 145817
Patch

Although I would prefer if this was landed with OS(WINDOWS) instead of defined(Q_OS_WIN), for consistency within the very same pre-processor line :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>643421</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-07 04:49:33 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 145817 [details])
&gt; Although I would prefer if this was landed with OS(WINDOWS) instead of defined(Q_OS_WIN), for consistency within the very same pre-processor line :)

Fixed patch landed in http://trac.webkit.org/changeset/119706</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>145817</attachid>
            <date>2012-06-05 09:20:11 -0700</date>
            <delta_ts>2012-06-07 04:49:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88305-20120605182005.patch</filename>
            <type>text/plain</type>
            <size>1776</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRmYzdlNTJjNzgyOGY1
ZjBiM2JhMDllYzMwNzc0MGZlNmMzOTBkMS4uZGRmMDhlMzg3ZjRkMWJkYjIyNzc4Njg4ZTk1NzE2
MTU1NjdjNzZjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA2LTA1ICBDc2Fi
YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XVtXaW5dIFVz
ZSBRX09TX1dJTiBpbnN0ZWFkIG9mIFFfV1NfV0lOIGluIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp
Y3MvR3JhcGhpY3NDb250ZXh0LmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTg4MzA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaDogQnVpbGRm
aXguCisgICAgICAgIChHcmFwaGljc0NvbnRleHQpOgorCiAyMDEyLTA2LTA1ICBBcnBpdGEgQmFo
dWd1bmEgIDxhcnBpdGFiYWh1Z3VuYUBnbWFpbC5jb20+CiAKICAgICAgICAgQ1NTIDIuMSBmYWls
dXJlOiBib3JkZXItY29uZmxpY3QtZWxlbWVudC0wMjFhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaCBiL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCmluZGV4IDMxMmU4ODVkNjFiMzIy
YzUxNDhmZGQ1MzBmMTYyNTQyYTE5NDk4ZGYuLmU1YTRkZTE4MDgwZDVhZDhjY2IxODZmMTI4MTNl
ZTU5YjUwMGEwOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L0dyYXBoaWNzQ29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L0dyYXBoaWNzQ29udGV4dC5oCkBAIC05Niw3ICs5Niw3IEBAIHR5cGVkZWYgdW5zaWduZWQgY2hh
ciBVSW50ODsKICNlbmRpZgogI2VuZGlmCiAKLSNpZiBQTEFURk9STShRVCkgJiYgZGVmaW5lZChR
X1dTX1dJTikKKyNpZiBQTEFURk9STShRVCkgJiYgZGVmaW5lZChRX09TX1dJTikKICNpbmNsdWRl
IDx3aW5kb3dzLmg+CiAjZW5kaWYKIApAQCAtNDg4LDcgKzQ4OCw3IEBAIG5hbWVzcGFjZSBXZWJD
b3JlIHsKICAgICAgICAgdm9pZCBkcmF3V2luZG93c0JpdG1hcChXaW5kb3dzQml0bWFwKiwgY29u
c3QgSW50UG9pbnQmKTsKICNlbmRpZgogCi0jaWYgKFBMQVRGT1JNKFFUKSAmJiBkZWZpbmVkKFFf
V1NfV0lOKSkgfHwgKFBMQVRGT1JNKFdYKSAmJiBPUyhXSU5ET1dTKSkKKyNpZiAoUExBVEZPUk0o
UVQpICYmIGRlZmluZWQoUV9PU19XSU4pKSB8fCAoUExBVEZPUk0oV1gpICYmIE9TKFdJTkRPV1Mp
KQogICAgICAgICBIREMgZ2V0V2luZG93c0NvbnRleHQoY29uc3QgSW50UmVjdCYsIGJvb2wgc3Vw
cG9ydEFscGhhQmxlbmQgPSB0cnVlLCBib29sIG1heUNyZWF0ZUJpdG1hcCA9IHRydWUpOwogICAg
ICAgICB2b2lkIHJlbGVhc2VXaW5kb3dzQ29udGV4dChIREMsIGNvbnN0IEludFJlY3QmLCBib29s
IHN1cHBvcnRBbHBoYUJsZW5kID0gdHJ1ZSwgYm9vbCBtYXlDcmVhdGVCaXRtYXAgPSB0cnVlKTsK
ICAgICAgICAgYm9vbCBzaG91bGRJbmNsdWRlQ2hpbGRXaW5kb3dzKCkgY29uc3QgeyByZXR1cm4g
ZmFsc2U7IH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>