88304 2012-06-05 01:08:02 -0700 [Qt][Win] Fix IDL dependency generation 2012-06-05 08:26:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 88300 1 ossy ossy ossy vestbo webkit.review.bot oldest_to_newest 641266 0 ossy 2012-06-05 01:08:02 -0700 Now WebCore/bindings/scripts/preprocess-idls.pl works incorrectly on Qt Windows, because the generated WebKitBuild/Release/Source/WebCore/generated/idl_files.tmp contains trailing whitespaces after filenames. It is generated by "GENERATOR 0" in WebCore/DerivedSources.pri by simple echo. 641460 1 145771 ossy 2012-06-05 05:51:03 -0700 Created attachment 145771 Patch 641467 2 ossy 2012-06-05 05:55:59 -0700 (In reply to comment #1) > Created an attachment (id=145771) [details] > Patch (In reply to comment #1) > Created an attachment (id=145771) [details] > Patch WebCore/bindings/scripts/preprocess-idls.pl can't handle "foo.idl " filenames, so we don't dump "foo.idl " names, but "foo.idl" names to idl_files.tmp. The bug was caused by echo's different behaviour on Linux and Windows: Linux's echo trims trailing whitespaces, but Windows' echo preserve all of them. 641470 3 145771 vestbo 2012-06-05 06:01:25 -0700 Comment on attachment 145771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145771&action=review > Source/WebCore/DerivedSources.pri:685 > + # We need "$$binding " instead of "$$binding", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304) Isn't the case that we need "$$binding", not "$$binding " with trailing space? > Source/WebCore/DerivedSources.pri:686 > + preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC Can this be done by quoting instead? 641476 4 ossy 2012-06-05 06:08:29 -0700 (In reply to comment #3) > (From update of attachment 145771 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145771&action=review > > > Source/WebCore/DerivedSources.pri:685 > > + # We need "$$binding " instead of "$$binding", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304) > > Isn't the case that we need "$$binding", not "$$binding " with trailing space? Good point. :) > > Source/WebCore/DerivedSources.pri:686 > > + preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC > > Can this be done by quoting instead? Unfortunately no. echo "xxx" >1.txt --> 1.txt:"xxx" + the trailing whitespace (similar to ' instead of ") 641478 5 145776 ossy 2012-06-05 06:10:34 -0700 Created attachment 145776 Patch Fixed typo 641583 6 145776 webkit.review.bot 2012-06-05 08:26:23 -0700 Comment on attachment 145776 Patch Clearing flags on attachment: 145776 Committed r119490: <http://trac.webkit.org/changeset/119490> 641584 7 webkit.review.bot 2012-06-05 08:26:35 -0700 All reviewed patches have been landed. Closing bug. 145771 2012-06-05 05:51:03 -0700 2012-06-05 06:10:28 -0700 Patch bug-88304-20120605145102.patch text/plain 1558 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZkYWViNjg5MDNhNjA1 NjdkZjk3MTdjN2JjZGEyZjNjNjY0OWM2MS4uNGFhYjBhYmI0MDg3OGZlY2MyYzg1YmQ4NWY2YzM4 MDg5Y2ZmODQ4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2LTA1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XVtXaW5dIEZp eCBJREwgZGVwZW5kZW5jeSBnZW5lcmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04ODMwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMucHJpOgorCiAyMDEyLTA2LTA1ICBD aGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBK U0M6bmVlZCB0byBpbXBsZW1lbnQgRGljdGlvbmFyeTo6Z2V0V2l0aFVuZGVmaW5lZE9yTnVsbENo ZWNrIGZvciBJREIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLnBy aSBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQppbmRleCBlNWY0ODQ0Njk1Mjg2 MjM2MmQ3YjlkYjMyMjNhODIxMzQ2NmQzOWJiLi40MTc0YWJlZDUyNzg0M2E3M2JkNDdkMTRjNzUz OTQ4Njk1ZjI0ZDEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5w cmkKKysrIGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMucHJpCkBAIC02ODIsNyArNjgy LDggQEAgRU9DID0gJCRlc2NhcGVfZXhwYW5kKFxcblxcdCkKIHdpbl9jbWRfc2hlbGw6IHByZXBy b2Nlc3NJZGxzLmNvbW1hbmRzID0gdHlwZSBudWwgPiAkJElETF9GSUxFU19UTVAgJCRFT0MKIGVs c2U6IHByZXByb2Nlc3NJZGxzLmNvbW1hbmRzID0gY2F0IC9kZXYvbnVsbCA+ICQkSURMX0ZJTEVT X1RNUCAkJEVPQwogZm9yKGJpbmRpbmcsIElETF9CSU5ESU5HUykgewotICAgIHByZXByb2Nlc3NJ ZGxzLmNvbW1hbmRzICs9IGVjaG8gJCRiaW5kaW5nID4+ICQkSURMX0ZJTEVTX1RNUCAkJEVPQwor ICAgICMgV2UgbmVlZCAiJCRiaW5kaW5nICIgaW5zdGVhZCBvZiAiJCRiaW5kaW5nIiwgYmVjYXVz ZSBXaW5kb3dzJyBlY2hvIHdyaXRlcyB0cmFpbGluZyB3aGl0ZXNwYWNlcy4gKGh0dHA6Ly93a2Iu dWcvODgzMDQpCisgICAgcHJlcHJvY2Vzc0lkbHMuY29tbWFuZHMgKz0gZWNobyAkJGJpbmRpbmc+ PiAkJElETF9GSUxFU19UTVAgJCRFT0MKIH0KIHByZXByb2Nlc3NJZGxzLmNvbW1hbmRzICs9IHBl cmwgLUkkJFBXRC9iaW5kaW5ncy9zY3JpcHRzICQkcHJlcHJvY2Vzc0lkbHMuc2NyaXB0IFwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLWRlZmluZXMgXCIkJHtGRUFUVVJFX0RFRklO RVNfSkFWQVNDUklQVH1cIiBcCg== 145776 2012-06-05 06:10:34 -0700 2012-06-05 08:26:23 -0700 Patch bug-88304-20120605151033.patch text/plain 1558 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZkYWViNjg5MDNhNjA1 NjdkZjk3MTdjN2JjZGEyZjNjNjY0OWM2MS4uNGFhYjBhYmI0MDg3OGZlY2MyYzg1YmQ4NWY2YzM4 MDg5Y2ZmODQ4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2LTA1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XVtXaW5dIEZp eCBJREwgZGVwZW5kZW5jeSBnZW5lcmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04ODMwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMucHJpOgorCiAyMDEyLTA2LTA1ICBD aGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBK U0M6bmVlZCB0byBpbXBsZW1lbnQgRGljdGlvbmFyeTo6Z2V0V2l0aFVuZGVmaW5lZE9yTnVsbENo ZWNrIGZvciBJREIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLnBy aSBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQppbmRleCBlNWY0ODQ0Njk1Mjg2 MjM2MmQ3YjlkYjMyMjNhODIxMzQ2NmQzOWJiLi5kMWMxYTdhZDhiZjNmZTMyOTNlNWQwZDg4Mzc4 YWMwOTQ4NzM4NjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5w cmkKKysrIGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMucHJpCkBAIC02ODIsNyArNjgy LDggQEAgRU9DID0gJCRlc2NhcGVfZXhwYW5kKFxcblxcdCkKIHdpbl9jbWRfc2hlbGw6IHByZXBy b2Nlc3NJZGxzLmNvbW1hbmRzID0gdHlwZSBudWwgPiAkJElETF9GSUxFU19UTVAgJCRFT0MKIGVs c2U6IHByZXByb2Nlc3NJZGxzLmNvbW1hbmRzID0gY2F0IC9kZXYvbnVsbCA+ICQkSURMX0ZJTEVT X1RNUCAkJEVPQwogZm9yKGJpbmRpbmcsIElETF9CSU5ESU5HUykgewotICAgIHByZXByb2Nlc3NJ ZGxzLmNvbW1hbmRzICs9IGVjaG8gJCRiaW5kaW5nID4+ICQkSURMX0ZJTEVTX1RNUCAkJEVPQwor ICAgICMgV2UgbmVlZCAiJCRiaW5kaW5nIiBpbnN0ZWFkIG9mICIkJGJpbmRpbmcgIiwgYmVjYXVz ZSBXaW5kb3dzJyBlY2hvIHdyaXRlcyB0cmFpbGluZyB3aGl0ZXNwYWNlcy4gKGh0dHA6Ly93a2Iu dWcvODgzMDQpCisgICAgcHJlcHJvY2Vzc0lkbHMuY29tbWFuZHMgKz0gZWNobyAkJGJpbmRpbmc+ PiAkJElETF9GSUxFU19UTVAgJCRFT0MKIH0KIHByZXByb2Nlc3NJZGxzLmNvbW1hbmRzICs9IHBl cmwgLUkkJFBXRC9iaW5kaW5ncy9zY3JpcHRzICQkcHJlcHJvY2Vzc0lkbHMuc2NyaXB0IFwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLWRlZmluZXMgXCIkJHtGRUFUVVJFX0RFRklO RVNfSkFWQVNDUklQVH1cIiBcCg==