88302 2012-06-05 01:03:04 -0700 [Qt][Win] Fix linking WTF with ICU 2012-06-07 04:41:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 88300 1 ossy ossy ossy oldest_to_newest 641261 0 ossy 2012-06-05 01:03:04 -0700 Linking WTF fails because of missing ICU libraries. (It seems the lib names are different on Windows.) 641456 1 145768 ossy 2012-06-05 05:33:09 -0700 Created attachment 145768 Patch 641895 2 145768 hausmann 2012-06-05 14:31:59 -0700 Comment on attachment 145768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145768&action=review > Source/WTF/WTF.pri:30 > + win32-*: LIBS += -licuin -licuuc -licudt I think that you can just use win32 instead of win32-*. The former is also what we use in Qt. 643412 3 ossy 2012-06-07 04:40:47 -0700 (In reply to comment #2) > (From update of attachment 145768 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145768&action=review > > > Source/WTF/WTF.pri:30 > > + win32-*: LIBS += -licuin -licuuc -licudt > > I think that you can just use win32 instead of win32-*. The former is also what we use in Qt. Good point. Fixed patch landed in http://trac.webkit.org/changeset/119704 145768 2012-06-05 05:33:09 -0700 2012-06-07 04:41:00 -0700 Patch bug-88302-20120605143308.patch text/plain 1198 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMxZTkxMzY5NjMzMmRkZjI1ZjgxN2U2 Yzg5YTMzMDAyMTE4MDNiZTcuLjEyZDBmNjdjZTMzZTIyMGIzYjU3ZDA3NDIwYTNlNTBkYWRiNzhh MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMDUgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dpbl0gRml4IGxpbmtpbmcgV1RGIHdp dGggSUNVCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 ODMwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V1RGLnByaTogVXNlIHByb3BlciBsaWJyYXJ5IG5hbWVzIG9uIHdpbjMyLSogcGxhdGZvcm1zLgor CiAyMDEyLTA2LTA0ICBUYWthc2hpIFRveW9zaGltYSAgPHRveW9zaGltQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbV2ViU29ja2V0XSBTZW5kIHJlcXVpcmVzIHN1cGVyIGxpbmVhciB0aW1lIGFn YWluc3QgZGF0YSBzaXplCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL1dURi5wcmkgYi9Tb3VyY2Uv V1RGL1dURi5wcmkKaW5kZXggMzQzYjU5MmY2ZGYyMDRlZDkyN2QwZjM4MjQzNzJlNGZkMzNkMjM2 MC4uMzJkYWY5MzE2M2E1ZTBjMjZhNzVkNGRmNWU4YzA4MzBmYjEwNDAyMiAxMDA2NDQKLS0tIGEv U291cmNlL1dURi9XVEYucHJpCisrKyBiL1NvdXJjZS9XVEYvV1RGLnByaQpAQCAtMjcsNyArMjcs OCBAQCBoYXZlUXQoNSkgewogICAgICAgICBMSUJTICs9IC1saWN1Y29yZQogICAgIH0gZWxzZSB7 CiAgICAgICAgIGNvbnRhaW5zKFFUX0NPTkZJRyxpY3UpIHsKLSAgICAgICAgICAgIExJQlMgKz0g LWxpY3VpMThuIC1saWN1dWMgLWxpY3VkYXRhCisgICAgICAgICAgICB3aW4zMi0qOiBMSUJTICs9 IC1saWN1aW4gLWxpY3V1YyAtbGljdWR0CisgICAgICAgICAgICBlbHNlOiBMSUJTICs9IC1saWN1 aTE4biAtbGljdXVjIC1saWN1ZGF0YQogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgZXJy b3IoIlRvIGJ1aWxkIFF0V2ViS2l0IHdpdGggUXQgNSB5b3UgbmVlZCBJQ1UiKQogICAgICAgICB9 Cg==