8823 2006-05-10 00:53:45 -0700 SVG does not support tabbing navigation between web page links 2010-04-27 12:14:42 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED WORKSFORME http://www.peepo.co.uk HasReduction, Regression P2 Normal --- 14027 10849 1 jay webkit-unassigned emacemac7 eric harrison ian mrowe oliver oldest_to_newest 41837 0 jay 2006-05-10 00:53:45 -0700 keyboard support for SVG withing webkit Safari is currently broken Reproducible: Always Steps to Reproduce: 1.open URI 2.try to navigate through the homepage using the keyboard 'tab' or other key 3. Actual Results: tab key onkeydown not recognised Expected Results: focus should change to next anchor It should be possible to cycle through the links on any SVG page as one can with HTML using a keyboard 41889 1 eric 2006-05-10 10:37:09 -0700 Yeah, this just hasn't been wired up yet. Definitely a bug. 47865 2 jay 2006-06-30 13:38:27 -0700 although http://www.peepo.co.uk tabbing works in Mozilla, this is itself a bug :-) please use http://www.peepo.co.uk/index-opera.svg. simply the second tabs to anchors, whereas mozilla uses groups. Erik@Opera kindly pointed suggested anchors was correct. 55350 3 10522 eric 2006-09-12 23:11:13 -0700 Created attachment 10522 A partial patch This patch gets us part of the way there. It doesn't seem to work quite right yet though. I have not debugged why. Even once we make SVGAElement's focusable, we'll have to find a way to draw the css outline property, as that's how WebKit does the link focusing. 19388 4 13594 jay 2007-03-12 10:34:10 -0700 Created attachment 13594 reduced testcase 18045 5 jay 2007-03-20 09:54:08 -0700 olliej & harrison, apologies for copying you in on this bug, it's SVG & Accessibility. I understand you're all tied up on P1s. keyboard accessibility is essential. 18046 6 mrowe 2007-03-20 09:56:30 -0700 I don't think this needs to be a P1. 18047 7 jay 2007-03-20 10:04:52 -0700 #6 bdash, evidently you're not blind, and also in control of a mouse. http://www.w3.org/TR/SVG-access/#events http://www.w3.org/TR/WAI-WEBCONTENT-TECHS/#def-device-independent 18048 8 mrowe 2007-03-20 10:12:41 -0700 Actually I lack a mouse. That's besides the point though. The normal criteria for determining whether something qualifies as a P1 is if it is a crash, security problem, regression, obvious rendering issue, or a bug that affect major sites. 18049 9 jay 2007-03-20 10:14:06 -0700 The attachment works in Opera, Camino and Mozilla 8375 10 14889 eric 2007-06-06 13:41:34 -0700 Created attachment 14889 Updated (complete) patch 8379 11 14891 eric 2007-06-06 14:17:42 -0700 Created attachment 14891 automated layout test (hits ASSERT in WebView) 8380 12 eric 2007-06-06 14:18:35 -0700 This is the backtrace for the ASSERT which is tripped by this layout test: #0 0x0026426c in -[WebView becomeFirstResponder] at WebView.mm:2251 #1 0x932cc483 in -[NSWindow makeFirstResponder:] #2 0x93380fef in -[NSWindow selectKeyViewFollowingView:] #3 0x002951d8 in WebChromeClient::takeFocus at WebChromeClient.mm:119 #4 0x013efedb in WebCore::Chrome::takeFocus at Chrome.cpp:85 #5 0x0143227f in WebCore::FocusController::advanceFocus at FocusController.cpp:155 #6 0x0143253c in WebCore::FocusController::advanceFocus at FocusController.cpp:112 #7 0x002477d2 in -[WebHTMLView becomeFirstResponder] at WebHTMLView.mm:3142 #8 0x932cc483 in -[NSWindow makeFirstResponder:] #9 0x9344fcd3 in -[NSClipView becomeFirstResponder] #10 0x932cc483 in -[NSWindow makeFirstResponder:] #11 0x9344fc34 in -[NSScrollView becomeFirstResponder] #12 0x932cc483 in -[NSWindow makeFirstResponder:] #13 0x0025a8f3 in -[WebFrameView becomeFirstResponder] at WebFrameView.mm:391 #14 0x932cc483 in -[NSWindow makeFirstResponder:] #15 0x002643a8 in -[WebView becomeFirstResponder] at WebView.mm:2275 #16 0x932cc483 in -[NSWindow makeFirstResponder:] #17 0x93380fef in -[NSWindow selectKeyViewFollowingView:] #18 0x002951d8 in WebChromeClient::takeFocus at WebChromeClient.mm:119 #19 0x013efedb in WebCore::Chrome::takeFocus at Chrome.cpp:85 #20 0x0143227f in WebCore::FocusController::advanceFocus at FocusController.cpp:155 #21 0x0143253c in WebCore::FocusController::advanceFocus at FocusController.cpp:112 #22 0x014083e1 in WebCore::EventHandler::defaultTabEventHandler at EventHandler.cpp:1681 #23 0x01409463 in WebCore::EventHandler::defaultKeyboardEventHandler at EventHandler.cpp:1419 #24 0x01239c99 in WebCore::EventTargetNode::defaultEventHandler at EventTargetNode.cpp:583 #25 0x01237fc4 in WebCore::EventTargetNode::dispatchGenericEvent at EventTargetNode.cpp:267 #26 0x01239909 in WebCore::EventTargetNode::dispatchEvent at EventTargetNode.cpp:308 #27 0x0106041d in WebCore::SVGElement::dispatchEvent at SVGElement.cpp:237 #28 0x01409350 in WebCore::EventHandler::defaultKeyboardEventHandler at EventHandler.cpp:1409 #29 0x01239c99 in WebCore::EventTargetNode::defaultEventHandler at EventTargetNode.cpp:583 #30 0x01237fc4 in WebCore::EventTargetNode::dispatchGenericEvent at EventTargetNode.cpp:267 #31 0x01239909 in WebCore::EventTargetNode::dispatchEvent at EventTargetNode.cpp:308 #32 0x0106041d in WebCore::SVGElement::dispatchEvent at SVGElement.cpp:237 #33 0x01238f3a in WebCore::EventTargetNode::dispatchKeyEvent at EventTargetNode.cpp:370 #34 0x014081a4 in WebCore::EventHandler::keyEvent at EventHandler.cpp:1375 #35 0x01405265 in WebCore::EventHandler::keyEvent at EventHandlerMac.mm:138 #36 0x0023f128 in -[WebHTMLView keyDown:] at WebHTMLView.mm:3419 #37 0x00004dad in -[EventSendingController keyDown:withModifiers:] at EventSendingController.m:367 #38 0x90a5ac56 in objc_msgSendv #39 0x927f53b2 in -[NSInvocation invoke] #40 0x003e1486 in KJS::Bindings::ObjcInstance::invokeMethod at objc_instance.mm:187 #41 0x003dcfd5 in KJS::RuntimeMethod::callAsFunction at runtime_method.cpp:89 #42 0x0041e24e in KJS::JSObject::call at object.cpp:98 #43 0x0044773d in KJS::FunctionCallDotNode::evaluate at nodes.cpp:790 #44 0x00444e93 in KJS::ExprStatementNode::execute at nodes.cpp:1723 #45 0x00444d9d in KJS::IfNode::execute at nodes.cpp:1742 #46 0x00442176 in KJS::SourceElementsNode::execute at nodes.cpp:2528 #47 0x0041adb4 in KJS::BlockNode::execute at nodes.cpp:1699 #48 0x0043f301 in KJS::Interpreter::evaluate at interpreter.cpp:365 #49 0x0127901f in WebCore::KJSProxy::evaluate at kjs_proxy.cpp:78 #50 0x013df4bb in WebCore::FrameLoader::executeScript at FrameLoader.cpp:712 #51 0x0102cd6f in WebCore::XMLTokenizer::endElementNs at XMLTokenizer.cpp:753 #52 0x0102ce07 in endElementNsHandler at XMLTokenizer.cpp:985 #53 0x91bff515 in xmlParseNotationDecl #54 0x91be4d86 in xmlParseChunk #55 0x0102be90 in WebCore::XMLTokenizer::write at XMLTokenizer.cpp:566 #56 0x013d4075 in WebCore::FrameLoader::write at FrameLoader.cpp:927 #57 0x013d41a7 in WebCore::FrameLoader::addData at FrameLoader.cpp:1583 #58 0x01102a01 in -[WebCoreFrameBridge addData:] at WebCoreFrameBridge.mm:288 #59 0x01105b9c in -[WebCoreFrameBridge receivedData:textEncodingName:] at WebCoreFrameBridge.mm:1427 #60 0x00233245 in -[WebHTMLRepresentation receivedData:withDataSource:] at WebHTMLRepresentation.mm:173 #61 0x0022e73b in -[WebDataSource(WebInternal) _receivedData:] at WebDataSource.mm:176 #62 0x002917c5 in WebFrameLoaderClient::committedLoad at WebFrameLoaderClient.mm:658 #63 0x013d0f6b in WebCore::FrameLoader::committedLoad at FrameLoader.cpp:3027 #64 0x013e1acd in WebCore::DocumentLoader::commitLoad at DocumentLoader.cpp:347 #65 0x013e1b26 in WebCore::DocumentLoader::receivedData at DocumentLoader.cpp:359 #66 0x013d0465 in WebCore::FrameLoader::receivedData at FrameLoader.cpp:2039 #67 0x013e33f0 in WebCore::MainResourceLoader::addData at MainResourceLoader.cpp:133 #68 0x013e5599 in WebCore::ResourceLoader::didReceiveData at ResourceLoader.cpp:208 #69 0x013e3725 in WebCore::MainResourceLoader::didReceiveData at MainResourceLoader.cpp:289 #70 0x013e51a0 in WebCore::ResourceLoader::didReceiveData at ResourceLoader.cpp:330 #71 0x013c0100 in -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] at ResourceHandleMac.mm:351 #72 0x92854afa in -[NSURLConnection(NSURLConnectionInternal) _sendDidReceiveDataCallback] #73 0x92852ddb in -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] #74 0x92852ab5 in _sendCallbacks #75 0x9082bf92 in CFRunLoopRunSpecific #76 0x9082bace in CFRunLoopRunInMode #77 0x92823d3a in -[NSRunLoop runMode:beforeDate:] #78 0x0000b09d in runTest at DumpRenderTree.m:1458 #79 0x00006f7e in dumpRenderTree at DumpRenderTree.m:526 #80 0x000071e6 in main at DumpRenderTree.m:572 8382 13 eric 2007-06-06 14:22:52 -0700 I'm betting that the implementation of static Node* deepFocusableNode(FocusDirection direction, Node* node, KeyboardEvent* event) in FocusController is our problem. It seems to be looking for a HTMLFrameOwnerElement, which I doubt an SVG document has. 8384 14 eric 2007-06-06 15:01:35 -0700 If I make it send option-\t instead, it doesn't hit the ASSERT (but it also fails the test). option-\t is required in my Safari browser, I guess because I don't have some preference turned on to allow link-tabbing. I'm not sure which preference is on in DRT. I believe it's hitting the ASSERT because it's not able to find any node which responds yes to isKeyboardFocusable (which makes sense, because they all respond "NO" when keyboard tabbing it turned off). It doesn't seem that the focus code is prepared for this eventuality however. 8188 15 eric 2007-06-07 10:39:53 -0700 *** Bug 12631 has been marked as a duplicate of this bug. *** 8183 16 eric 2007-06-07 10:44:02 -0700 Ha! Turns out that this is not an SVG bug after all. This happens with xhtml documents too! I've filed bug 14027 to track the ASSERT/crash. 8170 17 eric 2007-06-07 11:22:13 -0700 To clarify: The patch still stands for review. It can be landed. We just can't land the layout test until bug 14027 is fixed. 8108 18 14889 oliver 2007-06-08 02:26:19 -0700 Comment on attachment 14889 Updated (complete) patch r=me 8109 19 eric 2007-06-08 02:29:56 -0700 Landed on feature branch as r22066. 455 20 jay 2007-09-15 01:33:51 -0700 I don't seem to have received an email regarding this having been "fixed" however, using Safari 3.0.3 webkit r25571 seems totally broken. 453 21 oliver 2007-09-15 02:11:15 -0700 This has been fixed in the feature branch (r22066) 454 22 jay 2007-09-15 02:30:08 -0700 #21 how about a link? when will the 'feature' branch enter the trunk? the comments so far fall short of being helpful to the bug reporter cheers 452 23 oliver 2007-09-15 02:37:42 -0700 The bug is fixed, if you checkout the feature branch you can verify that it is fixed. There is no date we can provide for when the feature branch will be merged into trunk, nor when a subsequent release will occur. All that matters is that the bug is fixed, and will eventually end up in a release. 451 24 jay 2007-09-15 05:47:13 -0700 #23 Oliver wrote "checkout the feature branch" however this isn't a link, let alone a method. a search with google provided no further information. is there a build, or is this cvs only? where is it? as the bug reporter, it's hard for me to agree this is 'fixed' without further information. also iirc it is quite usual for developers to consider a bug fixed, when in fact the reporter is not of the same opinion.... 450 25 mrowe 2007-09-15 06:10:57 -0700 Jay, you can check out and build the feature branch in a similar manner to the normal (eg, trunk) build process. Follow the instructions starting from <http://webkit.org/building/checkout.html>, but replace the step that says: svn checkout http://svn.webkit.org/repository/webkit/trunk WebKit with: svn checkout http://svn.webkit.org/repository/webkit/branches/feature-branch WebKit Then if you follow the build steps through to completion, you will have a built copy of WebKit from the feature branch which contains the fix for this issue. 447 26 jay 2007-09-15 13:50:28 -0700 #25 cheers Mark, well all went okay till build, ran for a short while and then: .... CompileC /Users/Jay/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/ppc/WebCoreAXObject.o /Users/Jay/WebKit/WebCore/bridge/mac/WebCoreAXObject.mm normal ppc objective-c++ com.apple.compilers.gcc.4_0 cd /Users/Jay/WebKit/WebCore /usr/bin/gcc-4.0 -x objective-c++ -arch ppc -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fobjc-exceptions -fpascal-strings -fasm-blocks -O2 -Werror -Wnon-virtual-dtor -Wnewline-eof -DNDEBUG -DENABLE_SVG -DENABLE_SVG_EXPERIMENTAL_FEATURES -DENABLE_XPATH -DENABLE_XSLT -DENABLE_VIDEO -fmessage-length=0 -fobjc-direct-dispatch -fobjc-gc -mtune=G5 -fvisibility-inlines-hidden -fno-threadsafe-statics -mmacosx-version-min=10.4 -gdwarf-2 -I/Users/Jay/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore.hmap -Wall -W -Wcast-align -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-format-y2k -Wno-unused-parameter -Wno-long-double -Wundef -Wshorten-64-to-32 -F/Users/Jay/WebKit/WebKitBuild/Release -I/Users/Jay/WebKit/WebKitBuild/Release/include -IForwardingHeaders -Iicu -I/usr/include/libxslt -I/usr/include/libxml2 -I/Users/Jay/WebKit/WebKitBuild/Release/DerivedSources/WebCore -I/Users/Jay/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources -include /Library/Caches/com.apple.Xcode.501/SharedPrecompiledHeaders/WebCorePrefix-emjzgmqqjsmxpbcgzxwibfbkfkom/WebCorePrefix.h -c /Users/Jay/WebKit/WebCore/bridge/mac/WebCoreAXObject.mm -o /Users/Jay/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/ppc/WebCoreAXObject.o /Users/Jay/WebKit/WebCore/bridge/mac/WebCoreAXObject.mm: In function 'BOOL -[WebCoreAXObject accessibilityIsIgnored](WebCoreAXObject*, objc_selector*)': /Users/Jay/WebKit/WebCore/bridge/mac/WebCoreAXObject.mm:820: internal compiler error: Bus error Please submit a full bug report, with preprocessed source if appropriate. See <URL:http://developer.apple.com/bugreporter> for instructions. {standard input}:11105:FATAL:.abort detected. Assembly stopping. ** BUILD FAILED ** jay:~ Jay$ 117894 27 jay 2009-04-17 04:47:34 -0700 I had thought the 'feature' branch was discontinued. what is the delay? any clues please? regards 117911 28 eric 2009-04-17 07:53:28 -0700 It would appear this regressed. 119319 29 14889 eric 2009-04-29 13:06:27 -0700 Comment on attachment 14889 Updated (complete) patch Clearing review bit so it's out of the review queue. 119341 30 jay 2009-04-29 14:15:48 -0700 #29 eric could you clarify, please. does this comment suggest that your patch doesn't need reviewing? or perhaps that this bug doesn't need reviewing for the next 'landing'? or something else? cheers 119342 31 eric 2009-04-29 14:19:06 -0700 (In reply to comment #30) > #29 eric could you clarify, please. The code is already in the tree. We never landed (aka committed) the layout test because of bug 14027. Our behavior regressed (which could have been avoided had we landed the layout test as well). Eventually someone will get around to fixing this again. 119740 32 eric 2009-05-03 15:38:44 -0700 turns out our navigation is just fine. It's just that our repaint rects do not include the outline (thus it's never painted). 217794 33 jay 2010-04-27 11:04:31 -0700 eric, what's the status on this bug? 10522 2006-09-12 23:11:13 -0700 2007-06-06 13:41:34 -0700 A partial patch partial.patch text/plain 2626 eric SW5kZXg6IGtzdmcyL3N2Zy9TVkdBRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga3N2ZzIvc3Zn L1NWR0FFbGVtZW50LmNwcAkocmV2aXNpb24gMTYzMzgpCisrKyBrc3ZnMi9zdmcvU1ZHQUVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAsNiArMTEwLDQyIEBAIHZvaWQgU1ZHQUVsZW1l bnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXYKICAgICBTVkdTdHlsZWRUcmFuc2Zvcm1hYmxlRWxl bWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihldnQpOwogfQogCitib29sIFNWR0FFbGVtZW50Ojpz dXBwb3J0c0ZvY3VzKCkgY29uc3QKK3sKKyAgICBpZiAoaXNDb250ZW50RWRpdGFibGUoKSkKKyAg ICAgICAgcmV0dXJuIFNWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50OjpzdXBwb3J0c0ZvY3Vz KCk7CisgICAgcmV0dXJuIGlzRm9jdXNhYmxlKCkgfHwgKGRvY3VtZW50KCkgJiYgIWRvY3VtZW50 KCktPmhhdmVTdHlsZXNoZWV0c0xvYWRlZCgpKTsKK30KKworYm9vbCBTVkdBRWxlbWVudDo6aXNG b2N1c2FibGUoKSBjb25zdAoreworICAgIGlmIChpc0NvbnRlbnRFZGl0YWJsZSgpKQorICAgICAg ICByZXR1cm4gU1ZHU3R5bGVkVHJhbnNmb3JtYWJsZUVsZW1lbnQ6OmlzRm9jdXNhYmxlKCk7Cisg ICAgCisgICAgLy8gRklYTUU6IEV2ZW4gaWYgd2UgYXJlIG5vdCB2aXNpYmxlLCB3ZSBtaWdodCBo YXZlIGEgY2hpbGQgdGhhdCBpcyB2aXNpYmxlLgorICAgIC8vIERhdmUgd2FudHMgdG8gZml4IHRo YXQgc29tZSBkYXkgd2l0aCBhICJoYXMgdmlzaWJsZSBjb250ZW50IiBmbGFnIG9yIHRoZSBsaWtl LgorICAgIGlmICghKHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+c3R5bGUoKS0+dmlzaWJpbGl0 eSgpID09IFZJU0lCTEUpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgCisgICAgcmV0dXJu ICFyZW5kZXJlcigpLT5nZXRBYnNvbHV0ZVJlcGFpbnRSZWN0KCkuaXNFbXB0eSgpOworfQorCiti b29sIFNWR0FFbGVtZW50Ojppc01vdXNlRm9jdXNhYmxlKCkgY29uc3QKK3sKKyAgICByZXR1cm4g ZmFsc2U7Cit9CisKK2Jvb2wgU1ZHQUVsZW1lbnQ6OmlzS2V5Ym9hcmRGb2N1c2FibGUoKSBjb25z dAoreworICAgIGlmICghaXNGb2N1c2FibGUoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAg IAorICAgIGlmICghZG9jdW1lbnQoKS0+ZnJhbWUoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIAorICAgIHJldHVybiBkb2N1bWVudCgpLT5mcmFtZSgpLT50YWJzVG9MaW5rcygpOworfQor CiB9CiAKIC8vIHZpbTp0cz00Om5vZXQKSW5kZXg6IGtzdmcyL3N2Zy9TVkdBRWxlbWVudC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGtzdmcyL3N2Zy9TVkdBRWxlbWVudC5oCShyZXZpc2lvbiAxNjMzOCkKKysr IGtzdmcyL3N2Zy9TVkdBRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00NSwxMyArNDUsMTgg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAvLyAnU1ZHQUVsZW1lbnQnIGZ1bmN0aW9u cwogICAgICAgICB2aXJ0dWFsIGJvb2wgaXNWYWxpZCgpIGNvbnN0IHsgcmV0dXJuIFNWR1Rlc3Rz Ojppc1ZhbGlkKCk7IH0KIAotICAgICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1 dGUoTWFwcGVkQXR0cmlidXRlICphdHRyKTsKKyAgICAgICAgdmlydHVhbCB2b2lkIHBhcnNlTWFw cGVkQXR0cmlidXRlKE1hcHBlZEF0dHJpYnV0ZSopOwogCiAgICAgICAgIC8vIERlcml2ZWQgZnJv bTogJ1NWR1N0eWxlZEVsZW1lbnQnCi0gICAgICAgIHZpcnR1YWwgYm9vbCByZW5kZXJlcklzTmVl ZGVkKFJlbmRlclN0eWxlICpzdHlsZSkgeyByZXR1cm4gU3R5bGVkRWxlbWVudDo6cmVuZGVyZXJJ c05lZWRlZChzdHlsZSk7IH0KLSAgICAgICAgdmlydHVhbCBSZW5kZXJPYmplY3QgKmNyZWF0ZVJl bmRlcmVyKFJlbmRlckFyZW5hICphcmVuYSwgUmVuZGVyU3R5bGUgKnN0eWxlKTsKKyAgICAgICAg dmlydHVhbCBib29sIHJlbmRlcmVySXNOZWVkZWQoUmVuZGVyU3R5bGUqIHN0eWxlKSB7IHJldHVy biBTdHlsZWRFbGVtZW50OjpyZW5kZXJlcklzTmVlZGVkKHN0eWxlKTsgfQorICAgICAgICB2aXJ0 dWFsIFJlbmRlck9iamVjdCAqY3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqLCBSZW5kZXJTdHls ZSopOwogCi0gICAgICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50ICpl dnQpOworICAgICAgICB2aXJ0dWFsIHZvaWQgZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCopOwor ICAgICAgICAKKyAgICAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzRm9jdXMoKSBjb25zdDsKKyAg ICAgICAgdmlydHVhbCBib29sIGlzTW91c2VGb2N1c2FibGUoKSBjb25zdDsKKyAgICAgICAgdmly dHVhbCBib29sIGlzS2V5Ym9hcmRGb2N1c2FibGUoKSBjb25zdDsKKyAgICAgICAgdmlydHVhbCBi b29sIGlzRm9jdXNhYmxlKCkgY29uc3Q7CiAKICAgICBwcm90ZWN0ZWQ6CiAgICAgICAgIHZpcnR1 YWwgY29uc3QgU1ZHRWxlbWVudCogY29udGV4dEVsZW1lbnQoKSBjb25zdCB7IHJldHVybiB0aGlz OyB9Cg== 13594 2007-03-12 10:34:10 -0700 2007-03-12 10:34:10 -0700 reduced testcase css-events-opera.svg image/svg+xml 1220 jay PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiIHN0YW5kYWxvbmU9Im5vIj8+Cjxz dmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIgogICAgIHhtbG5zOnhsaW5rPSJo dHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIgp3aWR0aD0iMTAwJSIgaGVpZ2h0PSIxMDAlIgo+ CjxkZWZzPgoKPHN0eWxlIHR5cGU9InRleHQvY3NzIiBpZD0iY3NzIj48IVtDREFUQVsKdGV4dCB7 CiAgZm9udC1mYW1pbHk6IGNvbWljLXNhbnM7CiAgdGV4dC1hbmNob3I6IGxlZnQ7CiAgICBmaWxs OiBub25lOwpmb250LXNpemU6IDUuMGVtOyAKICB9CgoKLnN0IHtmaWxsOiBub25lO30KYTpob3Zl ciB0ZXh0IHsgZmlsbDogIzY2NjsgfQphOmhvdmVyIGNpcmNsZS5ydCB7IGZpbGw6ICNmZmY7IH0K YTpob3ZlciBjaXJjbGUuc3QgeyBmaWxsOiAjMGYwOyB9CmE6Zm9jdXMgdGV4dCB7IGZpbGw6ICM2 NjY7IH0KYTpmb2N1cyBjaXJjbGUucnQgeyBmaWxsOiAjZmZmOyB9CmE6Zm9jdXMgY2lyY2xlLnN0 IHsgZmlsbDogIzBmMDsgfQpdXT48L3N0eWxlPgo8L2RlZnM+CjxnID4KPHJlY3QgeD0iMCIgeT0i MCIgd2lkdGg9IjEwMCUiIGhlaWdodD0iMTAwJSIgZmlsbD0iI2NjYSIgc3Ryb2tlPSJub25lIiBp ZD0ibWVudUJHIiAvPgo8ZyBpZD0ibGluayAxIiA+PHRpdGxlPm11c2ljPC90aXRsZT4gCiA8YSAg eGxpbms6aHJlZj0iaHR0cDovL3d3dy5wZWVwby5jby51ay9sYXVuY2gvbXVzaWMuc3ZnIiBpZD0i bGluazEiPgogIDxjaXJjbGUgY3g9IjkwIiBjeT0iMTU1IiByPSI0OCIgZmlsbD0icmVkIiBjbGFz cz0icnQiIC8+CiAgPGNpcmNsZSBjeD0iMTAwIiBjeT0iMTU1IiByPSI0OCIgZmlsbD0ibm9uZSIg Y2xhc3M9InN0IiAvPgoKICA8dGV4dCB4PSIxMzAiIHk9IjY1Ij5nYW1lczwvdGV4dD4KIDwvYT48 L2c+CjxnIGlkPSJsaW5rIDIiIHg9IjEyMCI+PHRpdGxlPmdhbWVzPC90aXRsZT4gCiA8YSAgeGxp bms6aHJlZj0iaHR0cDovL3d3dy5wZWVwby5jby51ay9sYXVuY2gvZ2FtZXMuc3ZnIiBpZD0ibGlu azIiID4KICA8Y2lyY2xlIGN4PSIzOTAiIGN5PSIxNzUiIHI9IjQ4IiBmaWxsPSJ5ZWxsb3ciIGNs YXNzPSJydCIgLz4KICA8Y2lyY2xlIGN4PSI0MDAiIGN5PSIxNzUiIHI9IjQ4IiBmaWxsPSJub25l IiBjbGFzcz0ic3QiLz4KCiAgPHRleHQgICB4PSIxMzAiIHk9IjY1Ij5tdXNpY2FsPC90ZXh0Pgog PC9hPjwvZz4KPC9nPgogCjwvc3ZnPgo= 14889 2007-06-06 13:41:34 -0700 2009-04-29 13:06:27 -0700 Updated (complete) patch links.patch text/plain 4186 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDMy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDctMDYt MDYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciB0YWJiaW5nIGJldHdl ZW4gbGlua3MgaW4gYW4gU1ZHIGZpbGUKKyAgICAgICAgQWxzbyBhZGQgc3VwcG9ydCBmb3IgZHJh d2luZyBhIGZvY3VzIHJpbmcgYXJvdW5kIGZvY3VzZWQgc3ZnIGNvbnRlbnQuCisgICAgICAgIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MjMKKworICAgICAgICAqIGNz cy9zdmcuY3NzOgorICAgICAgICAqIGtzdmcyL3N2Zy9TVkdBRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTVkdBRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6CisgICAgICAgIChX ZWJDb3JlOjpTVkdBRWxlbWVudDo6c3VwcG9ydHNGb2N1cyk6CisgICAgICAgIChXZWJDb3JlOjpT VkdBRWxlbWVudDo6aXNGb2N1c2FibGUpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQUVsZW1lbnQ6 OmlzTW91c2VGb2N1c2FibGUpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQUVsZW1lbnQ6OmlzS2V5 Ym9hcmRGb2N1c2FibGUpOgorICAgICAgICAqIGtzdmcyL3N2Zy9TVkdBRWxlbWVudC5oOgorCiAy MDA3LTA2LTA2ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBvbGxpZWouCkluZGV4OiBjc3Mvc3ZnLmNzcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjc3Mvc3Zn LmNzcwkocmV2aXNpb24gMjIwMjgpCisrKyBjc3Mvc3ZnLmNzcwkod29ya2luZyBjb3B5KQpAQCAt NTMsMyArNTMsOSBAQCB0ZXh0LCBmb3JlaWduT2JqZWN0IHsKIHRleHQsIHRzcGFuLCB0ZXh0UGF0 aCB7CiAgICB3aGl0ZS1zcGFjZTogbm93cmFwCiB9CisKKy8qIHN0YXRlcyAqLworCis6Zm9jdXMg eworICAgIG91dGxpbmU6IGF1dG8gNXB4IC13ZWJraXQtZm9jdXMtcmluZy1jb2xvcgorfQpJbmRl eDoga3N2ZzIvc3ZnL1NWR0FFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBrc3ZnMi9zdmcvU1ZH QUVsZW1lbnQuY3BwCShyZXZpc2lvbiAyMjAyOCkKKysrIGtzdmcyL3N2Zy9TVkdBRWxlbWVudC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcgQEAKIAogI2luY2x1ZGUgIkF0dHIuaCIK ICNpbmNsdWRlICJEb2N1bWVudC5oIgorI2luY2x1ZGUgIkV2ZW50SGFuZGxlci5oIgogI2luY2x1 ZGUgIkV2ZW50TmFtZXMuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9h ZGVyLmgiCkBAIC05OCw3ICs5OSw2IEBAIFJlbmRlck9iamVjdCogU1ZHQUVsZW1lbnQ6OmNyZWF0 ZVJlbmRlcmUKIAogdm9pZCBTVkdBRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCog ZXZ0KQogewotICAgIC8vIFRPRE8gOiBzaG91bGQgdXNlIENMSUNLIGluc3RlYWQKICAgICBpZiAo bV9pc0xpbmsgJiYgKGV2dC0+dHlwZSgpID09IGNsaWNrRXZlbnQgfHwgKGV2dC0+dHlwZSgpID09 IGtleWRvd25FdmVudCAmJiBtX2ZvY3VzZWQpKSkgewogICAgICAgICBNb3VzZUV2ZW50KiBlID0g MDsKICAgICAgICAgaWYgKGV2dC0+dHlwZSgpID09IGNsaWNrRXZlbnQgJiYgZXZ0LT5pc01vdXNl RXZlbnQoKSkKQEAgLTE0Myw2ICsxNDMsNDIgQEAgdm9pZCBTVkdBRWxlbWVudDo6ZGVmYXVsdEV2 ZW50SGFuZGxlcihFdgogICAgIFNWR1N0eWxlZFRyYW5zZm9ybWFibGVFbGVtZW50OjpkZWZhdWx0 RXZlbnRIYW5kbGVyKGV2dCk7CiB9CiAKK2Jvb2wgU1ZHQUVsZW1lbnQ6OnN1cHBvcnRzRm9jdXMo KSBjb25zdAoreworICAgIGlmIChpc0NvbnRlbnRFZGl0YWJsZSgpKQorICAgICAgICByZXR1cm4g U1ZHU3R5bGVkVHJhbnNmb3JtYWJsZUVsZW1lbnQ6OnN1cHBvcnRzRm9jdXMoKTsKKyAgICByZXR1 cm4gaXNGb2N1c2FibGUoKSB8fCAoZG9jdW1lbnQoKSAmJiAhZG9jdW1lbnQoKS0+aGF2ZVN0eWxl c2hlZXRzTG9hZGVkKCkpOworfQorCitib29sIFNWR0FFbGVtZW50Ojppc0ZvY3VzYWJsZSgpIGNv bnN0Cit7CisgICAgaWYgKGlzQ29udGVudEVkaXRhYmxlKCkpCisgICAgICAgIHJldHVybiBTVkdT dHlsZWRUcmFuc2Zvcm1hYmxlRWxlbWVudDo6aXNGb2N1c2FibGUoKTsKKyAgICAKKyAgICAvLyBG SVhNRTogRXZlbiBpZiB3ZSBhcmUgbm90IHZpc2libGUsIHdlIG1pZ2h0IGhhdmUgYSBjaGlsZCB0 aGF0IGlzIHZpc2libGUuCisgICAgLy8gRGF2ZSB3YW50cyB0byBmaXggdGhhdCBzb21lIGRheSB3 aXRoIGEgImhhcyB2aXNpYmxlIGNvbnRlbnQiIGZsYWcgb3IgdGhlIGxpa2UuCisgICAgaWYgKCFy ZW5kZXJlcigpIHx8ICEocmVuZGVyZXIoKS0+c3R5bGUoKS0+dmlzaWJpbGl0eSgpID09IFZJU0lC TEUpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgCisgICAgcmV0dXJuICFyZW5kZXJlcigp LT5hYnNvbHV0ZUNsaXBwZWRPdmVyZmxvd1JlY3QoKS5pc0VtcHR5KCk7Cit9CisKK2Jvb2wgU1ZH QUVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUoKSBjb25zdAoreworICAgIHJldHVybiBmYWxzZTsK K30KKworYm9vbCBTVkdBRWxlbWVudDo6aXNLZXlib2FyZEZvY3VzYWJsZShLZXlib2FyZEV2ZW50 KiBldmVudCkgY29uc3QKK3sKKyAgICBpZiAoIWlzRm9jdXNhYmxlKCkpCisgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICAKKyAgICBpZiAoIWRvY3VtZW50KCktPmZyYW1lKCkpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAKKyAgICByZXR1cm4gZG9jdW1lbnQoKS0+ZnJhbWUoKS0+ZXZlbnRI YW5kbGVyKCktPnRhYnNUb0xpbmtzKGV2ZW50KTsKK30KKwogYm9vbCBTVkdBRWxlbWVudDo6Y2hp bGRTaG91bGRDcmVhdGVSZW5kZXJlcihOb2RlKiBjaGlsZCkgY29uc3QKIHsKICAgICBpZiAoc3Rh dGljX2Nhc3Q8U1ZHRWxlbWVudCo+KHBhcmVudCgpKS0+aXNUZXh0Q29udGVudCgpKQpJbmRleDog a3N2ZzIvc3ZnL1NWR0FFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga3N2ZzIvc3ZnL1NWR0FFbGVt ZW50LmgJKHJldmlzaW9uIDIyMDI4KQorKysga3N2ZzIvc3ZnL1NWR0FFbGVtZW50LmgJKHdvcmtp bmcgY29weSkKQEAgLTQ2LDEyICs0NiwxNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAg IAogICAgICAgICB2aXJ0dWFsIFN0cmluZyB0aXRsZSgpIGNvbnN0OwogCi0gICAgICAgIHZpcnR1 YWwgdm9pZCBwYXJzZU1hcHBlZEF0dHJpYnV0ZShNYXBwZWRBdHRyaWJ1dGUgKmF0dHIpOworICAg ICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1dGUoTWFwcGVkQXR0cmlidXRlKik7 CiAKICAgICAgICAgLy8gRGVyaXZlZCBmcm9tOiAnU1ZHU3R5bGVkRWxlbWVudCcKLSAgICAgICAg dmlydHVhbCBSZW5kZXJPYmplY3QgKmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hICphcmVuYSwg UmVuZGVyU3R5bGUgKnN0eWxlKTsKKyAgICAgICAgdmlydHVhbCBSZW5kZXJPYmplY3QqIGNyZWF0 ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiwgUmVuZGVyU3R5bGUqKTsKIAotICAgICAgICB2aXJ0dWFs IHZvaWQgZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCAqZXZ0KTsKKyAgICAgICAgdmlydHVhbCB2 b2lkIGRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqKTsKKyAgICAgICAgCisgICAgICAgIHZpcnR1 YWwgYm9vbCBzdXBwb3J0c0ZvY3VzKCkgY29uc3Q7CisgICAgICAgIHZpcnR1YWwgYm9vbCBpc01v dXNlRm9jdXNhYmxlKCkgY29uc3Q7CisgICAgICAgIHZpcnR1YWwgYm9vbCBpc0tleWJvYXJkRm9j dXNhYmxlKEtleWJvYXJkRXZlbnQqKSBjb25zdDsKKyAgICAgICAgdmlydHVhbCBib29sIGlzRm9j dXNhYmxlKCkgY29uc3Q7CiAKICAgICAgICAgdmlydHVhbCBib29sIGNoaWxkU2hvdWxkQ3JlYXRl UmVuZGVyZXIoTm9kZSopIGNvbnN0OwogCg== 14891 2007-06-06 14:17:42 -0700 2007-06-06 14:17:42 -0700 automated layout test (hits ASSERT in WebView) focus.svg image/svg+xml 653 eric PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KICA8c3R5bGU+CiAgICA6Zm9jdXMgeyBmaWxsOiBi bHVlIH0KICA8L3N0eWxlPgogIAogIDxhIHhsaW5rOmhyZWY9IiNmb28iIG9uZm9jdXM9ImdvdEZv Y3VzKCdmaXJzdCcpIj4KICAgIDxyZWN0IGlkPSJmaXJzdCIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIx MDAiIGZpbGw9InJlZCIgLz4KICA8L2E+CiAgPGEgeGxpbms6aHJlZj0iI2JhciIgb25mb2N1cz0i Z290Rm9jdXMoJ3NlY29uZCcpIj4KICAgIDxyZWN0IGlkPSJzZWNvbmQiIHg9IjExMCIgd2lkdGg9 IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9InJlZCIvPgogIDwvYT4KICAKICA8c2NyaXB0PgogICAg PCFbQ0RBVEFbCiAgICAgIGZ1bmN0aW9uIGdvdEZvY3VzKG5hbWUpIHsKICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZChuYW1lKS5zdHlsZS5maWxsID0gJ2dyZWVuJzsKICAgICAgfQogICAg CiAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJmaXJzdCIpLmZvY3VzKCk7CiAgICAgIGlm ICh3aW5kb3cuZXZlbnRTZW5kZXIpCiAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bignXHQnKTsK ICAgIF1dPgogIDwvc2NyaXB0Pgo8L3N2Zz4=