88044 2012-05-31 21:35:09 -0700 [Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order. 2012-06-01 02:41:14 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80009 1 yosin yosin tkent webkit.review.bot oldest_to_newest 638957 0 yosin 2012-05-31 21:35:09 -0700 There is code cleanup failure: UInt128& UInt128::operator /=(const uint32_t divisor) { ... ORIGINAL: const uint64_t work = (uint64_t(remainder) << 32) | dividend[i]; CLEANUP: const uint64_t work = makeUInt64(remainder, dividend[i]); However, signature of makeUInt64 is static uint64_t makeUInt64(uint32_t low, uint32_t high) 638964 1 yosin 2012-05-31 21:52:59 -0700 This bug affects only multiplication. 639029 2 145223 yosin 2012-06-01 00:18:57 -0700 Created attachment 145223 Patch 1 639033 3 145223 yosin 2012-06-01 00:20:07 -0700 Comment on attachment 145223 Patch 1 I made mistake for rewriting to makeUInt128. Could you review this patch? Thanks in advance. 639036 4 145223 tkent 2012-06-01 00:24:05 -0700 Comment on attachment 145223 Patch 1 ok 639128 5 145223 webkit.review.bot 2012-06-01 02:41:00 -0700 Comment on attachment 145223 Patch 1 Clearing flags on attachment: 145223 Committed r119205: <http://trac.webkit.org/changeset/119205> 639129 6 webkit.review.bot 2012-06-01 02:41:14 -0700 All reviewed patches have been landed. Closing bug. 145223 2012-06-01 00:18:57 -0700 2012-06-01 02:41:00 -0700 Patch 1 bug-88044-20120601161856.patch text/plain 3170 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM1NTVhZTIxYTFmNTA1 MDRkNjUwMTk0M2U0Y2UzNjczMTllMWI2ZS4uYWE1ZGExYzBjMTY0MzIwMWQ3MWI4ZGJhMjYzMzVi MWU4NzRlZTZhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTMxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1BsYXRmb3JtXVtE ZWNpbWFsXSBVSW50MTI4OjpvcGVyYXRvci89IGNhbGxzIG1ha2VVSW50MTI4IHdpdGggd3Jvbmcg YXJndW1lbnQgb3JkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg4MDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBwYXRjaCBmaXhlZCB3cm9uZyBhcmd1bWVudCBvZiBtYWtlVUludDEyOCBpbiBV SW50MTI4OjpvcGVyYXRvci89IHRvIGdldCByaWdodAorICAgICAgICByZXN1bHQgZm9yIGRlY2lt YWwgbXVsdGlwbGljYXRpb24uCisKKyAgICAgICAgVGVzdDogV2ViS2l0L2Nocm9taXVtL3Rlc3Rz L0RlY2ltYWxUZXN0LmNwcDogQWRkIG5ldyBhIG5ldyB0ZXN0IGNhc2UuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9EZWNpbWFsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRlY2ltYWxQcml2YXRlOjpV SW50MTI4OjpvcGVyYXRvci89KToKKwogMjAxMi0wNS0zMSAgSGFqaW1lIE1vcnJpdGEgIDxtb3Jy aXRhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxMTc1NzIpOiBlZGl0aW5n L3NwZWxsaW5nL3NwZWxsY2hlY2stYXN5bmMtcmVtb3ZlLWZyYW1lLmh0bWwgY3Jhc2hlcyBvbiBN YWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMDllZDA2NTFiZTkwMDc1NGJkY2VjNDYz MTNlYmMzNzdiODIyYzFjZi4uMGFmNDMxNGRlMzMzOTBlZjI2ODMzYzQwMzNiMjIyOTU4ZDIwN2Ez NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNS0z MSAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtQbGF0 Zm9ybV1bRGVjaW1hbF0gVUludDEyODo6b3BlcmF0b3IvPSBjYWxscyBtYWtlVUludDEyOCB3aXRo IHdyb25nIGFyZ3VtZW50IG9yZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04ODA0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogdGVzdHMvRGVjaW1hbFRlc3QuY3BwOgorICAgICAgICAoVEVTVF9GKTog QWRkIGEgbmV3IHRlc3QgZm9yIG11bHRpcGxpY2F0aW9uLgorCiAyMDEyLTA1LTMxICBIYWppbWUg TW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEx NzU3Mik6IGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxjaGVjay1hc3luYy1yZW1vdmUtZnJhbWUuaHRt bCBjcmFzaGVzIG9uIE1hYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGVj aW1hbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EZWNpbWFsLmNwcAppbmRleCBkMmRk ODMyOWNjY2ViY2QwYjk3MDQ4NTgxNmNhNjNmYmRkYWNlMGYxLi41OTY5ZTNiNzcwMmI2MzA2NTRm ZDZlODZjZDdjY2UzMDUzNmNkNDQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9EZWNpbWFsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EZWNpbWFsLmNwcApA QCAtMTY4LDcgKzE2OCw3IEBAIFVJbnQxMjgmIFVJbnQxMjg6Om9wZXJhdG9yLz0oY29uc3QgdWlu dDMyX3QgZGl2aXNvcikKICAgICB1aW50MzJfdCBxdW90aWVudFs0XTsKICAgICB1aW50MzJfdCBy ZW1haW5kZXIgPSAwOwogICAgIGZvciAoaW50IGkgPSAzOyBpID49IDA7IC0taSkgewotICAgICAg ICBjb25zdCB1aW50NjRfdCB3b3JrID0gbWFrZVVJbnQ2NChyZW1haW5kZXIsIGRpdmlkZW5kW2ld KTsKKyAgICAgICAgY29uc3QgdWludDY0X3Qgd29yayA9IG1ha2VVSW50NjQoZGl2aWRlbmRbaV0s IHJlbWFpbmRlcik7CiAgICAgICAgIHJlbWFpbmRlciA9IHN0YXRpY19jYXN0PHVpbnQzMl90Pih3 b3JrICUgZGl2aXNvcik7CiAgICAgICAgIHF1b3RpZW50W2ldID0gc3RhdGljX2Nhc3Q8dWludDMy X3Q+KHdvcmsgLyBkaXZpc29yKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL0RlY2ltYWxUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVz dHMvRGVjaW1hbFRlc3QuY3BwCmluZGV4IGRiNjllZGQzOGY2MmQwYTE1YTcxMmFkYzIzMjZhODU3 MGE2ZTc0NzguLjE4NDU3ZmRmNDVhNDI5ZDUwYmI4ODM1NzAyNzQyZDhmYzNhZTRhNjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRGVjaW1hbFRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRGVjaW1hbFRlc3QuY3BwCkBAIC02NDYsNiAr NjQ2LDcgQEAgVEVTVF9GKERlY2ltYWxUZXN0LCBNdWx0aXBsaWNhdGlvbikKICAgICBFWFBFQ1Rf RVEoZW5jb2RlKDIsIDAsIE5lZ2F0aXZlKSwgRGVjaW1hbCgtMSkgKiBEZWNpbWFsKDIpKTsKICAg ICBFWFBFQ1RfRVEoZW5jb2RlKDk5LCAwLCBQb3NpdGl2ZSksIERlY2ltYWwoOTkpICogRGVjaW1h bCgxKSk7CiAgICAgRVhQRUNUX0VRKGVuY29kZSgyNTAwLCAwLCBQb3NpdGl2ZSksIERlY2ltYWwo LTUwKSAqIERlY2ltYWwoLTUwKSk7CisgICAgRVhQRUNUX0VRKGVuY29kZSgxLCAyMSwgUG9zaXRp dmUpLCBlbmNvZGUoVUlOVDY0X0MoMTAwMDAwMDAwMDApLCAwLCBQb3NpdGl2ZSkgKiBlbmNvZGUo VUlOVDY0X0MoMTAwMDAwMDAwMDAwKSwgMCwgUG9zaXRpdmUpKTsKIH0KIAogVEVTVF9GKERlY2lt YWxUZXN0LCBNdWx0aXBsaWNhdGlvbkJpZ0V4cG9uZW50KQo=