87963 2012-05-31 05:40:24 -0700 Need special-case toJS(IDBAny) for IDBCursorWithValue 2014-04-24 16:45:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 45110 1 charles.wei charles.wei ggaren jorlow jrogers jsbell oliver PeterHWang rwlbuis sam staikos webkit.review.bot oldest_to_newest 638283 0 charles.wei 2012-05-31 05:40:24 -0700 For JSC binding for JavaScript IDL files, say, Base and Derived where Derived derives from Base, the JSC binding generator generates native to JS binding toJS(native object) for the base interface but not the derived interface. So "JSValue toJS(A*)" will be generated but not" JSValue toJS(B*)". with IndexedDB support, IDBAny is the wildcard interface that can be many things, like IDBRequest, IDBIndex, IDBCursor, IDBCursorWithValue. toJS(IDBAny*) generates corresponding JSValue according to the real data it holds. case IDBAny::IDBCursorType: return toJS(exec, globalObject, idbAny->idbCursor()); case IDBAny::IDBCursorWithValueType: return toJS(exec, globalObject, idbAny->idbCursorWithValue()); Actually generates both to IDBCursor objects, because there's no toJS(exec, globalObject, IDBCursorWithValue*) generated by the code generator because IDBCursorWithValue interface is derived from IDBCursor interface. So when the IDBCursor JSObject is generated for IDBCursorWithValue, it can't access the attributes (the value) hold by the actual IDBCursorWithValue object. 638857 1 145183 charles.wei 2012-05-31 17:59:22 -0700 Created attachment 145183 Patch 642186 2 145183 webkit.review.bot 2012-06-05 22:37:44 -0700 Comment on attachment 145183 Patch Clearing flags on attachment: 145183 Committed r119561: <http://trac.webkit.org/changeset/119561> 642187 3 webkit.review.bot 2012-06-05 22:37:49 -0700 All reviewed patches have been landed. Closing bug. 1003865 4 darin 2014-04-24 16:45:33 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 145183 2012-05-31 17:59:22 -0700 2012-06-05 22:37:44 -0700 Patch bug-87963-20120601090829.patch text/plain 1902 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVkZjdhMzczOTEyYWY5 YmEwZjk5ZTRiNmEzNjFmMWRjMzUxODMyNy4uYjNhOGQ2YzYzMzQ1OWI2OTAzOWE0NDQ0ODE4MDAy NDVjNWVmOTJlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTMxICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBOZWVk IHNwZWNpYWwtY2FzZSB0b0pTKElEQkFueSkgZm9yIElEQkN1cnNvcldpdGhWYWx1ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc5NjMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRo aXMgaXMgZm9yIGluZGV4ZWREQiwgd2hpY2ggaXMgbm90IHdvcmtpbmcgZm9yIEpTQyBiaW5kaW5n LgorICAgICAgICBXaGVuIGluZGV4ZWREQiB3b3JraW5nIGZvciBKU0MsIGFsbCB0aGUgaW5kZXhk YiB0ZXN0IGNhc2VzIHNob3VsZCBhcHBseS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSURC QW55Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvSlMpOgorCiAyMDEyLTA1LTMxICBT aGF3biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1 bV0gTWlncmF0ZSB0byBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNJREJBbnlDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNJREJBbnlDdXN0b20uY3BwCmluZGV4IGRlZmE2NTZlN2UyYjlmMzQ0ODI1 YmYwMzFjMmI4OTEzMzgzODdiMjYuLmNmNTQ1ZDMwMDlhYTk0YmI5ODg4ODYyMTA5MGVlZTY4NDJm YjQyYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCQW55Q3Vz dG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQkFueUN1c3RvbS5j cHAKQEAgLTQxLDYgKzQxLDcgQEAKICNpbmNsdWRlICJJREJPYmplY3RTdG9yZS5oIgogI2luY2x1 ZGUgIkpTRE9NU3RyaW5nTGlzdC5oIgogI2luY2x1ZGUgIkpTSURCQ3Vyc29yLmgiCisjaW5jbHVk ZSAiSlNJREJDdXJzb3JXaXRoVmFsdWUuaCIKICNpbmNsdWRlICJKU0lEQkRhdGFiYXNlLmgiCiAj aW5jbHVkZSAiSlNJREJGYWN0b3J5LmgiCiAjaW5jbHVkZSAiSlNJREJJbmRleC5oIgpAQCAtNjgs NyArNjksNyBAQCBKU1ZhbHVlIHRvSlMoRXhlY1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVj dCogZ2xvYmFsT2JqZWN0LCBJREJBbnkqIGlkYkFueSkKICAgICBjYXNlIElEQkFueTo6SURCQ3Vy c29yVHlwZToKICAgICAgICAgcmV0dXJuIHRvSlMoZXhlYywgZ2xvYmFsT2JqZWN0LCBpZGJBbnkt PmlkYkN1cnNvcigpKTsKICAgICBjYXNlIElEQkFueTo6SURCQ3Vyc29yV2l0aFZhbHVlVHlwZToK LSAgICAgICAgcmV0dXJuIHRvSlMoZXhlYywgZ2xvYmFsT2JqZWN0LCBpZGJBbnktPmlkYkN1cnNv cldpdGhWYWx1ZSgpKTsKKyAgICAgICAgcmV0dXJuIHdyYXA8SlNJREJDdXJzb3JXaXRoVmFsdWU+ KGV4ZWMsIGdsb2JhbE9iamVjdCwgaWRiQW55LT5pZGJDdXJzb3JXaXRoVmFsdWUoKS5nZXQoKSk7 CiAgICAgY2FzZSBJREJBbnk6OklEQkRhdGFiYXNlVHlwZToKICAgICAgICAgcmV0dXJuIHRvSlMo ZXhlYywgZ2xvYmFsT2JqZWN0LCBpZGJBbnktPmlkYkRhdGFiYXNlKCkpOwogICAgIGNhc2UgSURC QW55OjpJREJGYWN0b3J5VHlwZToK