87948 2012-05-31 03:06:23 -0700 [V8] Pass Isolate to v8Boolean() 2012-05-31 16:14:08 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 638178 0 haraken 2012-05-31 03:06:23 -0700 The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8Boolean(). 638180 1 145038 haraken 2012-05-31 03:07:49 -0700 Created attachment 145038 Patch 638791 2 145038 webkit.review.bot 2012-05-31 16:14:04 -0700 Comment on attachment 145038 Patch Clearing flags on attachment: 145038 Committed r119171: <http://trac.webkit.org/changeset/119171> 638792 3 webkit.review.bot 2012-05-31 16:14:08 -0700 All reviewed patches have been landed. Closing bug. 145038 2012-05-31 03:07:49 -0700 2012-05-31 16:14:04 -0700 Patch bug-87948-20120531190748.patch text/plain 4955 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGVjMTI3ZDE3NjI0OGUz YjNiMGU3OGVkMTVjMGVjMjc3MTYxYzQwYS4uNGIxYjExYTQzMGEzMzk2ZTM0YmYyMjg0NTQwMjlj NzllMzdjYTI3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA1LTMxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byB2OEJvb2xlYW4oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODc5NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgb2JqZWN0aXZlIGlzIHRvIHBhc3MgSXNvbGF0ZSBhcm91bmQgaW4gVjgg YmluZGluZ3MuCisgICAgICAgIFRoaXMgcGF0Y2ggcGFzc2VzIElzb2xhdGUgdG8gdjhCb29sZWFu KCkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHA6CisgICAgICAgICogYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4RE9NU3RyaW5nTWFwQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlY4RE9NU3RyaW5nTWFwOjpuYW1lZFByb3BlcnR5RGVsZXRlcik6CisgICAgICAgICogYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4SW5qZWN0ZWRTY3JpcHRIb3N0Q3VzdG9tLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlY4SW5qZWN0ZWRTY3JpcHRIb3N0Ojppc0hUTUxBbGxDb2xsZWN0aW9uQ2FsbGJh Y2spOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6c3RvcmFnZURlbGV0ZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L2N1c3RvbS9WOFdlYlNvY2tldEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFdlYlNv Y2tldDo6c2VuZENhbGxiYWNrKToKKwogMjAxMi0wNS0zMSAgWW9zaGlmdW1pIElub3VlICA8eW9z aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtQbGF0Zm9ybV0gSW50cm9kdWNlIERlY2ltYWwg Y2xhc3MgZm9yIE51bWJlci9SYW5nZSBpbnB1dCB0eXBlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggNGU4MWNmMDc3 ZDdjZmQ5NWRkZDdlNDI2YmMzNWVjMTk3MjI1ZTg4ZS4uNjBkMDUzYjQyZjg3NGVjNmM0OWM2ZTFl MmNiMTFiNWI3OWJhNGQ1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv U2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCkBAIC0xMjY2LDEwICsxMjY2LDEwIEBAIHB1Ymxp YzoKICAgICAgICAgICAgICp2YWx1ZSA9IHY4TnVsbFdpdGhDaGVjayhtX2lzb2xhdGUpOwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgVHJ1ZVRhZzoKLSAgICAgICAgICAgICp2YWx1 ZSA9IHY4Qm9vbGVhbih0cnVlKTsKKyAgICAgICAgICAgICp2YWx1ZSA9IHY4Qm9vbGVhbldpdGhD aGVjayh0cnVlLCBtX2lzb2xhdGUpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug RmFsc2VUYWc6Ci0gICAgICAgICAgICAqdmFsdWUgPSB2OEJvb2xlYW4oZmFsc2UpOworICAgICAg ICAgICAgKnZhbHVlID0gdjhCb29sZWFuV2l0aENoZWNrKGZhbHNlLCBtX2lzb2xhdGUpOwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgVHJ1ZU9iamVjdFRhZzoKICAgICAgICAgICAg ICp2YWx1ZSA9IHY4OjpCb29sZWFuT2JqZWN0OjpOZXcodHJ1ZSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01TdHJpbmdNYXBDdXN0b20uY3BwIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NU3RyaW5nTWFwQ3VzdG9tLmNw cAppbmRleCA2YjFjMzU1YWIyZThhOTI3MTVjN2YwZGZhNTE3OTVmNzRlNjMxODdmLi5kYjA0NWE4 NDQ5OTNhMWVkOWZmNjYyM2FmMzRhN2YzNzA3NzY5YmY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01TdHJpbmdNYXBDdXN0b20uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVN0cmluZ01hcEN1c3RvbS5jcHAK QEAgLTcxLDcgKzcxLDcgQEAgdjg6OkhhbmRsZTx2ODo6Qm9vbGVhbj4gVjhET01TdHJpbmdNYXA6 Om5hbWVkUHJvcGVydHlEZWxldGVyKHY4OjpMb2NhbDx2ODo6U3RyaW4KICAgICBJTkNfU1RBVFMo IkRPTS5ET01TdHJpbmdNYXAuTmFtZWRQcm9wZXJ0eURlbGV0ZXIiKTsKICAgICBFeGNlcHRpb25D b2RlIGVjID0gMDsKICAgICBWOERPTVN0cmluZ01hcDo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSkt PmRlbGV0ZUl0ZW0odG9XZWJDb3JlU3RyaW5nKG5hbWUpLCBlYyk7Ci0gICAgcmV0dXJuIHY4Qm9v bGVhbighZWMpOworICAgIHJldHVybiB2OEJvb2xlYW4oIWVjLCBpbmZvLkdldElzb2xhdGUoKSk7 CiB9CiAKIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOERPTVN0cmluZ01hcDo6bmFtZWRQcm9wZXJ0 eVNldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4g dmFsdWUsIGNvbnN0IHY4OjpBY2Nlc3NvckluZm8mIGluZm8pCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJbmplY3RlZFNjcmlwdEhvc3RDdXN0b20uY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5qZWN0ZWRTY3JpcHRIb3N0 Q3VzdG9tLmNwcAppbmRleCAzZWNiZDgzZjhlY2VmYWNjYWFlY2Q2MzU1YzBiYzcxNTJhOTE0MmFm Li45YTQyZGVlOTA3YTNlMDJiZjA2NmJmYWE0ZGQ5MmJmNzI1YzA3NTc1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJbmplY3RlZFNjcmlwdEhvc3RDdXN0 b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluamVjdGVk U2NyaXB0SG9zdEN1c3RvbS5jcHAKQEAgLTExMCw3ICsxMTAsNyBAQCB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gVjhJbmplY3RlZFNjcmlwdEhvc3Q6OmlzSFRNTEFsbENvbGxlY3Rpb25DYWxsYmFjayhj b25zdCB2OAogICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogCiAgICAgaWYgKCFhcmdz WzBdLT5Jc09iamVjdCgpKQotICAgICAgICByZXR1cm4gdjhCb29sZWFuKGZhbHNlKTsKKyAgICAg ICAgcmV0dXJuIHY4Qm9vbGVhbihmYWxzZSwgYXJncy5HZXRJc29sYXRlKCkpOwogCiAgICAgdjg6 OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOwogICAgIHJldHVybiB2ODo6Qm9vbGVhbjo6TmV3KFY4 SFRNTEFsbENvbGxlY3Rpb246Okhhc0luc3RhbmNlKGFyZ3NbMF0pKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFnZUN1c3RvbS5jcHAKaW5kZXgg ZTg5NWE0OWQ1ZmQzYTUxZDRkYzNiNjQ0NDcyYTdmOWIxMWQwMDc4Ni4uMWJkYWRiNWQ5ZTUxYzA3 NTFlOWY2NGVmM2Q0ZTI4N2Q0YmIyYjc3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFnZUN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFnZUN1c3RvbS5jcHAKQEAgLTEzMyw3ICsxMzMsNyBA QCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6Qm9vbGVhbj4gc3RvcmFnZURlbGV0ZXIodjg6OkxvY2Fs PHY4OjpTdHJpbmc+IHY4TmFtZSwgY29ucwogICAgIAogICAgIGlmIChzdG9yYWdlLT5jb250YWlu cyhuYW1lKSkgewogICAgICAgICBzdG9yYWdlLT5yZW1vdmVJdGVtKG5hbWUpOwotICAgICAgICBy ZXR1cm4gdjhCb29sZWFuKHRydWUpOworICAgICAgICByZXR1cm4gdjhCb29sZWFuKHRydWUsIGlu Zm8uR2V0SXNvbGF0ZSgpKTsKICAgICB9CiAKICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6Qm9v bGVhbj4oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9W OFdlYlNvY2tldEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhXZWJTb2NrZXRDdXN0b20uY3BwCmluZGV4IDgxYTRjZGNiODlhMzBlMDFiNjk5MjEzYWYwNWYw NDU2ZTdmZmI3YTAuLmYwMTA5YzdlMTQ5Y2JlMzUyZmQwNTMxOTJkMzE0ZmQ3ZDE0NzdlZTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYlNvY2tldEN1 c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4V2ViU29j a2V0Q3VzdG9tLmNwcApAQCAtMTQxLDcgKzE0MSw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBW OFdlYlNvY2tldDo6c2VuZENhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiAgICAg aWYgKGVjKQogICAgICAgICByZXR1cm4gdGhyb3dFcnJvcihlYywgYXJncy5HZXRJc29sYXRlKCkp OwogCi0gICAgcmV0dXJuIHY4Qm9vbGVhbihyZXN1bHQpOworICAgIHJldHVybiB2OEJvb2xlYW4o cmVzdWx0LCBhcmdzLkdldElzb2xhdGUoKSk7CiB9CiAKIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBW OFdlYlNvY2tldDo6Y2xvc2VDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQo=