87941 2012-05-31 01:35:32 -0700 [Platform] Implementation of Decimal(int32_t) isn't portable. 2012-05-31 04:54:40 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80009 1 yosin yosin tkent webkit.review.bot oldest_to_newest 638115 0 yosin 2012-05-31 01:35:32 -0700 The value of expression (i32 < 0 ? -i32 : i32) is undefined when i32 = std::numeric_limits<int32_t>::min(), e.g. 0x80000000. 638131 1 145021 yosin 2012-05-31 02:04:42 -0700 Created attachment 145021 Patch 1 638132 2 145021 yosin 2012-05-31 02:05:41 -0700 Comment on attachment 145021 Patch 1 Could you review this patch? Thanks in advance. -yosi 638133 3 145021 tkent 2012-05-31 02:06:20 -0700 Comment on attachment 145021 Patch 1 ok 638243 4 145021 webkit.review.bot 2012-05-31 04:54:36 -0700 Comment on attachment 145021 Patch 1 Clearing flags on attachment: 145021 Committed r119088: <http://trac.webkit.org/changeset/119088> 638244 5 webkit.review.bot 2012-05-31 04:54:40 -0700 All reviewed patches have been landed. Closing bug. 145021 2012-05-31 02:04:42 -0700 2012-05-31 04:54:35 -0700 Patch 1 bug-87941-20120531180441.patch text/plain 1595 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGVjMTI3ZDE3NjI0OGUz YjNiMGU3OGVkMTVjMGVjMjc3MTYxYzQwYS4uZDhhYmJmZDNhM2U4NjY3MjJiNWE3MDI0NWJlNDc0 MTMzOGNiNWFmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA1LTMxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW1BsYXRmb3JtXSBJ bXBsZW1lbnRhdGlvbiBvZiBEZWNpbWFsKGludDMyX3QpIGlzbid0IHBvcnRhYmxlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc5NDEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5n ZXMgbmVnYXRpb24gb2YgaW50ZWdlciB0byBtYWtlIHVuc2lnbmVkIGludGVnZXIKKyAgICAgICAg aW4gcG9ydGFibGUgd2F5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBkb2Vz bid0IGNoYW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL0RlY2ltYWwuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RGVjaW1hbDo6RGVjaW1hbCk6IFVzZSB1aW50NjRfdCgtaW50NjRf dChpMzIpKSBpbnN0ZWFkIG9mIHVpbnQ2NF90KC1pMzIpIAorCisyMDEyLTA1LTMxICBZb3NoaWZ1 bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW1BsYXRmb3JtXSBJbnRy b2R1Y2UgRGVjaW1hbCBjbGFzcyBmb3IgTnVtYmVyL1JhbmdlIGlucHV0IHR5cGUuCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzM2MAogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EZWNpbWFsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0RlY2ltYWwuY3BwCmluZGV4IDIwNjFkZWQwNzU5YTgxMThlZjAxYmZmMmYzYjM2 NGYzNWQ1YmJiMmUuLmJmYzk5MDc4MDc5ZmVhYWVlMmY3Nzc2YTI0YTBkZmYyN2ZjMTUwZWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RlY2ltYWwuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0RlY2ltYWwuY3BwCkBAIC0yNzgsNyArMjc4LDcgQEAgYm9vbCBE ZWNpbWFsOjpFbmNvZGVkRGF0YTo6b3BlcmF0b3I9PShjb25zdCBFbmNvZGVkRGF0YSYgYW5vdGhl cikgY29uc3QKIH0KIAogRGVjaW1hbDo6RGVjaW1hbChpbnQzMl90IGkzMikKLSAgICA6IG1fZGF0 YShpMzIgPCAwID8gTmVnYXRpdmUgOiBQb3NpdGl2ZSwgMCwgc3RhdGljX2Nhc3Q8dWludDMyX3Q+ KGkzMiA8IDAgPyAtaTMyIDogaTMyKSkKKyAgICA6IG1fZGF0YShpMzIgPCAwID8gTmVnYXRpdmUg OiBQb3NpdGl2ZSwgMCwgaTMyIDwgMCA/IHN0YXRpY19jYXN0PHVpbnQ2NF90Pigtc3RhdGljX2Nh c3Q8aW50NjRfdD4oaTMyKSkgOiBzdGF0aWNfY2FzdDx1aW50NjRfdD4oaTMyKSkKIHsKIH0KIAo=