87814 2012-05-29 20:57:18 -0700 [V8] Implement V8Binding::v8BooleanWithCheck(isolate) 2012-05-30 17:29:56 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 636788 0 haraken 2012-05-29 20:57:18 -0700 The objective is to pass Isolate to v8::True() and v8::False(). Similarly to v8NullWithCheck() (bug 87713), we can implement V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False() or v8::True(isolate)/v8::False(isolate) depending on whether the passed isolate is null or not. 636792 1 144688 haraken 2012-05-29 21:03:46 -0700 Created attachment 144688 Patch 637854 2 144688 webkit.review.bot 2012-05-30 17:29:52 -0700 Comment on attachment 144688 Patch Clearing flags on attachment: 144688 Committed r119003: <http://trac.webkit.org/changeset/119003> 637855 3 webkit.review.bot 2012-05-30 17:29:56 -0700 All reviewed patches have been landed. Closing bug. 144688 2012-05-29 21:03:46 -0700 2012-05-30 17:29:52 -0700 Patch bug-87814-20120530130345.patch text/plain 6768 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRmYzNiY2MyMGRlNGRm YzZiNTFmMGY2YTE4NjY1NTgzYTczMmJkYS4uM2Y0MzNjMzVhOWM3Y2FkM2UyZjJjZjNmODQ4MmZh OTY2YmE0YjJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM1IEBACiAyMDEyLTA1LTI5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIEltcGxlbWVu dCBWOEJpbmRpbmc6OnY4Qm9vbGVhbldpdGhDaGVjayhpc29sYXRlKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc4MTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb2JqZWN0aXZlIGlzIHRvIHBhc3Mg SXNvbGF0ZSB0byB2ODo6VHJ1ZSgpIGFuZCB2ODo6RmFsc2UoKS4KKyAgICAgICAgU2ltaWxhcmx5 IHRvIHY4TnVsbFdpdGhDaGVjaygpIChidWcgODc3MTMpLCB0aGlzIHBhdGNoIGltcGxlbWVudHMK KyAgICAgICAgVjhCaW5kaW5nOjp2OEJvb2xlYW5XaXRoQ2hlY2soaXNvbGF0ZSksIHdoaWNoIGNh bGxzIHY4OjpUcnVlKCkvdjg6OkZhbHNlKCkKKyAgICAgICAgb3Igdjg6OlRydWUoaXNvbGF0ZSkv djg6OkZhbHNlKGlzb2xhdGUpIGRlcGVuZGluZyBvbiB3aGV0aGVyIHRoZQorICAgICAgICBwYXNz ZWQgaXNvbGF0ZSBpcyBudWxsIG9yIG5vdC4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gcGFz c2VzIElzb2xhdGUgdG8gdjhCb29sZWFuKCkgaW4gQ29kZUdlbmVyYXRvclY4LnBtLgorCisgICAg ICAgIE5vIHRlc3RzLiBObyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKE5hdGl2ZVRvSlNWYWx1ZSk6Cisg ICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdEV2ZW50VGFyZ2V0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlRlc3RFdmVudFRhcmdldFY4SW50ZXJuYWw6OmRpc3BhdGNoRXZl bnRDYWxsYmFjayk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9i ai5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXN0T2JqVjhJbnRlcm5hbDo6Y3JlYXRlQXR0ckdl dHRlcik6CisgICAgICAgIChXZWJDb3JlOjpUZXN0T2JqVjhJbnRlcm5hbDo6cmVmbGVjdGVkQm9v bGVhbkF0dHJBdHRyR2V0dGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlRlc3RPYmpWOEludGVybmFs OjpyZWZsZWN0ZWRDdXN0b21Cb29sZWFuQXR0ckF0dHJHZXR0ZXIpOgorICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4QmluZGluZy5oOgorICAgICAgICAoV2ViQ29yZTo6djhCb29sZWFuKToKKyAgICAg ICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6djhCb29sZWFuV2l0aENoZWNrKToKKwor MjAxMi0wNS0yOSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgW1Y4XSBSZW5hbWUgdjhOdWxsKCkgdG8gdjhOdWxsV2l0aENoZWNrKCkKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NzEzCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggZjk5 Zjc4NGZiODk4MzhiMGEyMDNkY2VjMzg2ZWNhOTVjYTM3ZGJkZC4uY2EyNTVhYzU4ZjU5MWQ1ZWIz MGM0YjExM2I2ODNiM2RiZDhkNzljZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTM4MDIsNyArMzgwMiw3IEBAIHN1YiBO YXRpdmVUb0pTVmFsdWUKICAgICBteSAkZ2V0SXNvbGF0ZUFyZyA9ICRnZXRJc29sYXRlID8gIiwg JGdldElzb2xhdGUiIDogIiI7CiAgICAgbXkgJHR5cGUgPSBHZXRUeXBlRnJvbVNpZ25hdHVyZSgk c2lnbmF0dXJlKTsKIAotICAgIHJldHVybiAidjhCb29sZWFuKCR2YWx1ZSkiIGlmICR0eXBlIGVx ICJib29sZWFuIjsKKyAgICByZXR1cm4gKCRnZXRJc29sYXRlID8gInY4Qm9vbGVhbigkdmFsdWUs ICRnZXRJc29sYXRlKSIgOiAidjhCb29sZWFuKCR2YWx1ZSkiKSBpZiAkdHlwZSBlcSAiYm9vbGVh biI7CiAgICAgcmV0dXJuICJ2ODo6SGFuZGxlPHY4OjpWYWx1ZT4oKSIgaWYgJHR5cGUgZXEgInZv aWQiOyAgICAgIyBlcXVpdmFsZW50IHRvIHY4OjpVbmRlZmluZWQoKQogCiAgICAgIyBIVE1MNSBz YXlzIHRoYXQgdW5zaWduZWQgcmVmbGVjdGVkIGF0dHJpYnV0ZXMgc2hvdWxkIGJlIGluIHRoZSBy YW5nZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4 L1Y4VGVzdEV2ZW50VGFyZ2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv dGVzdC9WOC9WOFRlc3RFdmVudFRhcmdldC5jcHAKaW5kZXggNGExNTEyNzM2MzI0NmRiY2U3Zjlk ZmQzNzdiNDZmNzk3NGU0ZjAxNi4uNmRiZmY1N2NkNmU1NTE3N2VlMzZjYjQxZjE0Y2Y1NTAxZTAw OTgzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4 L1Y4VGVzdEV2ZW50VGFyZ2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvVjgvVjhUZXN0RXZlbnRUYXJnZXQuY3BwCkBAIC05Niw3ICs5Niw3IEBAIHN0YXRp YyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZGlzcGF0Y2hFdmVudENhbGxiYWNrKGNvbnN0IHY4OjpB cmd1bWVudHMmIGFyZ3MpCiAgICAgYm9vbCByZXN1bHQgPSBpbXAtPmRpc3BhdGNoRXZlbnQoZXZ0 LCBlYyk7CiAgICAgaWYgKFVOTElLRUxZKGVjKSkKICAgICAgICAgZ290byBmYWlsOwotICAgIHJl dHVybiB2OEJvb2xlYW4ocmVzdWx0KTsKKyAgICByZXR1cm4gdjhCb29sZWFuKHJlc3VsdCwgYXJn cy5HZXRJc29sYXRlKCkpOwogICAgIH0KICAgICBmYWlsOgogICAgIHJldHVybiBWOFByb3h5Ojpz ZXRET01FeGNlcHRpb24oZWMsIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHAKaW5kZXggODU2 M2M0YmExNTQ1OWE0MmZlMTY3OGRhOTY5N2EyODA0ZTVmYWY2ZS4uNWRlMzg4ZDc3Y2I3NTFmM2Ni YTE4YzIyZTM2M2RlN2U4ODkwNDgyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHAKQEAgLTQ2NCw3ICs0NjQsNyBAQCBz dGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNyZWF0ZUF0dHJHZXR0ZXIodjg6OkxvY2FsPHY4 OjpTdHJpbmc+IG5hbWUsIGNvbnN0CiB7CiAgICAgSU5DX1NUQVRTKCJET00uVGVzdE9iai5jcmVh dGUuX2dldCIpOwogICAgIFRlc3RPYmoqIGltcCA9IFY4VGVzdE9iajo6dG9OYXRpdmUoaW5mby5I b2xkZXIoKSk7Ci0gICAgcmV0dXJuIHY4Qm9vbGVhbihpbXAtPmlzQ3JlYXRlKCkpOworICAgIHJl dHVybiB2OEJvb2xlYW4oaW1wLT5pc0NyZWF0ZSgpLCBpbmZvLkdldElzb2xhdGUoKSk7CiB9CiAK IHN0YXRpYyB2b2lkIGNyZWF0ZUF0dHJTZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUs IHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZhbHVlLCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZv KQpAQCAtNTI4LDcgKzUyOCw3IEBAIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcmVmbGVj dGVkQm9vbGVhbkF0dHJBdHRyR2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nCiB7CiAgICAgSU5D X1NUQVRTKCJET00uVGVzdE9iai5yZWZsZWN0ZWRCb29sZWFuQXR0ci5fZ2V0Iik7CiAgICAgVGVz dE9iaiogaW1wID0gVjhUZXN0T2JqOjp0b05hdGl2ZShpbmZvLkhvbGRlcigpKTsKLSAgICByZXR1 cm4gdjhCb29sZWFuKGltcC0+aGFzQXR0cmlidXRlKFdlYkNvcmU6OkhUTUxOYW1lczo6cmVmbGVj dGVkYm9vbGVhbmF0dHJBdHRyKSk7CisgICAgcmV0dXJuIHY4Qm9vbGVhbihpbXAtPmhhc0F0dHJp YnV0ZShXZWJDb3JlOjpIVE1MTmFtZXM6OnJlZmxlY3RlZGJvb2xlYW5hdHRyQXR0ciksIGluZm8u R2V0SXNvbGF0ZSgpKTsKIH0KIAogc3RhdGljIHZvaWQgcmVmbGVjdGVkQm9vbGVhbkF0dHJBdHRy U2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCB2ODo6TG9jYWw8djg6OlZhbHVlPiB2 YWx1ZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbykKQEAgLTU5Miw3ICs1OTIsNyBAQCBz dGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHJlZmxlY3RlZEN1c3RvbUJvb2xlYW5BdHRyQXR0 ckdldHRlcih2ODo6TG9jYWw8djg6OgogewogICAgIElOQ19TVEFUUygiRE9NLlRlc3RPYmoucmVm bGVjdGVkQ3VzdG9tQm9vbGVhbkF0dHIuX2dldCIpOwogICAgIFRlc3RPYmoqIGltcCA9IFY4VGVz dE9iajo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSk7Ci0gICAgcmV0dXJuIHY4Qm9vbGVhbihpbXAt Pmhhc0F0dHJpYnV0ZShXZWJDb3JlOjpIVE1MTmFtZXM6OmN1c3RvbUNvbnRlbnRCb29sZWFuQXR0 ckF0dHIpKTsKKyAgICByZXR1cm4gdjhCb29sZWFuKGltcC0+aGFzQXR0cmlidXRlKFdlYkNvcmU6 OkhUTUxOYW1lczo6Y3VzdG9tQ29udGVudEJvb2xlYW5BdHRyQXR0ciksIGluZm8uR2V0SXNvbGF0 ZSgpKTsKIH0KIAogc3RhdGljIHZvaWQgcmVmbGVjdGVkQ3VzdG9tQm9vbGVhbkF0dHJBdHRyU2V0 dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1 ZSwgY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYgaW5mbykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhCaW5kaW5nLmgKaW5kZXggMjlkMjQzMmVhM2MwYmZlZGY4OTMxNGNhNzM4M2E5NGMxNDA5N2Rm OS4uY2NhYjY2ZGM1NGNkMDdiYzMzYjI0MzA0ZjAxMDI1YTc4N2ViOWRjYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTI0OCw3ICsyNDgsNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgU3RyaW5nVHlwZSB2OFN0cmluZ1RvV2ViQ29yZVN0cmluZyh2ODo6SGFu ZGxlPHY4OjpTdHJpbmc+IHY4U3RyaW5nLCBFeHRlcm5hbE1vZGUgZXh0ZXJuYWwpOwogCiAgICAg Ly8gU2luY2Ugdjg6Ok51bGwoaXNvbGF0ZSkgY3Jhc2hlcyBpZiB3ZSBwYXNzIGEgbnVsbCBpc29s YXRlLAotICAgIC8vIHdlIG5lZWQgdG8gaW5zdGVhZCB1c2UgdjhOdWxsV2l0aENoZWNrKGlzb2xh dGUpLgorICAgIC8vIHdlIG5lZWQgdG8gdXNlIHY4TnVsbFdpdGhDaGVjayhpc29sYXRlKSBpZiBh biBpc29sYXRlIGNhbiBiZSBudWxsLgogICAgIC8vCiAgICAgLy8gRklYTUU6IFJlbW92ZSBhbGwg bnVsbCBpc29sYXRlcyBmcm9tIFY4IGJpbmRpbmdzLCBhbmQgcmVtb3ZlIHY4TnVsbFdpdGhDaGVj ayhpc29sYXRlKS4KICAgICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHY4TnVsbFdpdGhD aGVjayh2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKQEAgLTQwOCw2ICs0MDgsMjAgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgICAgICByZXR1cm4gdmFsdWUgPyB2ODo6VHJ1ZSgpIDogdjg6OkZhbHNl KCk7CiAgICAgfQogCisgICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OkJvb2xlYW4+IHY4Qm9vbGVh bihib29sIHZhbHVlLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKKyAgICB7CisgICAgICAgIHJldHVy biB2YWx1ZSA/IHY4OjpUcnVlKGlzb2xhdGUpIDogdjg6OkZhbHNlKGlzb2xhdGUpOworICAgIH0K KworICAgIC8vIFNpbmNlIHY4Qm9vbGVhbih2YWx1ZSwgaXNvbGF0ZSkgY3Jhc2hlcyBpZiB3ZSBw YXNzIGEgbnVsbCBpc29sYXRlLAorICAgIC8vIHdlIG5lZWQgdG8gdXNlIHY4Qm9vbGVhbldpdGhD aGVjayh2YWx1ZSwgaXNvbGF0ZSkgaWYgYW4gaXNvbGF0ZSBjYW4gYmUgbnVsbC4KKyAgICAvLwor ICAgIC8vIEZJWE1FOiBSZW1vdmUgYWxsIG51bGwgaXNvbGF0ZXMgZnJvbSBWOCBiaW5kaW5ncywg YW5kIHJlbW92ZSB2OEJvb2xlYW5XaXRoQ2hlY2sodmFsdWUsIGlzb2xhdGUpLgorICAgIGlubGlu ZSB2ODo6SGFuZGxlPHY4OjpCb29sZWFuPiB2OEJvb2xlYW5XaXRoQ2hlY2soYm9vbCB2YWx1ZSwg djg6Oklzb2xhdGUqIGlzb2xhdGUpCisgICAgeworICAgICAgICByZXR1cm4gaXNvbGF0ZSA/IHY4 Qm9vbGVhbih2YWx1ZSwgaXNvbGF0ZSkgOiB2OEJvb2xlYW4odmFsdWUpOworICAgIH0KKwogICAg IGlubGluZSBTdHJpbmcgdG9XZWJDb3JlU3RyaW5nV2l0aE51bGxDaGVjayh2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gdmFsdWUpCiAgICAgewogICAgICAgICByZXR1cm4gdmFsdWUtPklzTnVsbCgpID8g U3RyaW5nKCkgOiB2OFZhbHVlVG9XZWJDb3JlU3RyaW5nKHZhbHVlKTsK