87812 2012-05-29 19:29:48 -0700 [V8] Replace v8::True() and v8::False() with v8Boolean() 2012-05-30 17:16:31 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 636754 0 haraken 2012-05-29 19:29:48 -0700 To avoid implementing v8TrueWithCheck(isolate), v8FalseWithCheck(isolate) and v8BooleanWithCheck(isolate), we can first replace v8::True() and v8::False() with v8Boolean(). Then we can just implement v8BooleanWithCheck(isolate). 636766 1 144685 haraken 2012-05-29 19:54:21 -0700 Created attachment 144685 Patch 637844 2 144685 webkit.review.bot 2012-05-30 17:16:26 -0700 Comment on attachment 144685 Patch Clearing flags on attachment: 144685 Committed r119002: <http://trac.webkit.org/changeset/119002> 637846 3 webkit.review.bot 2012-05-30 17:16:31 -0700 All reviewed patches have been landed. Closing bug. 144685 2012-05-29 19:54:21 -0700 2012-05-30 17:16:26 -0700 Patch bug-87812-20120530115419.patch text/plain 6090 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRmYzNiY2MyMGRlNGRm YzZiNTFmMGY2YTE4NjY1NTgzYTczMmJkYS4uMTIwYWU1ZjBjNjA0Zjc4ODg0ZmY0NTI4NGU1ZGYx MDc5YjJmNTljOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTA1LTI5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlcGxhY2Ug djg6OlRydWUoKSBhbmQgdjg6OkZhbHNlKCkgd2l0aCB2OEJvb2xlYW4oKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc4MTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBhdm9pZCBpbXBsZW1lbnRpbmcg YWxsIG9mIHY4VHJ1ZVdpdGhDaGVjayhpc29sYXRlKSwgdjhGYWxzZVdpdGhDaGVjayhpc29sYXRl KQorICAgICAgICBhbmQgdjhCb29sZWFuV2l0aENoZWNrKGlzb2xhdGUpLCB3ZSBjYW4gZmlyc3Qg cmVwbGFjZSB2ODo6VHJ1ZSgpIGFuZCB2ODo6RmFsc2UoKQorICAgICAgICB3aXRoIHY4Qm9vbGVh bigpLiBUaGVuIHdlIGNhbiBqdXN0IGltcGxlbWVudCB2OEJvb2xlYW5XaXRoQ2hlY2soaXNvbGF0 ZSkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHA6CisgICAgICAgICogYmlu ZGluZ3MvdjgvVjhCaW5kaW5nLmg6CisgICAgICAgIChXZWJDb3JlOjp2OFN0cmluZ09yRmFsc2Up OgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4TlBVdGlscy5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojpjb252ZXJ0TlBWYXJpYW50VG9WOE9iamVjdCk6CisgICAgICAgICogYmluZGluZ3MvdjgvY3Vz dG9tL1Y4RE9NU3RyaW5nTWFwQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NU3Ry aW5nTWFwOjpuYW1lZFByb3BlcnR5RGVsZXRlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3Vz dG9tL1Y4SW5qZWN0ZWRTY3JpcHRIb3N0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4 SW5qZWN0ZWRTY3JpcHRIb3N0Ojppc0hUTUxBbGxDb2xsZWN0aW9uQ2FsbGJhY2spOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c3RvcmFnZURlbGV0ZXIpOgorCisyMDEyLTA1LTI5ICBLZW50YXJvIEhhcmEgIDxoYXJh a2VuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbVjhdIFJlbmFtZSB2OE51bGwoKSB0byB2OE51 bGxXaXRoQ2hlY2soKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODc3MTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2Vy aWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nlcmlh bGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggN2I3OTk2MjQ4YjVmN2VlOTlmYWRiZmI2MGFiYmQy YTc3ODExMTcwZC4uNjRmYTQzYTMyM2M4MTc4YTU1OGE3ODI1YTVlY2I0N2RkMjUyYzhjNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFs dWUuY3BwCkBAIC0xMjY2LDEwICsxMjY2LDEwIEBAIHB1YmxpYzoKICAgICAgICAgICAgICp2YWx1 ZSA9IHY4OjpOdWxsKCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBUcnVlVGFn OgotICAgICAgICAgICAgKnZhbHVlID0gdjg6OlRydWUoKTsKKyAgICAgICAgICAgICp2YWx1ZSA9 IHY4Qm9vbGVhbih0cnVlKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEZhbHNl VGFnOgotICAgICAgICAgICAgKnZhbHVlID0gdjg6OkZhbHNlKCk7CisgICAgICAgICAgICAqdmFs dWUgPSB2OEJvb2xlYW4oZmFsc2UpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug VHJ1ZU9iamVjdFRhZzoKICAgICAgICAgICAgICp2YWx1ZSA9IHY4OjpCb29sZWFuT2JqZWN0OjpO ZXcodHJ1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRp bmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCmluZGV4IDI5ZDI0 MzJlYTNjMGJmZWRmODkzMTRjYTczODNhOTRjMTQwOTdkZjkuLjgyZTdjNDRhZTJiMWVjMDFmODU5 N2U5MTljNGJkNDk4YWI1YmU1NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGlu Zy5oCkBAIC00NDAsNyArNDQwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgaW5saW5l IHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OFN0cmluZ09yRmFsc2UoY29uc3QgU3RyaW5nJiBzdHIs IHY4OjpJc29sYXRlKiBpc29sYXRlID0gMCkKICAgICB7Ci0gICAgICAgIHJldHVybiBzdHIuaXNO dWxsKCkgPyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4odjg6OkZhbHNlKCkpIDogdjg6OkhhbmRsZTx2 ODo6VmFsdWU+KHY4U3RyaW5nKHN0ciwgaXNvbGF0ZSkpOworICAgICAgICByZXR1cm4gc3RyLmlz TnVsbCgpID8gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KHY4Qm9vbGVhbihmYWxzZSkpIDogdjg6Okhh bmRsZTx2ODo6VmFsdWU+KHY4U3RyaW5nKHN0ciwgaXNvbGF0ZSkpOwogICAgIH0KIAogICAgIHRl bXBsYXRlIDxjbGFzcyBUPiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhOdW1iZXJBcnJheShjb25z dCBWZWN0b3I8VD4mIHZhbHVlcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4TlBVdGlscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5QVXRpbHMu Y3BwCmluZGV4IGM2NTM4MjVmZjA2MjkzZGZlNWQ0MjRiZWIyZmVlZDllZDUyOGMwNjkuLmNhOWUx ZWE3MGRhZTMwNmVjNjM1OWM4NzlmZmViZmQyM2VlZDgxOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TlBVdGlscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhOUFV0aWxzLmNwcApAQCAtMzcsNiArMzcsNyBAQAogI2luY2x1ZGUgIm5wcnVu dGltZV9pbXBsLmgiCiAjaW5jbHVkZSAibnBydW50aW1lX3ByaXYuaCIKICNpbmNsdWRlICJOUFY4 T2JqZWN0LmgiCisjaW5jbHVkZSAiVjhCaW5kaW5nLmgiCiAjaW5jbHVkZSAiVjhOUE9iamVjdC5o IgogI2luY2x1ZGUgIlY4UHJveHkuaCIKIApAQCAtODYsNyArODcsNyBAQCB2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gY29udmVydE5QVmFyaWFudFRvVjhPYmplY3QoY29uc3QgTlBWYXJpYW50KiB2YXJp YW50LCBOUE9iagogICAgIGNhc2UgTlBWYXJpYW50VHlwZV9Eb3VibGU6CiAgICAgICAgIHJldHVy biB2ODo6TnVtYmVyOjpOZXcoTlBWQVJJQU5UX1RPX0RPVUJMRSgqdmFyaWFudCkpOwogICAgIGNh c2UgTlBWYXJpYW50VHlwZV9Cb29sOgotICAgICAgICByZXR1cm4gTlBWQVJJQU5UX1RPX0JPT0xF QU4oKnZhcmlhbnQpID8gdjg6OlRydWUoKSA6IHY4OjpGYWxzZSgpOworICAgICAgICByZXR1cm4g djhCb29sZWFuKE5QVkFSSUFOVF9UT19CT09MRUFOKCp2YXJpYW50KSk7CiAgICAgY2FzZSBOUFZh cmlhbnRUeXBlX051bGw6CiAgICAgICAgIHJldHVybiB2ODo6TnVsbCgpOwogICAgIGNhc2UgTlBW YXJpYW50VHlwZV9Wb2lkOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4RE9NU3RyaW5nTWFwQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOERPTVN0cmluZ01hcEN1c3RvbS5jcHAKaW5kZXggODUxZDllMGQ4MjFlYjM3 YzEzYjQ4YWE1ZDdmMTUxOTc3ZjRiOTBiZi4uZDg1NWU0ODMxZjg5YTFmZThhMWY2NTQwMmE1NjAw OTY0OTk2YTBlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4RE9NU3RyaW5nTWFwQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhET01TdHJpbmdNYXBDdXN0b20uY3BwCkBAIC03MSw3ICs3MSw3IEBAIHY4OjpI YW5kbGU8djg6OkJvb2xlYW4+IFY4RE9NU3RyaW5nTWFwOjpuYW1lZFByb3BlcnR5RGVsZXRlcih2 ODo6TG9jYWw8djg6OlN0cmluCiAgICAgSU5DX1NUQVRTKCJET00uRE9NU3RyaW5nTWFwLk5hbWVk UHJvcGVydHlEZWxldGVyIik7CiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAgVjhET01T dHJpbmdNYXA6OnRvTmF0aXZlKGluZm8uSG9sZGVyKCkpLT5kZWxldGVJdGVtKHRvV2ViQ29yZVN0 cmluZyhuYW1lKSwgZWMpOwotICAgIHJldHVybiBlYyA/IHY4OjpGYWxzZSgpIDogdjg6OlRydWUo KTsKKyAgICByZXR1cm4gdjhCb29sZWFuKCFlYyk7CiB9CiAKIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBWOERPTVN0cmluZ01hcDo6bmFtZWRQcm9wZXJ0eVNldHRlcih2ODo6TG9jYWw8djg6OlN0cmlu Zz4gbmFtZSwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGNvbnN0IHY4OjpBY2Nlc3Nvcklu Zm8mIGluZm8pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhJbmplY3RlZFNjcmlwdEhvc3RDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4SW5qZWN0ZWRTY3JpcHRIb3N0Q3VzdG9tLmNwcAppbmRleCBhMTEzNjUwYWQ4 Mzg0YjVkZWY0OTUwZjE2NzgzNDc0NjkxNTIwMTc0Li45NzIyYWM3N2RkMzIwMWM5ZDBhNmRjYTkx Y2NlZTAzMzIyZTYxYmUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhJbmplY3RlZFNjcmlwdEhvc3RDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluamVjdGVkU2NyaXB0SG9zdEN1c3RvbS5jcHAKQEAgLTEx MCw3ICsxMTAsNyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhJbmplY3RlZFNjcmlwdEhvc3Q6 OmlzSFRNTEFsbENvbGxlY3Rpb25DYWxsYmFjayhjb25zdCB2OAogICAgICAgICByZXR1cm4gdjg6 OlVuZGVmaW5lZCgpOwogCiAgICAgaWYgKCFhcmdzWzBdLT5Jc09iamVjdCgpKQotICAgICAgICBy ZXR1cm4gdjg6OkZhbHNlKCk7CisgICAgICAgIHJldHVybiB2OEJvb2xlYW4oZmFsc2UpOwogCiAg ICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOwogICAgIHJldHVybiB2ODo6Qm9vbGVhbjo6 TmV3KFY4SFRNTEFsbENvbGxlY3Rpb246Okhhc0luc3RhbmNlKGFyZ3NbMF0pKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFnZUN1c3RvbS5jcHAK aW5kZXggZjUyNTdiOWE5MmQ0ZWVjNTE3NWRhODNkMTBiOGUzOTU0ZTYzOTY2Mi4uMWJhYTBkYTFj Nzg1ZDM0YmRmOWQxODM5OTIwNDhhM2RkN2ExMzQ3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFnZUN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFnZUN1c3RvbS5jcHAKQEAgLTEzMyw3ICsx MzMsNyBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6Qm9vbGVhbj4gc3RvcmFnZURlbGV0ZXIodjg6 OkxvY2FsPHY4OjpTdHJpbmc+IHY4TmFtZSwgY29ucwogICAgIAogICAgIGlmIChzdG9yYWdlLT5j b250YWlucyhuYW1lKSkgewogICAgICAgICBzdG9yYWdlLT5yZW1vdmVJdGVtKG5hbWUpOwotICAg ICAgICByZXR1cm4gdjg6OlRydWUoKTsKKyAgICAgICAgcmV0dXJuIHY4Qm9vbGVhbih0cnVlKTsK ICAgICB9CiAKICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6Qm9vbGVhbj4oKTsK