87694 2012-05-28 22:42:07 -0700 [CSS] Move StyleResolver::canShareStyleWithElement to StyledElement as virtual method 2022-07-13 15:33:07 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 80381 1 yosin webkit-unassigned bfulgham eric oldest_to_newest 635585 0 yosin 2012-05-28 22:42:07 -0700 I would like to move StyleResolver::canShareStyleWithElement to StyleElement class as virtual method. The reasons are: 1. Move hasTagName checking to class which implements element. This also removes some #if, e.g. ENABLE(PROGRESS_TAG) 2. Control sharing in fine grain, e.g. if (element->hasTagName(optionTag)) return false is too conservative. Call site changes are: inline StyledElement* StyleResolver::findSiblingForStyleSharing(Node* node, unsigned& count) const { for (; node; node = node->previousSibling()) { if (!node->isStyledElement()) continue; NOW: if (canShareStyleWithElement(static_cast<StyledElement*>(node))) NEW: if (m_element->canShareStyleWithElement(static_cast<StyledElement*>(node))) break; .... } 861836 1 eric 2013-03-22 14:16:45 -0700 canShareStyleWith is an insanity-hot function. I do not recommend this approach, unless you're finding ways to avoid calling it. 1883418 2 bfulgham 2022-07-13 15:33:07 -0700 This code has been significantly refactored since this patch was proposed. There doesn't seem to be any action we can take here.