87646 2012-05-28 03:15:51 -0700 Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless> 2012-09-18 12:01:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 45950 1 eric eric abarth aestes bdakin jberlin lforschler sam webkit-bug-importer webkit.review.bot oldest_to_newest 635081 0 eric 2012-05-28 03:15:51 -0700 Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless> 635084 1 144320 eric 2012-05-28 03:18:46 -0700 Created attachment 144320 Patch 635098 2 eric 2012-05-28 03:51:21 -0700 Apple may want to pull this into their release branches, since I believe they've disabled seamless there. 636380 3 webkit-bug-importer 2012-05-29 13:23:19 -0700 <rdar://problem/11550608> 636752 4 144320 webkit.review.bot 2012-05-29 19:28:33 -0700 Comment on attachment 144320 Patch Clearing flags on attachment: 144320 Committed r118883: <http://trac.webkit.org/changeset/118883> 636753 5 webkit.review.bot 2012-05-29 19:28:38 -0700 All reviewed patches have been landed. Closing bug. 637590 6 sam 2012-05-30 13:13:23 -0700 What is the symptom if this bug is not incorporated? Is there a user visible effect? 637614 7 abarth 2012-05-30 13:27:29 -0700 > What is the symptom if this bug is not incorporated? Is there a user visible effect? The symptom is that an iframe with the seamless attribute would exhibit some of the seamless behaviors (e.g., style inheritance), but not all of them (e.g., redirected navigation). The effect should only be visible in content that attempts to use the seamless attribute. 637706 8 sam 2012-05-30 14:41:12 -0700 (In reply to comment #7) > > What is the symptom if this bug is not incorporated? Is there a user visible effect? > > The symptom is that an iframe with the seamless attribute would exhibit some of the seamless behaviors (e.g., style inheritance), but not all of them (e.g., redirected navigation). The effect should only be visible in content that attempts to use the seamless attribute. Thanks Adam. 144320 2012-05-28 03:18:46 -0700 2012-05-29 19:28:33 -0700 Patch bug-87646-20120528031845.patch text/plain 2715 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTYzNDMwMjc4MmVmN2Zk ZGMxY2MwYTRjNGE2YTFkYzZhN2RhMDM0Ny4uNmFkYTFkYTA2MmRhNDhjNjVhZmIyZDM5YTY3MjEz NWZiNjliMGQzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA1LTI4ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggRU5BQkxFX0lGUkFNRV9T RUFNTEVTUyB0byBhY3R1YWxseSBmdWxseSBkaXNhYmxlIDxpZnJhbWUgc2VhbWxlc3M+CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzY0NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHRoZSBwcm9jZXNz IG9mIG1vdmluZyB0aGUgc2VhbWxlc3MgZmVhdHVyZSBvdXQgb2YgZ2l0aHViIGFuZCBpbnRvIGJ1 Z3Mud2Via2l0Lm9yZworICAgICAgICBtdWx0aXBsZSB2ZXJzaW9ucyBvZiB0aGUgc2hvdWxkRGlz cGxheVNlYW1sZXNzbHkgZnVuY3Rpb24gZ290IHdyaXR0ZW4KKyAgICAgICAgKGFuZCBtb3ZlZCBm cm9tIEhUTUxJRnJhbWVFbGVtZW50IHRvIERvY3VtZW50KSwgYnV0IG9ubHkgb25lIG9mIHRoZW0g d2FzIHdyYXBwZWQKKyAgICAgICAgaW4gRU5BQkxFX0lGUkFNRV9TRUFNTEVTUy4gIEhUTUxJRnJh bWVFbGVtZW50IHdhcyBjaGVja2luZyBtYXlEaXNwbGF5U2VhbWxlc3NseQorICAgICAgICBkaXJl Y3RseSAoYXMgd2FzIG15IG9yaWdpbmFsIGRlc2lnbiksIHdoaWNoIGdvdCBhcm91bmQgdGhlIEVO QUJMRV9JRlJBTUVfU0VBTUxFU1MgY2hlY2suCisgICAgICAgIEkndmUgZml4ZWQgdGhpcyBvdmVy c2lnaHQsIGFuZCB0aGUgZmVhdHVyZSBpcyBub3cgb2ZmIHdoZW4gd2UgdGVsbCBpdCB0byBiZSBv ZmYuCisKKyAgICAgICAgVGhpcyBpcyBjb3ZlcmVkIGJ5IG1hbnkgZXhpc3RpbmcgdGVzdHMuICBJ J3ZlIHZlcmlmaWVkIGxvY2FsbHkgdGhhdAorICAgICAgICBhbGwgdGVzdHMgZmFpbCB3aGVuIEVO QUJMRV9JRlJBTUVfU0VBTUxFU1MgaXMgZGlzYWJsZWQgaW5zdGVhZCBvZgorICAgICAgICBvbmx5 IHNvbWUgb2YgdGhlbS4KKworICAgICAgICAqIGRvbS9TZWN1cml0eUNvbnRleHQuaDoKKyAgICAg ICAgKFNlY3VyaXR5Q29udGV4dCk6CisgICAgICAgICogaHRtbC9IVE1MSUZyYW1lRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSUZyYW1lRWxlbWVudDo6c2hvdWxkRGlzcGxheVNl YW1sZXNzbHkpOgorCiAyMDEyLTA1LTI4ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTE4NjUwLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NlY3VyaXR5Q29udGV4dC5oIGIvU291cmNl L1dlYkNvcmUvZG9tL1NlY3VyaXR5Q29udGV4dC5oCmluZGV4IGZlYmQxMjI2MTFhY2I3ZTA4NzJj YzA3MDY2ZTJjMGNmODMzMzdkZjMuLjdiNDc0NmQxMzdlOGEzNzMzYmFjNTEyZDMwZjU4M2UzZjE1 YWUyNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWN1cml0eUNvbnRleHQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2VjdXJpdHlDb250ZXh0LmgKQEAgLTY3LDggKzY3LDYg QEAgcHVibGljOgogCiAgICAgc3RhdGljIFNhbmRib3hGbGFncyBwYXJzZVNhbmRib3hQb2xpY3ko Y29uc3QgU3RyaW5nJiBwb2xpY3kpOwogCi0gICAgYm9vbCBtYXlEaXNwbGF5U2VhbWxlc3NXaXRo UGFyZW50KCkgY29uc3QgeyByZXR1cm4gbV9tYXlEaXNwbGF5U2VhbWxlc3NXaXRoUGFyZW50OyB9 Ci0KIHByb3RlY3RlZDoKICAgICBTZWN1cml0eUNvbnRleHQoKTsKICAgICB+U2VjdXJpdHlDb250 ZXh0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJRnJhbWVFbGVtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElGcmFtZUVsZW1lbnQuY3BwCmluZGV4IGRj NGQ0MzU4NjVjYjgzMGE5NGY1NmNmMzZkM2MyYzMwOTA5MmMxYmUuLjBlYmUwOTQ2OWM2YzA0MTE1 YmY5OGFiNTA1NmRlYjJjZmEyYzhlYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTElGcmFtZUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElGcmFt ZUVsZW1lbnQuY3BwCkBAIC0xMjIsNyArMTIyLDcgQEAgdm9pZCBIVE1MSUZyYW1lRWxlbWVudDo6 cmVtb3ZlZEZyb20oQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9uUG9pbnQpCiAKIGJvb2wgSFRNTElG cmFtZUVsZW1lbnQ6OnNob3VsZERpc3BsYXlTZWFtbGVzc2x5KCkgY29uc3QKIHsKLSAgICByZXR1 cm4gY29udGVudERvY3VtZW50KCkgJiYgY29udGVudERvY3VtZW50KCktPm1heURpc3BsYXlTZWFt bGVzc1dpdGhQYXJlbnQoKSAmJiBoYXNBdHRyaWJ1dGUoc2VhbWxlc3NBdHRyKTsKKyAgICByZXR1 cm4gY29udGVudERvY3VtZW50KCkgJiYgY29udGVudERvY3VtZW50KCktPnNob3VsZERpc3BsYXlT ZWFtbGVzc2x5V2l0aFBhcmVudCgpOwogfQogCiB2b2lkIEhUTUxJRnJhbWVFbGVtZW50OjpkaWRS ZWNhbGNTdHlsZShTdHlsZUNoYW5nZSBzdHlsZUNoYW5nZSkK