87641 2012-05-28 02:12:52 -0700 [Shadow DOM] Add an assertion to make sure that an inaccessible node is not set to event's target or relatedTarget in event dispatching 2012-06-18 15:58:13 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59805 1 hayato hayato dglazkov dominicc morrita shinyak tasak webkit.review.bot oldest_to_newest 635029 0 hayato 2012-05-28 02:12:52 -0700 We should have an assertion to make sure that an inaccessible node is not set to event's target or relatedTarget in event dispatching. 635140 1 144335 hayato 2012-05-28 05:06:27 -0700 Created attachment 144335 add assertions 636128 2 144335 dglazkov 2012-05-29 09:44:31 -0700 Comment on attachment 144335 add assertions View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review > Source/WebCore/dom/EventContext.h:52 > + bool accessible(Node*); Might as well not compile it in NDEBUG. 636710 3 hayato 2012-05-29 18:45:37 -0700 Thank you for the review. (In reply to comment #2) > (From update of attachment 144335 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review > > > Source/WebCore/dom/EventContext.h:52 > > + bool accessible(Node*); > > Might as well not compile it in NDEBUG. Okay. I'll guard it using NDEBUG. Let me land this patch after that. 636730 4 144676 hayato 2012-05-29 19:07:30 -0700 Created attachment 144676 Patch for landing 636796 5 144676 webkit.review.bot 2012-05-29 21:06:09 -0700 Comment on attachment 144676 Patch for landing Clearing flags on attachment: 144676 Committed r118889: <http://trac.webkit.org/changeset/118889> 636797 6 webkit.review.bot 2012-05-29 21:06:14 -0700 All reviewed patches have been landed. Closing bug. 144335 2012-05-28 05:06:27 -0700 2012-05-29 19:07:24 -0700 add assertions bug-87641-20120528210626.patch text/plain 2928 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIyYmZlODk3ZjYxYjE4 MWYyMzljYWNiZmQ4YmZmMzEzZWE0NjAxMi4uNTY1ODdmMWExMTc1ZTNhMmZkNjhlZDA2ZmE1YzU3 OTFlN2U5ZGY4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTI4ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYXNzZXJ0aW9ucyB0 byBtYWtlIHN1cmUgdGhhdCBldmVudCdzIHRhcmdldCBhbmQgcmVsYXRlZFRhcmdldCBhcmUgYWNj ZXNzaWJsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg3NjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBObyBuZXcgZnVuY3Rpb25hbGl0eSBleGNlcHQgZm9yIGFzc2VydGlvbnMu CisKKyAgICAgICAgKiBkb20vRXZlbnRDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2 ZW50Q29udGV4dDo6RXZlbnRDb250ZXh0KToKKyAgICAgICAgKiBkb20vRXZlbnRDb250ZXh0Lmg6 CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKEV2ZW50Q29udGV4dCk6CisgICAgICAgIChX ZWJDb3JlOjpFdmVudENvbnRleHQ6OnNldFJlbGF0ZWRUYXJnZXQpOgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRDb250ZXh0OjphY2Nlc3NpYmxlKToKKwogMjAxMi0wNS0yNyAgU2hpbnlhIEthd2Fu YWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgY3V0LCBjb3B5IG9yIHBhc3Rl IGV2ZW50IHdvbid0IGJlIGZpcmVkIGluIFNoYWRvdyBET00uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRXZlbnRDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudENv bnRleHQuY3BwCmluZGV4IDgwOTRiYTBiYjM4NjVkMzYyZTY1ODAxMWI3OWYxMDA5ZjIwZWE4NzYu LmJmZmI1OTJhMGMyNjJkZDM1OWRjMmMwZWE2NjA4YTMyM2U5OTJiZTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9FdmVudENvbnRleHQuY3BwCkBAIC00MSw2ICs0MSw4IEBAIEV2ZW50Q29udGV4dDo6RXZlbnRD b250ZXh0KFBhc3NSZWZQdHI8Tm9kZT4gbm9kZSwgUGFzc1JlZlB0cjxFdmVudFRhcmdldD4gY3Vy cmVuCiAgICAgLCBtX3RhcmdldCh0YXJnZXQpCiAgICAgLCBtX3JlbGF0ZWRUYXJnZXQoMCkKIHsK KyAgICBBU1NFUlQobV9ub2RlKTsKKyAgICBBU1NFUlQoIW1fdGFyZ2V0IHx8IG1fdGFyZ2V0LT50 b05vZGUoKSB8fCBhY2Nlc3NpYmxlKG1fdGFyZ2V0LT50b05vZGUoKSkpOwogfQogCiB2b2lkIEV2 ZW50Q29udGV4dDo6aGFuZGxlTG9jYWxFdmVudHMoRXZlbnQqIGV2ZW50KSBjb25zdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50Q29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUv ZG9tL0V2ZW50Q29udGV4dC5oCmluZGV4IDYzMjU4MTAwOTBjMDQyOTcyNjljZTUyZTcwZTJkZDEw YWRkMTQ0MDkuLjYxYTAyNjgwMzQyMWNmYWY5NTNmYTg4OGJmNjNiZmMwYzFiZWZlOTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRXZlbnRDb250ZXh0LmgKQEAgLTI3LDEzICsyNywxNCBAQAogI2lmbmRlZiBFdmVu dENvbnRleHRfaAogI2RlZmluZSBFdmVudENvbnRleHRfaAogCisjaW5jbHVkZSAiRXZlbnRUYXJn ZXQuaCIKKyNpbmNsdWRlICJOb2RlLmgiCisjaW5jbHVkZSAiVHJlZVNjb3BlLmgiCiAjaW5jbHVk ZSA8d3RmL1JlZlB0ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIEV2ZW50VGFy Z2V0OwogY2xhc3MgRXZlbnQ7Ci1jbGFzcyBOb2RlOwogCiBjbGFzcyBFdmVudENvbnRleHQgewog cHVibGljOgpAQCAtNDgsNiArNDksNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRSZWxhdGVkVGFy Z2V0KFBhc3NSZWZQdHI8RXZlbnRUYXJnZXQ+KTsKIAogcHJpdmF0ZToKKyAgICBib29sIGFjY2Vz c2libGUoTm9kZSopOwogICAgIFJlZlB0cjxOb2RlPiBtX25vZGU7CiAgICAgUmVmUHRyPEV2ZW50 VGFyZ2V0PiBtX2N1cnJlbnRUYXJnZXQ7CiAgICAgUmVmUHRyPEV2ZW50VGFyZ2V0PiBtX3Rhcmdl dDsKQEAgLTc2LDkgKzc4LDIxIEBAIGlubGluZSBFdmVudFRhcmdldCogRXZlbnRDb250ZXh0Ojpy ZWxhdGVkVGFyZ2V0KCkgY29uc3QKIAogaW5saW5lIHZvaWQgRXZlbnRDb250ZXh0OjpzZXRSZWxh dGVkVGFyZ2V0KFBhc3NSZWZQdHI8RXZlbnRUYXJnZXQ+IHJlbGF0ZWRUYXJnZXQpCiB7CisgICAg QVNTRVJUKCFyZWxhdGVkVGFyZ2V0IHx8ICFyZWxhdGVkVGFyZ2V0LT50b05vZGUoKSB8fCBhY2Nl c3NpYmxlKHJlbGF0ZWRUYXJnZXQtPnRvTm9kZSgpKSk7CiAgICAgbV9yZWxhdGVkVGFyZ2V0ID0g cmVsYXRlZFRhcmdldDsKIH0KIAoraW5saW5lIGJvb2wgRXZlbnRDb250ZXh0OjphY2Nlc3NpYmxl KE5vZGUqIHRhcmdldCkKK3sKKyAgICBBU1NFUlQodGFyZ2V0KTsKKyAgICBUcmVlU2NvcGUqIHRh cmdldFNjb3BlID0gdGFyZ2V0LT50cmVlU2NvcGUoKTsKKyAgICBmb3IgKFRyZWVTY29wZSogc2Nv cGUgPSBtX25vZGUtPnRyZWVTY29wZSgpOyBzY29wZTsgc2NvcGUgPSBzY29wZS0+cGFyZW50VHJl ZVNjb3BlKCkpIHsKKyAgICAgICAgaWYgKHNjb3BlID09IHRhcmdldFNjb3BlKQorICAgICAgICAg ICAgcmV0dXJuIHRydWU7CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKK30KKwogfQogCiAjZW5k aWYgLy8gRXZlbnRDb250ZXh0X2gK 144676 2012-05-29 19:07:30 -0700 2012-05-29 21:06:09 -0700 Patch for landing bug-87641-20120530110729.patch text/plain 2977 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIyYmZlODk3ZjYxYjE4 MWYyMzljYWNiZmQ4YmZmMzEzZWE0NjAxMi4uNjdlOTcwZWRlZDJlMWVkYjYxNmQyYzU5ODJhNWFi MTQ4NjY0Yjg4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTI4ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYXNzZXJ0aW9ucyB0 byBtYWtlIHN1cmUgdGhhdCBldmVudCdzIHRhcmdldCBhbmQgcmVsYXRlZFRhcmdldCBhcmUgYWNj ZXNzaWJsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg3NjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gTm8gbmV3IGZ1bmN0aW9uYWxpdHkgZXhjZXB0IGZvciBhc3NlcnRpb25z LgorCisgICAgICAgICogZG9tL0V2ZW50Q29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpF dmVudENvbnRleHQ6OkV2ZW50Q29udGV4dCk6CisgICAgICAgICogZG9tL0V2ZW50Q29udGV4dC5o OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChFdmVudENvbnRleHQpOgorICAgICAgICAo V2ViQ29yZTo6RXZlbnRDb250ZXh0OjpzZXRSZWxhdGVkVGFyZ2V0KToKKyAgICAgICAgKFdlYkNv cmU6OkV2ZW50Q29udGV4dDo6YWNjZXNzaWJsZSk6CisKIDIwMTItMDUtMjcgIFNoaW55YSBLYXdh bmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGN1dCwgY29weSBvciBwYXN0 ZSBldmVudCB3b24ndCBiZSBmaXJlZCBpbiBTaGFkb3cgRE9NLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0V2ZW50Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRD b250ZXh0LmNwcAppbmRleCA4MDk0YmEwYmIzODY1ZDM2MmU2NTgwMTFiNzlmMTAwOWYyMGVhODc2 Li5iZmZiNTkyYTBjMjYyZGQzNTlkYzJjMGVhNjYwOGEzMjNlOTkyYmU4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRXZlbnRDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRXZlbnRDb250ZXh0LmNwcApAQCAtNDEsNiArNDEsOCBAQCBFdmVudENvbnRleHQ6OkV2ZW50 Q29udGV4dChQYXNzUmVmUHRyPE5vZGU+IG5vZGUsIFBhc3NSZWZQdHI8RXZlbnRUYXJnZXQ+IGN1 cnJlbgogICAgICwgbV90YXJnZXQodGFyZ2V0KQogICAgICwgbV9yZWxhdGVkVGFyZ2V0KDApCiB7 CisgICAgQVNTRVJUKG1fbm9kZSk7CisgICAgQVNTRVJUKCFtX3RhcmdldCB8fCBtX3RhcmdldC0+ dG9Ob2RlKCkgfHwgYWNjZXNzaWJsZShtX3RhcmdldC0+dG9Ob2RlKCkpKTsKIH0KIAogdm9pZCBF dmVudENvbnRleHQ6OmhhbmRsZUxvY2FsRXZlbnRzKEV2ZW50KiBldmVudCkgY29uc3QKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQuaCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9FdmVudENvbnRleHQuaAppbmRleCA2MzI1ODEwMDkwYzA0Mjk3MjY5Y2U1MmU3MGUyZGQx MGFkZDE0NDA5Li4xMmM4MTU2OTUwYTdjYTM2ZWU0NDVmNDA1NTQyZTkzMzI3NjRmMjQzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRDb250ZXh0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0V2ZW50Q29udGV4dC5oCkBAIC0yNywxMyArMjcsMTQgQEAKICNpZm5kZWYgRXZl bnRDb250ZXh0X2gKICNkZWZpbmUgRXZlbnRDb250ZXh0X2gKIAorI2luY2x1ZGUgIkV2ZW50VGFy Z2V0LmgiCisjaW5jbHVkZSAiTm9kZS5oIgorI2luY2x1ZGUgIlRyZWVTY29wZS5oIgogI2luY2x1 ZGUgPHd0Zi9SZWZQdHIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1jbGFzcyBFdmVudFRh cmdldDsKIGNsYXNzIEV2ZW50OwotY2xhc3MgTm9kZTsKIAogY2xhc3MgRXZlbnRDb250ZXh0IHsK IHB1YmxpYzoKQEAgLTQ4LDYgKzQ5LDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0UmVsYXRlZFRh cmdldChQYXNzUmVmUHRyPEV2ZW50VGFyZ2V0Pik7CiAKIHByaXZhdGU6CisjaWZuZGVmIE5ERUJV RworICAgIGJvb2wgYWNjZXNzaWJsZShOb2RlKik7CisjZW5kaWYKICAgICBSZWZQdHI8Tm9kZT4g bV9ub2RlOwogICAgIFJlZlB0cjxFdmVudFRhcmdldD4gbV9jdXJyZW50VGFyZ2V0OwogICAgIFJl ZlB0cjxFdmVudFRhcmdldD4gbV90YXJnZXQ7CkBAIC03Niw5ICs4MCwyMyBAQCBpbmxpbmUgRXZl bnRUYXJnZXQqIEV2ZW50Q29udGV4dDo6cmVsYXRlZFRhcmdldCgpIGNvbnN0CiAKIGlubGluZSB2 b2lkIEV2ZW50Q29udGV4dDo6c2V0UmVsYXRlZFRhcmdldChQYXNzUmVmUHRyPEV2ZW50VGFyZ2V0 PiByZWxhdGVkVGFyZ2V0KQogeworICAgIEFTU0VSVCghcmVsYXRlZFRhcmdldCB8fCAhcmVsYXRl ZFRhcmdldC0+dG9Ob2RlKCkgfHwgYWNjZXNzaWJsZShyZWxhdGVkVGFyZ2V0LT50b05vZGUoKSkp OwogICAgIG1fcmVsYXRlZFRhcmdldCA9IHJlbGF0ZWRUYXJnZXQ7CiB9CiAKKyNpZm5kZWYgTkRF QlVHCitpbmxpbmUgYm9vbCBFdmVudENvbnRleHQ6OmFjY2Vzc2libGUoTm9kZSogdGFyZ2V0KQor eworICAgIEFTU0VSVCh0YXJnZXQpOworICAgIFRyZWVTY29wZSogdGFyZ2V0U2NvcGUgPSB0YXJn ZXQtPnRyZWVTY29wZSgpOworICAgIGZvciAoVHJlZVNjb3BlKiBzY29wZSA9IG1fbm9kZS0+dHJl ZVNjb3BlKCk7IHNjb3BlOyBzY29wZSA9IHNjb3BlLT5wYXJlbnRUcmVlU2NvcGUoKSkgeworICAg ICAgICBpZiAoc2NvcGUgPT0gdGFyZ2V0U2NvcGUpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK KyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorI2VuZGlmCisKIH0KIAogI2VuZGlmIC8vIEV2 ZW50Q29udGV4dF9oCg==