87485 2012-05-25 03:16:11 -0700 [WTF] Introduce UINT64_C to MathExtras.h 2012-05-27 19:26:57 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87360 1 yosin yosin tkent webkit.review.bot oldest_to_newest 633784 0 yosin 2012-05-25 03:16:11 -0700 WebSocket implementation and decimal arithmetic implementation(BUG-87360) use 64bit unsigned int literal. However, UINT64_C macro isn't available for all platforms, e.g. Qt. 633790 1 144029 yosin 2012-05-25 03:25:27 -0700 Created attachment 144029 Patch 1 634048 2 ap 2012-05-25 10:36:12 -0700 Should this patch be marked for review? 634832 3 144029 yosin 2012-05-27 18:14:03 -0700 Comment on attachment 144029 Patch 1 Could you review this patch? Thanks in advance. P.S. Oops, I forgot to mark r?. :< 634833 4 144029 tkent 2012-05-27 18:33:02 -0700 Comment on attachment 144029 Patch 1 Looks good. 634846 5 144029 webkit.review.bot 2012-05-27 19:26:52 -0700 Comment on attachment 144029 Patch 1 Clearing flags on attachment: 144029 Committed r118643: <http://trac.webkit.org/changeset/118643> 634847 6 webkit.review.bot 2012-05-27 19:26:57 -0700 All reviewed patches have been landed. Closing bug. 144029 2012-05-25 03:25:27 -0700 2012-05-27 19:26:52 -0700 Patch 1 bug-87485-20120525192526.patch text/plain 3231 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFhYWU0MWRiNTNjYjFkNzdkMzRmMWEy N2UyMjNhZjAyZTgxZDJlMDkuLmVjMGM4ODEwMGQ5MjZhZmUzOTIzMGEwYzFlZmJkYWI4ZjRlZDI3 MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDUtMjUgIFlvc2hpZnVtaSBJbm91ZSAgPHlv c2luQGNocm9taXVtLm9yZz4KKworICAgICAgICBbV1RGXSBJbnRyb2R1Y2UgVUlOVDY0X0MgdG8g TWF0aEV4dHJhcy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzQ4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogd3RmL01hdGhFeHRyYXMuaDoKKwogMjAxMi0wNS0yMyAgRGFyaW4gQWRsZXIgIDxkYXJp bkBhcHBsZS5jb20+CiAKICAgICAgICAgT3B0aW1pemUgaXRlcmF0aW9uIG9mIGVtcHR5IGhhc2gg dGFibGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggYTUzMDkwNzJmYzBmZDM3NzhkZjY2NDIzM2Q5N2NhMmJlZTQ2 ZTRlNC4uMGE5OTcwZDE3Njk0NGIzYjc3MGI5MmUzYTk5NjIxNGZjM2U1ZDEyYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTI1ICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1dURl0gSW50cm9kdWNlIFVJTlQ2NF9DIHRvIE1hdGhF eHRyYXMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODc0ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGludHJvZHVjZXMgVUlOVDY0X0MgZm9yIGFsbCBwbGF0Zm9ybXMgdG8gYXZvaWQg dXNpbmcKKyAgICAgICAgY29uZGl0aW9uYWwgY29tcGlsYXRpb24uCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiBUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIGJlaGF2aW9yLgorCisgICAgICAgICog TW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldEZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldlYlNvY2tldEZyYW1lOjpwYXJzZUZyYW1lKTogUmVwbGFjZSBjb25kaXRpb25hbCBjb21waWxh dGlvbiB3aXRoIFVJTlQ2NF9DLgorCiAyMDEyLTA1LTI0ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlu eWFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBFbGVtZW50cyBpbiBTaGFkb3cgRE9NIGFyZSBu b3QgcmVzaXphYmxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oIGIv U291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCmluZGV4IDk1NmZjOTRjYzBkNDNkMDkyYzBkMGZj ZGI3ZWY2ODgyNzU3MzI5NTguLjE1NGM4ODcyNTdmNDdiZTc5NDkyYjgzY2Y4NTU1ZTVmNzYwM2Rj ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAorKysgYi9Tb3VyY2Uv V1RGL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTMwMiw2ICszMDIsMTQgQEAgdXNpbmcgc3RkOjp3dGZf aXNuYW47CiAjZGVmaW5lIGlzbmFuKHgpIHd0Zl9pc25hbih4KQogI2VuZGlmCiAKKyNpZm5kZWYg VUlOVDY0X0MKKyNpZiBDT01QSUxFUihNU1ZDKQorI2RlZmluZSBVSU5UNjRfQyhjKSBjICMjIHVp NjQKKyNlbHNlCisjZGVmaW5lIFVJTlQ2NF9DKGMpIGMgIyMgdWxsCisjZW5kaWYKKyNlbmRpZgor CiAKIC8vIGRlY29tcG9zZSAnbnVtYmVyJyB0byBpdHMgc2lnbiwgZXhwb25lbnQsIGFuZCBtYW50 aXNzYSBjb21wb25lbnRzLgogLy8gVGhlIHJlc3VsdCBpcyBpbnRlcnByZXRlZCBhczoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXRGcmFtZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0RnJhbWUuY3Bw CmluZGV4IGZhNmYzODQ1ZWEyZDNmYTY5OGZjMTAyN2I2MGJiOTY0MTkzNzdmM2YuLmEyODc2ZWFk YmYxNjUwZmZmYWE4NDFkNTgwYTg3MTI4MTc3NTI4ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXRGcmFtZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldEZyYW1lLmNwcApAQCAtMjcsNiArMjcs NyBAQAogI2luY2x1ZGUgIldlYlNvY2tldEZyYW1lLmgiCiAKICNpbmNsdWRlIDx3dGYvQ3J5cHRv Z3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuaD4KKyNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgog CiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCkBAIC05NCwxMiArOTUsNyBAQCBXZWJTb2NrZXRGcmFt ZTo6UGFyc2VGcmFtZVJlc3VsdCBXZWJTb2NrZXRGcmFtZTo6cGFyc2VGcmFtZShjaGFyKiBkYXRh LCBzaXplX3QgZAogICAgICAgICB9CiAgICAgfQogCi0gICAgLy8gRklYTUU6IFVJTlQ2NF9DKDB4 N0ZGRkZGRkZGRkZGRkZGRikgc2hvdWxkIGJlIHVzZWQgYnV0IGl0IGRpZCBub3QgY29tcGlsZSBv biBRdCBib3RzLgotI2lmIENPTVBJTEVSKE1TVkMpCi0gICAgc3RhdGljIGNvbnN0IHVpbnQ2NF90 IG1heFBheWxvYWRMZW5ndGggPSAweDdGRkZGRkZGRkZGRkZGRkZ1aTY0OwotI2Vsc2UKLSAgICBz dGF0aWMgY29uc3QgdWludDY0X3QgbWF4UGF5bG9hZExlbmd0aCA9IDB4N0ZGRkZGRkZGRkZGRkZG RnVsbDsKLSNlbmRpZgorICAgIHN0YXRpYyBjb25zdCB1aW50NjRfdCBtYXhQYXlsb2FkTGVuZ3Ro ID0gVUlOVDY0X0MoMHg3RkZGRkZGRkZGRkZGRkZGKTsKICAgICBzaXplX3QgbWFza2luZ0tleUxl bmd0aCA9IG1hc2tlZCA/IG1hc2tpbmdLZXlXaWR0aEluQnl0ZXMgOiAwOwogICAgIGlmIChwYXls b2FkTGVuZ3RoNjQgPiBtYXhQYXlsb2FkTGVuZ3RoIHx8IHBheWxvYWRMZW5ndGg2NCArIG1hc2tp bmdLZXlMZW5ndGggPiBudW1lcmljX2xpbWl0czxzaXplX3Q+OjptYXgoKSkgewogICAgICAgICBl cnJvclN0cmluZyA9ICJXZWJTb2NrZXQgZnJhbWUgbGVuZ3RoIHRvbyBsYXJnZTogIiArIFN0cmlu Zzo6bnVtYmVyKHBheWxvYWRMZW5ndGg2NCkgKyAiIGJ5dGVzIjsK