87468 2012-05-25 00:49:34 -0700 REGRESSION(r118461): Breaks two chromium browser_tests. (Requested by vsevik on #webkit). 2022-03-01 03:06:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86819 1 webkit.review.bot webkit.review.bot abarth aelias vsevik oldest_to_newest 633656 0 webkit.review.bot 2012-05-25 00:49:34 -0700 http://trac.webkit.org/changeset/118461 broke the build: Breaks two chromium browser_tests. (Requested by vsevik on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 633658 1 143995 webkit.review.bot 2012-05-25 00:50:12 -0700 Created attachment 143995 ROLLOUT of r118461 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 633661 2 vsevik 2012-05-25 01:00:05 -0700 Committed: http://trac.webkit.org/changeset/118490 143995 2012-05-25 00:50:12 -0700 2022-03-01 03:06:25 -0800 ROLLOUT of r118461 bug-87468-20120525075428.patch text/plain 3951 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDUzYjdlNTNkMGI5ZjBlNGI2MmY1MTE1YzVjOTc3NzZhOTZhNDk4MTQuLmFiNjYwYTc0ZTVlYzcy MjFkZDE3MjBiMGZlZGVhYTc0NjRhNDFhYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDUtMjUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTg0NjEu CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzExODQ2MQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc0NjgKKworICAgICAg ICBCcmVha3MgdHdvIGNocm9taXVtIGJyb3dzZXJfdGVzdHMuIChSZXF1ZXN0ZWQgYnkgdnNldmlr IG9uCisgICAgICAgICN3ZWJraXQpLgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnJlc2l6ZSk6CisKIDIwMTItMDUtMjQgIFRp bSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGZlYXR1 cmUgZGVmaW5lcyBmb3Igd2ViLWZhY2luZyBwYXJ0cyBvZiBDU1MgUmVnaW9ucyBhbmQgRXhjbHVz aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDc4 M2I5ODkxNzhlNmFmOGFkOTdkZDFiMjBkOWYwNzY2N2JhMTUxNGMuLmE0N2NiMjg1MDgwNTY1Y2Ew NjQ0ZDQ1MGZmOWMyMjlmY2ZmZWUzYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3SW1wbC5jcHAKQEAgLTEzMjYsMjggKzEzMjYsOCBAQCB2b2lkIFdlYlZpZXdJbXBsOjpy ZXNpemUoY29uc3QgV2ViU2l6ZSYgbmV3U2l6ZSkKIHsKICAgICBpZiAobV9zaG91bGRBdXRvUmVz aXplIHx8IG1fc2l6ZSA9PSBuZXdTaXplKQogICAgICAgICByZXR1cm47Ci0KLSAgICBGcmFtZVZp ZXcqIHZpZXcgPSBtYWluRnJhbWVJbXBsKCktPmZyYW1lVmlldygpOwotICAgIGlmICghdmlldykK LSAgICAgICAgcmV0dXJuOwotCi0gICAgV2ViU2l6ZSBvbGRTaXplID0gbV9zaXplOwotICAgIGZs b2F0IG9sZFBhZ2VTY2FsZUZhY3RvciA9IHBhZ2VTY2FsZUZhY3RvcigpOwotICAgIEludFNpemUg b2xkU2Nyb2xsT2Zmc2V0ID0gdmlldy0+c2Nyb2xsT2Zmc2V0KCk7Ci0gICAgaW50IG9sZEZpeGVk TGF5b3V0V2lkdGggPSBmaXhlZExheW91dFNpemUoKS53aWR0aDsKLQogICAgIG1fc2l6ZSA9IG5l d1NpemU7CiAKLSAgICBpZiAoaXNGaXhlZExheW91dE1vZGVFbmFibGVkKCkpIHsKLSAgICAgICAg Ly8gRmFsbGJhY2sgd2lkdGggaXMgdXNlZCB0byBsYXlvdXQgc2l0ZXMgZGVzaWduZWQgZm9yIGRl c2t0b3AuIFRoZQotICAgICAgICAvLyBjb252ZW50aW9uYWwgc2l6ZSB1c2VkIGJ5IGFsbCBtb2Jp bGUgYnJvd3NlcnMgaXMgOTgwLiBXaGVuIGEgbW9iaWxlCi0gICAgICAgIC8vIGRldmljZSBoYXMg YSBwYXJ0aWN1bGFybHkgd2lkZSBzY3JlZW4gKHN1Y2ggYXMgYSAxMCIgdGFibGV0IGhlbGQgaW4K LSAgICAgICAgLy8gbGFuZHNjYXBlKSwgaXQgY2FuIGJlIGxhcmdlci4KLSAgICAgICAgY29uc3Qg aW50IHN0YW5kYXJkRmFsbGJhY2tXaWR0aCA9IDk4MDsKLSAgICAgICAgaW50IGRwaUluZGVwZW5k ZW50Vmlld3BvcnRXaWR0aCA9IG5ld1NpemUud2lkdGggLyBwYWdlKCktPnNldHRpbmdzKCktPmRl ZmF1bHREZXZpY2VTY2FsZUZhY3RvcigpOwotICAgICAgICBzZXR0aW5ncygpLT5zZXRMYXlvdXRG YWxsYmFja1dpZHRoKHN0ZDo6bWF4KHN0YW5kYXJkRmFsbGJhY2tXaWR0aCwgZHBpSW5kZXBlbmRl bnRWaWV3cG9ydFdpZHRoKSk7Ci0gICAgfQotCiAjaWYgRU5BQkxFKFZJRVdQT1JUKQogICAgIGlm IChzZXR0aW5ncygpLT52aWV3cG9ydEVuYWJsZWQoKSkgewogICAgICAgICBWaWV3cG9ydEFyZ3Vt ZW50cyB2aWV3cG9ydEFyZ3VtZW50cyA9IG1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKS0+ZG9jdW1l bnQoKS0+dmlld3BvcnRBcmd1bWVudHMoKTsKQEAgLTEzNjQsMzEgKzEzNDQsNiBAQCB2b2lkIFdl YlZpZXdJbXBsOjpyZXNpemUoY29uc3QgV2ViU2l6ZSYgbmV3U2l6ZSkKICAgICAgICAgICAgIHdl YkZyYW1lLT5mcmFtZVZpZXcoKS0+cmVzaXplKG5ld1NpemUud2lkdGgsIG5ld1NpemUuaGVpZ2h0 KTsKICAgICB9CiAKLSAgICBpZiAoaXNGaXhlZExheW91dE1vZGVFbmFibGVkKCkpIHsKLSAgICAg ICAgLy8gUmVsYXlvdXQgaW1tZWRpYXRlbHkgdG8gb2J0YWluIHRoZSBuZXcgY29udGVudCB3aWR0 aCwgd2hpY2ggaXMgbmVlZGVkCi0gICAgICAgIC8vIHRvIGNhbGN1bGF0ZSB0aGUgbWluaW11bSBz Y2FsZSBsaW1pdC4KLSAgICAgICAgdmlldy0+bGF5b3V0KCk7Ci0gICAgICAgIGNvbXB1dGVQYWdl U2NhbGVGYWN0b3JMaW1pdHMoKTsKLSAgICAgICAgLy8gV2hlbiB0aGUgZGV2aWNlIHJvdGF0ZXM6 Ci0gICAgICAgIC8vIC0gSWYgdGhlIHBhZ2Ugd2lkdGggaXMgdW5jaGFuZ2VkLCB0aGVuIHpvb20g YnkgbmV3IHdpZHRoL29sZCB3aWR0aAotICAgICAgICAvLyAgIHN1Y2ggYXMgdG8ga2VlcCB0aGUg c2FtZSBjb250ZW50IGhvcml6b250YWxseSBvbnNjcmVlbi4KLSAgICAgICAgLy8gLSBJZiB0aGUg cGFnZSB3aWR0aCBzdHJldGNoZXMgcHJvcG9ydGlvbmFsbHkgdG8gdGhlIGNoYW5nZSBpbgotICAg ICAgICAvLyAgIHNjcmVlbiB3aWR0aCwgdGhlbiBkb24ndCB6b29tIGF0IGFsbCAoYXNzdW1pbmcg dGhlIGNvbnRlbnQgaGFzCi0gICAgICAgIC8vICAgc2NhbGVkIHVuaWZvcm1seSwgdGhlbiB0aGUg c2FtZSBjb250ZW50IHdpbGwgYmUgaG9yaXpvbnRhbGx5Ci0gICAgICAgIC8vICAgb25zY3JlZW4p LgotICAgICAgICAvLyAgIC0gSWYgdGhlIHBhZ2Ugd2lkdGggcGFydGlhbGx5IHN0cmV0Y2hlcywg dGhlbiB6b29tIHBhcnRpYWxseSB0bwotICAgICAgICAvLyAgIG1ha2UgdXAgdGhlIGRpZmZlcmVu Y2UuCi0gICAgICAgIC8vIEluIGFsbCBjYXNlcyB0cnkgdG8ga2VlcCB0aGUgc2FtZSBjb250ZW50 IGF0IHRoZSB0b3Agb2YgdGhlIHNjcmVlbi4KLSAgICAgICAgZmxvYXQgdmlld3BvcnRXaWR0aFJh dGlvID0gIW9sZFNpemUud2lkdGggPyAxIDogbmV3U2l6ZS53aWR0aCAvIChmbG9hdCkgb2xkU2l6 ZS53aWR0aDsKLSAgICAgICAgZmxvYXQgZml4ZWRMYXlvdXRXaWR0aFJhdGlvID0gIW9sZEZpeGVk TGF5b3V0V2lkdGggPyAxIDogZml4ZWRMYXlvdXRTaXplKCkud2lkdGggLyAoZmxvYXQpIG9sZEZp eGVkTGF5b3V0V2lkdGg7Ci0gICAgICAgIGZsb2F0IHNjYWxlTXVsdGlwbGllciA9IHZpZXdwb3J0 V2lkdGhSYXRpbyAvIGZpeGVkTGF5b3V0V2lkdGhSYXRpbzsKLSAgICAgICAgaWYgKHNjYWxlTXVs dGlwbGllciAhPSAxKSB7Ci0gICAgICAgICAgICBJbnRTaXplIHNjcm9sbE9mZnNldEF0TmV3U2Nh bGUgPSBvbGRTY3JvbGxPZmZzZXQ7Ci0gICAgICAgICAgICBzY3JvbGxPZmZzZXRBdE5ld1NjYWxl LnNjYWxlKHNjYWxlTXVsdGlwbGllcik7Ci0gICAgICAgICAgICBzZXRQYWdlU2NhbGVGYWN0b3Io b2xkUGFnZVNjYWxlRmFjdG9yICogc2NhbGVNdWx0aXBsaWVyLCBJbnRQb2ludChzY3JvbGxPZmZz ZXRBdE5ld1NjYWxlKSk7Ci0gICAgICAgIH0KLSAgICB9Ci0KICAgICBzZW5kUmVzaXplRXZlbnRB bmRSZXBhaW50KCk7CiB9CiAK