87258 2012-05-23 06:10:54 -0700 Several media/ LayoutTests started crashing around r118091 2012-05-25 15:41:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87285 1 steveblock annacc annacc arv haraken imasaki jberlin jknotten jsbell steveblock vsevik webkit.review.bot oldest_to_newest 631581 0 steveblock 2012-05-23 06:10:54 -0700 The cause is not clear, but several media tests started crashing around r118091 on a number of platforms. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=media%2Fvideo-source-none-supported.html%2Cmedia%2Ftrack%2Ftrack-prefer-captions.html%2Cmedia%2Fvideo-timeupdate-during-playback.html%2Cmedia%2Ftrack%2Ftrack-prefer-captions.html%2Cmedia%2Ftrack%2Ftrack-cues-sorted-before-dispatch.html%2Cmedia%2Ftrack%2Ftrack-cues-seeking.html 631588 1 steveblock 2012-05-23 06:17:14 -0700 Tests are ... media/video-source-none-supported.html media/track/track-prefer-captions.html media/video-timeupdate-during-playback.html media/track/track-cues-sorted-before-dispatch.html media/track/track-cues-seeking.html This could be related to Bug 73865 631594 2 steveblock 2012-05-23 06:23:20 -0700 Set crashing expectation for Chromium with http://trac.webkit.org/changeset/118168 631650 3 steveblock 2012-05-23 07:29:06 -0700 Set crashing expectation for media/video-src-invalid-remove.html in http://trac.webkit.org/changeset/118179 631728 4 jsbell 2012-05-23 09:30:20 -0700 And more crashing expectations for: media/track/track-language-preference.html media/track/track-load-from-element-readyState.html media/track/track-webvtt-tc019-cue-size.html http://trac.webkit.org/changeset/118186 631841 5 jsbell 2012-05-23 11:26:08 -0700 Added: media/track/track-text-track-destructor-crash.html http://trac.webkit.org/changeset/118096/ has caused widespread flaky-crashing in tests and appears to be a candidate for the crashes linked to this bug. It was rolled out in http://trac.webkit.org/changeset/118203 so if it was the cause we should see these disappear. 631996 6 ap 2012-05-23 13:43:54 -0700 Could this be the same as bug 87265? 631997 7 ap 2012-05-23 13:44:23 -0700 Sorry, I now see that Joshua said the same above. 634100 8 144106 annacc 2012-05-25 11:22:43 -0700 Created attachment 144106 Patch Since r118133, r118129, r118120 and r118134 have been reverted, I'm no longer seeing these crashes. Removing from text_expectations.txt. 634109 9 jsbell 2012-05-25 11:33:19 -0700 Looks good to me. This doesn't need a review - you can commit directly (not through the commit queue). Or ping me and I can do it. 634346 10 144106 haraken 2012-05-25 15:31:51 -0700 Comment on attachment 144106 Patch LGTM 634348 11 144106 webkit.review.bot 2012-05-25 15:34:06 -0700 Comment on attachment 144106 Patch Rejecting attachment 144106 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3021. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12793590 634359 12 annacc 2012-05-25 15:41:54 -0700 Thanks, but I just landed by hand: http://trac.webkit.org/changeset/118575 Sorry for any confusion. 144106 2012-05-25 11:22:43 -0700 2012-05-25 15:34:05 -0700 Patch bug-87258-20120525112242.patch text/plain 2107 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTM5ZTUyNmQ5ZmM2YTQyY2JjZjBh MTNlMjVkY2ZlNmNlZTg4NzIxMi4uZjMwNGQzMzNhNTVhY2NhYjQ4MmY0NDczMDFlNGYyM2NlOTc1 YjA5YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTI1ICBBbm5hIENhdmVuZGVyICA8 YW5uYWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFJlbW92aW5nIHRlc3Rz IGZyb20gdGVzdF9leHBlY3RhdGlvbnMudHh0IHRoYXQgYXJlIG5vIGxvbmdlciBjcmFzaGluZy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MjU4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTItMDUtMjUgIEpvc2h1YSBC ZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFdpZGVuIENS QVNIIGV4cGVjdGF0aW9uIGZvciB2aXNpYmlsaXR5LXNpbXBsZS1jYW52YXMyZC1sYXllci5odG1s IHRvIGluY2x1ZGUgTWFjMTAuNi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCBkNWI1MmUwMjlmZGM5ZmI0Y2Q4MzY2NGNi NDM1MjViYjgxYmRjNzk4Li5kMzJkOGYwNGMwNWViMGZlYTFiNzM3YmFhYmVjNTk4MzE0ODcwNjg5 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0 aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0CkBAIC0zMDIxLDE3ICszMDIxLDYgQEAgQlVHV0s3Mzg2NSA6IG1lZGlhL3RyYWNr L3RyYWNrbGlzdC1pcy1yZWFjaGFibGUuaHRtbCA9IFRFWFQgQ1JBU0gKIEJVR1dLNzM4NjUgOiBt ZWRpYS90cmFjay90ZXh0LXRyYWNrLWN1ZS1pcy1yZWFjaGFibGUuaHRtbCA9IFRFWFQgQ1JBU0gK IEJVR1dLNzM4NjUgOiBtZWRpYS90cmFjay90ZXh0LXRyYWNrLWlzLXJlYWNoYWJsZS5odG1sID0g VEVYVCBDUkFTSAogCi1CVUdXSzg3MjU4IDogbWVkaWEvdHJhY2svdHJhY2stY3Vlcy1zZWVraW5n Lmh0bWwgPSBDUkFTSCBQQVNTCi1CVUdXSzg3MjU4IDogbWVkaWEvdHJhY2svdHJhY2stY3Vlcy1z b3J0ZWQtYmVmb3JlLWRpc3BhdGNoLmh0bWwgPSBDUkFTSCBQQVNTCi1CVUdXSzg3MjU4IDogbWVk aWEvdHJhY2svdHJhY2stbGFuZ3VhZ2UtcHJlZmVyZW5jZS5odG1sID0gQ1JBU0ggUEFTUwotQlVH V0s4NzI1OCA6IG1lZGlhL3RyYWNrL3RyYWNrLWxvYWQtZnJvbS1lbGVtZW50LXJlYWR5U3RhdGUu aHRtbCA9IENSQVNIIFBBU1MKLUJVR1dLODcyNTggOiBtZWRpYS90cmFjay90cmFjay1wcmVmZXIt Y2FwdGlvbnMuaHRtbCA9IENSQVNIIFBBU1MKLUJVR1dLODcyNTggOiBtZWRpYS90cmFjay90cmFj ay10ZXh0LXRyYWNrLWRlc3RydWN0b3ItY3Jhc2guaHRtbCA9IENSQVNIIFBBU1MKLUJVR1dLODcy NTggOiBtZWRpYS90cmFjay90cmFjay13ZWJ2dHQtdGMwMTktY3VlLXNpemUuaHRtbCA9IENSQVNI IFBBU1MKLUJVR1dLODcyNTggOiBtZWRpYS92aWRlby1zb3VyY2Utbm9uZS1zdXBwb3J0ZWQuaHRt bCA9IENSQVNIIFBBU1MKLUJVR1dLODcyNTggOiBtZWRpYS92aWRlby1zcmMtaW52YWxpZC1yZW1v dmUuaHRtbCA9IENSQVNIIFBBU1MKLUJVR1dLODcyNTggOiBtZWRpYS92aWRlby10aW1ldXBkYXRl LWR1cmluZy1wbGF5YmFjay5odG1sID0gQ1JBU0ggUEFTUwotCiBCVUdXSzgxNDAyIFdJTiA6IG1l ZGlhL3RyYWNrL3RyYWNrLWFjdGl2ZS1jdWVzLmh0bWwgPSBQQVNTIFRJTUVPVVQKIEJVR1dLODM4 ODIgOiBtZWRpYS90cmFjay90cmFjay1tb2RlLmh0bWwgPSBQQVNTIFRFWFQgVElNRU9VVAogCg==