87041 2012-05-21 13:17:05 -0700 Ideographic comma and full-stops are mishandled in linebreak 2012-06-18 23:48:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 89426 89436 1 jshin mitz ap darin eric mitz ossy webkit.review.bot xji oldest_to_newest 629426 0 jshin 2012-05-21 13:17:05 -0700 Copied from our internal investigation: ---------- The problem is in shouldBreakAfter() of Source/WebCore/rendering/break_lines.cpp. static inline bool shouldBreakAfter(UChar ch, UChar nextCh) { switch (ch) { case ideographicComma: case ideographicFullStop: // FIXME: cases for ideographicComma and ideographicFullStop are a workaround for an issue in Unicode 5.0 // which is likely to be resolved in Unicode 5.1 <http://bugs.webkit.org/show_bug.cgi?id=17411>. // We may want to remove or conditionalize this workaround at some point. return true; default: .... shouldBreakAfter() hard coded a line break after ideographicComma and ideographicFullStop regardless any other punctuation right after these 2 characters. ----------------- The above issue is not present any more in ICU 4.0 or later. Chrome uses ICU 4.6. The other major port that uses ICU is Safari. I'm sure Safari Windows uses ICU 4.0 or later. The question boils down to the version of ICU on the earliest version of Mac OS X that Safari has to support. If it's ICU 4.0 or alter, we can just remove two hard-coded cases above (ideographicComma and ideographicFullStop). Otherwise, either we have to detect the ICU version at run-time and do different things or at least we have to fix Chromium and Safari on Windows with #if-def (build-time check). darin or ap, can you tell us the version of ICU on the earliest version of Mac OS X Safari has to support? 630702 1 darin 2012-05-22 13:31:09 -0700 ICU 4.0 is there on Snow Leopard, so the only issue is Leopard. The Apple folks are not expecting to support Leopard with the current WebKit TOT, so it would be OK to remove this completely from the Apple Mac port point of view. 637734 2 jshin 2012-05-30 15:02:23 -0700 Thank you, Darin, for the reply. (I was OOO for a while). I'll make a patch to remove it. 651463 3 mitz 2012-06-18 09:56:37 -0700 <rdar://problem/11215797> 651650 4 148157 mitz 2012-06-18 13:15:44 -0700 Created attachment 148157 Remove the unconditional line breaking opportunity after ideographic commas and full stops 651677 5 mitz 2012-06-18 13:40:51 -0700 Fixed in <http://trac.webkit.org/r120624>. 652061 6 ossy 2012-06-18 23:06:34 -0700 (In reply to comment #5) > Fixed in <http://trac.webkit.org/r120624>. It made a test fail on Qt. Could you check it, please? I file a new bug report to track this new regression - https://bugs.webkit.org/show_bug.cgi?id=89426 652072 7 mitz 2012-06-18 23:12:11 -0700 (In reply to comment #6) > (In reply to comment #5) > > Fixed in <http://trac.webkit.org/r120624>. > > It made a test fail on Qt. Could you check it, please? I file a new bug report to track this new regression - https://bugs.webkit.org/show_bug.cgi?id=89426 That’s an odd way to put it. The test was added as part of this change. 652086 8 ossy 2012-06-18 23:23:26 -0700 (In reply to comment #7) > That’s an odd way to put it. The test was added as part of this change. Oh, I overlooked it, I fixed the title of the bug. 148157 2012-06-18 13:15:44 -0700 2012-06-18 13:31:33 -0700 Remove the unconditional line breaking opportunity after ideographic commas and full stops bug-87041-20120618131546.patch text/plain 6539 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDYyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA2LTE4ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgSWRlb2dyYXBoaWMgY29tbWEgYW5k IGZ1bGwtc3RvcHMgYXJlIG1pc2hhbmRsZWQgaW4gbGluZWJyZWFrCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzA0MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9saW5lLWJyZWFr cy1hZnRlci1pZGVvZ3JhcGhpYy1jb21tYS1vci1mdWxsLXN0b3AtMi5odG1sCisKKyAgICAgICAg U3BlY2lmaWNhbGx5LCBsaW5lIGJyZWFrcyB3ZXJlIGFsd2F5cyBhbGxvd2VkIGFmdGVyIGFuIGlk ZW9ncmFwaGljIGNvbW1hIG9yIGZ1bGwgc3RvcCwgZXZlbgorICAgICAgICBiZWZvcmUgYSBjbG9z aW5nIGJyYWNrZXQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvYnJlYWtfbGluZXMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6c2hvdWxkQnJlYWtBZnRlcik6IFJlbW92ZWQgY29kZSB0aGF0IHVuY29u ZGl0aW9uYWxseSBhbGxvd2VkIGxpbmUgYnJlYWtzIGFmdGVyCisgICAgICAgIGlkZW9ncmFwaGlj IGNvbW1hcyBhbmQgZnVsbCBzdG9wcywgd2hpY2ggd2FzIGFkZGVkIGZvciA8aHR0cDovL3dlYmtp dC5vcmcvYi8xNzQxMT4gdG8gd29yaworICAgICAgICBhcm91bmQgYW4gaXNzdWUgaW4gVW5pY29k ZSA1LjAuIEN1cnJlbnQgbGluZSBicmVhayBpdGVyYXRvciBpbXBsZW1lbnRhdGlvbnMgYXJlIGJh c2VkIG9uCisgICAgICAgIG5ld2VyIHZlcnNpb25zIG9mIFVuaWNvZGUsIHdoaWNoIGRvIG5vdCBo YXZlIHRoYXQgaXNzdWUsIHNvIHdlIGNhbiB1c2UgdGhlbSBpbnN0ZWFkIG9mIHRoZQorICAgICAg ICBoYXJkY29kZWQgYXBwcm94aW1hdGUgcnVsZS4KKwogMjAxMi0wNi0xOCAgTWlrZSBXZXN0ICA8 bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENyYXNoIGluIENTUFNvdXJjZTo6cGFyc2VT b3VyY2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9icmVha19saW5lcy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2JyZWFrX2xpbmVzLmNwcAkocmV2 aXNpb24gMTIwNjA4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2JyZWFrX2xpbmVzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTIxLDMyICsxMjEsMjEgQEAgQ09NUElMRV9BU1NFUlQoV1RG X0FSUkFZX0xFTkdUSChhc2NpaUxpbgogCiBzdGF0aWMgaW5saW5lIGJvb2wgc2hvdWxkQnJlYWtB ZnRlcihVQ2hhciBsYXN0Q2gsIFVDaGFyIGNoLCBVQ2hhciBuZXh0Q2gpCiB7Ci0gICAgc3dpdGNo IChjaCkgewotICAgIGNhc2UgaWRlb2dyYXBoaWNDb21tYToKLSAgICBjYXNlIGlkZW9ncmFwaGlj RnVsbFN0b3A6Ci0gICAgICAgIC8vIEZJWE1FOiBjYXNlcyBmb3IgaWRlb2dyYXBoaWNDb21tYSBh bmQgaWRlb2dyYXBoaWNGdWxsU3RvcCBhcmUgYSB3b3JrYXJvdW5kIGZvciBhbiBpc3N1ZSBpbiBV bmljb2RlIDUuMAotICAgICAgICAvLyB3aGljaCBpcyBsaWtlbHkgdG8gYmUgcmVzb2x2ZWQgaW4g VW5pY29kZSA1LjEgPGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDEx Pi4KLSAgICAgICAgLy8gV2UgbWF5IHdhbnQgdG8gcmVtb3ZlIG9yIGNvbmRpdGlvbmFsaXplIHRo aXMgd29ya2Fyb3VuZCBhdCBzb21lIHBvaW50LgotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBj YXNlICctJzoKLSAgICAgICAgaWYgKGlzQVNDSUlEaWdpdChuZXh0Q2gpKSB7Ci0gICAgICAgICAg ICAvLyBEb24ndCBhbGxvdyBsaW5lIGJyZWFraW5nIGJldHdlZW4gJy0nIGFuZCBhIGRpZ2l0IGlm IHRoZSAnLScgbWF5IG1lYW4gYSBtaW51cyBzaWduIGluIHRoZSBjb250ZXh0LAotICAgICAgICAg ICAgLy8gd2hpbGUgYWxsb3cgYnJlYWtpbmcgaW4gJ0FCQ0QtMTIzNCcgYW5kICcxMjM0LTU2Nzgn IHdoaWNoIG1heSBiZSBpbiBsb25nIFVSTHMuCi0gICAgICAgICAgICByZXR1cm4gaXNBU0NJSUFs cGhhbnVtZXJpYyhsYXN0Q2gpOwotICAgICAgICB9Ci0gICAgICAgIC8vIEZhbGwgdGhyb3VnaAot ICAgIGRlZmF1bHQ6Ci0gICAgICAgIC8vIElmIGJvdGggY2ggYW5kIG5leHRDaCBhcmUgQVNDSUkg Y2hhcmFjdGVycywgdXNlIGEgbG9va3VwIHRhYmxlIGZvciBlbmhhbmNlZCBzcGVlZCBhbmQgZm9y IGNvbXBhdGliaWxpdHkKLSAgICAgICAgLy8gd2l0aCBvdGhlciBicm93c2VycyAoc2VlIGNvbW1l bnRzIGZvciBhc2NpaUxpbmVCcmVha1RhYmxlIGZvciBkZXRhaWxzKS4KLSAgICAgICAgaWYgKGNo ID49IGFzY2lpTGluZUJyZWFrVGFibGVGaXJzdENoYXIgJiYgY2ggPD0gYXNjaWlMaW5lQnJlYWtU YWJsZUxhc3RDaGFyCi0gICAgICAgICAgICAgICAgJiYgbmV4dENoID49IGFzY2lpTGluZUJyZWFr VGFibGVGaXJzdENoYXIgJiYgbmV4dENoIDw9IGFzY2lpTGluZUJyZWFrVGFibGVMYXN0Q2hhcikg ewotICAgICAgICAgICAgY29uc3QgdW5zaWduZWQgY2hhciogdGFibGVSb3cgPSBhc2NpaUxpbmVC cmVha1RhYmxlW2NoIC0gYXNjaWlMaW5lQnJlYWtUYWJsZUZpcnN0Q2hhcl07Ci0gICAgICAgICAg ICBpbnQgbmV4dENoSW5kZXggPSBuZXh0Q2ggLSBhc2NpaUxpbmVCcmVha1RhYmxlRmlyc3RDaGFy OwotICAgICAgICAgICAgcmV0dXJuIHRhYmxlUm93W25leHRDaEluZGV4IC8gOF0gJiAoMSA8PCAo bmV4dENoSW5kZXggJSA4KSk7Ci0gICAgICAgIH0KLSAgICAgICAgLy8gT3RoZXJ3aXNlIGRlZmVy IHRvIHRoZSBVbmljb2RlIGFsZ29yaXRobSBieSByZXR1cm5pbmcgZmFsc2UuCi0gICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAvLyBEb24ndCBhbGxvdyBsaW5lIGJyZWFraW5nIGJldHdlZW4gJy0n IGFuZCBhIGRpZ2l0IGlmIHRoZSAnLScgbWF5IG1lYW4gYSBtaW51cyBzaWduIGluIHRoZSBjb250 ZXh0LAorICAgIC8vIHdoaWxlIGFsbG93IGJyZWFraW5nIGluICdBQkNELTEyMzQnIGFuZCAnMTIz NC01Njc4JyB3aGljaCBtYXkgYmUgaW4gbG9uZyBVUkxzLgorICAgIGlmIChjaCA9PSAnLScgJiYg aXNBU0NJSURpZ2l0KG5leHRDaCkpCisgICAgICAgIHJldHVybiBpc0FTQ0lJQWxwaGFudW1lcmlj KGxhc3RDaCk7CisKKyAgICAvLyBJZiBib3RoIGNoIGFuZCBuZXh0Q2ggYXJlIEFTQ0lJIGNoYXJh Y3RlcnMsIHVzZSBhIGxvb2t1cCB0YWJsZSBmb3IgZW5oYW5jZWQgc3BlZWQgYW5kIGZvciBjb21w YXRpYmlsaXR5CisgICAgLy8gd2l0aCBvdGhlciBicm93c2VycyAoc2VlIGNvbW1lbnRzIGZvciBh c2NpaUxpbmVCcmVha1RhYmxlIGZvciBkZXRhaWxzKS4KKyAgICBpZiAoY2ggPj0gYXNjaWlMaW5l QnJlYWtUYWJsZUZpcnN0Q2hhciAmJiBjaCA8PSBhc2NpaUxpbmVCcmVha1RhYmxlTGFzdENoYXIK KyAgICAgICAgICAgICYmIG5leHRDaCA+PSBhc2NpaUxpbmVCcmVha1RhYmxlRmlyc3RDaGFyICYm IG5leHRDaCA8PSBhc2NpaUxpbmVCcmVha1RhYmxlTGFzdENoYXIpIHsKKyAgICAgICAgY29uc3Qg dW5zaWduZWQgY2hhciogdGFibGVSb3cgPSBhc2NpaUxpbmVCcmVha1RhYmxlW2NoIC0gYXNjaWlM aW5lQnJlYWtUYWJsZUZpcnN0Q2hhcl07CisgICAgICAgIGludCBuZXh0Q2hJbmRleCA9IG5leHRD aCAtIGFzY2lpTGluZUJyZWFrVGFibGVGaXJzdENoYXI7CisgICAgICAgIHJldHVybiB0YWJsZVJv d1tuZXh0Q2hJbmRleCAvIDhdICYgKDEgPDwgKG5leHRDaEluZGV4ICUgOCkpOwogICAgIH0KKyAg ICAvLyBPdGhlcndpc2UgZGVmZXIgdG8gdGhlIFVuaWNvZGUgYWxnb3JpdGhtIGJ5IHJldHVybmlu ZyBmYWxzZS4KKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKIHN0YXRpYyBpbmxpbmUgYm9vbCBuZWVk c0xpbmVCcmVha0l0ZXJhdG9yKFVDaGFyIGNoKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTIwNjIwKQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTItMDYtMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBJ ZGVvZ3JhcGhpYyBjb21tYSBhbmQgZnVsbC1zdG9wcyBhcmUgbWlzaGFuZGxlZCBpbiBsaW5lYnJl YWsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3MDQx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0 L3RleHQvbGluZS1icmVha3MtYWZ0ZXItaWRlb2dyYXBoaWMtY29tbWEtb3ItZnVsbC1zdG9wLTIt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RleHQvbGluZS1icmVha3MtYWZ0 ZXItaWRlb2dyYXBoaWMtY29tbWEtb3ItZnVsbC1zdG9wLTIuaHRtbDogQWRkZWQuCisKIDIwMTIt MDYtMTggIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDcmFzaCBp biBDU1BTb3VyY2U6OnBhcnNlU291cmNlCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvbGlu ZS1icmVha3MtYWZ0ZXItaWRlb2dyYXBoaWMtY29tbWEtb3ItZnVsbC1zdG9wLTItZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvdGV4dC9saW5lLWJyZWFrcy1hZnRl ci1pZGVvZ3JhcGhpYy1jb21tYS1vci1mdWxsLXN0b3AtMi1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvbGluZS1icmVha3MtYWZ0ZXItaWRlb2dyYXBo aWMtY29tbWEtb3ItZnVsbC1zdG9wLTItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDQgQEAKK1RoaXMgdGVzdHMgdGhhdCBhIGxpbmUgYnJlYWsgaXMgcHJvaGliaXRlZCBiZXR3 ZWVuIGFuIGlkZW9ncmFwaGljIGNvbW1hIGFuZCBhIHJpZ2h0IGNvcm5lciBicmFja2V0LgorCivj gYbjgIHjgI3jgYYKK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC9saW5lLWJyZWFr cy1hZnRlci1pZGVvZ3JhcGhpYy1jb21tYS1vci1mdWxsLXN0b3AtMi5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvdGV4dC9saW5lLWJyZWFrcy1hZnRlci1pZGVvZ3JhcGhpYy1j b21tYS1vci1mdWxsLXN0b3AtMi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC90ZXh0L2xpbmUtYnJlYWtzLWFmdGVyLWlkZW9ncmFwaGljLWNvbW1hLW9yLWZ1bGwtc3RvcC0y Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjIgQEAKKzxwPgorICAgIFRoaXMgdGVzdHMg dGhhdCBhIGxpbmUgYnJlYWsgaXMgcHJvaGliaXRlZCBiZXR3ZWVuIGFuIGlkZW9ncmFwaGljIGNv bW1hIGFuZCBhIHJpZ2h0IGNvcm5lciBicmFja2V0LgorPC9wPgorPGRpdiBpZD0idGFyZ2V0IiBz dHlsZT0iZm9udC1zaXplOiA3MnB4OyI+JiN4MzA0NjsmI3gzMDAxOyYjeDAzMDBkOyYjeDMwNDY7 PC9kaXY+Cis8cCBpZD0icmVzdWx0Ij5UZXN0IGRpZCBub3QgcnVuLjwvcD4KKzxzY3JpcHQ+Cisg ICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQo KTsKKworICAgIHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iik7 CisgICAgdmFyIHJhbmdlID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKKyAgICByYW5nZS5zZXRT dGFydCh0YXJnZXQuZmlyc3RDaGlsZCwgMCk7CisgICAgcmFuZ2Uuc2V0RW5kKHRhcmdldC5maXJz dENoaWxkLCAyKTsKKyAgICB2YXIgd2lkdGggPSBNYXRoLmNlaWwocmFuZ2UuZ2V0Qm91bmRpbmdD bGllbnRSZWN0KCkud2lkdGgpOworICAgIHRhcmdldC5zdHlsZS53aWR0aCA9IHdpZHRoICsgInB4 IjsKKworICAgIHJhbmdlLnNldFN0YXJ0KHRhcmdldC5maXJzdENoaWxkLCAyKTsKKyAgICByYW5n ZS5zZXRFbmQodGFyZ2V0LmZpcnN0Q2hpbGQsIDMpOworICAgIHZhciBsZWZ0ID0gTWF0aC5jZWls KHJhbmdlLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmxlZnQpIC0gdGFyZ2V0Lm9mZnNldExlZnQ7 CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJUZXh0ID0gbGVm dCA+PSB3aWR0aCA/ICJQQVNTIiA6ICJGQUlMIjsKKzwvc2NyaXB0Pgo=