86999 2012-05-21 02:19:35 -0700 When a text node is clicked, event's target should be adjusted by using composed shadow tree. 2012-06-18 15:59:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 87072 59805 1 hayato hayato dglazkov dominicc morrita shinyak tasak webkit.review.bot oldest_to_newest 628899 0 hayato 2012-05-21 02:19:35 -0700 Suppose the following tree: <div id='host'> - <shadow root> - <content> - <text node A> When <text node A> is clicked, click event's target becomes #host. But that should be 'shadow root'. The reason is that the text node is distributed and the nearest parentNode of the text node is 'shadow root' in composed shadow DOM tree. 631320 1 143485 hayato 2012-05-23 00:27:54 -0700 Created attachment 143485 use composed shadow tree 631708 2 143485 dglazkov 2012-05-23 09:00:52 -0700 Comment on attachment 143485 use composed shadow tree View in context: https://bugs.webkit.org/attachment.cgi?id=143485&action=review > LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching.html:193 > +function prepareDOMTree6(parent) you really should consider naming these methods to describe the nature of the test. 632277 3 hayato 2012-05-23 18:24:36 -0700 Thank you for the review. (In reply to comment #2) > (From update of attachment 143485 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143485&action=review > > > LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching.html:193 > > +function prepareDOMTree6(parent) > > you really should consider naming these methods to describe the nature of the test. Yeah, let me name these functions to good ones in another patch. 632298 4 143485 webkit.review.bot 2012-05-23 18:47:08 -0700 Comment on attachment 143485 use composed shadow tree Clearing flags on attachment: 143485 Committed r118299: <http://trac.webkit.org/changeset/118299> 632299 5 webkit.review.bot 2012-05-23 18:47:20 -0700 All reviewed patches have been landed. Closing bug. 143485 2012-05-23 00:27:54 -0700 2012-05-23 18:47:07 -0700 use composed shadow tree bug-86999-20120523162753.patch text/plain 5948 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA0ZDM3OTc0NmU1NThm OWZhOGFhNTRlY2RmNjI4ZDQzM2MyOGFmMS4uZTMwOWFhMWFjYzhjNGU2NGJlZjBmODI2OWQxZGNh Y2E4YzJkZDQ3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTIzICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGp1c3QgYSB0YXJnZXQg bm9kZSBvZiBhIG1vdXNlIGV2ZW50IGNvcnJlY3RseSB3aGVuIGEgZGlzdHJpYnV0ZWQgdGV4dCBu b2RlIGlzIGNsaWNrZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04Njk5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1ha2UgRXZlbnRIYW5kbGVyOjp1cGRhdGVNb3VzZUV2ZW50VGFyZ2V0Tm9kZSgpIGJl IGF3YXJlIG9mIHNoYWRvdyBkb20gc3VidHJlZQorICAgICAgICBzbyB0aGF0IGFuIGluc2VydGlv biBwb2ludCBjYW4gcmVjZWl2ZSBhbiBldmVudCB3aGVuIGEgZGlzdHJpYnV0ZWQgdGV4dCBub2Rl IGlzIGNsaWNrZWQuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZG9tL3NoYWRvdy9zaGFkb3ctZG9t LWV2ZW50LWRpc3BhdGNoaW5nLmh0bWwKKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6dXBkYXRlTW91c2VFdmVudFRhcmdl dE5vZGUpOgorCiAyMDEyLTA1LTIyICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4K IAogICAgICAgICBTaG9ydC1jaXJjdWl0IEVsZW1lbnQ6OmF0dHJJZkV4aXN0cygpIHdoZW4gdGhl IEVsZW1lbnQgaGFzIG5vIEF0dHIgbGlzdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw cAppbmRleCA3ZWNhNTk5N2E4YTY2NTIyNmY4MjU4YTA5YWJiMjBjMjljNDI3YTcyLi5jNTA3ODFh OWRiNjRhZmI5OThmMmQ4YjU5Y2I2NjcxYTg3ZWY5ZGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiQ2FjaGVkSW1hZ2UuaCIK ICNpbmNsdWRlICJDaHJvbWUuaCIKICNpbmNsdWRlICJDaHJvbWVDbGllbnQuaCIKKyNpbmNsdWRl ICJDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuaCIKICNpbmNsdWRlICJDdXJzb3IuaCIKICNpbmNs dWRlICJDdXJzb3JMaXN0LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKQEAgLTIxMTMsOCArMjEx NCwxMSBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6dXBkYXRlTW91c2VFdmVudFRhcmdldE5vZGUoTm9k ZSogdGFyZ2V0Tm9kZSwgY29uc3QgUGxhdGZvcm1NbwogICAgICAgICByZXN1bHQgPSBtX2NhcHR1 cmluZ01vdXNlRXZlbnRzTm9kZS5nZXQoKTsKICAgICBlbHNlIHsKICAgICAgICAgLy8gSWYgdGhl IHRhcmdldCBub2RlIGlzIGEgdGV4dCBub2RlLCBkaXNwYXRjaCBvbiB0aGUgcGFyZW50IG5vZGUg LSByZGFyOi8vNDE5NjY0NgotICAgICAgICBpZiAocmVzdWx0ICYmIHJlc3VsdC0+aXNUZXh0Tm9k ZSgpKQotICAgICAgICAgICAgcmVzdWx0ID0gcmVzdWx0LT5wYXJlbnROb2RlKCk7CisgICAgICAg IGlmIChyZXN1bHQgJiYgcmVzdWx0LT5pc1RleHROb2RlKCkpIHsKKyAgICAgICAgICAgIENvbXBv c2VkU2hhZG93VHJlZVdhbGtlciB3YWxrZXIocmVzdWx0KTsKKyAgICAgICAgICAgIHdhbGtlci5w YXJlbnRJbmNsdWRpbmdJbnNlcnRpb25Qb2ludEFuZFNoYWRvd1Jvb3QoKTsKKyAgICAgICAgICAg IHJlc3VsdCA9IHdhbGtlci5nZXQoKTsKKyAgICAgICAgfQogICAgIH0KICAgICBtX25vZGVVbmRl ck1vdXNlID0gcmVzdWx0OwogI2lmIEVOQUJMRShTVkcpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTllNTk0NDUwZjAxM2M5 ZjQ0ZWNiNjYxZTRjNzhiMTI5NTliNTUyMC4uYmFjMTJjZmJlZTYwNjg2Y2ExYzNjNzRkMDdkYzcz NjVmODUxM2ZiOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTIzICBIYXlhdG8gSXRv ICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGp1c3QgYSB0YXJnZXQgbm9kZSBv ZiBhIG1vdXNlIGV2ZW50IGNvcnJlY3RseSB3aGVuIGEgZGlzdHJpYnV0ZWQgdGV4dCBub2RlIGlz IGNsaWNrZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04Njk5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZmFzdC9kb20vc2hhZG93L3NoYWRvdy1kb20tZXZlbnQtZGlzcGF0Y2hpbmctZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9zaGFkb3ctZG9tLWV2ZW50LWRpc3BhdGNo aW5nLmh0bWw6CisKIDIwMTItMDUtMjIgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJlbW92ZSBhbiBhc3NlcnRpb24gc2luY2UgYW4gZXZlbnQncyB0YXJnZXQg bWlnaHQgYmUgYSBzaGFkb3cgcm9vdCBpZiBhIHRleHQgbm9kZSBpcyBjbGlja2VkLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1kb20tZXZlbnQtZGlzcGF0 Y2hpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1k b20tZXZlbnQtZGlzcGF0Y2hpbmctZXhwZWN0ZWQudHh0CmluZGV4IDIxZGYwNzI1NDExNTYzZTIw Njc2NDZjZTEyMjc4YjM4Y2FjOGZmNjkuLjU0MTY0MjlkNWRjZDAwMjNmODc4ZjNhZGY4MzM3MWE3 MmVlYzkyZTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ct ZG9tLWV2ZW50LWRpc3BhdGNoaW5nLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9zaGFkb3cvc2hhZG93LWRvbS1ldmVudC1kaXNwYXRjaGluZy1leHBlY3RlZC50eHQKQEAg LTI3Niw2ICsyNzYsMjUgQEAgTW92aW5nIG1vdXNlIGZyb20gYSBkaXJlY3QgY2hpbGQgdGV4dCBu b2RlIG9mIHRoZSBzaGFkb3cgcm9vdCB0byB0b3AKIAogICBtb3VzZW92ZXIKICAgICAgQHRvcCAo dGFyZ2V0OiB0b3ApIChyZWxhdGVkOiBzaGFkb3ctaG9zdCkKKworCitDb21wb3NlZCBTaGFkb3cg VHJlZSB3aWxsIGJlOgorRElWCSBpZD1zYW5kYm94CisJRElWCSBpZD10b3AKKwkJRElWCSBpZD1z aGFkb3ctaG9zdAorCQkJI3RleHQJCisKKworTW92aW5nIG1vdXNlIGZyb20gYSBkaXN0cmlidXRl ZCB0ZXh0IG5vZGUgdG8gdG9wCisKKyAgbW91c2VvdXQKKyAgICAgQGNvbnRlbnQgKHRhcmdldDog Y29udGVudCkgKHJlbGF0ZWQ6IHRvcCkKKyAgICAgQHNoYWRvdy1yb290ICh0YXJnZXQ6IGNvbnRl bnQpIChyZWxhdGVkOiB0b3ApCisgICAgIEBzaGFkb3ctaG9zdCAodGFyZ2V0OiBzaGFkb3ctaG9z dCkgKHJlbGF0ZWQ6IHRvcCkKKyAgICAgQHRvcCAodGFyZ2V0OiBzaGFkb3ctaG9zdCkgKHJlbGF0 ZWQ6IHRvcCkKKworICBtb3VzZW92ZXIKKyAgICAgQHRvcCAodGFyZ2V0OiB0b3ApIChyZWxhdGVk OiBzaGFkb3ctaG9zdCkKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBD T01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1k b20tZXZlbnQtZGlzcGF0Y2hpbmcuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9z aGFkb3ctZG9tLWV2ZW50LWRpc3BhdGNoaW5nLmh0bWwKaW5kZXggNjNmNzZiY2I0NjBkODNlOWNi Yzc5MjFmMGMyM2QzYjIzYTUyMWQ2MC4uNDUzYTlkZGNiMTE3NjEyNTgwMTQ3YWM2MmVkYmNhNTZh NzgwYzgwYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1k b20tZXZlbnQtZGlzcGF0Y2hpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFk b3cvc2hhZG93LWRvbS1ldmVudC1kaXNwYXRjaGluZy5odG1sCkBAIC0xOTAsNiArMTkwLDIyIEBA IGZ1bmN0aW9uIHByZXBhcmVET01UcmVlNShwYXJlbnQpCiAgICAgZGVidWcoJ1xuXG5Db21wb3Nl ZCBTaGFkb3cgVHJlZSB3aWxsIGJlOlxuJyArIGR1bXBDb21wb3NlZFNoYWRvd1RyZWUocGFyZW50 KSk7CiB9CiAKK2Z1bmN0aW9uIHByZXBhcmVET01UcmVlNihwYXJlbnQpCit7CisgICAgLy8gTWFr ZXMgc3VyZSBhbiBpbnNlcnRpb24gcG9pbnQgY2FuIHJlY2VpdmUgYSBldmVudCB3aGVuIGEgZGlz dHJpYnV0ZWQgdGV4dCBub2RlIGlzIGNsaWNrZWQuCisgICAgcGFyZW50LmFwcGVuZENoaWxkKAor ICAgICAgICBjcmVhdGVET00oJ2RpdicsIHsnaWQnOiAndG9wJ30sCisgICAgICAgICAgICAgICAg ICBjcmVhdGVET00oJ2RpdicsIHsnaWQnOiAnc2hhZG93LWhvc3QnfSwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjcmVhdGVTaGFkb3dSb290KAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjcmVhdGVET00oJ2NvbnRlbnQnLCB7J2lkJzogJ2NvbnRlbnQnfSkpLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCdUZXh0IE5vZGUn KSkpKTsKKyAgICB2YXIgc2hhZG93Um9vdCA9IGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnc2hh ZG93LWhvc3QvJykuaWQgPSAnc2hhZG93LXJvb3QnOworICAgIGFkZEV2ZW50TGlzdGVuZXJzKFsn dG9wJywgJ3NoYWRvdy1ob3N0JywgJ3NoYWRvdy1ob3N0LycsICdzaGFkb3ctaG9zdC9jb250ZW50 J10pOworICAgIHBhcmVudC5vZmZzZXRMZWZ0OworICAgIGRlYnVnKCdcblxuQ29tcG9zZWQgU2hh ZG93IFRyZWUgd2lsbCBiZTpcbicgKyBkdW1wQ29tcG9zZWRTaGFkb3dUcmVlKHBhcmVudCkpOwor fQorCisKIGZ1bmN0aW9uIGRlYnVnRGlzcGF0Y2hlZEV2ZW50KGV2ZW50VHlwZSkKIHsKICAgICBk ZWJ1ZygnXG4gICcgKyBldmVudFR5cGUpOwpAQCAtMjYxLDYgKzI3NywyMiBAQCBmdW5jdGlvbiB0 ZXN0KCkKICAgICBtb3ZlTW91c2VPdmVyKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0b3AnKSk7 CiAgICAgZGVidWdEaXNwYXRjaGVkRXZlbnQoJ21vdXNlb3V0Jyk7CiAgICAgZGVidWdEaXNwYXRj aGVkRXZlbnQoJ21vdXNlb3ZlcicpOworCisgICAgc2FuZGJveC5pbm5lckhUTUwgPSAnJzsKKyAg ICBwcmVwYXJlRE9NVHJlZTYoc2FuZGJveCk7CisKKyAgICAvLyBDYWxjdWxhdGVzIHRoZSBwb3Np dGlvbiBvZiB0aGUgdGV4dCBub2RlLgorICAgIHZhciBob3N0ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3NoYWRvdy1ob3N0Jyk7CisgICAgdmFyIHggPSBob3N0Lm9mZnNldExlZnQgKyA1Owor ICAgIHZhciB5ID0gaG9zdC5vZmZzZXRUb3AgKyBkZWZhdWx0UGFkZGluZ1NpemUgKyA1OworICAg IGRlYnVnKCdcbicgKyAnTW92aW5nIG1vdXNlIGZyb20gYSBkaXN0cmlidXRlZCB0ZXh0IG5vZGUg dG8gdG9wJyk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7CisgICAgY2xlYXJF dmVudFJlY29yZHMoKTsKKyAgICBtb3ZlTW91c2VPdmVyKGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCd0b3AnKSk7CisgICAgZGVidWdEaXNwYXRjaGVkRXZlbnQoJ21vdXNlb3V0Jyk7CisgICAgZGVi dWdEaXNwYXRjaGVkRXZlbnQoJ21vdXNlb3ZlcicpOworCisgICAgc2FuZGJveC5pbm5lckhUTUwg PSAnJzsKIH0KIAogdGVzdCgpOwo=