<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>86880</bug_id>
          
          <creation_ts>2012-05-18 11:53:51 -0700</creation_ts>
          <short_desc>REGRESSION (r116645): &quot;background-size: auto 100%; width:auto; height:100%;&quot; doesn&apos;t display correctly</short_desc>
          <delta_ts>2012-05-21 14:34:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc>http://peterlew.is/beta.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Regression</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Peter Lewis">peter</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>bdakin</cc>
    
    <cc>joethomas</cc>
    
    <cc>menard</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>627882</commentid>
    <comment_count>0</comment_count>
      <attachid>142755</attachid>
    <who name="Peter Lewis">peter</who>
    <bug_when>2012-05-18 11:53:51 -0700</bug_when>
    <thetext>Created attachment 142755
Safari vs Webkit nightly

On http://iam.ptrl.ws/beta.html I&apos;m using width:auto; height:100% to have a 2000x2000px displayed. In Webkit this doesn&apos;t display correctly and instead fills the whole browser window.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629348</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-05-21 12:02:12 -0700</bug_when>
    <thetext>The bug URL is 404 Not Found. Could you please attach your test here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629357</commentid>
    <comment_count>2</comment_count>
    <who name="Peter Lewis">peter</who>
    <bug_when>2012-05-21 12:09:01 -0700</bug_when>
    <thetext>Oh I am sorry, I changed my website&apos;s URL today! The URL of the page is: 

http://peterlew.is/beta.html

Peter :)

(In reply to comment #1)
&gt; The bug URL is 404 Not Found. Could you please attach your test here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629419</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-05-21 13:13:55 -0700</bug_when>
    <thetext>Regressed in &lt;http://trac.webkit.org/changeset/116645&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629430</commentid>
    <comment_count>4</comment_count>
    <who name="Joe Thomas">joethomas</who>
    <bug_when>2012-05-21 13:25:23 -0700</bug_when>
    <thetext>Here is the CSS from the regressed page

   background-size: auto 100%;
   width:auto;
   height:100%;
   background:url(pl_av_cp.jpg) center center no-repeat;

Here background-size is defined before background shorthand.

Since we added background-size to background-shorthand in http://trac.webkit.org/changeset/116645, if background-size is not part of background shorthand, we initialize it with the default value. So this can be solved either by adding background-size to background-shorthand or defining background-size after background.

Peter, Can you please try this out?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629432</commentid>
    <comment_count>5</comment_count>
    <who name="Joe Thomas">joethomas</who>
    <bug_when>2012-05-21 13:28:18 -0700</bug_when>
    <thetext>The same issue is mentioned in https://bugs.webkit.org/show_bug.cgi?id=27577#c2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629440</commentid>
    <comment_count>6</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2012-05-21 13:36:21 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Here is the CSS from the regressed page
&gt; 
&gt;    background-size: auto 100%;
&gt;    width:auto;
&gt;    height:100%;
&gt;    background:url(pl_av_cp.jpg) center center no-repeat;
&gt; 
&gt; Here background-size is defined before background shorthand.
&gt; 
&gt; Since we added background-size to background-shorthand in http://trac.webkit.org/changeset/116645, if background-size is not part of background shorthand, we initialize it with the default value. So this can be solved either by adding background-size to background-shorthand or defining background-size after background.
&gt; 
&gt; Peter, Can you please try this out?

We render the same as FF and Opera now. So it&apos;s not really a regression. The behavior we had before was buggy.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629473</commentid>
    <comment_count>7</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2012-05-21 13:59:49 -0700</bug_when>
    <thetext>Previous behavior was wrong as we :

- Didn&apos;t parse the background-size if it was part of the shorthand. We do now.

- Didn&apos;t reset the background-size to initial if we don&apos;t find it in the shorthand, we do now.


We now behave like the specification : http://www.w3.org/TR/css3-background/#the-background . If a value is missing in a CSS shorthand declaration we should set it to initial which we do now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629510</commentid>
    <comment_count>8</comment_count>
    <who name="Peter Lewis">peter</who>
    <bug_when>2012-05-21 14:34:22 -0700</bug_when>
    <thetext>Gosh you guys are quick to respond, thank you.

I&apos;ve made the adjustments as are recommended and it now renders correctly as can be seen in:

http://peterlew.is/beta2.html

So yes, the resolved/invalid status seems correct, thanks! :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>142755</attachid>
            <date>2012-05-18 11:53:51 -0700</date>
            <delta_ts>2012-05-18 11:53:51 -0700</delta_ts>
            <desc>Safari vs Webkit nightly</desc>
            <filename>url.txt</filename>
            <type>text/plain</type>
            <size>19</size>
            <attacher name="Peter Lewis">peter</attacher>
            
              <data encoding="base64">aHR0cDovL3B0cmwud3MvR2o0TA==
</data>

          </attachment>
      

    </bug>

</bugzilla>