86836 2012-05-18 03:12:27 -0700 [EFL] Text input events are emitted for nodes that do not allow editing. 2012-05-22 11:18:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85369 0 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 627531 0 mikhail.pozdnyakov 2012-05-18 03:12:27 -0700 Text input events are emitted for nodes that do not allow editing. 627542 1 142679 mikhail.pozdnyakov 2012-05-18 03:40:43 -0700 Created attachment 142679 Fix. 627547 2 142679 gyuyoung.kim 2012-05-18 03:58:41 -0700 Comment on attachment 142679 Fix. Looks good to me. 627603 3 rakuco 2012-05-18 05:50:51 -0700 Do we have a test for this? 627605 4 mikhail.pozdnyakov 2012-05-18 05:51:53 -0700 (In reply to comment #3) > Do we have a test for this? fast/events/key-events-in-input-button.html 627607 5 rakuco 2012-05-18 05:53:15 -0700 Can you please mention that in the ChangeLog? 627611 6 142697 mikhail.pozdnyakov 2012-05-18 05:59:42 -0700 Created attachment 142697 patch v2 (added more info to changelog) 627613 7 mikhail.pozdnyakov 2012-05-18 06:00:07 -0700 (In reply to comment #5) > Can you please mention that in the ChangeLog? sure 627615 8 142697 rakuco 2012-05-18 06:00:32 -0700 Comment on attachment 142697 patch v2 (added more info to changelog) Looks good, thank you. 627659 9 142697 webkit.review.bot 2012-05-18 06:54:21 -0700 Comment on attachment 142697 patch v2 (added more info to changelog) Clearing flags on attachment: 142697 Committed r117584: <http://trac.webkit.org/changeset/117584> 627660 10 webkit.review.bot 2012-05-18 06:54:27 -0700 All reviewed patches have been landed. Closing bug. 142679 2012-05-18 03:40:43 -0700 2012-05-18 05:59:42 -0700 Fix. bug86836 text/plain 1558 mikhail.pozdnyakov Y29tbWl0IGVjMGYyMGZmMDFhYWM1MjI0MDlhOTljZmI1ZjgwMjkzZGI1YmFhMWIKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg RnJpIE1heSAxOCAxMzozOTo1NSAyMDEyICswMzAwCgogICAgYnVnODY4MzYKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VM b2cKaW5kZXggMTgyNDYyMC4uYmZlMjRhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA1LTE4ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZA aW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIFRleHQgaW5wdXQgZXZlbnRzIGFyZSBlbWl0dGVk IGZvciBub2RlcyB0aGF0IGRvIG5vdCBhbGxvdyBlZGl0aW5nLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4MzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVu dEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3JDbGllbnRFZmw6OmhhbmRsZUVkaXRp bmdLZXlib2FyZEV2ZW50KTogUmV0dXJucyBmYWxzZSBpZiB0aGUgbm9kZSBjYW5ub3QgZWRpdC4K KwogMjAxMi0wNS0xNyAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgW0VGTF1bRFJUXSBDYWxsIHJlc2V0SW50ZXJuYWxzT2JqZWN0KCkgYWZ0ZXIg ZWFjaCB0ZXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQv RWRpdG9yQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEVmbC5jcHAKaW5kZXggNzVhMDRlMy4uODJlYzg0NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuY3BwCkBAIC00 NDEsNiArNDQxLDEwIEBAIGJvb2wgRWRpdG9yQ2xpZW50RWZsOjpoYW5kbGVFZGl0aW5nS2V5Ym9h cmRFdmVudChLZXlib2FyZEV2ZW50KiBldmVudCkKICAgICBpZiAoY29tbWFuZC5leGVjdXRlKGV2 ZW50KSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKKyAgICAvLyBEb24ndCBhbGxvdyB0ZXh0IGlu c2VydGlvbiBmb3Igbm9kZXMgdGhhdCBjYW5ub3QgZWRpdC4KKyAgICBpZiAoIWZyYW1lLT5lZGl0 b3IoKS0+Y2FuRWRpdCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAvLyBEb24ndCBp bnNlcnQgbnVsbCBvciBjb250cm9sIGNoYXJhY3RlcnMgYXMgdGhleSBjYW4gcmVzdWx0IGluIHVu ZXhwZWN0ZWQgYmVoYXZpb3VyCiAgICAgaWYgKGV2ZW50LT5jaGFyQ29kZSgpIDwgJyAnKQogICAg ICAgICByZXR1cm4gZmFsc2U7Cg== 142697 2012-05-18 05:59:42 -0700 2012-05-18 06:54:21 -0700 patch v2 (added more info to changelog) bug86836_v2 text/plain 1739 mikhail.pozdnyakov Y29tbWl0IGZjYmEwMzA3ZGRmN2JiMGY1Yzg1Y2ZjMDE1ZTc3MmM1ODdmMGMxYjgKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg RnJpIE1heSAxOCAxMzozOTo1NSAyMDEyICswMzAwCgogICAgYnVnODY4MzYKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VM b2cKaW5kZXggMTgyNDYyMC4uMWQ5YjFhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA1LTE4ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZA aW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIFRleHQgaW5wdXQgZXZlbnRzIGFyZSBlbWl0dGVk IGZvciBub2RlcyB0aGF0IGRvIG5vdCBhbGxvdyBlZGl0aW5nLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY4MzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXh0IGlucHV0IGV2ZW50cyBhcmUgbm90IGFu eW1vcmUgZW1pdHRlZCBmb3Igbm9kZXMgdGhhdCBkbyBub3QgYWxsb3cgZWRpdGluZy4KKyAgICAg ICAgVGhpcyBjYW4gYmUgY2hlY2tlZCB3aXRoIGZhc3QvZXZlbnRzL2tleS1ldmVudHMtaW4taW5w dXQtYnV0dG9uLmh0bWwgdGVzdCBvdXRwdXQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yQ2xpZW50RWZsOjpo YW5kbGVFZGl0aW5nS2V5Ym9hcmRFdmVudCk6IFJldHVybnMgZmFsc2UgaWYgdGhlIG5vZGUgY2Fu bm90IGVkaXQuCisKIDIwMTItMDUtMTcgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJha3Vjb0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdW0RSVF0gQ2FsbCByZXNldEludGVybmFsc09iamVj dCgpIGFmdGVyIGVhY2ggdGVzdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNv cmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuY3BwCmluZGV4IDc1YTA0ZTMuLjgyZWM4NDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVmbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZs LmNwcApAQCAtNDQxLDYgKzQ0MSwxMCBAQCBib29sIEVkaXRvckNsaWVudEVmbDo6aGFuZGxlRWRp dGluZ0tleWJvYXJkRXZlbnQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiAgICAgaWYgKGNvbW1hbmQu ZXhlY3V0ZShldmVudCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisgICAgLy8gRG9uJ3QgYWxs b3cgdGV4dCBpbnNlcnRpb24gZm9yIG5vZGVzIHRoYXQgY2Fubm90IGVkaXQuCisgICAgaWYgKCFm cmFtZS0+ZWRpdG9yKCktPmNhbkVkaXQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAg Ly8gRG9uJ3QgaW5zZXJ0IG51bGwgb3IgY29udHJvbCBjaGFyYWN0ZXJzIGFzIHRoZXkgY2FuIHJl c3VsdCBpbiB1bmV4cGVjdGVkIGJlaGF2aW91cgogICAgIGlmIChldmVudC0+Y2hhckNvZGUoKSA8 ICcgJykKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=