86802 2012-05-17 21:37:30 -0700 [V8][Refactoring] Remove V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0) 2012-05-18 05:32:05 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 627315 0 haraken 2012-05-17 21:37:30 -0700 As commented here (https://bugs.webkit.org/show_bug.cgi?id=84074#c5), I am refactoring a series of confusing throwError()s. This would be the final patch for the refactoring. In this bug I remove V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0). Also I refactor up a couple of throwError()s that I've forgot to refactor in the previous patches. 627316 1 142626 haraken 2012-05-17 21:39:32 -0700 Created attachment 142626 Patch 627587 2 142626 webkit.review.bot 2012-05-18 05:32:00 -0700 Comment on attachment 142626 Patch Clearing flags on attachment: 142626 Committed r117579: <http://trac.webkit.org/changeset/117579> 627588 3 webkit.review.bot 2012-05-18 05:32:05 -0700 All reviewed patches have been landed. Closing bug. 142626 2012-05-17 21:39:32 -0700 2012-05-18 05:32:00 -0700 Patch bug-86802-20120518133931.patch text/plain 5668 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI3M2ExYTI0ODA4NGRm Zjg4YmNjMzNkM2IzZjM2ZDAyNzY5Zjc3NS4uMTNiNzhmN2RkMmMyZDQ5OGM5ZDUwNTFhYzhiYTQz ZmJjMTc1ZTdiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMyIEBACiAyMDEyLTA1LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdW1JlZmFjdG9y aW5nXSBSZW1vdmUgVjhQcm94eTo6dGhyb3dFcnJvcihjb25zdCBjaGFyKiwgRXJyb3JUeXBlLCB2 ODo6SXNvbGF0ZSo9MCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg2ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXMgY29tbWVudGVkIGhlcmUgKGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NDA3NCNjNSksCisgICAgICAgIEkgYW0gcmVmYWN0b3JpbmcgYSBzZXJpZXMgb2Yg Y29uZnVzaW5nIHRocm93RXJyb3IoKXMuIFRoaXMgd291bGQgYmUKKyAgICAgICAgdGhlIGZpbmFs IHBhdGNoIGZvciB0aGUgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVz IFY4UHJveHk6OnRocm93RXJyb3IoY29uc3QgY2hhciosIEVycm9yVHlwZSwgdjg6Oklzb2xhdGUq PTApLgorICAgICAgICBBbHNvIHRoaXMgcGF0Y2ggcmVmYWN0b3JzIHVwIGEgY291cGxlIG9mIHRo cm93RXJyb3IoKXMgdGhhdCBJJ3ZlIGZvcmdvdCB0bworICAgICAgICByZWZhY3RvciBpbiB0aGUg cHJldmlvdXMgcGF0Y2hlcy4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2 aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6YWNjZXB0Tm9kZSk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5oOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1 c3RvbS9WOEFycmF5QnVmZmVyQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4QXJyYXlC dWZmZXI6OmNvbnN0cnVjdG9yQ2FsbGJhY2spOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3Rv bS9WOEFycmF5QnVmZmVyVmlld0N1c3RvbS5oOgorICAgICAgICAoV2ViQ29yZTo6Y29uc3RydWN0 V2ViR0xBcnJheSk6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4U1FMUmVzdWx0U2V0 Um93TGlzdEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFNRTFJlc3VsdFNldFJvd0xp c3Q6Oml0ZW1DYWxsYmFjayk6CisKKzIwMTItMDUtMTcgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5A Y2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtWOF1bUmVmYWN0b3JpbmddIFJlbW92ZSBWOFByb3h5 Ojp0aHJvd0Vycm9yKGNvbnN0IGNoYXIqLCB2ODo6SXNvbGF0ZSogPSAwKQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY3OTQKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Tm9kZUZpbHRlckNvbmRpdGlvbi5jcHAKaW5kZXgg MmE2NjNlODU1YjdmNmJmYmY1MDkxYmMyMDY2YWZkMDVlZDU1MzFhYy4uNzBkYjQ3ZGUyZDA0NmQy ZGZkMGRjZTE1ZDViNDY4ODMwMDE3MWZkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uY3BwCkBAIC03Myw3ICs3Myw3IEBAIHNo b3J0IFY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6YWNjZXB0Tm9kZShTY3JpcHRTdGF0ZSogc3RhdGUs IE5vZGUqIG5vZGUpIGNvbnN0CiAgICAgZWxzZSB7CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6VmFs dWU+IHZhbHVlID0gbV9maWx0ZXItPlRvT2JqZWN0KCktPkdldCh2ODo6U3RyaW5nOjpOZXcoImFj Y2VwdE5vZGUiKSk7CiAgICAgICAgIGlmICghdmFsdWUtPklzRnVuY3Rpb24oKSkgewotICAgICAg ICAgICAgVjhQcm94eTo6dGhyb3dFcnJvcihWOFByb3h5OjpUeXBlRXJyb3IsICJOb2RlRmlsdGVy IG9iamVjdCBkb2VzIG5vdCBoYXZlIGFuIGFjY2VwdE5vZGUgZnVuY3Rpb24iKTsKKyAgICAgICAg ICAgIFY4UHJveHk6OnRocm93VHlwZUVycm9yKCJOb2RlRmlsdGVyIG9iamVjdCBkb2VzIG5vdCBo YXZlIGFuIGFjY2VwdE5vZGUgZnVuY3Rpb24iKTsKICAgICAgICAgICAgIHJldHVybiBOb2RlRmls dGVyOjpGSUxURVJfUkVKRUNUOwogICAgICAgICB9CiAgICAgICAgIGNhbGxiYWNrID0gdjg6Okhh bmRsZTx2ODo6RnVuY3Rpb24+OjpDYXN0KHZhbHVlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 UHJveHkuaAppbmRleCA0MWRjODVmYTllMzE2MGQxNmViNjQ0ZTVkNGM4NTU2MmYzZGQwNzUyLi43 ZDVlZGY5YjM1ZmIzZTc3NWJjMTIyMzczMWRjYTU2MzhjMzhmNzNhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhQcm94eS5oCkBAIC0zMjUsMTMgKzMyNSw2IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6Qm9vbGVhbj4oKTsKICAgICB9CiAKLSAg ICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6UHJpbWl0aXZlPiB0aHJvd0Vycm9yKGNvbnN0IGNoYXIq IG1lc3NhZ2UsIFY4UHJveHk6OkVycm9yVHlwZSB0eXBlLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSA9 IDApCi0gICAgewotICAgICAgICBpZiAoIXY4OjpWODo6SXNFeGVjdXRpb25UZXJtaW5hdGluZygp KQotICAgICAgICAgICAgVjhQcm94eTo6dGhyb3dFcnJvcih0eXBlLCBtZXNzYWdlLCBpc29sYXRl KTsKLSAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKLSAgICB9Ci0KICAgICBpbmxpbmUg djg6OkhhbmRsZTx2ODo6UHJpbWl0aXZlPiB0aHJvd0Vycm9yKEV4Y2VwdGlvbkNvZGUgZWMsIHY4 OjpJc29sYXRlKiBpc29sYXRlID0gMCkKICAgICB7CiAgICAgICAgIGlmICghdjg6OlY4OjpJc0V4 ZWN1dGlvblRlcm1pbmF0aW5nKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhBcnJheUJ1ZmZlckN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhBcnJheUJ1ZmZlckN1c3RvbS5jcHAKaW5kZXggYjY1NGRlNzgxMGIz MGNjNjdiZmEyNWRmMDhjZThiZDVjMDM0MzQ4ZS4uMzFlYjZiYmI1ZGM5OTQ2ODIyMGRjZTc3ZDYx ZTVjOGUyNmNlMjNiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4QXJyYXlCdWZmZXJDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOEFycmF5QnVmZmVyQ3VzdG9tLmNwcApAQCAtNDMsNyArNDMsNyBAQCB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gVjhBcnJheUJ1ZmZlcjo6Y29uc3RydWN0b3JDYWxsYmFjayhjb25z dCB2ODo6QXJndW1lbnRzJiBhcgogICAgIElOQ19TVEFUUygiRE9NLkFycmF5QnVmZmVyLkNvbnN0 cnVjdG9yIik7CiAKICAgICBpZiAoIWFyZ3MuSXNDb25zdHJ1Y3RDYWxsKCkpCi0gICAgICAgIHJl dHVybiB0aHJvd0Vycm9yKCJET00gb2JqZWN0IGNvbnN0cnVjdG9yIGNhbm5vdCBiZSBjYWxsZWQg YXMgYSBmdW5jdGlvbi4iLCBWOFByb3h5OjpUeXBlRXJyb3IpOworICAgICAgICByZXR1cm4gVjhQ cm94eTo6dGhyb3dUeXBlRXJyb3IoIkRPTSBvYmplY3QgY29uc3RydWN0b3IgY2Fubm90IGJlIGNh bGxlZCBhcyBhIGZ1bmN0aW9uLiIpOwogCiAgICAgaWYgKENvbnN0cnVjdG9yTW9kZTo6Y3VycmVu dCgpID09IENvbnN0cnVjdG9yTW9kZTo6V3JhcEV4aXN0aW5nT2JqZWN0KQogICAgICAgICByZXR1 cm4gYXJncy5Ib2xkZXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOEFycmF5QnVmZmVyVmlld0N1c3RvbS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmgKaW5kZXggZTNjMjMxMjQyMThm ZGMxZTIxMWRkMzEzZWU3YWIwYTgxNjNkOTEyOC4uODBmYTVjMGY3NjRhM2JjMDE0YjdiNDM0NTQz Y2RhZDRiMmFlNjA5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmgKQEAgLTEzOSw3ICsxMzksNyBA QCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29uc3RydWN0V2ViR0xBcnJheShjb25zdCB2ODo6QXJn dW1lbnRzJiBhcmdzLCBXcmFwcGVyVHlwZQogICAgIGlmIChhcmdzWzBdLT5Jc051bGwoKSkgewog ICAgICAgICAvLyBJbnZhbGlkIGZpcnN0IGFyZ3VtZW50CiAgICAgICAgIC8vIEZJWE1FOiB1c2Ug Zm9ydGhjb21pbmcgVjhQcm94eTo6dGhyb3dUeXBlRXJyb3IoKS4KLSAgICAgICAgcmV0dXJuIFY4 UHJveHk6OnRocm93RXJyb3IoVjhQcm94eTo6VHlwZUVycm9yLCAiVHlwZSBlcnJvciIpOworICAg ICAgICByZXR1cm4gVjhQcm94eTo6dGhyb3dUeXBlRXJyb3IoKTsKICAgICB9CiAKICAgICAvLyBT ZWUgd2hldGhlciB0aGUgZmlyc3QgYXJndW1lbnQgaXMgYSBBcnJheUJ1ZmZlci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNRTFJlc3VsdFNldFJvd0xp c3RDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U1FMUmVz dWx0U2V0Um93TGlzdEN1c3RvbS5jcHAKaW5kZXggODY1MzFhYmVjYTdiMmRmYmNjMTViMzAzNWVl OWNhYWQ4ZTg1NTZhOC4uNzIyYWEzNTc3YTMzNGZlOGYwOGRlMjQzOTg4MjRkODMxMzExZTJjYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U1FMUmVzdWx0 U2V0Um93TGlzdEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4U1FMUmVzdWx0U2V0Um93TGlzdEN1c3RvbS5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IFY4U1FMUmVzdWx0U2V0Um93TGlzdDo6aXRlbUNhbGxiYWNrKGNv bnN0IHY4OjpBcmd1bWVudHMmIGEKICAgICB9CiAKICAgICBpZiAoIWFyZ3NbMF0tPklzTnVtYmVy KCkpIHsKLSAgICAgICAgVjhQcm94eTo6dGhyb3dFcnJvcihWOFByb3h5OjpUeXBlRXJyb3IsICJJ dGVtIGluZGV4IG11c3QgYmUgYSBudW1iZXIuIik7CisgICAgICAgIFY4UHJveHk6OnRocm93VHlw ZUVycm9yKCJJdGVtIGluZGV4IG11c3QgYmUgYSBudW1iZXIuIik7CiAgICAgICAgIHJldHVybiB2 ODo6VW5kZWZpbmVkKCk7CiAgICAgfQogCg==